Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64144497
--- Diff: src/main/java/org/apache/joshua/decoder/JoshuaConfiguration.java
---
@@ -587,7 +588,7 @@ else if (fds[1].toLowerCase().equals("http"))
Github user thammegowda commented on the pull request:
https://github.com/apache/incubator-joshua/pull/15#issuecomment-220796532
@KellenSunderland Thanks for the review and feedback. I fixed them.
However, we are left with 200+ `System.out.print` and 200+
`System.err.print` mo
Github user thammegowda commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64138704
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/berkeley_lm/LMGrammarBerkeley.java
---
@@ -37,6 +37,7 @@
import edu.berkeley.nlp.lm
Github user thammegowda commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64138103
--- Diff: src/main/java/org/apache/joshua/corpus/Vocabulary.java ---
@@ -45,6 +47,7 @@
public class Vocabulary {
+ public st
Dynamite Chris. Looks like we got it covered pretty well on our side :)
Please post anything here as well so that others can benefit. That goes
without saying :)
Have a nice weekend troops :)
On Fri, May 20, 2016 at 9:50 AM, <
dev-digest-h...@joshua.incubator.apache.org> wrote:
>
>
> From: "Mattm
[
https://issues.apache.org/jira/browse/JOSHUA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294936#comment-15294936
]
ASF GitHub Bot commented on JOSHUA-264:
---
Github user KellenSunderland commented on t
Github user KellenSunderland commented on the pull request:
https://github.com/apache/incubator-joshua/pull/13#issuecomment-220772283
Hey Thamme, thanks for the great PR. Haven't checked the build yet myself
but the commit looks good to me.
---
If your project is set up for it, you
[
https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294879#comment-15294879
]
Kellen Sunderland commented on JOSHUA-262:
--
Hey Thamme. Just wanted to say a hug
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64132137
--- Diff: src/main/java/org/apache/joshua/util/CompareGrammars.java ---
@@ -134,15 +132,15 @@ public static void compareValues(File grammarFi
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64132143
--- Diff: src/main/java/org/apache/joshua/decoder/JoshuaDecoder.java ---
@@ -84,12 +79,13 @@ public static void main(String[] args) throws
I
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64132090
--- Diff:
src/main/java/org/apache/joshua/util/encoding/FeatureTypeAnalyzer.java ---
@@ -122,7 +123,7 @@ public void inferTypes(boolean labe
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64132048
--- Diff:
src/main/java/org/apache/joshua/util/encoding/FeatureTypeAnalyzer.java ---
@@ -122,7 +123,7 @@ public void inferTypes(boolean labe
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131989
--- Diff: src/main/java/org/apache/joshua/util/CompareGrammars.java ---
@@ -117,11 +115,11 @@ public static void compareValues(File grammarFi
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131968
--- Diff: src/main/java/org/apache/joshua/util/CompareGrammars.java ---
@@ -101,13 +100,12 @@ public static void compareValues(File grammarFi
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131955
--- Diff: src/main/java/org/apache/joshua/util/Cache.java ---
@@ -104,20 +104,18 @@ public Cache() {
@Override
public V g
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131960
--- Diff: src/main/java/org/apache/joshua/util/Cache.java ---
@@ -104,20 +104,18 @@ public Cache() {
@Override
public V g
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131952
--- Diff: src/main/java/org/apache/joshua/util/Cache.java ---
@@ -104,20 +104,18 @@ public Cache() {
@Override
public V g
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131932
--- Diff: src/main/java/org/apache/joshua/tools/GrammarPackerCli.java ---
@@ -146,7 +147,7 @@ public static void main(String[] args) throws
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131880
--- Diff: src/main/java/org/apache/joshua/lattice/Lattice.java ---
@@ -305,14 +305,14 @@ public int distance(int i, int j) {
List> n
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131858
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/tm/packed/PackedGrammar.java ---
@@ -159,7 +162,7 @@ public PackedGrammar(String gramma
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131820
--- Diff: src/main/java/org/apache/joshua/decoder/ff/tm/GrammarReader.java
---
@@ -20,12 +20,12 @@
import java.io.IOException;
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131751
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/buildin_lm/TrieLM.java ---
@@ -315,15 +315,15 @@ public static void main(String[] ar
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131735
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/buildin_lm/TrieLM.java ---
@@ -178,7 +177,8 @@ public TrieLM(ArpaFile arpaFile) thro
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131731
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/buildin_lm/TrieLM.java ---
@@ -168,7 +166,8 @@ public TrieLM(ArpaFile arpaFile) thro
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131721
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/buildin_lm/TrieLM.java ---
@@ -156,7 +153,8 @@ public TrieLM(ArpaFile arpaFile) thro
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131711
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/buildin_lm/TrieLM.java ---
@@ -141,7 +138,7 @@ public TrieLM(ArpaFile arpaFile) thro
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131693
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/buildin_lm/TrieLM.java ---
@@ -101,7 +97,7 @@ public TrieLM(ArpaFile arpaFile) throw
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131682
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/bloomfilter_lm/BloomFilterLanguageModel.java
---
@@ -62,7 +63,7 @@
/**
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131607
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/berkeley_lm/LMGrammarBerkeley.java
---
@@ -37,6 +37,7 @@
import edu.berkeley.n
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131583
--- Diff: src/main/java/org/apache/joshua/decoder/ff/lm/ArpaFile.java ---
@@ -180,21 +177,21 @@ public Vocabulary getVocab() {
@Suppre
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131585
--- Diff: src/main/java/org/apache/joshua/decoder/ff/lm/ArpaFile.java ---
@@ -209,10 +206,10 @@ public int getOrder() throws FileNotFoundExce
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131505
--- Diff: src/main/java/org/apache/joshua/decoder/chart_parser/Chart.java
---
@@ -683,8 +681,8 @@ private int addUnaryNodes(Grammar[] gramma
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131409
--- Diff: src/main/java/org/apache/joshua/decoder/JoshuaDecoder.java ---
@@ -70,10 +65,10 @@ public static void main(String[] args) throws
I
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131388
--- Diff: src/main/java/org/apache/joshua/decoder/JoshuaDecoder.java ---
@@ -84,12 +79,13 @@ public static void main(String[] args) throws
I
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131369
--- Diff: src/main/java/org/apache/joshua/decoder/JoshuaConfiguration.java
---
@@ -662,14 +663,14 @@ else if (fds[1].toLowerCase().equals("h
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131361
--- Diff: src/main/java/org/apache/joshua/decoder/JoshuaConfiguration.java
---
@@ -587,7 +588,7 @@ else if (fds[1].toLowerCase().equals("htt
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131325
--- Diff: src/main/java/org/apache/joshua/decoder/DecoderThread.java ---
@@ -140,14 +142,14 @@ public Translation translate(Sentence sentence
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131303
--- Diff: src/main/java/org/apache/joshua/corpus/Vocabulary.java ---
@@ -45,6 +47,7 @@
public class Vocabulary {
+ publ
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131297
--- Diff: src/main/java/org/apache/joshua/decoder/Decoder.java ---
@@ -786,7 +783,7 @@ private void initializeTranslationGrammars() throws
I
GitHub user thammegowda opened a pull request:
https://github.com/apache/incubator-joshua/pull/15
Joshua-262: Slf4j - Log4j bridge
Migrated from java.util.logging to slf4j with log4j bridge.
You can merge this pull request into a Git repository by running:
$ git pull htt
40 matches
Mail list logo
