[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12 Unless there are any objections, I'd like to merge this branch back into master. There are a few small issues, but none that can't be addressed with documentation. I'd love to do this

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12 Ho @mjpost can you point me at the latest BerkeleyLM codebase? I can Mavenize it and get it in to Maven Central so we can use it as a dependency in pom.xml --- If your project is

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...

Github user chrismattmann commented on the pull request: https://github.com/apache/incubator-joshua/pull/12 +1 great work! watch out there are conflicts to resolve before merging @mjpost --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-81985 ack --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user thammegowda commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-80945 @lewissmc Thank you very much, Sir. Joshua in Docker - not yet tried so far, I will definitely try it. I am much interested in your [PR to

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user thammegowda commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-54428 @mjpost > Okay, great! That worked. I assume the edits to $JOSHUA/bin/joshua mean that eclipse compiled files will override the jar? So I can do fast

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-38661 > I assume the edits to $JOSHUA/bin/joshua mean that eclipse compiled files will override the jar? So I can do fast development in Eclipse? Yes all you

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-37297 Okay, great! That worked. I assume the edits to $JOSHUA/bin/joshua mean that eclipse compiled files will override the jar? So I can do fast development in

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user thammegowda commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-28146 @mjpost I am unable to run `test.sh` script, because - Caused by: java.lang.RuntimeException: java.lang.UnsatisfiedLinkError: no ken in

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user thammegowda commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-25251 Found the issue with logger config file. Seems like `-Dlog4j.configuration` to override is no longer supported. Please review #18 and merge.

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user thammegowda commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-06844 @lewismc @mjpost Just looked into this. I will debug this issue and come back with my findings soon. +1 for rethinking about log levels. we can

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-04726 Yes, I hope I was clear that this is all great work. We just have to figure out how to get log4j to read the config file, which it's currently not doing. Then,

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-04155 Make an entry in logging file? Parameterized logging as implemented by @thammegowda is magnitudes more efficient than traditional string + Excepton logging

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-3 Just to be clear, not sure it needs to be reverted. We just need to find a way to make sure the config file gets read and that logging gets set to INFO by

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222199387 @thammegowda please revert logging patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222120221 I went into joshua/decoder/chart_parser/ComputeNodeResult; adding and removing the following lines makes a huge difference in speed. So it looks like logging is

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222118458 On a hunch, I went through and removed all the calls LOG.*() in Decoder, DecoderThread, JoshuaDecoder, Translation, Chart, DotChart, and ComputeNodeResult. This

Re: [GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

yeah this is really strange. I'm talking about the regression tests, not the unit tests. these are in src/test/resources. run for example test/bn-en/hiero/test.sh. 3 seconds on master, 18 on JOSHUA-252 (you might have to remove "-threads 2") matt (from my phone) > On May 26, 2016, at 9:15 PM,

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222037050 What kind of 'tests' are we talking about here? The only tests which I know of are invoked by running ```mvn clean test```. These execute very quickly by the

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222032586 Okay, I just pushed up the changes after merging in master and making some other changes to that the tests will run (with manual calls). The code on master runs

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user thammegowda commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222027825 My guess is that `ConcurrentModificationException` occurs when we try to loop (eg: for) on a collection and inside the loop the collection is being updated

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222016587 Also, multithreading is broken. I randomly (not always) get the following error when decoding with more than 1 thread: ``` Exception in thread

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222013844 Okay, cool. It doesn't seem to look for that file automatically, though; if I remove the -Dlog4j.configuration, it doesn't find the file you pointed to. So I am

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user thammegowda commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222012667 @mjpost as you pointed out, you need to edit log4j settings. The other way is to edit `src/main/resources/log4j.properties` If you

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222011444 Okay, the answer is that our slfj4 is using log4j12 as the backend. I had to add -Dlog4j.configuration=$JOSHUA/logging.properties to the

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user KellenSunderland commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222011143 Does setting it to error instead of info help? On May 27, 2016 12:04 AM, "Matt Post" wrote: > Can someone tell

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222008424 Can someone tell me how to turn off logging in slf4j? I have tried passing -Dorg.slf4j.Logger.defaultLogLevel=info but this does not seem to

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222003148 Yep, working through those. Making good progress on the build. Once I can verify that the test cases pass under the new build (so I can know I've done the merge

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222002633 There will be a number of scripts which we need to update with the paths to the generated jar files. This is all part of the new build. --- If your project

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222000585 Nevermind, found Thamme's [old instructions](https://github.com/apache/incubator-joshua/pull/14#issue-155139645). --- If your project is set up for it, you can

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-221969513 Okay, cool, I got this merged and compiling. First, THANK YOU for all of this amazing work! This feels like a real milestone and it was fun to work through the

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-221928486 There have been changes on master (JOSHUA-271 and JOSHUA-272), will try to get to this soon, probably not till tomorrow. Do you want me to be the one to

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-221793740 Cool @thammegowda #15 merged into JOSHUA-252 Work still to be done * plan on how we are going to compile and package GIZA++, KenLM,

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user thammegowda commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-221778184 @lewismc thanks for the reply. rebased #13 , it is ready for merge! --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user chrismattmann commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-220756830 dusted --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user thammegowda commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-220753345 @mjpost Sorry for my previous incomplete comment. The problem I see with that line is, now we have new package `org.apache.joshua.decoder.ff` instead

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-219586976 I didn't see your JOSHUA-252 branch. I just created a "maven" branch that pulls PRs 4 and 5 into this one. However, I don't see these on github / incubator. It

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user thammegowda commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-219337253 this is indeed a big change and I think it's better to split into multiple small PRs. Maybe we can have a 'maven' branch in parallel for a short

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-219336222 ACK Safe flight Kellen. On Sun, May 15, 2016 at 7:25 PM, Kellen Sunderland wrote: > Hey Lewis. I'm flying

[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...

Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-219335321 The PR is not finished yet. There are a number of issues as highlighted above which need attention. --- If your project is set up for it, you can reply to