[jira] [Commented] (KAFKA-1289) Misc. nitpicks in log cleaner

[ https://issues.apache.org/jira/browse/KAFKA-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919034#comment-13919034 ] Jun Rao commented on KAFKA-1289: +1 > Misc. nitpicks in log cleaner > ---

[jira] [Commented] (KAFKA-1289) Misc. nitpicks in log cleaner

[ https://issues.apache.org/jira/browse/KAFKA-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919022#comment-13919022 ] Sriram Subramanian commented on KAFKA-1289: --- +1 > Misc. nitpicks in log cleaner

Re: [VOTE} Apache Kafka Release 0.8.1 - Candidate 1

I fixed a couple of niggling issues with the log cleaner I found testing the release. None of these are very major but it would be nice to get these in 0.8.1 just to ensure a nice out-of-the-box experience. If someone could review: https://issues.apache.org/jira/browse/KAFKA-1289 -Jay On Fri, Fe

[jira] [Updated] (KAFKA-1289) Misc. nitpicks in log cleaner

[ https://issues.apache.org/jira/browse/KAFKA-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1289: - Attachment: KAFKA-1289-v1.patch 1. Fix logging by keying everything off the same class 2. Decrease backof

[jira] [Updated] (KAFKA-1289) Misc. nitpicks in log cleaner

[ https://issues.apache.org/jira/browse/KAFKA-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1289: - Affects Version/s: 0.8.1 > Misc. nitpicks in log cleaner > - > >

[jira] [Created] (KAFKA-1289) Misc. nitpicks in log cleaner

Jay Kreps created KAFKA-1289: Summary: Misc. nitpicks in log cleaner Key: KAFKA-1289 URL: https://issues.apache.org/jira/browse/KAFKA-1289 Project: Kafka Issue Type: Bug Reporter: Jay

Re: [VOTE} Apache Kafka Release 0.8.1 - Candidate 1

Yeah, you are right Jun, I think I was just getting confused because I was looking at an out of date test that referenced old configs. -Jay On Mon, Mar 3, 2014 at 4:12 PM, Jun Rao wrote: > Actually, config name standardization was done in 0.8.0. In 0.8.1, we added > a few new configs. However,

[jira] [Commented] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918871#comment-13918871 ] Andrew Olson commented on KAFKA-1028: - Patch has been updated with the suggested chang

Re: Review Request 17537: Patch for KAFKA-1028

> On Feb. 4, 2014, 11:21 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/ReplicaFetcherThread.scala, line 86 > > > > > > Reading from zookeeper is unnecessary here, since the broker has a > > mechanism

[jira] [Updated] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Olson updated KAFKA-1028: Attachment: KAFKA-1028_2014-03-03_18:48:43.patch > per topic configuration of preference for consis

[jira] [Commented] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918842#comment-13918842 ] Andrew Olson commented on KAFKA-1028: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 17537: Patch for KAFKA-1028

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17537/ --- (Updated March 4, 2014, 12:48 a.m.) Review request for kafka. Bugs: KAFKA-102

Re: [VOTE} Apache Kafka Release 0.8.1 - Candidate 1

Actually, config name standardization was done in 0.8.0. In 0.8.1, we added a few new configs. However, existing configs should have the same name as in 0.8.0. Thanks, Jun On Mon, Mar 3, 2014 at 3:05 PM, Jay Kreps wrote: > This is the first release with the standardized configuration naming,

[jira] [Closed] (KAFKA-1266) Metadata Request with non-exist topic will case NPE and also inFlightRequest blocks producer shutdown

[ https://issues.apache.org/jira/browse/KAFKA-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang closed KAFKA-1266. > Metadata Request with non-exist topic will case NPE and also inFlightRequest > blocks producer shutd

[jira] [Resolved] (KAFKA-1266) Metadata Request with non-exist topic will case NPE and also inFlightRequest blocks producer shutdown

[ https://issues.apache.org/jira/browse/KAFKA-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-1266. -- Resolution: Fixed > Metadata Request with non-exist topic will case NPE and also inFlightReques

[jira] [Commented] (KAFKA-1266) Metadata Request with non-exist topic will case NPE and also inFlightRequest blocks producer shutdown

[ https://issues.apache.org/jira/browse/KAFKA-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918775#comment-13918775 ] Guozhang Wang commented on KAFKA-1266: -- This is fixed as part of KAFKA-1260 > Metada

Re: Review Request 18716: Patch for KAFKA-1288

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18716/#review36059 --- Ship it! Ship It! - Neha Narkhede On March 3, 2014, 11:47 p.m.,

Re: [VOTE} Apache Kafka Release 0.8.1 - Candidate 1

1. Put up a fix in KAFKA-1288. 2. This is partially fixed in KAFKA-1287 in trunk. If you build the jar from source, it automatically copies slf4j-log4j12 jar to the dependent libs dir to prevent those messages from showing up. However, in the binary release, we can't include the slf4j-log4j12 jar

Re: Review Request 17537: Patch for KAFKA-1028

> On March 3, 2014, 7:03 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/admin/AdminUtils.scala, line 356 > > > > > > "unclean leader" is a bit confusing, how about > > uncleanLeaderElectionEnabled? > > Andr

[jira] [Created] (KAFKA-1288) add enclosing dir in release tar gz

Jun Rao created KAFKA-1288: -- Summary: add enclosing dir in release tar gz Key: KAFKA-1288 URL: https://issues.apache.org/jira/browse/KAFKA-1288 Project: Kafka Issue Type: Bug Components: p

[jira] [Updated] (KAFKA-1288) add enclosing dir in release tar gz

[ https://issues.apache.org/jira/browse/KAFKA-1288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1288: --- Attachment: KAFKA-1288.patch > add enclosing dir in release tar gz > --- > >

[jira] [Commented] (KAFKA-1288) add enclosing dir in release tar gz

[ https://issues.apache.org/jira/browse/KAFKA-1288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918749#comment-13918749 ] Jun Rao commented on KAFKA-1288: Created reviewboard https://reviews.apache.org/r/18716/

Review Request 18716: Patch for KAFKA-1288

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18716/ --- Review request for kafka. Bugs: KAFKA-1288 https://issues.apache.org/jira/b

Re: Review Request 18712: Patch for KAFKA-1281

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/ --- (Updated March 3, 2014, 11:22 p.m.) Review request for kafka. Bugs: KAFKA-128

[jira] [Commented] (KAFKA-1281) add the new producer to existing tools

[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918703#comment-13918703 ] Neha Narkhede commented on KAFKA-1281: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1281) add the new producer to existing tools

[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1281: - Attachment: KAFKA-1281.patch > add the new producer to existing tools > -

Review Request 18712: Patch for KAFKA-1281

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/ --- Review request for kafka. Bugs: KAFKA-1281 https://issues.apache.org/jira/b

Re: [VOTE] Metrics package for new clients

The (2)'s have it. I will put up a patch using this approach. -Jay On Fri, Feb 28, 2014 at 8:29 AM, Guozhang Wang wrote: > +1 on 2 > > > On Thu, Feb 27, 2014 at 9:34 AM, Jay Kreps wrote: > > > Hey all, > > > > There was several previous discussions on metrics for the new clients but > > I'm n

Re: [VOTE} Apache Kafka Release 0.8.1 - Candidate 1

This is the first release with the standardized configuration naming, right? We need to include a table of the changes somewhere and link to it from the release notes or people will be very frustrated... -Jay On Mon, Mar 3, 2014 at 9:53 AM, Jay Kreps wrote: > Several minor issues: > 1. No encl

[jira] [Work started] (KAFKA-1281) add the new producer to existing tools

[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1281 started by Neha Narkhede. > add the new producer to existing tools > -- > > Key: KAFKA-1281 >

[jira] [Assigned] (KAFKA-1281) add the new producer to existing tools

[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede reassigned KAFKA-1281: Assignee: Neha Narkhede > add the new producer to existing tools >

Re: Review Request 17537: Patch for KAFKA-1028

> On March 3, 2014, 7:03 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ReplicaFetcherThread.scala, line 86 > > > > > > I am not sure we need to check the unclean election flag here. If we > > can keep

Re: Review Request 17537: Patch for KAFKA-1028

> On March 3, 2014, 7:03 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/controller/PartitionLeaderSelector.scala, line 64 > > > > > > Not sure throwing an exception is the right behavior here? If unclean > >

Re: [VOTE} Apache Kafka Release 0.8.1 - Candidate 1

Thanks Jay! I would like to keep the vote open until the end (Tuesday, March 4th, 6pm PDT) to give anyone voting time to provide feedback on are any other issues to fix prior to RC2. More inline, some are new topic discussions not for 0.8.1 necessarily but related to release candidates in general

[jira] [Commented] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918457#comment-13918457 ] Guozhang Wang commented on KAFKA-1286: -- Thanks for the guidance Jay, I can take this

Re: Review Request 17537: Patch for KAFKA-1028

> On March 3, 2014, 7:03 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/admin/AdminUtils.scala, line 356 > > > > > > "unclean leader" is a bit confusing, how about > > uncleanLeaderElectionEnabled? Sounds g

[jira] [Commented] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918451#comment-13918451 ] Jay Kreps commented on KAFKA-1286: -- If you are saying that we repeat the metadata request

[jira] [Commented] (KAFKA-1230) shell script files under bin don't work with cygwin (bash on windows)

[ https://issues.apache.org/jira/browse/KAFKA-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918448#comment-13918448 ] Guozhang Wang commented on KAFKA-1230: -- Hi Alok, could you try to rebase on trunk? Th

[jira] [Commented] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918432#comment-13918432 ] Guozhang Wang commented on KAFKA-1028: -- Sorry for the late reply Andrew, add some mor

Re: Review Request 17537: Patch for KAFKA-1028

> On Feb. 4, 2014, 11:21 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/PartitionLeaderSelector.scala, line 64 > > > > > > the config object should already have the per topic preference for > > unc

Re: Review Request 17537: Patch for KAFKA-1028

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17537/#review35999 --- core/src/main/scala/kafka/admin/AdminUtils.scala

[jira] Subscription: outstanding kafka patches

Issue Subscription Filter: outstanding kafka patches (84 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1275 fixes for quickstart documentation https://issues.apache.org/jira/browse/KAFKA-1275 KAFKA-1264 Make ConsoleProducer com

[jira] [Updated] (KAFKA-1281) add the new producer to existing tools

[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1281: - Issue Type: Sub-task (was: Bug) Parent: KAFKA-1239 > add the new producer to existing to

[jira] [Commented] (KAFKA-1215) Rack-Aware replica assignment option

[ https://issues.apache.org/jira/browse/KAFKA-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918391#comment-13918391 ] Guozhang Wang commented on KAFKA-1215: -- Some more comments on the RB. > Rack-Aware r

Re: Review Request 17248: Patch for KAFKA-1215

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17248/#review35997 --- Some high-level comments: 1. Instead of exposing the maxRackReplica

Re: New Consumer API discussion

Hey Guys, Also, for reference, we'll be looking to implement new Samza consumers which have these APIs: http://samza.incubator.apache.org/learn/documentation/0.7.0/api/javadocs/or g/apache/samza/system/SystemConsumer.html http://samza.incubator.apache.org/learn/documentation/0.7.0/api/javadocs/o

Re: New Consumer API discussion

Hey Guys, Sorry for the late follow up. Here are my questions/thoughts on the API: 1. Why is the config String->Object instead of String->String? 2. Are these Java docs correct? KafkaConsumer(java.util.Map configs) A consumer is instantiated by providing a set of key-value pairs as configur

[jira] [Commented] (KAFKA-1281) add the new producer to existing tools

[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918316#comment-13918316 ] Neha Narkhede commented on KAFKA-1281: -- Ya, converting all tools to use 2 options see

Re: [VOTE} Apache Kafka Release 0.8.1 - Candidate 1

Several minor issues: 1. No enclosing directory in the tgz. That is tar xzf creates the full contents in the current directory instead of creating a single kafka directory with all the files. 2. SLF4j error: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-op

[jira] [Updated] (KAFKA-615) Avoid fsync on log segment roll

[ https://issues.apache.org/jira/browse/KAFKA-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-615: Issue Type: New Feature (was: Bug) > Avoid fsync on log segment roll > --- > >

[jira] [Updated] (KAFKA-330) Add delete topic support

[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-330: Issue Type: New Feature (was: Bug) > Add delete topic support > - > >

[jira] [Updated] (KAFKA-918) Change log.retention.hours to be log.retention.mins

[ https://issues.apache.org/jira/browse/KAFKA-918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-918: Issue Type: Improvement (was: New Feature) > Change log.retention.hours to be log.retention.mins >

[jira] [Updated] (KAFKA-561) Rebuild index file for a log segment if there is none

[ https://issues.apache.org/jira/browse/KAFKA-561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-561: Issue Type: Improvement (was: New Feature) > Rebuild index file for a log segment if there is none > --

[jira] [Resolved] (KAFKA-1287) enable log4j in command line tools using the new producer

[ https://issues.apache.org/jira/browse/KAFKA-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1287. Resolution: Fixed Fix Version/s: 0.8.2 Thanks for the review. Committed to trunk. > enable log4j in

Re: Review Request 18690: Patch for KAFKA-1287

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18690/#review35978 --- Ship it! Ship It! - Neha Narkhede On March 3, 2014, 4:16 p.m., J

Re: Review Request 18690: Patch for KAFKA-1287

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18690/#review35976 --- Ship it! Ship It! - Guozhang Wang On March 3, 2014, 4:16 p.m., J

[jira] [Commented] (KAFKA-1287) enable log4j in command line tools using the new producer

[ https://issues.apache.org/jira/browse/KAFKA-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918210#comment-13918210 ] Jun Rao commented on KAFKA-1287: Created reviewboard https://reviews.apache.org/r/18690/

[jira] [Updated] (KAFKA-1287) enable log4j in command line tools using the new producer

[ https://issues.apache.org/jira/browse/KAFKA-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1287: --- Attachment: KAFKA-1287.patch > enable log4j in command line tools using the new producer > --

Review Request 18690: Patch for KAFKA-1287

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18690/ --- Review request for kafka. Bugs: KAFKA-1287 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1287) enable log4j in command line tools using the new producer

Jun Rao created KAFKA-1287: -- Summary: enable log4j in command line tools using the new producer Key: KAFKA-1287 URL: https://issues.apache.org/jira/browse/KAFKA-1287 Project: Kafka Issue Type: Impro

To subscribe

tks