[
https://issues.apache.org/jira/browse/KAFKA-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974159#comment-13974159
]
BalajiSeshadri commented on KAFKA-1365:
---
We will test the controller issue one in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20471/#review40772
---
Could you add some comments at the beginning of TopicConfigManager
[
https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps resolved KAFKA-1398.
--
Resolution: Fixed
Topic config changes can be lost and cause fatal exceptions on broker restarts
[
https://issues.apache.org/jira/browse/KAFKA-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974266#comment-13974266
]
Jun Rao commented on KAFKA-1405:
Vadim,
Thanks for reporting this. Yes, overriding
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20471/#review40780
---
core/src/main/scala/kafka/server/TopicConfigManager.scala
See https://builds.apache.org/job/Kafka-trunk/167/changes
Changes:
[jay.kreps] KAFKA-1398 dynamic config changes are broken.
--
[...truncated 738 lines...]
kafka.admin.AddPartitionsTest testManualAssignmentOfReplicas PASSED
kafka.admin.AddPartitionsTest
[
https://issues.apache.org/jira/browse/KAFKA-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974302#comment-13974302
]
Jun Rao commented on KAFKA-1403:
Would it be good enough to just add the timestamp in the
On April 18, 2014, 3:22 p.m., Jun Rao wrote:
core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 87-88
https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line87
The child list returned by ZK doesn't guarantee any ordering. We will
need to sort this list
On April 18, 2014, 5:25 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 121-134
https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line121
You mean that the purge is only triggered by a broker bounce or a new
config change? I
On April 18, 2014, 4:54 p.m., Jun Rao wrote:
README.md, lines 10-11
https://reviews.apache.org/r/20376/diff/1/?file=558371#file558371line10
Do we need the trailing ###?
Will make that change.
On April 18, 2014, 4:54 p.m., Jun Rao wrote:
build.gradle, lines 78-79
https://reviews.apache.org/r/20440/
Should be a simple one.
-Jay
On April 18, 2014, 3:22 p.m., Jun Rao wrote:
core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 123-124
https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line123
This is not needed. In ZK, new sequential nodes always get a higher id
whether previous
[
https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974311#comment-13974311
]
Jay Kreps commented on KAFKA-1398:
--
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-1398:
-
Attachment: KAFKA-1398.patch
Topic config changes can be lost and cause fatal exceptions on broker
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20440/#review40790
---
Ship it!
Ship It!
- Jun Rao
On April 17, 2014, 12:41 a.m., Jay
On April 18, 2014, 6:01 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 87-88
https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line87
Say you override the retention to x hours, realize you made a mistake
and then override
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20376/#review40791
---
Ship it!
Ship It!
- Jun Rao
On April 15, 2014, 7:39 p.m., Joel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20471/#review40792
---
core/src/main/scala/kafka/server/TopicConfigManager.scala
[
https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1380:
--
Due Date: 21/Apr/14 (was: 16/Apr/14)
Quick update - we have to push this out to Monday. Most of the
[
https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974333#comment-13974333
]
Jun Rao commented on KAFKA-1356:
Joel,
+1 on
[
https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974346#comment-13974346
]
Joel Koshy commented on KAFKA-1356:
---
Thanks for the review. Committed the follow-up
On April 18, 2014, 6:12 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 87-88
https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line87
Actually that's not the right example - it would work fine since you
only want the later
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20498/
---
Review request for kafka.
Bugs: KAFKA-1398
[
https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-1398:
-
Attachment: KAFKA-1398.patch
Topic config changes can be lost and cause fatal exceptions on broker
[
https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974418#comment-13974418
]
Jay Kreps commented on KAFKA-1398:
--
Created reviewboard
On April 18, 2014, 3:22 p.m., Jun Rao wrote:
core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 123-124
https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line123
This is not needed. In ZK, new sequential nodes always get a higher id
whether previous
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20471/
---
(Updated April 18, 2014, 8:03 p.m.)
Review request for kafka.
Summary
[
https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-1398:
-
Attachment: KAFKA-1398_2014-04-18_13:03:03.patch
Topic config changes can be lost and cause fatal
[
https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974420#comment-13974420
]
Jay Kreps commented on KAFKA-1398:
--
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20471/#review40809
---
Ship it!
Ship It!
- Joel Koshy
On April 18, 2014, 8:03 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20471/#review40810
---
Ship it!
Ship It!
- Jun Rao
On April 18, 2014, 8:03 p.m., Jay
[
https://issues.apache.org/jira/browse/KAFKA-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1397#comment-1397
]
Jun Rao commented on KAFKA-1399:
We are re-rewriting the clients in java. Once that's
Joel Koshy created KAFKA-1406:
-
Summary: Fix scaladoc/javadoc warnings
Key: KAFKA-1406
URL: https://issues.apache.org/jira/browse/KAFKA-1406
Project: Kafka
Issue Type: Bug
Components:
[
https://issues.apache.org/jira/browse/KAFKA-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1406:
--
Labels: build (was: )
Fix scaladoc/javadoc warnings
-
[
https://issues.apache.org/jira/browse/KAFKA-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1406:
--
Fix Version/s: 0.8.2
Fix scaladoc/javadoc warnings
-
[
https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974454#comment-13974454
]
Joel Koshy commented on KAFKA-1362:
---
Committed to both 0.8.1 and trunk
Filed KAFKA-1406
[
https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1362.
---
Resolution: Fixed
Publish sources and javadoc jars
[
https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy reopened KAFKA-1398:
---
Reopening to keep track of the follow-up. Also, I need to commit to 0.8.1.
Topic config changes can be
[
https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974471#comment-13974471
]
Joel Koshy commented on KAFKA-493:
--
For (1) I think the issue was discussed (not yet
[
https://issues.apache.org/jira/browse/KAFKA-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1355.
---
Resolution: Fixed
Thanks for the review. Committed to 0.8.1 as well.
Reduce/optimize update
[
https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974561#comment-13974561
]
Guozhang Wang commented on KAFKA-1359:
--
I did a small benchmark on my mac laptop and
See https://builds.apache.org/job/Kafka-trunk/168/changes
[
https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1398.
---
Resolution: Fixed
Committed to 0.8.1 as well
Topic config changes can be lost and cause fatal
[
https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974624#comment-13974624
]
Jay Kreps commented on KAFKA-1359:
--
Yeah I'm not opposed to switching.
Add topic/broker
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20468/#review40838
---
Ship it!
core/src/main/scala/kafka/log/LogCleanerManager.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20468/#review40840
---
Also, I think we need to make the following var volatile.
46 matches
Mail list logo