> On April 18, 2014, 5:25 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 121-134 > > <https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line121> > > > > You mean that the purge is only triggered by a broker bounce or a new > > config change? I think that is fine right? i.e., in favor of some separate > > trigger such as a scheduled task doing that? > > > > We could store the last executed change as part of the topic config > > itself for informational purposes (so people can be sure that a config > > change still sitting in zookeeper was in fact applied to the topic config).
Yes, though that "ack" would have to be per-broker, and we would need to clean it up if/when the partition moves to another broker. - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40780 ----------------------------------------------------------- On April 18, 2014, 12:36 a.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20471/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 12:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1398 > https://issues.apache.org/jira/browse/KAFKA-1398 > > > Repository: kafka > > > Description > ------- > > KAFKA-1398 dynamic config changes are broken. > > > Diffs > ----- > > core/src/main/scala/kafka/server/TopicConfigManager.scala > d41fd33d91406dfa2ce8c1e1b04a078e983ccadd > core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/20471/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
