> On April 18, 2014, 3:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 87-88 > > <https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line87> > > > > The child list returned by ZK doesn't guarantee any ordering. We will > > need to sort this list so that we don't miss the latest config change.
I don't think this depends on any ordering. > On April 18, 2014, 3:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 121-134 > > <https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line121> > > > > It seems that if there are no new config changes, the last few config > > changes in the notification path will not be deleted. This can be a bit > > confusing. Yes, that is by design. Otherwise you need some background thread to check. This is less confusing. Change notifications can't pile up because if new ones come that will trigger purging. > On April 18, 2014, 3:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 123-124 > > <https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line123> > > > > This is not needed. In ZK, new sequential nodes always get a higher id > > whether previous sequential nodes are deleted or not. ZK server maintains > > enough info to achieve that. If you are totally sure I will remove that bit. - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40772 ----------------------------------------------------------- On April 18, 2014, 12:36 a.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20471/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 12:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1398 > https://issues.apache.org/jira/browse/KAFKA-1398 > > > Repository: kafka > > > Description > ------- > > KAFKA-1398 dynamic config changes are broken. > > > Diffs > ----- > > core/src/main/scala/kafka/server/TopicConfigManager.scala > d41fd33d91406dfa2ce8c1e1b04a078e983ccadd > core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/20471/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
