[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-08-12 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093822#comment-14093822 ] Vladimir Tretyakov commented on KAFKA-1481: --- Hi Jun Rao, I understood what you s

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-08-12 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093830#comment-14093830 ] Joe Stein commented on KAFKA-1481: -- [~junrao] If this patch is going to cause existing us

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-08-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094147#comment-14094147 ] Jun Rao commented on KAFKA-1481: The name of "FetchQueueSize" is of the following format.

Re: Review Request 24196: Patch for KAFKA-1567

2014-08-12 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review50328 --- core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala

Re: [Kafka MirrorMaker] Message with Custom Partition Logic

2014-08-12 Thread Guozhang Wang
With new producer it will still do the hash based partitioning based on keys if the messages have keys. However it is a bit harder to customize partitioning logic as the new producer do not expose the partitioner any more. Guozhang On Mon, Aug 11, 2014 at 11:12 PM, Bhavesh Mistry wrote: > Hi N

[jira] [Commented] (KAFKA-1485) Upgrade to Zookeeper 3.4.6

2014-08-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094291#comment-14094291 ] Jun Rao commented on KAFKA-1485: Gwen, Joe, We probably don't want to leave system tests

[jira] [Commented] (KAFKA-1485) Upgrade to Zookeeper 3.4.6

2014-08-12 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094295#comment-14094295 ] Joe Stein commented on KAFKA-1485: -- I think that makes sense, let me revert the patch rig

[jira] [Updated] (KAFKA-1485) Upgrade to Zookeeper 3.4.6 and create "shim" for ZKCLI so system tests can run

2014-08-12 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1485: - Summary: Upgrade to Zookeeper 3.4.6 and create "shim" for ZKCLI so system tests can run (was: Upgrade to

[jira] [Reopened] (KAFKA-1485) Upgrade to Zookeeper 3.4.6

2014-08-12 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein reopened KAFKA-1485: -- > Upgrade to Zookeeper 3.4.6 > -- > > Key: KAFKA-1485 >

[jira] [Comment Edited] (KAFKA-1485) Upgrade to Zookeeper 3.4.6 and create "shim" for ZKCLI so system tests can run

2014-08-12 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094295#comment-14094295 ] Joe Stein edited comment on KAFKA-1485 at 8/12/14 4:47 PM: --- I th

[jira] [Commented] (KAFKA-1485) Upgrade to Zookeeper 3.4.6 and create "shim" for ZKCLI so system tests can run

2014-08-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094299#comment-14094299 ] Gwen Shapira commented on KAFKA-1485: - Yes. I'm planning to work on this specific issu

[jira] [Comment Edited] (KAFKA-1485) Upgrade to Zookeeper 3.4.6 and create "shim" for ZKCLI so system tests can run

2014-08-12 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094295#comment-14094295 ] Joe Stein edited comment on KAFKA-1485 at 8/12/14 4:47 PM: --- I th

[jira] [Commented] (KAFKA-1485) Upgrade to Zookeeper 3.4.6 and create "shim" for ZKCLI so system tests can run

2014-08-12 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094300#comment-14094300 ] Joe Stein commented on KAFKA-1485: -- [~lindong] patch reverted, system test away > Upgra

[jira] [Assigned] (KAFKA-1581) Log cleaner should have an option to ignore messages without keys

2014-08-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy reassigned KAFKA-1581: -- Assignee: Manikumar Reddy > Log cleaner should have an option to ignore messages withou

Re: Review Request 24214: Patch for KAFKA-1374

2014-08-12 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24214/ --- (Updated Aug. 12, 2014, 4:55 p.m.) Review request for kafka. Bugs: KAFKA-1374

[jira] [Commented] (KAFKA-1485) Upgrade to Zookeeper 3.4.6 and create "shim" for ZKCLI so system tests can run

2014-08-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094306#comment-14094306 ] Jun Rao commented on KAFKA-1485: Joe, Gwen, Thanks. I agree that KAFKA-1589 is probably

[jira] [Commented] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-08-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094307#comment-14094307 ] Manikumar Reddy commented on KAFKA-1374: Updated reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-08-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1374: --- Attachment: KAFKA-1374_2014-08-12_22:23:06.patch > LogCleaner (compaction) does not support c

Re: Review Request 24214: Patch for KAFKA-1374

2014-08-12 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24214/ --- (Updated Aug. 12, 2014, 4:57 p.m.) Review request for kafka. Bugs: KAFKA-1374

[jira] [Commented] (KAFKA-1589) Strengthen System Tests

2014-08-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094312#comment-14094312 ] Guozhang Wang commented on KAFKA-1589: -- As I tagged it with "0.9", I think we can do

[jira] [Work started] (KAFKA-1282) Disconnect idle socket connection in Selector

2014-08-12 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1282 started by nicu marasoiu. > Disconnect idle socket connection in Selector > - > > Key: KAFK

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-12 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094347#comment-14094347 ] nicu marasoiu commented on KAFKA-1510: -- ok, so I have not fully understood, but what

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-12 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094391#comment-14094391 ] Joel Koshy commented on KAFKA-1510: --- [~junrao] yes that would make sense. However, we do

[jira] [Commented] (KAFKA-1485) Upgrade to Zookeeper 3.4.6 and create "shim" for ZKCLI so system tests can run

2014-08-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094486#comment-14094486 ] Dong Lin commented on KAFKA-1485: - Joe Stein Thanks! > Upgrade to Zookeeper 3.4.6 and cr

Re: Review Request 24196: Patch for KAFKA-1567

2014-08-12 Thread Jiangjie Qin
> On Aug. 12, 2014, 3:43 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala, lines 119-120 > > > > > > Actually, I am not sure why DroppedMessagesPerSec is included in > > MessagesPerSe

Build failed in Jenkins: Kafka-trunk #246

2014-08-12 Thread Apache Jenkins Server
See Changes: [joe.stein] Revert KAFKA-1485 Upgrade to Zookeeper 3.4.6 since system tests are failing -- Started by an SCM change Building remotely on ubuntu-5 (Ubuntu ubuntu5 ubuntu) in workspace

[jira] [Commented] (KAFKA-656) Add Quotas to Kafka

2014-08-12 Thread Abhinav Anand (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094573#comment-14094573 ] Abhinav Anand commented on KAFKA-656: - H [~jkreps] [~jcreasy], Guys don't see much act

[jira] [Commented] (KAFKA-656) Add Quotas to Kafka

2014-08-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094589#comment-14094589 ] Jay Kreps commented on KAFKA-656: - Hey [~ab10anand], I would rather not do explicit leases.

[jira] [Updated] (KAFKA-1282) Disconnect idle socket connection in Selector

2014-08-12 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicu marasoiu updated KAFKA-1282: - Attachment: kafka-1282__Disconnect_idle_socket_connection_in_Selector.patch > Disconnect idle soc

[jira] [Updated] (KAFKA-1282) Disconnect idle socket connection in Selector

2014-08-12 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicu marasoiu updated KAFKA-1282: - Status: Patch Available (was: In Progress) > Disconnect idle socket connection in Selector > ---

[jira] [Commented] (KAFKA-1282) Disconnect idle socket connection in Selector

2014-08-12 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094686#comment-14094686 ] nicu marasoiu commented on KAFKA-1282: -- I attached a first version of the patch. I am

Re: Review Request 24196: Patch for KAFKA-1567

2014-08-12 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/ --- (Updated Aug. 12, 2014, 10:20 p.m.) Review request for kafka. Bugs: KAFKA-156

[jira] [Commented] (KAFKA-1567) Metric memory leaking after closing the clients

2014-08-12 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094789#comment-14094789 ] Jiangjie Qin commented on KAFKA-1567: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1567) Metric memory leaking after closing the clients

2014-08-12 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1567: Attachment: KAFKA-1567_2014-08-12_15:20:10.patch > Metric memory leaking after closing the clients

[jira] [Created] (KAFKA-1590) Binarize trace level request logging along with debug level text logging

2014-08-12 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1590: Summary: Binarize trace level request logging along with debug level text logging Key: KAFKA-1590 URL: https://issues.apache.org/jira/browse/KAFKA-1590 Project: Kafka

[jira] [Created] (KAFKA-1591) Clean-up Unnecessary stack trace in error/warn logs

2014-08-12 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1591: Summary: Clean-up Unnecessary stack trace in error/warn logs Key: KAFKA-1591 URL: https://issues.apache.org/jira/browse/KAFKA-1591 Project: Kafka Issue Type:

[jira] [Created] (KAFKA-1592) Some INFO level logging needs to be DEBUG

2014-08-12 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1592: Summary: Some INFO level logging needs to be DEBUG Key: KAFKA-1592 URL: https://issues.apache.org/jira/browse/KAFKA-1592 Project: Kafka Issue Type: Bug

Review Request 24620: Patch for KAFKA-1580

2014-08-12 Thread Jonathan Natkins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/ --- Review request for kafka. Bugs: KAFKA-1580 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1580) Reject producer requests to internal topics

2014-08-12 Thread Jonathan Natkins (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Natkins updated KAFKA-1580: Attachment: KAFKA-1580.patch > Reject producer requests to internal topics > --

[jira] [Commented] (KAFKA-1580) Reject producer requests to internal topics

2014-08-12 Thread Jonathan Natkins (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094895#comment-14094895 ] Jonathan Natkins commented on KAFKA-1580: - Created reviewboard https://reviews.apa

[jira] [Updated] (KAFKA-1580) Reject producer requests to internal topics

2014-08-12 Thread Jonathan Natkins (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Natkins updated KAFKA-1580: Assignee: Jonathan Natkins Status: Patch Available (was: Open) > Reject producer req

[jira] [Assigned] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in unit tests

2014-08-12 Thread Jonathan Natkins (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Natkins reassigned KAFKA-1420: --- Assignee: Jonathan Natkins > Replace AdminUtils.createOrUpdateTopicPartitionAssignmen

Review Request 24621: Patch for KAFKA-1507

2014-08-12 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24621/ --- Review request for kafka. Bugs: KAFKA-1507 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

2014-08-12 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1507: -- Attachment: KAFKA-1507.patch > Using GetOffsetShell against non-existent topic

[jira] [Commented] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

2014-08-12 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094929#comment-14094929 ] Sriharsha Chintalapani commented on KAFKA-1507: --- Created reviewboard https:/

[jira] [Commented] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

2014-08-12 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094936#comment-14094936 ] Sriharsha Chintalapani commented on KAFKA-1507: --- [~jkreps] [~junrao] can you

Re: Review Request 24621: Patch for KAFKA-1507

2014-08-12 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24621/ --- (Updated Aug. 13, 2014, 1:09 a.m.) Review request for kafka. Bugs: KAFKA-1507

[jira] [Commented] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

2014-08-12 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094994#comment-14094994 ] Sriharsha Chintalapani commented on KAFKA-1507: --- Updated reviewboard https:/

[jira] [Updated] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

2014-08-12 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1507: -- Attachment: KAFKA-1507_2014-08-12_18:09:06.patch > Using GetOffsetShell against

[jira] [Updated] (KAFKA-1569) Tooling for performance and corectness of transactions end-to-end

2014-08-12 Thread Raul Castro Fernandez (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Castro Fernandez updated KAFKA-1569: - Summary: Tooling for performance and corectness of transactions end-to-end (was:

Re: Review Request 24196: Patch for KAFKA-1567

2014-08-12 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review50401 --- core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.sca

Re: Review Request 24196: Patch for KAFKA-1567

2014-08-12 Thread Jiangjie Qin
> On Aug. 13, 2014, 4:28 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.scala, > > lines 61-68 > > > > > > Do we need to do the pattern matching here? Can we just remove based