[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282140#comment-14282140 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~gwenshap] in that case current

[jira] [Commented] (KAFKA-1876) pom file for scala 2.11 should reference a specific version

2015-01-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282083#comment-14282083 ] Jun Rao commented on KAFKA-1876: Created reviewboard

[jira] [Updated] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1761: --- Attachment: KAFKA-1761_2015-01-19_11:51:58.patch num.partitionsdocumented default is

[jira] [Commented] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282183#comment-14282183 ] Manikumar Reddy commented on KAFKA-1761: Updated reviewboard

Re: Review Request 30022: Patch for KAFKA-1761

2015-01-18 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30022/ --- (Updated Jan. 19, 2015, 6:23 a.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1760) Implement new consumer client

2015-01-18 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282100#comment-14282100 ] Jay Kreps commented on KAFKA-1760: -- Updated reviewboard

Re: Review Request 27799: Patch for KAFKA-1760

2015-01-18 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/ --- (Updated Jan. 19, 2015, 3:10 a.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1760) Implement new consumer client

2015-01-18 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282101#comment-14282101 ] Jay Kreps commented on KAFKA-1760: -- Posted an updated patch rebased against trunk.

[jira] [Updated] (KAFKA-1760) Implement new consumer client

2015-01-18 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1760: - Attachment: KAFKA-1760_2015-01-18_19:10:13.patch Implement new consumer client

[jira] [Comment Edited] (KAFKA-1875) Add info on PreCommit Patch Testing to wiki

2015-01-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282132#comment-14282132 ] Gwen Shapira edited comment on KAFKA-1875 at 1/19/15 4:38 AM: --

[jira] [Commented] (KAFKA-1875) Add info on PreCommit Patch Testing to wiki

2015-01-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282132#comment-14282132 ] Gwen Shapira commented on KAFKA-1875: - You don't actually need a JIRA to create / edit

[jira] [Commented] (KAFKA-1875) Add info on PreCommit Patch Testing to wiki

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282135#comment-14282135 ] Ashish Kumar Singh commented on KAFKA-1875: --- [~gwenshap] This is exactly what I

Re: Review Request 30019: Patch for kafka-1876

2015-01-18 Thread Joe Stein
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30019/#review68587 --- Ship it! Ship It! - Joe Stein On Jan. 19, 2015, 1:51 a.m., Jun

Re: [VOTE] 0.8.2.0 Candidate 1

2015-01-18 Thread Joe Stein
It works ok in gradle but fails if your using maven. taking a look at the patch you uploaded now. /*** Joe Stein Founder, Principal Consultant Big Data Open Source Security LLC http://www.stealth.ly Twitter: @allthingshadoop

[jira] [Updated] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1761: --- Assignee: Manikumar Reddy (was: Jay Kreps) Status: Patch Available (was: Open)

[jira] [Updated] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1761: --- Attachment: KAFKA-1761.patch num.partitionsdocumented default is 1 while actual

[jira] [Commented] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282178#comment-14282178 ] Manikumar Reddy commented on KAFKA-1761: Created reviewboard

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282131#comment-14282131 ] Gwen Shapira commented on KAFKA-1856: - Patches where A.B.C branch exist, should be

[jira] [Commented] (KAFKA-1728) update 082 docs

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282166#comment-14282166 ] Manikumar Reddy commented on KAFKA-1728: we need to update the default values of

Review Request 30022: Patch for KAFKA-1761

2015-01-18 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30022/ --- Review request for kafka. Bugs: KAFKA-1761

[jira] [Commented] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282185#comment-14282185 ] Manikumar Reddy commented on KAFKA-1761: 1. we need to update the default values

[jira] [Created] (KAFKA-1876) pom file for scala 2.11 should reference a specific version

2015-01-18 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1876: -- Summary: pom file for scala 2.11 should reference a specific version Key: KAFKA-1876 URL: https://issues.apache.org/jira/browse/KAFKA-1876 Project: Kafka Issue Type:

Review Request 30019: Patch for kafka-1876

2015-01-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30019/ --- Review request for kafka. Bugs: kafka-1876

[jira] [Updated] (KAFKA-1876) pom file for scala 2.11 should reference a specific version

2015-01-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1876: --- Attachment: kafka-1876.patch pom file for scala 2.11 should reference a specific version

[jira] [Updated] (KAFKA-1869) Openning some random ports while running kafka service

2015-01-18 Thread QianHu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] QianHu updated KAFKA-1869: -- Description: while running kafka service , four random ports have been opened . In which , and 9092 are

Re: [VOTE] 0.8.2.0 Candidate 1

2015-01-18 Thread Jun Rao
There seems to be an issue with the pom file for kafka_2.11-0.8.2 jar. It references scala-library 2.11, which doesn't exist in maven central (2.11.1, etc do exist). This seems to be an issue in the 0.8.2 beta as well. I tried to reference kafka_2.11-0.8.2 beta in a project and the build failed

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282164#comment-14282164 ] Ashish Kumar Singh commented on KAFKA-1856: --- Updated reviewboard

[jira] [Updated] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-1856: -- Attachment: KAFKA-1856_2015-01-18_21:43:56.patch Add PreCommit Patch Testing

Re: Review Request 29893: Patch for KAFKA-1856

2015-01-18 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29893/ --- (Updated Jan. 19, 2015, 5:44 a.m.) Review request for kafka. Summary

[jira] [Updated] (KAFKA-1876) pom file for scala 2.11 should reference a specific version

2015-01-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1876: --- Status: Patch Available (was: Open) pom file for scala 2.11 should reference a specific version

Re: [kafka-clients] Re: Heads up: KAFKA-1697 - remove code related to ack1 on the broker

2015-01-18 Thread Gwen Shapira
Overall, agree on point #1, less sure on point #2. 1. Some protocols never ever add new errors, while others add errors without bumping versions. HTTP is a good example of the second type. HTTP-451 was added fairly recently, there are some errors specific to NGINX, etc. No one cares. I think we

Re: Review Request 29893: KAFKA-1856: Add PreCommit Patch Testing

2015-01-18 Thread Ashish Singh
On Jan. 17, 2015, 1:48 a.m., Gwen Shapira wrote: dev-utils/test-patch.py, lines 144-145 https://reviews.apache.org/r/29893/diff/1/?file=821575#file821575line144 Can you validate that the hack is still needed? I'm concerned that we are dragging an old hack around that perhaps was

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282180#comment-14282180 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~gwenshap] I have tested both

[jira] [Commented] (KAFKA-1869) Openning some random ports while running kafka service

2015-01-18 Thread QianHu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282209#comment-14282209 ] QianHu commented on KAFKA-1869: --- Thank you !!! Openning some random ports while running

[jira] [Commented] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282051#comment-14282051 ] Ashish Kumar Singh commented on KAFKA-1722: --- Coverity does not support scala at

[jira] [Comment Edited] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282051#comment-14282051 ] Ashish Kumar Singh edited comment on KAFKA-1722 at 1/19/15 12:56 AM:

[jira] [Commented] (KAFKA-1866) LogStartOffset gauge throws exceptions after log.delete()

2015-01-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282056#comment-14282056 ] Jun Rao commented on KAFKA-1866: I think deleting a topic probably can reproduce the issue

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282060#comment-14282060 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~joestein] thanks for the info

[jira] [Created] (KAFKA-1875) Add info on PreCommit Patch Testing to wiki

2015-01-18 Thread Ashish Kumar Singh (JIRA)
Ashish Kumar Singh created KAFKA-1875: - Summary: Add info on PreCommit Patch Testing to wiki Key: KAFKA-1875 URL: https://issues.apache.org/jira/browse/KAFKA-1875 Project: Kafka Issue

[jira] [Commented] (KAFKA-1855) Topic unusable after unsuccessful UpdateMetadataRequest

2015-01-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282073#comment-14282073 ] Jun Rao commented on KAFKA-1855: This could be related to KAFKA-1738. Could you try the

Review Request 30013: Patch for KAFKA-1867

2015-01-18 Thread Jaikiran Pai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30013/ --- Review request for kafka. Bugs: KAFKA-1867

[jira] [Commented] (KAFKA-1867) liveBroker list not updated on a cluster with no topics

2015-01-18 Thread jaikiran pai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281822#comment-14281822 ] jaikiran pai commented on KAFKA-1867: - Created reviewboard

[jira] [Updated] (KAFKA-1867) liveBroker list not updated on a cluster with no topics

2015-01-18 Thread jaikiran pai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jaikiran pai updated KAFKA-1867: Attachment: KAFKA-1867.patch liveBroker list not updated on a cluster with no topics

Re: ProducerFailureHandlingTest.testCannotSendToInternalTopic is failing

2015-01-18 Thread Jaikiran Pai
I could reproduce this consistently when that test *method* is run individually. From what I could gather, the __consumer_offset topic (being accessed in that test) had 50 partitions (default) which took a while for each of them to be assigned a leader and do other initialization and that

Re: ProducerFailureHandlingTest.testCannotSendToInternalTopic is failing

2015-01-18 Thread Harsha
Jaikiran, I can't reproduce the failure of the ProdcuerFailureHandlingTest. I ran the single test . you probably are seeing some errors written to console when you use ./gradlew -i -Dsingle.test . These errors are expected in some unit tests as some of these

[jira] [Commented] (KAFKA-1872) Update Developer Setup

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281803#comment-14281803 ] Manikumar Reddy commented on KAFKA-1872: Thanks for the document. I was able to

Re: [DISCUSS] KIPs

2015-01-18 Thread Jay Kreps
Great! Sounds like everyone is on the same page - I created a template page to make things easier. If you do Tools-Copy on this page you can just fill in the italic portions with your details. - I retrofitted KIP-1 to match this formatting - I added the metadata section people asked

Re: [kafka-clients] Re: Heads up: KAFKA-1697 - remove code related to ack1 on the broker

2015-01-18 Thread Jay Kreps
Hey guys, I really think we are discussing two things here: 1. How should we generally handle changes to the set of errors? Should introducing new errors be considered a protocol change or should we reserve the right to introduce new error codes? 2. Given that this particular change

Re: Review Request 24214: Patch for KAFKA-1374

2015-01-18 Thread Eric Olander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24214/#review68569 --- core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala

[jira] [Commented] (KAFKA-1724) Errors after reboot in single node setup

2015-01-18 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281884#comment-14281884 ] Sriharsha Chintalapani commented on KAFKA-1724: --- [~junrao] Can you please

[jira] [Commented] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281995#comment-14281995 ] Ashish Kumar Singh commented on KAFKA-1722: --- [~bosco] coverall supports scala,

[jira] [Commented] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-18 Thread Don Bosco Durai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282002#comment-14282002 ] Don Bosco Durai commented on KAFKA-1722: There few things to note here: -

Re: [kafka-clients] Re: Heads up: KAFKA-1697 - remove code related to ack1 on the broker

2015-01-18 Thread Jun Rao
Overall, I agree with Jay on both points. 1. I think it's reasonable to add new error codes w/o bumping up the protocol version. In most cases, by adding new error codes, we are just refining the categorization of those unknown errors. So, a client shouldn't behave worse than before as long as

[jira] [Commented] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281977#comment-14281977 ] Ashish Kumar Singh commented on KAFKA-1722: --- After elaborate trials of various

[jira] [Commented] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-18 Thread Don Bosco Durai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281981#comment-14281981 ] Don Bosco Durai commented on KAFKA-1722: Ashish, Coverity is another option. They

[jira] [Comment Edited] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281977#comment-14281977 ] Ashish Kumar Singh edited comment on KAFKA-1722 at 1/18/15 10:18 PM:

[jira] [Commented] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281984#comment-14281984 ] Ashish Kumar Singh commented on KAFKA-1722: --- If we are open to use something

[jira] [Comment Edited] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281984#comment-14281984 ] Ashish Kumar Singh edited comment on KAFKA-1722 at 1/18/15 10:25 PM:

[jira] [Commented] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-18 Thread Don Bosco Durai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281992#comment-14281992 ] Don Bosco Durai commented on KAFKA-1722: coverall also seems to be good. It says

[jira] [Updated] (KAFKA-1722) static analysis code coverage for pci audit needs

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-1722: -- Description: Code coverage is a measure used to describe the degree to which the source