[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293919#comment-14293919
]
Jun Rao commented on KAFKA-1902:
Thanks for the explanation. A couple of things: (1) Since
Hi, Everyone,
We identified a blocker issue related to Yammer jmx reporter (
https://issues.apache.org/jira/browse/KAFKA-1902). We are addressing this
issue right now. Once it's resolved, we will roll out a new RC for voting.
Thanks,
Jun
On Mon, Jan 26, 2015 at 5:14 PM, Otis Gospodnetic
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293840#comment-14293840
]
Jason Rosenberg edited comment on KAFKA-1902 at 1/27/15 7:34 PM:
[
https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhishek Nigam reassigned KAFKA-1888:
-
Assignee: Abhishek Nigam
Add a rolling upgrade system test
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294289#comment-14294289
]
Jun Rao commented on KAFKA-1902:
In Kafka, topic/group/clientId can include only -, _ and
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294287#comment-14294287
]
Jason Rosenberg commented on KAFKA-1902:
Actually, a red flag here too, is why are
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294261#comment-14294261
]
Jason Rosenberg commented on KAFKA-1902:
[~jjkoshy] I did mean to just replace all
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294286#comment-14294286
]
Jun Rao commented on KAFKA-1902:
Is graphite the only reporter using scope? t seems that
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294239#comment-14294239
]
Joel Koshy commented on KAFKA-1902:
---
I meant mytopic$with$dot.myclientId$with$dot
fix
To illustrate my point, I will use allTopicsOwnedPartitionsCount guage
from ZookeeperConsumerConnector as an example. It captures number of
partitions for a topic that has been assigned owner for the consumer group.
let's say that I have a topic with 9 partitions. this metrics should
normally
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294545#comment-14294545
]
Kyle Banker commented on KAFKA-1902:
[~junrao] Agree that the dot may not be common,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/#review69936
---
patch -p1 patch-file does not do the renaming of
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294474#comment-14294474
]
Jun Rao commented on KAFKA-1902:
Making the replacing character configurable is actually
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294499#comment-14294499
]
Joel Koshy commented on KAFKA-1902:
---
Jun - to answer your earlier question. I took a
IIUC, Kafka uses the default registry in yammer metrics to create all kafka
related metrics. We observed a scenario where we found that our default
registry was getting populated by the metrics created by kafka which in
turn was causing other issues down the line. Just wanted to ask if there
was a
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294309#comment-14294309
]
Kyle Banker edited comment on KAFKA-1902 at 1/27/15 10:23 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294309#comment-14294309
]
Kyle Banker edited comment on KAFKA-1902 at 1/27/15 10:25 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293913#comment-14293913
]
Jason Rosenberg commented on KAFKA-1901:
At the very least, this could be updated
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294332#comment-14294332
]
Jason Rosenberg commented on KAFKA-1902:
+1
fix MetricName so that Yammer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/#review69737
---
minor nitpicks
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1729:
--
Attachment: KAFKA-1729.patch
add doc for Kafka-based offset management in 0.8.2
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294645#comment-14294645
]
Joel Koshy commented on KAFKA-1729:
---
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294647#comment-14294647
]
Joel Koshy commented on KAFKA-1729:
---
(Uploaded above patch since we will most likely
I think having dedicated registries would have been a better choice -
it sort of just ended up like this. We made note of this in KAFKA-1567
as well if you read through those comments but concluded that it will
be a larger refactoring at this point - which may not be worth it
since we intend to
I'm not sure if I'm misunderstanding the suggestion, but this metric
was ever intended for alerts. Some metrics are more for informational
purposes than for setting up alerts. In fact it is possible for some
consumers to have zero owned partitions if there are fewer partitions
than consumers in
[
https://issues.apache.org/jira/browse/KAFKA-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294761#comment-14294761
]
Guozhang Wang commented on KAFKA-1235:
--
The patch is actually already committed on
[
https://issues.apache.org/jira/browse/KAFKA-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-1235.
--
Resolution: Fixed
Fix Version/s: (was: 0.9.0)
0.8.2
Enable
[
https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294838#comment-14294838
]
Joe Stein commented on KAFKA-1901:
--
Can we collect that info during a meta data fetch for
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294733#comment-14294733
]
Otis Gospodnetic commented on KAFKA-1902:
-
bq. It's unfortunate it seems graphite
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30321/#review69814
---
core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala
Jun Rao created KAFKA-1902:
--
Summary: fix MetricName so that Yammer reporter can work correctly
Key: KAFKA-1902
URL: https://issues.apache.org/jira/browse/KAFKA-1902
Project: Kafka
Issue Type: Bug
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30321/
---
Review request for kafka.
Bugs: kafka-1902
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28769/#review69804
---
Some of my comments are outside of the scope of this review, so
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293747#comment-14293747
]
Jun Rao commented on KAFKA-1902:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1902:
---
Status: Patch Available (was: Open)
fix MetricName so that Yammer reporter can work correctly
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1902:
---
Attachment: kafka-1902.patch
fix MetricName so that Yammer reporter can work correctly
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293840#comment-14293840
]
Jason Rosenberg commented on KAFKA-1902:
In the yammer metric reporter (which is
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293840#comment-14293840
]
Jason Rosenberg edited comment on KAFKA-1902 at 1/27/15 5:30 PM:
[
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293854#comment-14293854
]
Kyle Banker commented on KAFKA-1902:
This definitely fixes the issue. I'm now seeing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30321/#review69813
---
Ship it!
Ship It!
- Manikumar Reddy O
On Jan. 27, 2015, 4:16
[
https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293825#comment-14293825
]
Dmitry Pekar commented on KAFKA-1792:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Pekar updated KAFKA-1792:
Attachment: KAFKA-1792_2015-01-27_19:09:27.patch
change behavior of --generate to produce
[
https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293825#comment-14293825
]
Dmitry Pekar edited comment on KAFKA-1792 at 1/27/15 5:12 PM:
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30321/#review69940
---
core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30355/
---
Review request for kafka.
Bugs: KAFKA-1729
45 matches
Mail list logo
