[jira] [Updated] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

2015-02-25 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Pekar updated KAFKA-1792: Attachment: (was: rebalance_use_cases.txt) change behavior of --generate to produce assignment

[jira] [Commented] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

2015-02-25 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14336656#comment-14336656 ] Neha Narkhede commented on KAFKA-1792: -- +1. To reduce back-n-forth, it is better to

[jira] [Commented] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

2015-02-25 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14336573#comment-14336573 ] Joe Stein commented on KAFKA-1792: -- [~Dmitry Pekar] we should have this discussion on the

[jira] [Commented] (KAFKA-1961) Looks like its possible to delete _consumer_offsets topic

2015-02-25 Thread Ted Malaska (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14336675#comment-14336675 ] Ted Malaska commented on KAFKA-1961: Let me know if there are any other changes I need

RE: Review Request 31385: Patch for KAFKA-1978

2015-02-25 Thread Abhishek Nigam
2015-02-06 00:51:30,975 - INFO - == 2015-02-06 00:51:30,975 - INFO - Exception while running test list index out of range 2015-02-06 00:51:30,975 - INFO - == Traceback (most recent call

Re: Announcing the Confluent Platform built on Apache Kafka

2015-02-25 Thread Jiangjie Qin
Congrats! On 2/25/15, 11:30 AM, Guozhang Wang wangg...@gmail.com wrote: +1, very nice! On Wed, Feb 25, 2015 at 11:20 AM, Sriram Subramanian srsubraman...@linkedin.com.invalid wrote: Congratulations! On 2/25/15 11:15 AM, Joe Stein joe.st...@stealth.ly wrote: Awesome! The future of

Re: Announcing the Confluent Platform built on Apache Kafka

2015-02-25 Thread Ashish Singh
Congrats guys! On Wed, Feb 25, 2015 at 11:47 AM, Jiangjie Qin j...@linkedin.com.invalid wrote: Congrats! On 2/25/15, 11:30 AM, Guozhang Wang wangg...@gmail.com wrote: +1, very nice! On Wed, Feb 25, 2015 at 11:20 AM, Sriram Subramanian srsubraman...@linkedin.com.invalid wrote:

Re: Announcing the Confluent Platform built on Apache Kafka

2015-02-25 Thread Andrew Otto
Wow, .deb packages. I love you. On Feb 25, 2015, at 14:48, Joseph Lawson jlaw...@roomkey.com wrote: This is really awesome stuff. It's great to see y'all growing! Thank you and congratulations! From: Neha Narkhede n...@confluent.io Sent:

Tips for working with Kafka and data streams

2015-02-25 Thread Jay Kreps
Hey guys, One thing we tried to do along with the product release was start to put together a practical guide for using Kafka. I wrote this up here: http://blog.confluent.io/2015/02/25/stream-data-platform-1/ I'd like to keep expanding on this as good practices emerge and we learn more stuff. So

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-02-25 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14336985#comment-14336985 ] Guozhang Wang commented on KAFKA-1910: -- The uploaded patch contains multiple fixes to

Re: Announcing the Confluent Platform built on Apache Kafka

2015-02-25 Thread Sriram Subramanian
Congratulations! On 2/25/15 11:15 AM, Joe Stein joe.st...@stealth.ly wrote: Awesome! The future of schema management, has arrived ~ Joestein On Wed, Feb 25, 2015 at 1:34 PM, Gwen Shapira gshap...@cloudera.com wrote: Congrats, Confluent team. This is super exciting :) On Wed, Feb

Announcing the Confluent Platform built on Apache Kafka

2015-02-25 Thread Neha Narkhede
Folks, We, at Confluent http://confluent.io, are excited to announce the release of Confluent Platform 1.0 built around Apache Kafka - http://blog.confluent.io/2015/02/25/announcing-the-confluent-platform-1-0/ We also published a detailed two-part guide on how you can put Kafka to use in your

Re: Announcing the Confluent Platform built on Apache Kafka

2015-02-25 Thread Gwen Shapira
Congrats, Confluent team. This is super exciting :) On Wed, Feb 25, 2015 at 10:31 AM, Neha Narkhede n...@confluent.io wrote: Folks, We, at Confluent http://confluent.io, are excited to announce the release of Confluent Platform 1.0 built around Apache Kafka -

Re: Announcing the Confluent Platform built on Apache Kafka

2015-02-25 Thread Joe Stein
Awesome! The future of schema management, has arrived ~ Joestein On Wed, Feb 25, 2015 at 1:34 PM, Gwen Shapira gshap...@cloudera.com wrote: Congrats, Confluent team. This is super exciting :) On Wed, Feb 25, 2015 at 10:31 AM, Neha Narkhede n...@confluent.io wrote: Folks, We,

Re: Announcing the Confluent Platform built on Apache Kafka

2015-02-25 Thread Harsha
Congrats! -Harsha On Wed, Feb 25, 2015, at 11:20 AM, Sriram Subramanian wrote: Congratulations! On 2/25/15 11:15 AM, Joe Stein joe.st...@stealth.ly wrote: Awesome! The future of schema management, has arrived ~ Joestein On Wed, Feb 25, 2015 at 1:34 PM, Gwen Shapira

RE: Review Request 31385: Patch for KAFKA-1978

2015-02-25 Thread Abhishek Nigam
I added debug information and the reason is that the array size, replicaIdxMsgIdList is 2 but the number of files which are being validated are 3. 2015-02-25 00:53:17,882 - INFO - array size: 2 (kafka_system_test_utils) 2015-02-25 00:53:17,882 - INFO - replicaFactor: 2

Unit tests in java7 vs java8

2015-02-25 Thread Gwen Shapira
Hi, Anyone running tests on Java 8? I just noticed that they take almost twice as long to run compared to Java 7 (at least on my box, and with Scala 2.10.4). Anyone else noticed this? Maybe even did some digging on the causes? Gwen

RE: Announcing the Confluent Platform built on Apache Kafka

2015-02-25 Thread Aditya Auradkar
Congrats! From: Andrew Otto [ao...@wikimedia.org] Sent: Wednesday, February 25, 2015 12:06 PM To: us...@kafka.apache.org Cc: dev@kafka.apache.org Subject: Re: Announcing the Confluent Platform built on Apache Kafka Wow, .deb packages. I love you. On

Build failed in Jenkins: KafkaPreCommit #20

2015-02-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/KafkaPreCommit/20/changes Changes: [jjkoshy] KAFKA-1953; KAFKA-1962; Disambiguate purgatory metrics; restore delayed request metrics; reviewed by Guozhang Wang -- [...truncated 834 lines...] kafka.admin.AdminTest

[jira] [Commented] (KAFKA-1985) Document on possible error codes for each response type

2015-02-25 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337193#comment-14337193 ] Gwen Shapira commented on KAFKA-1985: - Awesome awesome idea. However, we should also

Build failed in Jenkins: Kafka-trunk #407

2015-02-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/407/changes Changes: [jjkoshy] KAFKA-1953; KAFKA-1962; Disambiguate purgatory metrics; restore delayed request metrics; reviewed by Guozhang Wang -- [...truncated 820 lines...]

[jira] [Commented] (KAFKA-1985) Document on possible error codes for each response type

2015-02-25 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337214#comment-14337214 ] Jay Kreps commented on KAFKA-1985: -- Totally agree. The documentation for this should

Re: [jira] [Commented] (KAFKA-1664) Kafka does not properly parse multiple ZK nodes with non-root chroot

2015-02-25 Thread Jonathan Creasy
I think this is because it expects the string to be: baelish-001.edh.cloudera.com:2181,baelish-002.edh.cloudera.com:2181,baelis h-003.edh.cloudera.com:2181/kafka I donĀ¹t think you would ever want to have a different root per host. -Jonathan On 2/24/15, 1:04 PM, Ashish Singh (JIRA)

[jira] [Updated] (KAFKA-1881) transient unit test failure in testDeleteTopicWithCleaner due to OOME

2015-02-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1881: - Assignee: Ewen Cheslack-Postava (was: Gwen Shapira) Status: Patch Available

[jira] [Commented] (KAFKA-1881) transient unit test failure in testDeleteTopicWithCleaner due to OOME

2015-02-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337455#comment-14337455 ] Ewen Cheslack-Postava commented on KAFKA-1881: -- Created reviewboard

[jira] [Updated] (KAFKA-1881) transient unit test failure in testDeleteTopicWithCleaner due to OOME

2015-02-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1881: - Attachment: KAFKA-1881.patch transient unit test failure in

[jira] [Updated] (KAFKA-1986) Producer request failure rate should not include InvalidMessageSizeException and OffsetOutOfRangeException

2015-02-25 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar updated KAFKA-1986: --- Status: Patch Available (was: Open) Producer request failure rate should not include

Re: Review Request 31366: Patch for KAFKA-1461

2015-02-25 Thread Eric Olander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31366/#review74160 --- core/src/main/scala/kafka/server/AbstractFetcherThread.scala

[jira] [Commented] (KAFKA-1400) transient unit test failure in SocketServerTest

2015-02-25 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337608#comment-14337608 ] Gwen Shapira commented on KAFKA-1400: - Kinda strange, the TCPDUMP looks the same

[jira] [Reopened] (KAFKA-1400) transient unit test failure in SocketServerTest

2015-02-25 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira reopened KAFKA-1400: - transient unit test failure in SocketServerTest ---

[jira] [Commented] (KAFKA-1865) Add a flush() call to the new producer API

2015-02-25 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337636#comment-14337636 ] Jay Kreps commented on KAFKA-1865: -- Updated reviewboard

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

2015-02-25 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/ --- (Updated Feb. 26, 2015, 1:16 a.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1865) Add a flush() call to the new producer API

2015-02-25 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1865: - Attachment: KAFKA-1865_2015-02-25_17:15:26.patch Add a flush() call to the new producer API

[jira] [Updated] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

2015-02-25 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1929: Attachment: KAFKA-1929.patch Convert core kafka module to use the errors in

[jira] [Updated] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

2015-02-25 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman updated KAFKA-1929: Status: Patch Available (was: Open) Convert core kafka module to use the errors in

Re: Review Request 31306: Patch for KAFKA-1755

2015-02-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review74201 --- core/src/main/scala/kafka/message/ByteBufferMessageSet.scala

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31447/#review74200 --- Ship it! Ah, now I get what dedupe buffer refers to :) I never

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Ewen Cheslack-Postava
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. This happened consistently for me, which provided good motivation to figure out how to fix it :) It looks like the

Review Request 31460: Patch for KAFKA-1929

2015-02-25 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31460/ --- Review request for kafka. Bugs: KAFKA-1929

[jira] [Commented] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

2015-02-25 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337828#comment-14337828 ] Jeff Holoman commented on KAFKA-1929: - Created reviewboard

Re: Tips for working with Kafka and data streams

2015-02-25 Thread Tong Li
+2, these kind of articles coming from the ones who created Kafka always provide great value to Kafka users and developers. For my 2 cents, I would love to see one or two articles for developers who involved in Kafka development on the topics of how to develop test cases and how to run them, what

RE: Unit tests in java7 vs java8

2015-02-25 Thread Guozhang Wang
I am working on the test handing / NPE / failure issues of ConsumerTest only. I currently run Java 8 and the unit test takes about 10 minutes, I can do time ./gradlew test with both versions and see if there is a clear difference. Guozhang From: Jay Kreps

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-02-25 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337621#comment-14337621 ] Jay Kreps commented on KAFKA-1910: -- Where is the RB? Refactor KafkaConsumer

[jira] [Commented] (KAFKA-1664) Kafka does not properly parse multiple ZK nodes with non-root chroot

2015-02-25 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337379#comment-14337379 ] Jonathan Creasy commented on KAFKA-1664: I think this is because it expects the

[jira] [Commented] (KAFKA-1664) Kafka does not properly parse multiple ZK nodes with non-root chroot

2015-02-25 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337382#comment-14337382 ] Jonathan Creasy commented on KAFKA-1664: nevermind, missed Jun's response farther

[jira] [Commented] (KAFKA-1400) transient unit test failure in SocketServerTest

2015-02-25 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337452#comment-14337452 ] Gwen Shapira commented on KAFKA-1400: - and here are the logs : {code}

Review Request 31449: Patch for KAFKA-1986

2015-02-25 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31449/ --- Review request for kafka. Bugs: KAFKA-1986

[jira] [Updated] (KAFKA-1986) Producer request failure rate should not include InvalidMessageSizeException and OffsetOutOfRangeException

2015-02-25 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-1986: - Attachment: KAFKA-1986.patch Producer request failure rate should not include

[jira] [Commented] (KAFKA-1986) Producer request failure rate should not include InvalidMessageSizeException and OffsetOutOfRangeException

2015-02-25 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337506#comment-14337506 ] Aditya A Auradkar commented on KAFKA-1986: -- Created reviewboard

[jira] [Commented] (KAFKA-1978) Replication test_0131 system test has been failing.

2015-02-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337564#comment-14337564 ] Ewen Cheslack-Postava commented on KAFKA-1978: -- [~anigam] Can you explain the

Re: Unit tests in java7 vs java8

2015-02-25 Thread Jay Kreps
Yeah, hey Guozhang, is that fix part of the larger consumer patch you just posted or is that a separate issue? -Jay On Wed, Feb 25, 2015 at 4:25 PM, Gwen Shapira gshap...@cloudera.com wrote: The Consumer tests are currently hanging :( I think Guozhang is working on a solution. I'm commenting

Re: Unit tests in java7 vs java8

2015-02-25 Thread Guozhang Wang
I am working on the test handing / NPE / failure issues of ConsumerTest only as part of the consumer rewriting (KAFKA-1910). I currently run Java 8 and the unit test takes about 10 minutes, I can do time ./gradlew test with both versions and see if there is a clear difference. Guozhang On Wed,

[jira] [Created] (KAFKA-1986) Producer request failure rate should not include InvalidMessageSizeException and OffsetOutOfRangeException

2015-02-25 Thread Aditya Auradkar (JIRA)
Aditya Auradkar created KAFKA-1986: -- Summary: Producer request failure rate should not include InvalidMessageSizeException and OffsetOutOfRangeException Key: KAFKA-1986 URL:

Re: Unit tests in java7 vs java8

2015-02-25 Thread Tong Li
Gwen, I have not tried Java 8. Still on Java 7, but I always run into the test hung problems (no errors on the screen and the system is completely idle), it may be a different problem. I can recreate that problem every time when I run gradle --daemon testAll, I recall that couple of weeks ago

[jira] [Commented] (KAFKA-1460) NoReplicaOnlineException: No replica for partition

2015-02-25 Thread Chad Retz (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337575#comment-14337575 ] Chad Retz commented on KAFKA-1460: -- Likewise, embedded Kafka shutdowns (literally

[jira] [Commented] (KAFKA-1400) transient unit test failure in SocketServerTest

2015-02-25 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337652#comment-14337652 ] Gwen Shapira commented on KAFKA-1400: - On second thought, why do we even try to detect

Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31447/ --- Review request for kafka. Bugs: KAFKA-1881

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

2015-02-25 Thread Bhavesh Mistry
Hi Jiangjie, It might be too late. But, I wanted to bring-up following use case for adopting new MM: 1) Ability to publish message from src topic to different destination topic via --overidenTopics=srcTopic:newDestinationTopic In order to adopt, new MM enhancement customer will compare

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

2015-02-25 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/ --- (Updated Feb. 26, 2015, 1:15 a.m.) Review request for kafka. Summary

Re: Review Request 30763: KAFKA-1865: Producer Flush: if at first your patch doesn't succeed, try, try, try again.

2015-02-25 Thread Jay Kreps
On Feb. 24, 2015, 5:20 p.m., Guozhang Wang wrote: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, line 379 https://reviews.apache.org/r/30763/diff/4/?file=873436#file873436line379 Can also throw SchemaException. Yeah I intentionally left this and

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

2015-02-25 Thread Jiangjie Qin
For 1), the current design allow you to do it. The customizable message handler takes in a ConsumerRecord and spit a ListProducerRecord, you can just put a topic for the ProducerRecord different from ConsumerRecord. WRT performance, we did some test in LinkedIn, the performance looks good to us.

Re: Review Request 29467: Patch for KAFKA-1660

2015-02-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29467/#review74149 --- Could we add some unit tests for this new API, both called by

Re: Unit tests in java7 vs java8

2015-02-25 Thread Gwen Shapira
The Consumer tests are currently hanging :( I think Guozhang is working on a solution. I'm commenting them out until the problem is resolved... On Wed, Feb 25, 2015 at 4:00 PM, Tong Li liton...@us.ibm.com wrote: Gwen, I have not tried Java 8. Still on Java 7, but I always run into the

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

2015-02-25 Thread Jiangjie Qin
On Feb. 24, 2015, 5:20 p.m., Guozhang Wang wrote: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java, line 91 https://reviews.apache.org/r/30763/diff/4/?file=873442#file873442line91 I still think it is kind of waste to create duplicate

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Ewen Cheslack-Postava
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Gwen Shapira
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

2015-02-25 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review74196 --- Thanks for the patch. A few comments below.

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

2015-02-25 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review74229 ---

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Ewen Cheslack-Postava
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Gwen Shapira
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out