[
https://issues.apache.org/jira/browse/KAFKA-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491865#comment-14491865
]
Jun Rao commented on KAFKA-2117:
The issue seems to be that we should be using the
Jun Rao created KAFKA-2117:
--
Summary: OffsetManager uses incorrect field for metadata
Key: KAFKA-2117
URL: https://issues.apache.org/jira/browse/KAFKA-2117
Project: Kafka
Issue Type: Bug
For 1, the issue seems to be that we try to get metadata using the offset
field. Filed KAFKA-2117.
Thanks,
Jun
On Sun, Apr 12, 2015 at 1:12 PM, Jay Kreps jay.kr...@gmail.com wrote:
I see the following issues on trunk when doing almost anything:
1. Offset manager: it looks like this code
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2115:
Description:
Reported by [~jkreps] on the mailing list:
{code}
kafka.common.KafkaException:
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491878#comment-14491878
]
Gwen Shapira edited comment on KAFKA-2115 at 4/13/15 3:44 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491901#comment-14491901
]
Gwen Shapira commented on KAFKA-2115:
-
Updated reviewboard
Andrii,
404. Jay and I chatted a bit. We agreed to leave createTopicRequest as
async for now.
There is another thing.
500. Currently, we have this issue (KAFKA-1367) that the ISR in the
metadata cache can be out of sync. The reason is that ISR is really
maintained at the leader. We can
Andrii,
2. So the idea is to immediately start replicating those replicas on the
failed directory to the other directories? An IOException can be caused by
a disk running out of space. In this case, perhaps an admin may want to
bring down the broker, free up some disk space and restart the
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491878#comment-14491878
]
Gwen Shapira commented on KAFKA-2115:
-
I created a small test that uses the new
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491875#comment-14491875
]
Gwen Shapira commented on KAFKA-2115:
-
Created reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33118/
---
Review request for kafka.
Bugs: KAFKA-2115
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2115:
Attachment: KAFKA-2115.patch
Error updating metrics in RequestChannel
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2115:
Status: Patch Available (was: Open)
Error updating metrics in RequestChannel
On April 13, 2015, 4:16 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java, lines
23-35
https://reviews.apache.org/r/33118/diff/1/?file=924969#file924969line23
Those request names are slightly different from what's in RequestKeys.
To keep
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2115:
Attachment: KAFKA-2115_2015-04-12_21:28:12.patch
Error updating metrics in RequestChannel
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2115:
Status: Patch Available (was: In Progress)
Error updating metrics in RequestChannel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33118/
---
(Updated April 13, 2015, 4:28 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33118/#review79834
---
Thanks for the patch. A couple of comments.
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-2115:
---
Status: In Progress (was: Patch Available)
Error updating metrics in RequestChannel
The second error is a result of KAFKA-2044 - we moved few Requests out
of RequestKeys to the newer ApiKeys, but didn't update the metrics
code.
The only requests that moved were HeartBeat and JoinGroup, which are
part of the new consumer.
I think it will be a good idea to add tests that use new
Gwen Shapira created KAFKA-2115:
---
Summary: Error updating metrics in RequestChannel
Key: KAFKA-2115
URL: https://issues.apache.org/jira/browse/KAFKA-2115
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491471#comment-14491471
]
Sriharsha Chintalapani commented on KAFKA-1397:
---
[~smiklosovic]
It looks
[
https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491494#comment-14491494
]
Sriharsha Chintalapani commented on KAFKA-1397:
---
[~smiklosovic] I did a
[
https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491480#comment-14491480
]
Stefan Miklosovic commented on KAFKA-1397:
--
Yes it is delete.topic.enable, that
I see the following issues on trunk when doing almost anything:
1. Offset manager: it looks like this code has never been run, there is a
type that tries to read the offset as a string.
java.lang.ClassCastException: java.lang.Long cannot be cast to
java.lang.String
at
Also, I just want to remind people that everything in kafka.network should
really be a standalone network server, so that code block in RequestChannel
that hard codes stuff about followers is really wrong.
-Jay
On Sun, Apr 12, 2015 at 1:12 PM, Jay Kreps jay.kr...@gmail.com wrote:
I see the
[
https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491698#comment-14491698
]
Jay Kreps commented on KAFKA-1910:
--
Hey [~guozhang], on the whole this made things a lot
Gwen Shapira created KAFKA-2116:
---
Summary: Add code that uses new consumer to system_tests
Key: KAFKA-2116
URL: https://issues.apache.org/jira/browse/KAFKA-2116
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2115:
Description:
Reported by [~jkreps] on the mailing list:
kafka.common.KafkaException: Wrong
Jun
1. Hm, it looks like I didn't take this case into account in KIP.
I see your point. Why don't we do the same thing as with reassign
partitions - let's setup new (or
reuse) ReassignedPartitionsIsrChangeListener
that will check whether brokers that requested partitions restart
catch up (in isr
30 matches
Mail list logo
