[GitHub] kafka pull request: KAFKA-2406[WIP]: Throttle ISR propagation

2015-08-05 Thread becketqin
GitHub user becketqin opened a pull request: https://github.com/apache/kafka/pull/114 KAFKA-2406[WIP]: Throttle ISR propagation This is a follow up patch for KAFKA-2406. Further test to verify if this change alone is enough to solve the problem or not. You can merge this pull requ

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654923#comment-14654923 ] ASF GitHub Bot commented on KAFKA-2406: --- GitHub user becketqin opened a pull request

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-08-05 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654927#comment-14654927 ] Stevo Slavic commented on KAFKA-2351: - Running single instance of Kafka broker from la

[jira] [Commented] (KAFKA-1684) Implement TLS/SSL authentication

2015-08-05 Thread Navjot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655162#comment-14655162 ] Navjot commented on KAFKA-1684: --- Thanks for your help, We're now able to use the patch avail

[jira] [Commented] (KAFKA-1684) Implement TLS/SSL authentication

2015-08-05 Thread Navjot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655163#comment-14655163 ] Navjot commented on KAFKA-1684: --- Thanks for your help, We're now able to use the patch avail

[jira] [Commented] (KAFKA-1684) Implement TLS/SSL authentication

2015-08-05 Thread Navjot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655165#comment-14655165 ] Navjot commented on KAFKA-1684: --- Thanks for your help, We're now able to use the patch avail

[jira] [Issue Comment Deleted] (KAFKA-1684) Implement TLS/SSL authentication

2015-08-05 Thread Navjot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Navjot updated KAFKA-1684: -- Comment: was deleted (was: Thanks for your help, We're now able to use the patch available there. Much apprecia

[jira] [Issue Comment Deleted] (KAFKA-1684) Implement TLS/SSL authentication

2015-08-05 Thread Navjot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Navjot updated KAFKA-1684: -- Comment: was deleted (was: Thanks for your help, We're now able to use the patch available there. Much apprecia

Re: Modified the contribution pages in the wiki

2015-08-05 Thread Ismael Juma
Thanks for making it clearer Gwen. One less item on my to-do list. :) More below. On Tue, Aug 4, 2015 at 11:56 PM, Gwen Shapira wrote: > There's always a plan! > > The contributor page only lists github as a valid contribution method. > > Theoretically the committers / reviewers should start ask

Re: Modified the contribution pages in the wiki

2015-08-05 Thread Ismael Juma
Hi Gwen, I moved some text from https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review to https://cwiki.apache.org/confluence/display/KAFKA/Patch+Review+Tool and made a few other minor tweaks. I think it's even clearer this way. Please let me know if you disagree. Thanks, I

[jira] [Commented] (KAFKA-2405) KafkaHealthCheck kills the JVM in handleSessionEstablishmentError

2015-08-05 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658285#comment-14658285 ] Ismael Juma commented on KAFKA-2405: We have 43 instances of `System.exit` in `core` a

JIRA KAFKA-1716

2015-08-05 Thread Chris Barlock
While I don't have a patch to contribute today, per the "Nag us" note here: http://kafka.apache.org/contributing.html I'm wondering if we could get some attention to https://issues.apache.org/jira/browse/KAFKA-1716 We recently upgraded to Kafka 0.8.2.1 and hit a deadlock every time we shutdo

Re: Review Request 34641: Patch for KAFKA-2214

2015-08-05 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/ --- (Updated Aug. 5, 2015, 3:19 p.m.) Review request for kafka. Bugs: KAFKA-2214

[jira] [Updated] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-08-05 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2214: --- Attachment: KAFKA-2214_2015-08-05_20:47:17.patch > kafka-reassign-partitions.sh --verify shoul

Re: Review Request 34641: Patch for KAFKA-2214

2015-08-05 Thread Manikumar Reddy O
> On July 21, 2015, 1:50 p.m., Ismael Juma wrote: > > Thanks for the suggestions. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review92403

[jira] [Updated] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-08-05 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2214: --- Status: Patch Available (was: In Progress) > kafka-reassign-partitions.sh --verify should ret

[jira] [Commented] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-08-05 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658357#comment-14658357 ] Manikumar Reddy commented on KAFKA-2214: Updated reviewboard https://reviews.apach

Re: Review Request 34641: Patch for KAFKA-2214

2015-08-05 Thread Manikumar Reddy O
> On July 17, 2015, 5:03 a.m., Gwen Shapira wrote: > > Just realized that verifyAssigment runs on a Map of and > > originally printed status for each partition (some can succeed, fail or be > > in-progress). > > > > We need to return a single error code. In the existing code, we return 0 if

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658417#comment-14658417 ] Jun Rao commented on KAFKA-2406: [~becket_qin], thanks for the patch. Have you tested the

Re: Modified the contribution pages in the wiki

2015-08-05 Thread Gwen Shapira
Completely agree! Thank you for reviewing and improving. On Wed, Aug 5, 2015 at 7:22 AM, Ismael Juma wrote: > Hi Gwen, > > I moved some text from > > https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review > to https://cwiki.apache.org/confluence/display/KAFKA/Patch+Rev

[jira] [Commented] (KAFKA-2405) KafkaHealthCheck kills the JVM in handleSessionEstablishmentError

2015-08-05 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658510#comment-14658510 ] Gwen Shapira commented on KAFKA-2405: - It is supported to create KafkaServer by instan

Re: JIRA KAFKA-1716

2015-08-05 Thread Jiangjie Qin
Looking at the stacktrace and I am wondering if it has been solved in KAFKA-2241. Thanks, Jiangjie (Becket) Qin On Wed, Aug 5, 2015 at 8:00 AM, Chris Barlock wrote: > While I don't have a patch to contribute today, per the "Nag us" note > here: > > http://kafka.apache.org/contributing.html > >

Re: New Consumer API and Range Consumption with Fail-over

2015-08-05 Thread Jason Gustafson
Hey Bhavesh, I think your use case can be handled with the new consumer API in roughly the manner I suggested previously. It might be a little easier if we added the ability to set the end offset for consumption. Perhaps something like this: // stop consumption from the partition when offset is r

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658531#comment-14658531 ] Jiangjie Qin commented on KAFKA-2406: - Hi [~junrao], I'm doing the test right now. Thi

[jira] [Commented] (KAFKA-2390) Seek() should take a callback.

2015-08-05 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658534#comment-14658534 ] Jason Gustafson commented on KAFKA-2390: [~becket_qin] I can see where this might

Re: New Consumer API and Range Consumption with Fail-over

2015-08-05 Thread Bhavesh Mistry
Hi Jason, Thanks for info. I will implement (by end of next week) what you have proposed. If I encounter any issue, I will let you know. Indeed, adding new API would be uphill battle. I did follow email chain "Re: Kafka Consumer thoughts". Thanks, Bhavesh On Wed, Aug 5, 2015 at 10:03 AM, J

[jira] [Commented] (KAFKA-2390) Seek() should take a callback.

2015-08-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658541#comment-14658541 ] Dong Lin commented on KAFKA-2390: - [~hachikuji] Per discussion with [~becket_qin], the mot

[jira] [Commented] (KAFKA-2390) Seek() should take a callback.

2015-08-05 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658548#comment-14658548 ] Jason Gustafson commented on KAFKA-2390: [~lindong] Yeah, that makes sense. Perhap

[jira] [Commented] (KAFKA-2390) Seek() should take a callback.

2015-08-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658550#comment-14658550 ] Dong Lin commented on KAFKA-2390: - [~hachikuji] Yeah we definitely should do it. I will up

[jira] [Created] (KAFKA-2407) Only create a log directory when it will be used

2015-08-05 Thread Grant Henke (JIRA)
Grant Henke created KAFKA-2407: -- Summary: Only create a log directory when it will be used Key: KAFKA-2407 URL: https://issues.apache.org/jira/browse/KAFKA-2407 Project: Kafka Issue Type: Bug

Re: Modified the contribution pages in the wiki

2015-08-05 Thread Jiangjie Qin
Hi Gwen, I just added one sentence saying we would prefer PR for new patches. Let me know if you think it is too verbose. Thanks, Jiangjie (Becket) Qin On Wed, Aug 5, 2015 at 8:57 AM, Gwen Shapira wrote: > Completely agree! Thank you for reviewing and improving. > > > > > > On Wed, Aug 5, 201

Re: Modified the contribution pages in the wiki

2015-08-05 Thread Gwen Shapira
The sentence is good, but I think we route new developers to here: https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes Can you check if this page makes it clear that we take PRs and PRs only? Gwen On Wed, Aug 5, 2015 at 10:36 AM, Jiangjie Qin wrote: > Hi Gwen, > > I jus

[GitHub] kafka pull request: KAFKA-2407: Only create log directory when it ...

2015-08-05 Thread granthenke
GitHub user granthenke opened a pull request: https://github.com/apache/kafka/pull/115 KAFKA-2407: Only create log directory when it will be used You can merge this pull request into a Git repository by running: $ git pull https://github.com/granthenke/kafka log-fix Alternati

[jira] [Commented] (KAFKA-2407) Only create a log directory when it will be used

2015-08-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658594#comment-14658594 ] ASF GitHub Bot commented on KAFKA-2407: --- GitHub user granthenke opened a pull reques

[jira] [Updated] (KAFKA-2407) Only create a log directory when it will be used

2015-08-05 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2407: --- Status: Patch Available (was: Open) > Only create a log directory when it will be used >

Re: Modified the contribution pages in the wiki

2015-08-05 Thread Jiangjie Qin
Yes, that page is crystal clear that we are using PR only :) Jiangjie (Becket) Qin On Wed, Aug 5, 2015 at 10:56 AM, Gwen Shapira wrote: > The sentence is good, but I think we route new developers to here: > https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes > > Can you

[jira] [Updated] (KAFKA-2390) Seek() should take a callback.

2015-08-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2390: Description: Currently seek is an async call. To have the same interface as other calls like commit(), seek(

[GitHub] kafka pull request: KAFKA-2407: Only create log directory when it ...

2015-08-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Updated] (KAFKA-2407) Only create a log directory when it will be used

2015-08-05 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2407: Resolution: Fixed Reviewer: Gwen Shapira Status: Resolved (was: Patch Available) Push

[jira] [Commented] (KAFKA-2407) Only create a log directory when it will be used

2015-08-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658669#comment-14658669 ] ASF GitHub Bot commented on KAFKA-2407: --- Github user asfgit closed the pull request

[GitHub] kafka pull request: KAFKA-2400; expose heartbeat interval in Kafka...

2015-08-05 Thread hachikuji
GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/116 KAFKA-2400; expose heartbeat interval in KafkaConsumer configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/hachikuji/kafka KAFKA-2400

[jira] [Created] (KAFKA-2408) (new) system tests: ConsoleConsumerService occasionally fails to register consumed message

2015-08-05 Thread Geoffrey Anderson (JIRA)
Geoffrey Anderson created KAFKA-2408: Summary: (new) system tests: ConsoleConsumerService occasionally fails to register consumed message Key: KAFKA-2408 URL: https://issues.apache.org/jira/browse/KAFKA-2408

[jira] [Commented] (KAFKA-2400) Expose heartbeat frequency in new consumer configuration

2015-08-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658686#comment-14658686 ] ASF GitHub Bot commented on KAFKA-2400: --- GitHub user hachikuji opened a pull request

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658685#comment-14658685 ] Jun Rao commented on KAFKA-2406: [~becket_qin], another way to reduce the overhead is to b

[jira] [Updated] (KAFKA-2400) Expose heartbeat frequency in new consumer configuration

2015-08-05 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2400: --- Reviewer: Guozhang Wang Status: Patch Available (was: Open) > Expose heartbeat frequenc

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-08-05 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658749#comment-14658749 ] Mayuresh Gharat commented on KAFKA-2351: [~sslavic] I think this is different. Tha

[GitHub] kafka pull request: KAFKA-2401: fix transient failure in ProducerS...

2015-08-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Resolved] (KAFKA-2401) Fix transient failure of ProducerSendTest.testCloseWithZeroTimeoutFromSenderThread()

2015-08-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-2401. -- Resolution: Fixed Fix Version/s: 0.8.3 Issue resolved by pull request 113 [https://github

[jira] [Commented] (KAFKA-2401) Fix transient failure of ProducerSendTest.testCloseWithZeroTimeoutFromSenderThread()

2015-08-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658755#comment-14658755 ] ASF GitHub Bot commented on KAFKA-2401: --- Github user asfgit closed the pull request

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658781#comment-14658781 ] Jiangjie Qin commented on KAFKA-2406: - [~junrao], I'm still doing the test, here is wh

[jira] [Created] (KAFKA-2409) Have KafkaConsumer.committed() return null when there is no committed offset

2015-08-05 Thread Jason Gustafson (JIRA)
Jason Gustafson created KAFKA-2409: -- Summary: Have KafkaConsumer.committed() return null when there is no committed offset Key: KAFKA-2409 URL: https://issues.apache.org/jira/browse/KAFKA-2409 Projec

[jira] [Updated] (KAFKA-2409) Have KafkaConsumer.committed() return null when there is no committed offset

2015-08-05 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2409: --- Issue Type: Sub-task (was: Improvement) Parent: KAFKA-2387 > Have KafkaConsumer.commi

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658909#comment-14658909 ] Ashish K Singh commented on KAFKA-2406: --- [~junrao], [~becket_qin] it sounds like we

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658922#comment-14658922 ] Jun Rao commented on KAFKA-2406: [~becket_qin], are you suggesting not using sequential ZK

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658929#comment-14658929 ] Jiangjie Qin commented on KAFKA-2406: - [~ashishujjain], the large number of ISR change

Re: Review Request 36548: Patch for KAFKA-2336

2015-08-05 Thread Grant Henke
> On July 17, 2015, 4:26 a.m., Jiangjie Qin wrote: > > Looks good to me. > > Jiangjie Qin wrote: > Actually do we need to talk to Zookeeper every time? Can we read the data > from topic metadata cache directly? > > Gwen Shapira wrote: > Good point, Jiangjie - looks like partitionFor is

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658944#comment-14658944 ] Ashish K Singh commented on KAFKA-2406: --- Makes sense. Can I suggest that we still ke

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658968#comment-14658968 ] Jiangjie Qin commented on KAFKA-2406: - [~junrao], I was thinking to have a sequential

[jira] [Comment Edited] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658968#comment-14658968 ] Jiangjie Qin edited comment on KAFKA-2406 at 8/5/15 9:24 PM: -

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658974#comment-14658974 ] Jiangjie Qin commented on KAFKA-2406: - I just tried the WIP patch, no luck. I'll try o

[jira] [Issue Comment Deleted] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2406: Comment: was deleted (was: I just tried the WIP patch, no luck. I'll try out the solution we just d

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659007#comment-14659007 ] Jun Rao commented on KAFKA-2406: [~singhashish], yes, ideally we want to propagate isr asa

[GitHub] kafka pull request: KAFKA-2393: Correctly Handle InvalidTopicExcep...

2015-08-05 Thread granthenke
GitHub user granthenke opened a pull request: https://github.com/apache/kafka/pull/117 KAFKA-2393: Correctly Handle InvalidTopicException in KafkaApis.getTo… …picMetadata() You can merge this pull request into a Git repository by running: $ git pull https://github.com/grant

[jira] [Commented] (KAFKA-2393) Correctly Handle InvalidTopicException in KafkaApis.getTopicMetadata()

2015-08-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659017#comment-14659017 ] ASF GitHub Bot commented on KAFKA-2393: --- GitHub user granthenke opened a pull reques

[jira] [Updated] (KAFKA-2393) Correctly Handle InvalidTopicException in KafkaApis.getTopicMetadata()

2015-08-05 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2393: --- Fix Version/s: 0.8.3 Status: Patch Available (was: Open) > Correctly Handle InvalidTopicEx

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659039#comment-14659039 ] Jun Rao commented on KAFKA-2406: [~becket_qin], the ZK watcher is a one-time watcher. So,

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-08-05 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659065#comment-14659065 ] Ashish K Singh commented on KAFKA-1690: --- [~harsha_ch] sure, no issues. Also, do we h

[jira] [Commented] (KAFKA-1229) Reload broker config without a restart

2015-08-05 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659071#comment-14659071 ] Aditya Auradkar commented on KAFKA-1229: Hey [~vamsi360], We recently did a prett

[jira] [Created] (KAFKA-2410) Implement "Auto Topic Creation" client side and remove support from Broker side

2015-08-05 Thread Grant Henke (JIRA)
Grant Henke created KAFKA-2410: -- Summary: Implement "Auto Topic Creation" client side and remove support from Broker side Key: KAFKA-2410 URL: https://issues.apache.org/jira/browse/KAFKA-2410 Project: Ka

Re: Review Request 28096: Patch for KAFKA-313

2015-08-05 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/ --- (Updated Aug. 5, 2015, 10:37 p.m.) Review request for kafka, Gwen Shapira, Jare

Re: Review Request 28096: Patch for KAFKA-313

2015-08-05 Thread Ashish Singh
> On July 30, 2015, 2:11 p.m., Ismael Juma wrote: > > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala, line 45 > > > > > > Do we really need this var or can this be passed as a parameter to the > > relevant

[jira] [Commented] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-08-05 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659105#comment-14659105 ] Ashish K Singh commented on KAFKA-313: -- Updated reviewboard https://reviews.apache.org

Re: Review Request 28096: Patch for KAFKA-313

2015-08-05 Thread Ashish Singh
> On July 29, 2015, 6:35 p.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala, lines 36-39 > > > > > > Shouldn't this be an inner object? since its only visible and used by > > Consu

[jira] [Updated] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-08-05 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-313: - Status: Patch Available (was: In Progress) > Add JSON/CSV output and looping options to ConsumerGr

[jira] [Updated] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-08-05 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-313: - Attachment: KAFKA-313_2015-08-05_15:37:32.patch > Add JSON/CSV output and looping options to Consum

Re: Review Request 28096: Patch for KAFKA-313

2015-08-05 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/ --- (Updated Aug. 5, 2015, 10:43 p.m.) Review request for kafka, Gwen Shapira, Jare

[jira] [Updated] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-08-05 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-313: - Attachment: KAFKA-313_2015-08-05_15:43:00.patch > Add JSON/CSV output and looping options to Consum

[jira] [Commented] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-08-05 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659110#comment-14659110 ] Ashish K Singh commented on KAFKA-313: -- Updated reviewboard https://reviews.apache.org

[GitHub] kafka pull request: KAFKA-2393: Correctly Handle InvalidTopicExcep...

2015-08-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (KAFKA-2393) Correctly Handle InvalidTopicException in KafkaApis.getTopicMetadata()

2015-08-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659134#comment-14659134 ] ASF GitHub Bot commented on KAFKA-2393: --- Github user asfgit closed the pull request

[jira] [Updated] (KAFKA-2393) Correctly Handle InvalidTopicException in KafkaApis.getTopicMetadata()

2015-08-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2393: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch. Committed to trunk.

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659147#comment-14659147 ] Jiangjie Qin commented on KAFKA-2406: - [~ashishujjain] [~junrao], sure, we can make th

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659158#comment-14659158 ] Guozhang Wang commented on KAFKA-2397: -- I once considered letting KafkaApis to handle

Build failed in Jenkins: Kafka-trunk #572

2015-08-05 Thread Apache Jenkins Server
See Changes: [junrao] KAFKA-2393: Correctly Handle InvalidTopicException in KafkaApis.getTo��� -- [...truncated 1517 lines...] kafka.api.test.ProducerCompressionTest > testCompression[0] PASSED kafk

[jira] [Created] (KAFKA-2411) remove usage of BlockingChannel in the broker

2015-08-05 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-2411: -- Summary: remove usage of BlockingChannel in the broker Key: KAFKA-2411 URL: https://issues.apache.org/jira/browse/KAFKA-2411 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-08-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659174#comment-14659174 ] Jun Rao commented on KAFKA-1690: [~singhashish], thanks for the reminder. File KAFKA-2411

[jira] [Commented] (KAFKA-2411) remove usage of BlockingChannel in the broker

2015-08-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659184#comment-14659184 ] Jun Rao commented on KAFKA-2411: For AbstractFetcherThread, we could potentially use Netwo

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-05 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659185#comment-14659185 ] Gwen Shapira commented on KAFKA-2397: - No, SocketServer may be aware of host:port of c

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-08-05 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659188#comment-14659188 ] Ashish K Singh commented on KAFKA-1690: --- Thanks [~junrao]! > new java producer need

[GitHub] kafka pull request: MINOR: ConsumerRecords are organized per topic...

2015-08-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/92 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] kafka pull request: MINOR: auto.offset.reset docs not in sync with...

2015-08-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] kafka pull request: MINOR: Fixed javadoc for committed return valu...

2015-08-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[jira] [Assigned] (KAFKA-2411) remove usage of BlockingChannel in the broker

2015-08-05 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-2411: -- Assignee: Ismael Juma > remove usage of BlockingChannel in the broker > ---

[GitHub] kafka pull request: MINOR - Fix typo in ReplicaVerificationTool ou...

2015-08-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (KAFKA-2406) ISR propagation should be throttled to avoid overwhelming controller.

2015-08-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659217#comment-14659217 ] Jun Rao commented on KAFKA-2406: [~becket_qin], we can probably do a quick KIP on the conf

Re: Review Request 36652: Patch for KAFKA-2351

2015-08-05 Thread Jun Rao
> On July 24, 2015, 5:01 p.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/network/SocketServer.scala, line 264 > > > > > > Hi Jun, > > Cleaning up in finally is actually nice. I will make the necessary

[GitHub] kafka pull request: KAFKA-2390; Seek() should take a callback

2015-08-05 Thread lindong28
GitHub user lindong28 opened a pull request: https://github.com/apache/kafka/pull/118 KAFKA-2390; Seek() should take a callback You can merge this pull request into a Git repository by running: $ git pull https://github.com/lindong28/kafka KAFKA-2390 Alternatively you can rev

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

2015-08-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659235#comment-14659235 ] Jun Rao commented on KAFKA-2351: [~mgharat], sorry the delay. Just replied on RB. > Broke

[jira] [Commented] (KAFKA-2390) Seek() should take a callback.

2015-08-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659236#comment-14659236 ] ASF GitHub Bot commented on KAFKA-2390: --- GitHub user lindong28 opened a pull request

[jira] [Created] (KAFKA-2412) Documentation bug: Add information for key.serializer and value.serializer to New Producer Config sections

2015-08-05 Thread Jeremy Fields (JIRA)
Jeremy Fields created KAFKA-2412: Summary: Documentation bug: Add information for key.serializer and value.serializer to New Producer Config sections Key: KAFKA-2412 URL: https://issues.apache.org/jira/browse/KAFK

  1   2   >