Re: [DISCUSS] KIP-519: Make SSL context/engine configuration extensible

2019-10-16 Thread Maulin Vasavada
bump! On Sun, Oct 13, 2019 at 11:16 PM Maulin Vasavada wrote: > Hi Clement > > 1) existing validation code will remain in SslFactory > 2) the createEngine() method in SslEngineBuilder will move to SslFactory > and the client/server mode setting will go there (I documented this in the > latest

[jira] [Resolved] (KAFKA-8891) invalid assignment protocol java.lang.IllegalStateException: Coordinator selected invalid assignment protocol: null

2019-10-16 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8891. -- Fix Version/s: 2.4.0 Resolution: Fixed > invalid assignment protocol

[jira] [Resolved] (KAFKA-7263) Container exception java.lang.IllegalStateException: Coordinator selected invalid assignment protocol: null

2019-10-16 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-7263. -- Fix Version/s: 2.4.0 Resolution: Fixed > Container exception

[jira] [Resolved] (KAFKA-9000) Flaky Test KTableKTableForeignKeyJoinIntegrationTest.doLeftJoinFromRightThenDeleteRightEntity

2019-10-16 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9000. -- Fix Version/s: 2.4.0 Resolution: Fixed > Flaky Test >

Build failed in Jenkins: kafka-2.4-jdk8 #21

2019-10-16 Thread Apache Jenkins Server
See Changes: [wangguoz] Explain the separate upgrade paths for consumer groups and Streams -- [...truncated 5.41 MB...] org.apache.kafka.streams.TopologyTestDriverTest >

Re: [VOTE] KIP-534: Retain tombstones for approximately delete.retention.ms milliseconds

2019-10-16 Thread Richard Yu
Hi Guozhang, Your understanding basically is on point. I haven't looked into the details for what happens if we change the base timestamp and how its calculated, so I'm not clear on how small the delta (or big) is. To be fair, would the the delta size pose a big problem if it takes up more bytes

[jira] [Created] (KAFKA-9058) Foreign Key Join should not require a queriable store

2019-10-16 Thread John Roesler (Jira)
John Roesler created KAFKA-9058: --- Summary: Foreign Key Join should not require a queriable store Key: KAFKA-9058 URL: https://issues.apache.org/jira/browse/KAFKA-9058 Project: Kafka Issue

Build failed in Jenkins: kafka-2.0-jdk8 #299

2019-10-16 Thread Apache Jenkins Server
See Changes: [rhauch] KAFKA-8340, KAFKA-8819: Use PluginClassLoader while statically -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment

Re: [DISCUSS] KIP-535: Allow state stores to serve stale reads during rebalance

2019-10-16 Thread Navinder Brar
@Vinoth, I have incorporated a few of the discussions we have had in the KIP.  In the current code, t0 and t1 serve queries from Active(Running) partition. For case t2, we are planning to return List such that it returns so that if IQ fails on A, the replica on B can serve the data by

Build failed in Jenkins: kafka-2.1-jdk8 #237

2019-10-16 Thread Apache Jenkins Server
See Changes: [rhauch] KAFKA-8340, KAFKA-8819: Use PluginClassLoader while statically -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment

Jenkins build is back to normal : kafka-trunk-jdk8 #3975

2019-10-16 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-534: Retain tombstones for approximately delete.retention.ms milliseconds

2019-10-16 Thread Guozhang Wang
Hello Richard, Thanks for the KIP, I just have one clarification regarding "So the idea is to set the base timestamp to the delete horizon and adjust the deltas accordingly." My understanding is that during compaction, for each compacted new segment, we would set its base offset of each batch as

[jira] [Resolved] (KAFKA-6890) Add connector level configurability for producer/consumer client configs

2019-10-16 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-6890. -- Resolution: Duplicate This has been implemented via

[jira] [Created] (KAFKA-9057) Backport KAFKA-8819 and KAFKA-8340 to 1.1 and 1.0 branches

2019-10-16 Thread Randall Hauch (Jira)
Randall Hauch created KAFKA-9057: Summary: Backport KAFKA-8819 and KAFKA-8340 to 1.1 and 1.0 branches Key: KAFKA-9057 URL: https://issues.apache.org/jira/browse/KAFKA-9057 Project: Kafka

[jira] [Resolved] (KAFKA-8819) Plugin path for converters not working as intended

2019-10-16 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8819. -- Reviewer: Randall Hauch Assignee: Greg Harris (was: Magesh kumar Nandakumar)

[jira] [Resolved] (KAFKA-8340) ServiceLoader fails when used from isolated plugin path directory

2019-10-16 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8340. -- Reviewer: Randall Hauch Resolution: Fixed > ServiceLoader fails when used from isolated

Jenkins build is back to normal : kafka-trunk-jdk11 #887

2019-10-16 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-534: Retain tombstones for approximately delete.retention.ms milliseconds

2019-10-16 Thread Jason Gustafson
+1. Thanks Richard. On Wed, Oct 16, 2019 at 10:04 AM Richard Yu wrote: > Hi all, > > Want to try to get this KIP wrapped up. So it would be great if we can get > some votes. > > Cheers, > Richard > > On Tue, Oct 15, 2019 at 12:58 PM Jun Rao wrote: > > > Hi, Richard, > > > > Thanks for the

[jira] [Created] (KAFKA-9056) Selector outbound byte metric does not count partial sends

2019-10-16 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-9056: -- Summary: Selector outbound byte metric does not count partial sends Key: KAFKA-9056 URL: https://issues.apache.org/jira/browse/KAFKA-9056 Project: Kafka

Build failed in Jenkins: kafka-2.4-jdk8 #20

2019-10-16 Thread Apache Jenkins Server
See Changes: [matthias] MINOR: Update Kafka Streams upgrade docs for KIP-444, KIP-470, KIP-471, -- [...truncated 2.68 MB...]

[jira] [Resolved] (KAFKA-8603) Document upgrade path

2019-10-16 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-8603. Resolution: Fixed > Document upgrade path > - > >

[jira] [Created] (KAFKA-9055) ProducerPerformance and ConsumerPerformance to be used directly from code

2019-10-16 Thread Piotr Pietrzak (Jira)
Piotr Pietrzak created KAFKA-9055: - Summary: ProducerPerformance and ConsumerPerformance to be used directly from code Key: KAFKA-9055 URL: https://issues.apache.org/jira/browse/KAFKA-9055 Project:

Re: [DISCUSS] KIP-221: Repartition Topic Hints in Streams

2019-10-16 Thread Sophie Blee-Goldman
Hey Levani, I think people are busy with the upcoming 2.4 release, and don't have much spare time at the moment. It's kind of a difficult time to get attention on things, but feel free to pick up something else to work on in the meantime until things have calmed down a bit! Cheers, Sophie On

[jira] [Created] (KAFKA-9054) Kafka client with misconfigured TLS gets stuck in a loop

2019-10-16 Thread Brent Farrell (Jira)
Brent Farrell created KAFKA-9054: Summary: Kafka client with misconfigured TLS gets stuck in a loop Key: KAFKA-9054 URL: https://issues.apache.org/jira/browse/KAFKA-9054 Project: Kafka Issue

[jira] [Created] (KAFKA-9053) AssignmentInfo#encode hardcodes the LATEST_SUPPORTED_VERSION

2019-10-16 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-9053: -- Summary: AssignmentInfo#encode hardcodes the LATEST_SUPPORTED_VERSION Key: KAFKA-9053 URL: https://issues.apache.org/jira/browse/KAFKA-9053 Project:

Build failed in Jenkins: kafka-2.4-jdk8 #19

2019-10-16 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-9032: Bypass serdes for tombstones (#7518) -- [...truncated 2.68 MB...] org.apache.kafka.streams.internals.KeyValueStoreFacadeTest >

[jira] [Created] (KAFKA-9052) KIP-538: Add a metric tracking the number of open connections with a given SSL cipher type

2019-10-16 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-9052: --- Summary: KIP-538: Add a metric tracking the number of open connections with a given SSL cipher type Key: KAFKA-9052 URL: https://issues.apache.org/jira/browse/KAFKA-9052

Re: [VOTE] KIP-352: Distinguish URPs caused by reassignment

2019-10-16 Thread Ismael Juma
The current proposal says that replication throughput would change not to include reassignment though. Ismael On Wed, Oct 16, 2019, 11:53 AM Colin McCabe wrote: > Hi Ismael, > > I think every replica is doing replication, by definition. But not every > replica is undergoing reassignment. > >

Build failed in Jenkins: kafka-trunk-jdk11 #886

2019-10-16 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-9032: Bypass serdes for tombstones (#7518) [wangguoz] KAFKA-9039: Optimize ReplicaFetcher fetch path (#7443) -- [...truncated 2.69 MB...]

[DISCUSS] KIP-538: Add a metric tracking the number of open connections with a given SSL cipher type

2019-10-16 Thread Colin McCabe
Hi all, I wrote a short KIP about adding a metric to track the number of open connections with a given SSL cipher type. Take a look here: https://cwiki.apache.org/confluence/x/txPjBw best, Colin

Re: [VOTE] KIP-352: Distinguish URPs caused by reassignment

2019-10-16 Thread Colin McCabe
Hi Ismael, I think every replica is doing replication, by definition. But not every replica is undergoing reassignment. If the broker that died was in the set of new replicas being added, its death will not add a new under-replicated partition. Otherwise, it will add a new URP. best, Colin

Re: [VOTE] KIP-352: Distinguish URPs caused by reassignment

2019-10-16 Thread Ismael Juma
If a broker dies and loses the disk, is it replication or reassignment? Ismael On Thu, Oct 10, 2019 at 3:30 AM Viktor Somogyi-Vass wrote: > Hi All, > > During the code review it came up that we shouldn't count replication bytes > together with reassignment bytes so they count to a different

Re: [DISCUSS] KIP-537: Increase default zookeeper session timeout

2019-10-16 Thread Ismael Juma
Thanks for the KIP, +1 (binding). Ismael On Tue, Oct 15, 2019 at 4:41 PM Jason Gustafson wrote: > Hi All, > > I have a short KIP to raise the default zk session timeout: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout > . > Please

Re: [DISCUSS] KIP-221: Repartition Topic Hints in Streams

2019-10-16 Thread Levani Kokhreidze
Hello all, Sorry for bringing this thread again, but I would like to get some attention on this PR: https://github.com/apache/kafka/pull/7170 It's been a while now and I would love to move on to other KIPs as well. Please let me know if you have any

Re: [DISCUSS] KIP-537: Increase default zookeeper session timeout

2019-10-16 Thread Steve Rodrigues
Nice! I will observe that in a previous life, even within a "controlled datacenter environment" (albeit a large one), we wound up resetting the ZK timeout to 30s due to spurious network issues. Bumping replica max lag is important as well, since we also frequently saw the ISR=1 problem as machines

[jira] [Created] (KAFKA-9051) Source task source offset reads can block graceful shutdown

2019-10-16 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-9051: Summary: Source task source offset reads can block graceful shutdown Key: KAFKA-9051 URL: https://issues.apache.org/jira/browse/KAFKA-9051 Project: Kafka

[jira] [Created] (KAFKA-9050) Unable to find v1.1.2

2019-10-16 Thread Sarat Devineni (Jira)
Sarat Devineni created KAFKA-9050: - Summary: Unable to find v1.1.2 Key: KAFKA-9050 URL: https://issues.apache.org/jira/browse/KAFKA-9050 Project: Kafka Issue Type: Wish Components:

Re: [VOTE] KIP-534: Retain tombstones for approximately delete.retention.ms milliseconds

2019-10-16 Thread Richard Yu
Hi all, Want to try to get this KIP wrapped up. So it would be great if we can get some votes. Cheers, Richard On Tue, Oct 15, 2019 at 12:58 PM Jun Rao wrote: > Hi, Richard, > > Thanks for the updated KIP. +1 from me. > > Jun > > On Tue, Oct 15, 2019 at 12:46 PM Richard Yu > wrote: > > > Hi

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-10-16 Thread Nikolay Izhikov
Hello. I've got PR accepted by the Sophie Blee-Goldman. Tests are green. Please, others committers join the review. чт, 10 окт. 2019 г. в 16:52, Nikolay Izhikov : > Hello. > > This KIP was accepted. > > I created PR [1] for it. > Please, review. > > [1]

[jira] [Resolved] (KAFKA-9039) Optimize replica fetching CPU utilization with large number of partitions

2019-10-16 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9039. -- Fix Version/s: 2.5.0 Assignee: Lucas Bradstreet Resolution: Fixed > Optimize

[jira] [Resolved] (KAFKA-9032) Serializer is invoked with null when foreignValue=null

2019-10-16 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9032. -- Resolution: Fixed > Serializer is invoked with null when foreignValue=null >

Re: [DISCUSS] KIP-535: Allow state stores to serve stale reads during rebalance

2019-10-16 Thread Vinoth Chandar
Thanks for the updates on the KIP, Navinder! Few comments - AssignmentInfo is not public API?. But we will change it and thus need to increment the version and test for version_probing etc. Good to separate that from StreamsMetadata changes (which is public API) - From what I see, there is going

Build failed in Jenkins: kafka-2.1-jdk8 #236

2019-10-16 Thread Apache Jenkins Server
See Changes: [rhauch] KAFKA-8945/KAFKA-8947 backport (#7524) -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building

Build failed in Jenkins: kafka-2.2-jdk8 #177

2019-10-16 Thread Apache Jenkins Server
See Changes: [rhauch] KAFKA-8945/KAFKA-8947 backport (#7524) -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building

[jira] [Resolved] (KAFKA-8947) Connect framework incorrectly instantiates TaskStates for REST extensions

2019-10-16 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8947. -- Resolution: Fixed > Connect framework incorrectly instantiates TaskStates for REST extensions

Build failed in Jenkins: kafka-trunk-jdk8 #3974

2019-10-16 Thread Apache Jenkins Server
See Changes: [matthias] KAFKA-8897: Warn about no guaranteed backwards compatibility in -- [...truncated 2.68 MB...] org.apache.kafka.streams.test.TestRecordTest >

Build failed in Jenkins: kafka-trunk-jdk11 #885

2019-10-16 Thread Apache Jenkins Server
See Changes: [matthias] KAFKA-8897: Warn about no guaranteed backwards compatibility in -- [...truncated 5.67 MB...] org.apache.kafka.streams.TestTopicsTest >

[jira] [Resolved] (KAFKA-5648) make Merger extend Aggregator

2019-10-16 Thread Clemens Valiente (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clemens Valiente resolved KAFKA-5648. - Resolution: Won't Fix > make Merger extend Aggregator > - >

Jenkins build is back to normal : kafka-trunk-jdk8 #3973

2019-10-16 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-2.4-jdk8 #18

2019-10-16 Thread Apache Jenkins Server
See Changes: [matthias] MINOR: Provide better messages when waiting for a condition in test [matthias] KAFKA-8897: Warn about no guaranteed backwards compatibility in --

[jira] [Created] (KAFKA-9049) TopicCommandWithAdminClientTest should use mocks

2019-10-16 Thread Viktor Somogyi-Vass (Jira)
Viktor Somogyi-Vass created KAFKA-9049: -- Summary: TopicCommandWithAdminClientTest should use mocks Key: KAFKA-9049 URL: https://issues.apache.org/jira/browse/KAFKA-9049 Project: Kafka

Build failed in Jenkins: kafka-trunk-jdk11 #884

2019-10-16 Thread Apache Jenkins Server
See Changes: [github] KAFKA-4422 / KAFKA-8700 / KAFKA-5566: Wait for state to transit to [github] MINOR: code and JavaDoc cleanup (#7462) [wangguoz] MINOR: remove unused import in QueryableStateIntegrationTest

Build failed in Jenkins: kafka-2.4-jdk8 #17

2019-10-16 Thread Apache Jenkins Server
See Changes: [rhauch] KAFKA-9014: Fix AssertionError when SourceTask.poll returns an empty [rhauch] KAFKA-8945/KAFKA-8947: Fix bugs in Connect REST extension API (#7392) --

Re: [DISCUSS] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions

2019-10-16 Thread Matthias J. Sax
Walker, thanks for picking up this KIP. Did you read the previous discussion? It's still unclear if we want to apply the handler to repartition topics or not, and how errors for stores and changelog topic should be handled. For the Processor API, users could catch `SerializationException` but for