[
https://issues.apache.org/jira/browse/KAFKA-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-3126:
---
Assignee: (was: Mayuresh Gharat)
> Weird behavior in kafkaController on Control
[
https://issues.apache.org/jira/browse/KAFKA-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116436#comment-15116436
]
Mayuresh Gharat commented on KAFKA-3126:
It does look like a problem with consistency. It might
stom message validator then the audit can be done
> on-arrival
> > and we won't need a console auditor.
> >
> > One potential issue in this approach and any elaborate on-arrival
> > processing for that matter is that you may need to deserialize the
> message
> > as wel
[
https://issues.apache.org/jira/browse/KAFKA-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat resolved KAFKA-1796.
Resolution: Not A Problem
> Sanity check partition command line to
[
https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113128#comment-15113128
]
Mayuresh Gharat commented on KAFKA-1860:
[~guozhang] can you take another look at the PR? I have
[
https://issues.apache.org/jira/browse/KAFKA-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15112795#comment-15112795
]
Mayuresh Gharat commented on KAFKA-3126:
My confusion as described in this jira was :
(2) and (3
[
https://issues.apache.org/jira/browse/KAFKA-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-3126:
--
Assignee: Mayuresh Gharat
> Weird behavior in kafkaController on Controlled shutdo
[
https://issues.apache.org/jira/browse/KAFKA-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111611#comment-15111611
]
Mayuresh Gharat edited comment on KAFKA-3126 at 1/21/16 11:36 PM:
--
I had
[
https://issues.apache.org/jira/browse/KAFKA-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111611#comment-15111611
]
Mayuresh Gharat commented on KAFKA-3126:
Can you explain the steps in further detail :
2
[
https://issues.apache.org/jira/browse/KAFKA-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111353#comment-15111353
]
Mayuresh Gharat commented on KAFKA-3126:
I don't see why Controller B will see A in the ISR
[
https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109040#comment-15109040
]
Mayuresh Gharat commented on KAFKA-1397:
Can you paste the server side logs?
> delete to
Mayuresh Gharat created KAFKA-3126:
--
Summary: Weird behavior in kafkaController on Controlled
shutdowns. The leaderAndIsr in zookeeper is not updated during controlled
shutdown.
Key: KAFKA-3126
URL: https
[
https://issues.apache.org/jira/browse/KAFKA-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-3126:
---
Description:
Consider Broker B is controller, broker A is undergoing shutdown.
2016/01/14
[
https://issues.apache.org/jira/browse/KAFKA-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102259#comment-15102259
]
Mayuresh Gharat commented on KAFKA-3083:
For your question regarding :
If broker A shrinks
[
https://issues.apache.org/jira/browse/KAFKA-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102887#comment-15102887
]
Mayuresh Gharat commented on KAFKA-3083:
That's right.
I am thinking if there is a way to check
[
https://issues.apache.org/jira/browse/KAFKA-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102912#comment-15102912
]
Mayuresh Gharat commented on KAFKA-3083:
Hi Jun,
I was talking about
[
https://issues.apache.org/jira/browse/KAFKA-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098607#comment-15098607
]
Mayuresh Gharat commented on KAFKA-3083:
That's a very good point, I will verify if this can
[
https://issues.apache.org/jira/browse/KAFKA-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098607#comment-15098607
]
Mayuresh Gharat edited comment on KAFKA-3083 at 1/14/16 6:34 PM:
-
That's
[
https://issues.apache.org/jira/browse/KAFKA-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-3083:
--
Assignee: Mayuresh Gharat
> a soft failure in controller may leader a topic partit
[
https://issues.apache.org/jira/browse/KAFKA-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089586#comment-15089586
]
Mayuresh Gharat commented on KAFKA-3083:
[~fpj] can you shed some light on what you meant
[
https://issues.apache.org/jira/browse/KAFKA-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089686#comment-15089686
]
Mayuresh Gharat commented on KAFKA-2410:
I would like to bump up discussion on this.
The way I
[
https://issues.apache.org/jira/browse/KAFKA-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089686#comment-15089686
]
Mayuresh Gharat edited comment on KAFKA-2410 at 1/8/16 6:48 PM:
I would
a/browse/KAFKA-2410
>
> Hope that helps.
>
> Thanks,
> Grant
>
> On Thu, Jan 7, 2016 at 6:27 PM, Mayuresh Gharat <
> gharatmayures...@gmail.com>
> wrote:
>
> > Hi,
> >
> > I might have missed out the discussions on this :(
> >
> > I
wrote:
> Hey Mayuresh,
>
> The ticket that Grant Henke has been working on is here:
> https://issues.apache.org/jira/browse/KAFKA-2945. Is that what you were
> looking for?
>
> -Jason
>
> On Thu, Jan 7, 2016 at 1:50 PM, Mayuresh Gharat <
> gharatmayures...@gma
+ dev
Hi
There has been discussion on the ticket :
https://issues.apache.org/jira/browse/KAFKA-2887, that we are going to
deprecate auto-creation of topic or at least turn it off by default once we
have the CreateTopics API. It also says the patch is available for this.
The only other ticket
[
https://issues.apache.org/jira/browse/KAFKA-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on KAFKA-1911 started by Mayuresh Gharat.
--
> Log deletion on stopping replicas should be as
[
https://issues.apache.org/jira/browse/KAFKA-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-3013:
---
Status: Patch Available (was: In Progress)
> Display the topic-partition in the except
[
https://issues.apache.org/jira/browse/KAFKA-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on KAFKA-3013 started by Mayuresh Gharat.
--
> Display the topic-partition in the exception message for expired batc
[
https://issues.apache.org/jira/browse/KAFKA-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1911:
---
Status: Patch Available (was: In Progress)
> Log deletion on stopping replicas sho
[
https://issues.apache.org/jira/browse/KAFKA-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081987#comment-15081987
]
Mayuresh Gharat commented on KAFKA-3062:
Hi [~itismewxg], can you explain the usecase here
[
https://issues.apache.org/jira/browse/KAFKA-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081352#comment-15081352
]
Mayuresh Gharat commented on KAFKA-2937:
[~djh] does your integration test check if the topic
[
https://issues.apache.org/jira/browse/KAFKA-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081910#comment-15081910
]
Mayuresh Gharat commented on KAFKA-2937:
Yes, that might be possible but it should be rare
[
https://issues.apache.org/jira/browse/KAFKA-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081519#comment-15081519
]
Mayuresh Gharat commented on KAFKA-3040:
At Linkedin, we do have a separate controller log file
[
https://issues.apache.org/jira/browse/KAFKA-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071192#comment-15071192
]
Mayuresh Gharat commented on KAFKA-3040:
Do you have the controller logs for the time period
[
https://issues.apache.org/jira/browse/KAFKA-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071192#comment-15071192
]
Mayuresh Gharat edited comment on KAFKA-3040 at 12/24/15 7:09 PM:
--
Do you
[
https://issues.apache.org/jira/browse/KAFKA-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070294#comment-15070294
]
Mayuresh Gharat commented on KAFKA-2937:
[~rsivaram] This can occur if during delete topic
[
https://issues.apache.org/jira/browse/KAFKA-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070294#comment-15070294
]
Mayuresh Gharat edited comment on KAFKA-2937 at 12/23/15 11:21 PM
[
https://issues.apache.org/jira/browse/KAFKA-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064365#comment-15064365
]
Mayuresh Gharat commented on KAFKA-2937:
I ran a test with few commits behind trunk HEAD :
1
Mayuresh Gharat created KAFKA-3013:
--
Summary: Display the topic-partition in the exception message for
expired batches in recordAccumulator
Key: KAFKA-3013
URL: https://issues.apache.org/jira/browse/KAFKA-3013
[
https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062409#comment-15062409
]
Mayuresh Gharat commented on KAFKA-1860:
Cool.
> File system errors are not detected unless Ka
[
https://issues.apache.org/jira/browse/KAFKA-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063131#comment-15063131
]
Mayuresh Gharat edited comment on KAFKA-2887 at 12/18/15 12:02 AM
[
https://issues.apache.org/jira/browse/KAFKA-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063131#comment-15063131
]
Mayuresh Gharat commented on KAFKA-2887:
[~hachikuji] just wanted to be sure what you meant
[
https://issues.apache.org/jira/browse/KAFKA-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat resolved KAFKA-2975.
Resolution: Not A Problem
> The newtorkClient should request a metadata update af
Mayuresh Gharat created KAFKA-2976:
--
Summary: Mirror maker dies if we delete a topic from destination
cluster
Key: KAFKA-2976
URL: https://issues.apache.org/jira/browse/KAFKA-2976
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2975:
---
Description:
Currently in data pipeline,
1) Lets say Mirror Maker requestTimeout is set to 2
[
https://issues.apache.org/jira/browse/KAFKA-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2975:
---
Description:
Currently in data pipeline,
1) Lets say Mirror Maker requestTimeout is set to 2
Mayuresh Gharat created KAFKA-2975:
--
Summary: The newtorkClient should request a metadata update after
it gets an error in the handleResponse()
Key: KAFKA-2975
URL: https://issues.apache.org/jira/browse/KAFKA
[
https://issues.apache.org/jira/browse/KAFKA-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047220#comment-15047220
]
Mayuresh Gharat commented on KAFKA-2948:
Adding TTL would mean another user exposed config. Can we
[
https://issues.apache.org/jira/browse/KAFKA-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-2937:
--
Assignee: Mayuresh Gharat
> Topics marked for delete in Zookeeper may bec
[
https://issues.apache.org/jira/browse/KAFKA-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003232#comment-15003232
]
Mayuresh Gharat commented on KAFKA-1911:
[~geoffra] are you actively working on this. If not I
[
https://issues.apache.org/jira/browse/KAFKA-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-1911:
--
Assignee: Mayuresh Gharat (was: Geoff Anderson)
> Log deletion on stopping repli
[
https://issues.apache.org/jira/browse/KAFKA-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001559#comment-15001559
]
Mayuresh Gharat commented on KAFKA-2805:
Yes. That s right. The check was put in place because
[
https://issues.apache.org/jira/browse/KAFKA-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001024#comment-15001024
]
Mayuresh Gharat commented on KAFKA-2805:
Hi Jason,
I was debugging to find exactly what
[
https://issues.apache.org/jira/browse/KAFKA-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-2805:
--
Assignee: Mayuresh Gharat
> RecordAccumulator request timeout only enfor
[
https://issues.apache.org/jira/browse/KAFKA-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999844#comment-14999844
]
Mayuresh Gharat commented on KAFKA-2805:
Yes. That was the thinking. Also from the KIP-19
[
https://issues.apache.org/jira/browse/KAFKA-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1424#comment-1424
]
Mayuresh Gharat commented on KAFKA-2805:
[~hachikuji] My producer was on trunk when I ran
[
https://issues.apache.org/jira/browse/KAFKA-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999884#comment-14999884
]
Mayuresh Gharat commented on KAFKA-2805:
I did this experiment :
1) I created a topic called &quo
This might have been explained before. I had a question :
In the KIP it says :
"One ZooKeeper setting of interest on the server side is
zookeeper.allowSaslFailedClients. If this is false, then clients trying to
authenticate with an incorrect configuration will have their connections
dropped.
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959152#comment-14959152
]
Mayuresh Gharat commented on KAFKA-2120:
[~guozhang] The check is required to be done at each
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959196#comment-14959196
]
Mayuresh Gharat commented on KAFKA-2120:
[~guozhang] Yes sure. Will submit a PR for it.
>
[
https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958225#comment-14958225
]
Mayuresh Gharat commented on KAFKA-1554:
[~wangbo23] thanks for the review.
We did not iterate
[
https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat resolved KAFKA-1554.
Resolution: Duplicate
> Corrupt index found on clean star
Mayuresh Gharat created KAFKA-2635:
--
Summary: After deleting the topic, you can still send and receive
messages but kafka-topic --list does not show the topic.
Key: KAFKA-2635
URL: https://issues.apache.org/jira
[
https://issues.apache.org/jira/browse/KAFKA-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953697#comment-14953697
]
Mayuresh Gharat commented on KAFKA-2094:
[~mingfang] We should create a separate Jira for this. I
[
https://issues.apache.org/jira/browse/KAFKA-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2428:
---
Fix Version/s: 0.9.0.0
> Add sanity test in kafkaConsumer for the timeo
ply, visit:
https://reviews.apache.org/r/36858/#review101511
-------
On Sept. 28, 2015, 11:16 p.m., Mayuresh Gharat wrote:
>
> ---
> This is an automatically ge
+1 Ewen.
Currently the while creating the RecordBatch we extract the key and value
and add it to the batch. At a very high level, we will have to extract the
key and Value (minimum atleast) from each record in the RecordBatch, create
a wrapper with the exception,the key and the value and add it
[
https://issues.apache.org/jira/browse/KAFKA-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935428#comment-14935428
]
Mayuresh Gharat edited comment on KAFKA-2526 at 9/29/15 4:53 PM:
-
Hi
[
https://issues.apache.org/jira/browse/KAFKA-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935428#comment-14935428
]
Mayuresh Gharat commented on KAFKA-2526:
Hi [~guozhang], can you list the steps to reproduce
municate on the old version, and then we restart again removing the
> inter.broker.protocol.version. With this api the brokers could agree on a
> version to communicate with, and when bounced re-negotiate to the new
> version.
>
>
> On Mon, Sep 28, 2015 at 10:26 PM, Mayuresh Gharat <
Nice write-up.
Just had a question, instead of returning an empty response back to the
client, would it be better for the broker to return a response that gives
some more info to the client regarding the min version they need to upgrade
to in order to communicate with the broker.
Thanks,
rdless of the
select timeout). It should be possible to combine these but that will likely
require a callback to handle the KIP-19 timeout and I think that should really
be a separate jira.
- Mayuresh Gharat
On Sept. 19, 2015, 2:27 a.m., Mayuresh Gharat
09b8444c2add87f0f70dbb182e892977a6b5c243
Diff: https://reviews.apache.org/r/36858/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2120:
---
Attachment: KAFKA-2120_2015-09-28_16:13:02.patch
> Add a request timeout to NetworkCli
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934308#comment-14934308
]
Mayuresh Gharat commented on KAFKA-2120:
Updated reviewboard https://reviews.apache.org/r/36858
> On Sept. 28, 2015, 11:04 p.m., Mayuresh Gharat wrote:
> > core/src/main/scala/kafka/controller/ControllerChannelManager.scala, line
> > 109
> > <https://reviews.apache.org/r/36858/diff/13/?file=1077372#file1077372line109>
> >
> > The request tim
09b8444c2add87f0f70dbb182e892977a6b5c243
Diff: https://reviews.apache.org/r/36858/diff/
Testing (updated)
---
Unit test pass
Thanks,
Mayuresh Gharat
+1
On Wed, Sep 23, 2015 at 10:16 PM, Guozhang Wang wrote:
> +1
>
> On Wed, Sep 23, 2015 at 9:32 PM, Aditya Auradkar <
> aaurad...@linkedin.com.invalid> wrote:
>
> > +1
> >
> > On Wed, Sep 23, 2015 at 8:03 PM, Neha Narkhede
> wrote:
> >
> > > +1
> > >
> >
> On Sept. 19, 2015, 11:22 a.m., Ismael Juma wrote:
> > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java,
> > line 427
> > <https://reviews.apache.org/r/36858/diff/13/?file=1077354#file1077354line427>
> >
> > Can this TODO
-----
On Sept. 19, 2015, 2:27 a.m., Mayuresh Gharat wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36858/
>
> On Sept. 19, 2015, 11:22 a.m., Ismael Juma wrote:
> > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java,
> > line 427
> > <https://reviews.apache.org/r/36858/diff/13/?file=1077354#file1077354line427>
> >
> > Can this TODO
://reviews.apache.org/r/36858/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2120:
---
Status: Patch Available (was: Reopened)
> Add a request timeout to NetworkCli
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876838#comment-14876838
]
Mayuresh Gharat commented on KAFKA-2120:
Updated reviewboard https://reviews.apache.org/r/36858
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2120:
---
Attachment: KAFKA-2120_2015-09-18_19:27:48.patch
> Add a request timeout to NetworkCli
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14803338#comment-14803338
]
Mayuresh Gharat edited comment on KAFKA-2120 at 9/17/15 6:18 PM:
-
"Lo
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14803338#comment-14803338
]
Mayuresh Gharat commented on KAFKA-2120:
"Looking at the code, I noticed that we are pa
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14803215#comment-14803215
]
Mayuresh Gharat edited comment on KAFKA-2120 at 9/17/15 5:01 PM:
-
I
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790793#comment-14790793
]
Mayuresh Gharat commented on KAFKA-2120:
Thanks a lot everyone who provided great reviews
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791296#comment-14791296
]
Mayuresh Gharat commented on KAFKA-2120:
Yep. Looking in to this.
> Add a request time
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2120:
---
Attachment: KAFKA-2120_2015-09-15_18:57:20.patch
> Add a request timeout to NetworkCli
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36858/#review96095
---
On Sept. 16, 2015, 1:57 a.m., Mayuresh Gharat wrote:
>
> ---
> This is an autom
/KafkaConfigTest.scala
5b4f2db4607ae6d17696c1140f1a771ce75c80e0
core/src/test/scala/unit/kafka/utils/TestUtils.scala
09b8444c2add87f0f70dbb182e892977a6b5c243
Diff: https://reviews.apache.org/r/36858/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1474#comment-1474
]
Mayuresh Gharat commented on KAFKA-2120:
Updated reviewboard https://reviews.apache.org/r/36858
I suppose the jira link is different. It points to this jira :
https://issues.apache.org/jira/browse/KAFKA-1
Thanks,
Mayuresh
On Mon, Sep 14, 2015 at 5:13 PM, Jiangjie Qin
wrote:
> I just updated the KIP-33 to explain the indexing on CreateTime and
> LogAppendTime
zling me a little bit. Wouldn't we want to use the
> > oldest request for this check. If we use the last sent request, then we
> > might miss older requests that had already timed out, which would tend to
> > delay timeout detection. Maybe I'm missing something?
>
> Mayur
09b8444c2add87f0f70dbb182e892977a6b5c243
Diff: https://reviews.apache.org/r/36858/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741594#comment-14741594
]
Mayuresh Gharat commented on KAFKA-2120:
Updated reviewboard https://reviews.apache.org/r/36858
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-2120:
---
Attachment: KAFKA-2120_2015-09-11_14:54:15.patch
> Add a request timeout to NetworkCli
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738890#comment-14738890
]
Mayuresh Gharat commented on KAFKA-2120:
Hi [~junrao],
Thanks for the comments. I have uploaded
201 - 300 of 593 matches
Mail list logo