Re: [DISCUSS] KIP-334 Include partitions in exceptions raised during consumer record deserialization/validation

eel it > > would warrant a bigger discussion > > > Ok, that's fair. I thought I'd suggest it here just to see if there was any > interest in the community. At least with this KIP, users have a viable way > to skip past bad data if they wish. > > -Jason > > On Tue, Jul 3

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

Yes, good catch. Thank you, James! Best, Stanislav On Wed, Aug 1, 2018 at 5:05 PM James Cheng wrote: > Can you update the KIP to say what the default is for > max.uncleanable.partitions? > > -James > > Sent from my iPhone > > > On Jul 31, 2018, at 9:56 AM, S

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

Hey group, I just wanted to note that I have an implementation ready for review. Feel free to take a quick look and raise any concerns you might have in due time. I plan on starting the voting thread tomorrow. Best, Stanislav On Wed, Aug 1, 2018 at 10:01 AM Stanislav Kozlovski wrote: >

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

will be? If we're > going with the ".skip" file or equivalent, can we also add how > successful retries will behave? > > -Ray > > On 7/31/18 9:56 AM, Stanislav Kozlovski wrote: > > Hey group, > > > > I am planning on starting a voting thread tom

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

Hey group, I am planning on starting a voting thread tomorrow. Please do reply if you feel there is anything left to discuss. Best, Stanislav On Fri, Jul 27, 2018 at 11:05 PM Stanislav Kozlovski wrote: > Hey, Ray > > Thanks for pointing that out, it's fixed now > > Be

Re: [DISCUSS] KIP-334 Include partitions in exceptions raised during consumer record deserialization/validation

irst > > > > On Fri, Jul 20, 2018, 6:21 PM Ted Yu wrote: > > > > > Hi, Stanislav: > > > Do you plan to start VOTE thread ? > > > > > > Cheers > > > > > > On Fri, Jul 20, 2018 at 6:11 PM Stanislav Kozlovski < > > >

[jira] [Created] (KAFKA-7215) Improve LogCleaner behavior on error

Stanislav Kozlovski created KAFKA-7215: -- Summary: Improve LogCleaner behavior on error Key: KAFKA-7215 URL: https://issues.apache.org/jira/browse/KAFKA-7215 Project: Kafka Issue Type

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

y/KAFKA/Kafka+Improvement+Proposals#>? > > I tried, but the Wiki won't let me. > > -Ray > > On 7/26/18 2:01 PM, Stanislav Kozlovski wrote: > > Hey guys, > > > > @Colin - good point. I added some sentences mentioning recent > improvements > > in the

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

ld increase test > > > coverage for the log cleaner. > > > > > > > * About marking disks as offline when exceeding a certain threshold, > > > > that actually increases the blast radius of log compaction failures. > > > > Currently, the uncleaned partitions are

Re: [DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

lt, unsecured bearer tokens - >`unsecuredLoginExtension_`. > > > 2. Can you add the package for SaslExtensionsCallback class? > > > On Tue, Jul 24, 2018 at 10:03 PM, Stanislav Kozlovski < > stanis...@confluent.io> wrote: > > > Hi Ron, > > > > Thanks for

[VOTE] KIP-342 - Add support for custom SASL extensions in OAuthBearer authentication

Hey everbody, I'd like to start a vote thread for KIP-342 Add support for custom SASL extensions in OAuthBearer authentication -- Best, Stanislav

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

tion name can be long. > It is not necessary to repeat the topic name for each of its partitions. > How about the following format: > > topic-name1-{partition1, partition2, etc} > > That is, topic name only appears once. > > Cheers > > On Mon, Jul 23, 2018 at 9:08 PM Sta

Re: [DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

quest the extensions from its > callback handler, for backwards compatibility it is not necessary for the > callback handler to support SaslExtensionsCallback -- any > UnsupportedCallbackException that is thrown will be ignored and no > extensions will be added. > > Ron > > O

Re: [DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

; should be sufficient in the vast majority of the cases. Ron, do you > agree? > >> > >> On Mon, Jul 23, 2018 at 11:35 AM, Ron Dagostino > >> wrote: > >> > >> > Hi Stanislav. See https://tools.ietf.org/html/rfc7628#section-3.1, > and > >

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

Hi Ted, Yes, absolutely. Thanks for pointing that out! On Mon, Jul 23, 2018 at 6:12 PM Ted Yu wrote: > For `uncleanable-partitions`, should the example include topic name(s) ? > > Cheers > > On Mon, Jul 23, 2018 at 5:46 PM Stanislav Kozlovski < > stanis...@confluent

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

I renamed the KIP and that changed the link. Sorry about that. Here is the new link: https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error On Mon, Jul 23, 2018 at 5:11 PM Stanislav Kozlovski wrote: > Hey group, > > I created a new KIP about m

Re: [DISCUSS] KIP-289: Improve the default group id behavior in KafkaConsumer

e default group id (as > addressed by Jason in his response)? > This default group id would not support offset commits and consumers would > use `auto.offset.reset` config when there is no current offset. > > Thanks. > --Vahid > > > > > From: Stanislav Kozlovski >

[DISCUSS] KIP-346 - Limit blast radius of log compaction failure

Hey group, I created a new KIP about making log compaction more fault-tolerant. Please give it a look here and please share what you think, especially in regards to the points in the "Needs Discussion" paragraph. KIP: KIP-346

Re: [DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

this(Utils.parseMap(mapStr, keyValueSeparator, > elementSeparator), > > >> saslNameRegexPattern, saslValueRegexPattern); > > >>} > > >> > > >>public SaslExtensions(Map extensionsMap, Pattern > > >> saslNameRegexPattern, >

Re: [DISCUSS] KIP-334 Include partitions in exceptions raised during consumer record deserialization/validation

Hi Ted, I do plan to start one. When is the appropriate time? My reasoning was that people would like to view the changes first On Fri, Jul 20, 2018, 6:21 PM Ted Yu wrote: > Hi, Stanislav: > Do you plan to start VOTE thread ? > > Cheers > > On Fri, Jul 20, 2018 at 6:11 PM S

Re: [DISCUSS] KIP-334 Include partitions in exceptions raised during consumer record deserialization/validation

lowing commit was an initial step in unifying the exception > handling: > > > https://github.com/apache/kafka/commit/96bcfdfc7c9aac075635b2034e65e412a725672e > > But more can be done as you mentioned. > > Ismael > > On 5 Jul 2018 9:36 am, "Stanislav Kozlovski&

Re: [DISCUSS] KIP-289: Improve the default group id behavior in KafkaConsumer

I agree with Jason's notion that > implicit use of the empty group.id to commit offsets is more likely to be causing users unexpected problems than actually providing a useful capability. I was initially confused that this is the behavior when investigating a new-ish JIRA issue

Re: [DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

c and attach an instance of that to the > Subject's public credentials instead. > > Ron > > On Thu, Jul 19, 2018 at 8:15 PM Stanislav Kozlovski < > stanis...@confluent.io> > wrote: > > > I have updated the PR and KIP to address the comments made so far. Please > > take anot

Re: [DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

com/apache/kafka/pull/5379> Best, Stanislav On Thu, Jul 19, 2018 at 1:58 PM Stanislav Kozlovski wrote: > Hi Ron, > > Agreed. `SaslExtensionsCallback` will be the only public API addition and > new documentation for the extension strings. > A question that came up - should the

Re: [DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

mes are composed of only ALPHA [a-zA-Z] characters as per the spec (not > only for that reason, but to also make sure the token available at the > OAUTHBEARER.token negotiated property can't be overwritten). > > Ron > > On Thu, Jul 19, 2018 at 12:43 PM Stanislav Kozlovski < &g

Re: [DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

add > >> the desired SASL extensions to the Subject -- probably in the public > >> credentials -- where a custom sasl.client.callback.handler.class would > be > >> able to find them. The KIP might state this, too. > >> > >> I'll look forwa

Re: [DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

orted. > > Thanks for the KIP and the simultaneous PR -- having both at the same time > really helped. > > Ron > > On Tue, Jul 17, 2018 at 6:22 PM Stanislav Kozlovski < > stanis...@confluent.io> > wrote: > > > Hey group, > > > > I just c

Re: KAFKA-6690 Priorities for Source Topics

Hey Nick, This seems like a non-trivial change and more importantly - a change in the public interface. As such, following our contributing guidelines , it warrants a KIP (Kafka

[DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

Hey group, I just created a new KIP about adding customizable SASL extensions to the OAuthBearer authentication mechanism. More details in the proposal KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-342%3A+Add+support+for+Custom+SASL+extensions+in+OAuthBearer+authentication JIRA:

[jira] [Created] (KAFKA-7169) Add support for Custom SASL extensions in OAuth authentication

Stanislav Kozlovski created KAFKA-7169: -- Summary: Add support for Custom SASL extensions in OAuth authentication Key: KAFKA-7169 URL: https://issues.apache.org/jira/browse/KAFKA-7169 Project

Re: [DISCUSS] KIP-334 Include partitions in exceptions raised during consumer record deserialization/validation

not needed, maybe I'll outright remove the `cause` attribute On Thu, Jul 5, 2018 at 4:55 PM Ismael Juma wrote: > Thanks for the KIP, Stanislav. The following PR looks related: > > https://github.com/apache/kafka/pull/4093/files > > Ismael > > On Thu, Jul 5, 2018 at 8:44 AM Stanislav

[DISCUSS] KIP-334 Include partitions in exceptions raised during consumer record deserialization/validation

Hey everybody, I just created a new KIP about exposing more information in exceptions caused by consumer record deserialization/validation. Please have a look at it, it is a very short page. I am working under the assumption that all invalid record or deserialization exceptions in the consumer

Contributing: KIP permissions

Hey everybody, I've already implemented some JIRA tickets and would like to further my contributions into this great project by creating KIPs. Can I receive permission to do so? My e-mail: stanis...@confluent.io -- Best, Stanislav

Re: [DISCUSS] KIP-316: Command-line overrides for ConnectDistributed worker properties

Hey Kevin, I am not yet a committer so my word doesn't hold much weight but to me this is a no-brainer of a decision - this KIP can only improve the cli tool +1 From: Kevin Lafferty Sent: Friday, 15 June 2018 3:10 To: dev@kafka.apache.org Subject: [DISCUSS]

<    1   2   3   4