Thank you very much for the votes.
The vote is now closed with 3 binding +1 (Becket Qin, Jun Rao and Jason
Gustafson).
On Mon, Dec 11, 2017 at 11:21 PM, Jason Gustafson
wrote:
> +1. Thanks for the KIP.
>
> On Mon, Dec 11, 2017 at 1:54 AM, charly molter
> wrote:
>
> > Hi,
>
> > > > > >> But near the bottom of the KIP you refer to different method
> > > > > >> signatures that don't seem to match the above ones:
> > > > > >>
> > > > > >> getMatchingAcls(topicRegex)
> > > > > >> getMatchingAcls(principalRegex)
> > > > > >>
> > > > > >> Ron
> > > > > >>
> > > > > >>
> > > > > >> On Tue, May 1, 2018 at 11:48 AM, Ted Yu
> > > wrote:
> > > > > >>
> > > > > >> > The KIP was well written. Minor comment on formatting:
> > > > > >> >
> > > > > >> > https://github.com/apache/kafka/blob/trunk/core/src/
> > > > > >> > main/scala/kafka/admin/AclCommand.scala
> > > > > >> > to
> > > > > >> >
> > > > > >> > Leave space between the URL and 'to'
> > > > > >> >
> > > > > >> > Can you describe changes for the AdminClient ?
> > > > > >> >
> > > > > >> > Thanks
> > > > > >> >
> > > > > >> > On Tue, May 1, 2018 at 8:12 AM, Piyush Vijay <
> > > > piyushvij...@gmail.com>
> > > > > >> > wrote:
> > > > > >> >
> > > > > >> > > Hi all,
> > > > > >> > >
> > > > > >> > > I just opened a KIP to add support for wildcard suffixed
> ACLs.
> > > > This
> > > > > is
> > > > > >> > one
> > > > > >> > > of the feature I talked about in my Kafka summit talk and we
> > > > > promised
> > > > > >> to
> > > > > >> > > upstream it :)
> > > > > >> > >
> > > > > >> > > The details are here -
> > > > > >> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > >> > > 290%3A+Support+for+wildcard+suffixed+ACLs
> > > > > >> > >
> > > > > >> > > There is an open question about the way to add the support
> in
> > > the
> > > > > >> > > AdminClient, which I can discuss here in more detail once
> > > everyone
> > > > > has
> > > > > >> > > taken a first look at the KIP.
> > > > > >> > >
> > > > > >> > > Looking forward to discuss the change.
> > > > > >> > >
> > > > > >> > > Best,
> > > > > >> > > Piyush Vijay
> > > > > >> > >
> > > > > >> >
> > > > > >>
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
>
--
Charly Molter
Hi,
I would like to open a KIP and start a discussion.
Could someone please grant me access.
My username is cmolter: https://cwiki.apache.org/confluence/display/~cmolter
Thanks!
--
Charly Molter
Hi,
I'd like to start the discussion on KIP-225.
This KIP tries to correct the way the consumer lag metrics are reported to
use built in tags from MetricName.
Here's the link:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74686649
Thanks!
--
Charly Molter
Hi,
There doesn't seem to be much opposition to this KIP, I'll leave a couple
more days before starting the vote.
Thanks!
On Thu, Nov 9, 2017 at 1:59 PM, charly molter
wrote:
> Hi,
>
> I'd like to start the discussion on KIP-225.
>
> This KIP tries to correct th
gt;>
> >>> >>>>>>>> Some example in current code base:
> >>> >>>>>>>>
> >>> >>>>>>>> clients/src/main/java/org/apache/kafka/clients/Metadata.java:
> >>> >>>>>>>> throw new IllegalArgumentException("Max time to wait for
> metadata
> >>> >>>>>>> updates
> >>> >>>>>>>> should not be < 0 milliseconds");
> >>> >>>>>>>>
> >>> >>>>>>>> On Mon, Oct 16, 2017 at 3:06 PM, Clebert Suconic <
> >>> >>>>>>>> clebert.suco...@gmail.com>
> >>> >>>>>>>> wrote:
> >>> >>>>>>>>
> >>> >>>>>>>>> I updated the wiki with the list on the proposed arguments.
> >>> >>>>>>>>>
> >>> >>>>>>>>> I also changed it to include a new Exception class that
> would be named
> >>> >>>>>>>>> InvalidParameterException (since I couldn't find an existing
> Exception
> >>> >>>>>>>>> class that I could reuse into this). (I could review the
> name or the
> >>> >>>>>>>>> exception of course.. just my current proposal)
> >>> >>>>>>>>>
> >>> >>>>>>>>>> On Mon, Oct 16, 2017 at 5:55 PM, Jakub Scholz <
> ja...@scholz.cz> wrote:
> >>> >>>>>>>>>> Hi Clebert,
> >>> >>>>>>>>>>
> >>> >>>>>>>>>> I think it would be good if this could cover not only
> KafkaConsumer
> >>> >>>>>>> and
> >>> >>>>>>>>>> KafkaProducer but also the AdminClient. So that all three
> can be
> >>> >>>>>>>>> configured
> >>> >>>>>>>>>> the same way.
> >>> >>>>>>>>>>
> >>> >>>>>>>>>> The bootstrap servers are a list - you can provide multiple
> bootstrap
> >>> >>>>>>>>>> servers. Maybe you add an example of how that will be
> configured. I
> >>> >>>>>>>>> assume
> >>> >>>>>>>>>> it will be
> >>> >>>>>>>>>> "host:port,host2:port2;parameterName=value1;
> parameterName2=value2"
> >>> >>>>>>> but
> >>> >>>>>>>>> it
> >>> >>>>>>>>>> would be great to have it documented.
> >>> >>>>>>>>>>
> >>> >>>>>>>>>> Thanks & Regards
> >>> >>>>>>>>>> Jakub
> >>> >>>>>>>>>>
> >>> >>>>>>>>>> On Mon, Oct 16, 2017 at 11:30 PM, Clebert Suconic <
> >>> >>>>>>>>> clebert.suco...@gmail.com
> >>> >>>>>>>>>>> wrote:
> >>> >>>>>>>>>>
> >>> >>>>>>>>>>> I would like to start a discussion about KIP-209
> >>> >>>>>>>>>>> (https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> >>> >>>>>>>>>>> 209+-+Connection+String+Support)
> >>> >>>>>>>>>>>
> >>> >>>>>>>>>>> This is an extension of my previous thread:
> >>> >>>>>>>>>>> http://mail-archives.apache.org/mod_mbox/kafka-dev/201710.
> >>> >>>>>>>>>>> mbox/%3cCAKF+bsoFbN13D-u20tUsP6G+aHX4BUNk=S8M4KyJxAt_
> >>> >>>>>>>>>>> oyv...@mail.gmail.com%3e
> >>> >>>>>>>>>>>
> >>> >>>>>>>>>>> this could make the bootstrap of a consumer or producer
> similar to
> >>> >>>>>>>>>>> what users are already used when connecting into other
> systems,
> >>> >>>>>>> being
> >>> >>>>>>>>>>> a simple addition to Producer and Consumer, without
> breaking any
> >>> >>>>>>>>>>> previous client usage.
> >>> >>>>>>>>>>>
> >>> >>>>>>>>>>>
> >>> >>>>>>>>>>> --
> >>> >>>>>>>>>>> Clebert Suconic
> >>> >>>>>>>>>>>
> >>> >>>>>>>>>
> >>> >>>>>>>>>
> >>> >>>>>>>>>
> >>> >>>>>>>>> --
> >>> >>>>>>>>> Clebert Suconic
> >>> >>>>>>>>>
> >>> >>>>>>>>
> >>> >>>>>>> --
> >>> >>>>>>> Clebert Suconic
> >>> >>>>>>>
> >>> >>>>>
> >>> >>>>>
> >>> >>>>>
> >>> >>>>> --
> >>> >>>>> Clebert Suconic
> >>> >>>>
> >>> >>>>
> >>> >>>>
> >>> >>>> --
> >>> >>>> Clebert Suconic
> >
> >
> >
> > --
> > Clebert Suconic
>
>
>
> --
> Clebert Suconic
>
--
Charly Molter
er of these areas in action, see
> > this blog post.
> >
> >
> > records-lead-avg and records-lead-min don't need the partition prefix
> since
> > they are aggregates across all partitions. For records-lead, it seems
> that
> > it's better to add the topic partition as a tag, instead of as a prefix
> in
> > the metric name.
> >
> > Jun
> >
> >
> >
> >
> > On Thu, Nov 9, 2017 at 1:03 AM, Hu Xi wrote:
> >
> > > Hi all,
> > >
> > >
> > > As per Jun Rao's suggestion, I opened up the KIP-223(
> > https://cwiki.apache.
> > > org/confluence/display/KAFKA/KIP-223+-+Add+per-topic+min+
> > > lead+and+per-partition+lead+metrics+to+KafkaConsumer) concerning
> adding
> > > new kinds of lag metrics for KafkaConsumer. Be free to leave your
> > comments
> > > here. Thanks in advance.
> > >
> > >
> >
>
--
Charly Molter
at an external monitoring system can always
> derive that from the per partition record-lag.
>
> Thanks,
>
> Jun
>
> On Tue, Nov 14, 2017 at 6:57 AM, charly molter
> wrote:
>
> > Hi Jun, Hu,
> >
> > I have KIP-225 open for adding tags to records-lag:
&
ould need a
> deprecation timeframe for the old metric, and a transition plan to the new
> name. Is that right? I'm not sure how we deprecate metrics...
>
> During the deprecation timeframe, we could duplicate the metric to the new
> name.
>
> -James
>
> On Nov
compatibility much when we made
> that change.
>
> If the Kafka devs can comment on the backwards-compatibility-ness of
> metrics and how we treat that, that would be helpful.
>
> -James
>
> > On Nov 16, 2017, at 2:06 AM, charly molter
> wrote:
> >
> > Yes Jam
someone assign me to this Jira: KAFKA-5890
<https://issues.apache.org/jira/browse/KAFKA-5890>
Thanks,
--
Charly Molter
Hi all,
I've been trying to get a review on my PR:
https://github.com/apache/kafka/pull/4188
Could someone please help out?
Also could someone assign me the Jira:
https://issues.apache.org/jira/browse/KAFKA-6180 ?
Thanks!
Charly
--
Charly Molter
Hi,
Just a reminder that this vote is open. Let me know if you think this is
not a valuable change.
Thanks!
On Wed, Nov 22, 2017 at 10:48 AM, charly molter
wrote:
>
> Hi,
>
> I would like to start the voting thread for KIP-225.
> This KIP proposes to correct some lag metrics
; > As I didn't see any further discussion around this KIP, I'd like to
> start
> > > voting.
> > >
> > > KIP documentation:
> > >
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 223+-+Add+per-topic+min+lea
Since you proposed the original KIP-92, do you want to see if this KIP
> > makes sense?
> >
> > Thanks,
> >
> > Jun
> >
> > On Wed, Nov 22, 2017 at 2:48 AM, charly molter
> > wrote:
> >
> > > Hi,
> > >
> > > I
n 1.1 release.
>
> Thanks,
>
> Jiangjie (Becket) Qin
>
> On Tue, Dec 5, 2017 at 4:08 AM, charly molter
> wrote:
>
> > Thanks Jun and Becket!
> >
> > I think your point about 1.0 vs 2.0 makes sense I can update the KIP to
> > reflect this.
> >
&g
Hi,
The KIP has been updated. As it has change should I restart the vote?
In any case I'm still missing one binding vote if anyone wants to help.
Thanks!
On Wed, Dec 6, 2017 at 6:13 PM, charly molter
wrote:
> Sounds good I'll update the KIP
>
> On Wed, Dec 6, 2017 at 6:04 PM
ence/display/KAFKA/KIP-531%3A+Drop+support+for+Scala+2.11+in+Kafka+2.5
> >
> > Ismael
>
--
Charly Molter
Charly Molter created KAFKA-7868:
Summary: Move __consumer_offsets schema to the clients
Key: KAFKA-7868
URL: https://issues.apache.org/jira/browse/KAFKA-7868
Project: Kafka
Issue Type
Charly Molter created KAFKA-6445:
Summary: Remove deprecated metrics in 2.0
Key: KAFKA-6445
URL: https://issues.apache.org/jira/browse/KAFKA-6445
Project: Kafka
Issue Type: Bug
Affects
[
https://issues.apache.org/jira/browse/KAFKA-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878008#comment-15878008
]
Charly Molter commented on KAFKA-4195:
--
For those looking for the KIP:
h
Charly Molter created KAFKA-6969:
Summary: AdminClient should provide a way to get the version of a
node
Key: KAFKA-6969
URL: https://issues.apache.org/jira/browse/KAFKA-6969
Project: Kafka
Charly Molter created KAFKA-5890:
Summary: records.lag should use tags for topic and partition
rather than using metric name.
Key: KAFKA-5890
URL: https://issues.apache.org/jira/browse/KAFKA-5890
Charly Molter created KAFKA-6180:
Summary: AbstractConfig.getList() should never return null
Key: KAFKA-6180
URL: https://issues.apache.org/jira/browse/KAFKA-6180
Project: Kafka
Issue Type
Charly Molter created KAFKA-6192:
Summary: In Config always transform Properties to Map
Key: KAFKA-6192
URL: https://issues.apache.org/jira/browse/KAFKA-6192
Project: Kafka
Issue Type
Charly Molter created KAFKA-6204:
Summary: Interceptor and MetricsReporter should implement
java.io.Closeable
Key: KAFKA-6204
URL: https://issues.apache.org/jira/browse/KAFKA-6204
Project: Kafka
Charly Molter created KAFKA-6310:
Summary: ConcurrentModificationException when reporting
requests-in-flight in producer
Key: KAFKA-6310
URL: https://issues.apache.org/jira/browse/KAFKA-6310
Project
[
https://issues.apache.org/jira/browse/KAFKA-3992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946118#comment-15946118
]
Charly Molter commented on KAFKA-3992:
--
This is not a contribution.
Whi
Charly Molter created KAFKA-5513:
Summary: Contradicting scalaDoc for
AdminUtils.assignReplicasToBrokers
Key: KAFKA-5513
URL: https://issues.apache.org/jira/browse/KAFKA-5513
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467691#comment-15467691
]
Charly Molter commented on KAFKA-2729:
--
Hi,
We had this issue on a test cluste
[
https://issues.apache.org/jira/browse/KAFKA-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467691#comment-15467691
]
Charly Molter edited comment on KAFKA-2729 at 9/6/16 3:3
[
https://issues.apache.org/jira/browse/KAFKA-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467691#comment-15467691
]
Charly Molter edited comment on KAFKA-2729 at 9/6/16 3:3
[
https://issues.apache.org/jira/browse/KAFKA-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467691#comment-15467691
]
Charly Molter edited comment on KAFKA-2729 at 9/6/16 3:3
33 matches
Mail list logo
