Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

Thanks Gwen, Damian, I will go ahead and merge the corresponding PR then. Guozhang On Tue, Dec 19, 2017 at 2:04 PM, Gwen Shapira wrote: > +1 > > On Tue, Dec 19, 2017 at 1:06 PM Damian Guy wrote: > > > +1 > > > > On Tue, 19 Dec 2017 at 19:13 Bill

Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

+1 On Tue, Dec 19, 2017 at 1:06 PM Damian Guy wrote: > +1 > > On Tue, 19 Dec 2017 at 19:13 Bill Bejeck wrote: > > > +1 > > > > On Tue, Dec 19, 2017 at 1:21 PM, Matthias J. Sax > > wrote: > > > > > +1 > > > > > > On 12/19/17 9:23

Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

+1 On Tue, 19 Dec 2017 at 19:13 Bill Bejeck wrote: > +1 > > On Tue, Dec 19, 2017 at 1:21 PM, Matthias J. Sax > wrote: > > > +1 > > > > On 12/19/17 9:23 AM, Guozhang Wang wrote: > > > Hello, > > > > > > I'm calling for a re-vote on the additional API

Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

+1 On Tue, Dec 19, 2017 at 1:21 PM, Matthias J. Sax wrote: > +1 > > On 12/19/17 9:23 AM, Guozhang Wang wrote: > > Hello, > > > > I'm calling for a re-vote on the additional API changes in this KIP. > While > > working on the implementation I found it's better to add the

Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

+1 On 12/19/17 9:23 AM, Guozhang Wang wrote: > Hello, > > I'm calling for a re-vote on the additional API changes in this KIP. While > working on the implementation I found it's better to add the following > functions for programmability: > > * Overloaded KafkaStreams constructor to allow

Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

Hello, I'm calling for a re-vote on the additional API changes in this KIP. While working on the implementation I found it's better to add the following functions for programmability: * Overloaded KafkaStreams constructor to allow overriding the `Time` object. * Overloaded

Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

+1 from myself as well. I'm closing this KIP as accepted with 3 binding votes (Gwen, Damian, me) and 3 non-binding votes (Colin, Ted, Matthias). Guozhang On Mon, Nov 20, 2017 at 9:56 AM, Damian Guy wrote: > +1 > > On Mon, 20 Nov 2017 at 17:52 Gwen Shapira

Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

+1 On Mon, 20 Nov 2017 at 17:52 Gwen Shapira wrote: > +1 > > Make sense. We have a supplier for every other client type :) > > On Fri, Nov 17, 2017 at 1:33 PM Matthias J. Sax > wrote: > > > +1 > > > > On 11/17/17 9:35 AM, Ted Yu wrote: > > > +1 > > > >

Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

+1 Make sense. We have a supplier for every other client type :) On Fri, Nov 17, 2017 at 1:33 PM Matthias J. Sax wrote: > +1 > > On 11/17/17 9:35 AM, Ted Yu wrote: > > +1 > > > > On Fri, Nov 17, 2017 at 9:34 AM, Bill Bejeck wrote: > > > >> +1 > >> >

Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

+1 On 11/17/17 9:35 AM, Ted Yu wrote: > +1 > > On Fri, Nov 17, 2017 at 9:34 AM, Bill Bejeck wrote: > >> +1 >> >> Thanks, >> Bill >> >> On Fri, Nov 17, 2017 at 12:13 PM, Colin McCabe wrote: >> >>> +1 (non-binding) >>> >>> Colin >>> >>> On Tue, Nov 14,

Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

+1 On Fri, Nov 17, 2017 at 9:34 AM, Bill Bejeck wrote: > +1 > > Thanks, > Bill > > On Fri, Nov 17, 2017 at 12:13 PM, Colin McCabe wrote: > > > +1 (non-binding) > > > > Colin > > > > On Tue, Nov 14, 2017, at 10:02, Guozhang Wang wrote: > > > Hello folks, >

Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

+1 Thanks, Bill On Fri, Nov 17, 2017 at 12:13 PM, Colin McCabe wrote: > +1 (non-binding) > > Colin > > On Tue, Nov 14, 2017, at 10:02, Guozhang Wang wrote: > > Hello folks, > > > > I have filed a new KIP on adding AdminClient into Streams for internal > > topic management.

Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

+1 (non-binding) Colin On Tue, Nov 14, 2017, at 10:02, Guozhang Wang wrote: > Hello folks, > > I have filed a new KIP on adding AdminClient into Streams for internal > topic management. > > Please review and cast your vote on this thread. > >

[VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

Hello folks, I have filed a new KIP on adding AdminClient into Streams for internal topic management. Please review and cast your vote on this thread. *https://cwiki.apache.org/confluence/display/KAFKA/KIP-220%3A+Add+AdminClient+into+Kafka+Streams%27+ClientSupplier