Re: [VOTE] KIP-882: Kafka Connect REST API timeout improvements

2023-07-10 Thread Yash Mayya
Hi all, I just wanted to post an update on this KIP since it has been dormant for a while now. The original issue that motivated this KIP was resolved by tweaking some configurations for the client that the connector was using to talk to the external system. Instead of discarding this KIP, however

Re: [VOTE] KIP-882: Kafka Connect REST API timeout improvements

2023-03-02 Thread Yash Mayya
Hi Ashwin, Thanks for the feedback. I intentionally went with the choice of an unambiguous milliseconds unit and this would be clearly documented in the public Kafka Connect documentation. I think supporting multiple time units might lead to unnecessary confusion (what happens when no unit is spec

Re: [VOTE] KIP-882: Kafka Connect REST API timeout improvements

2023-03-01 Thread Ashwin
Thanks for the KIP Yash - +1 (non-binding) One nitpick - In one of the responses Chris had mentioned that the timeout param could be like 'timeout=10s'. The KIP seems to favour a millisecond timeout value and has an unwieldy value in the example - `POST /connectors?timeout=12` I like the idea

Re: [VOTE] KIP-882: Kafka Connect REST API timeout improvements

2023-03-01 Thread Chaitanya Mukka
Thanks for the KIP Yash! And also fixing the `double connector config validations` on POST. +1 (non-binding) on the KIP Regards, Chaitanya Mukka On 1 Mar 2023, 6:33 PM +0530, Yash Mayya , wrote: > Hi all, > > I'd like to call for a vote on the (hopefully) straightforward KIP-882 > which adds su

[VOTE] KIP-882: Kafka Connect REST API timeout improvements

2023-03-01 Thread Yash Mayya
Hi all, I'd like to call for a vote on the (hopefully) straightforward KIP-882 which adds support for configuring request timeouts on Kafka Connect REST APIs via query parameters along with a couple of related small improvements. KIP - https://cwiki.apache.org/confluence/display/KAFKA/KIP-882%3A+