[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512134#comment-14512134 ] Onur Karaman commented on KAFKA-1809: - As a follow-up: there was inconsistent document

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511660#comment-14511660 ] Onur Karaman commented on KAFKA-1809: - I hit problems upgrading to this patch because

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484538#comment-14484538 ] Gwen Shapira commented on KAFKA-1809: - Thanks [~onurkaraman], created KAFKA-2104 to tr

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484394#comment-14484394 ] Onur Karaman commented on KAFKA-1809: - In testDuplicateListeners() from KafkaConfigTes

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482207#comment-14482207 ] Gwen Shapira commented on KAFKA-1809: - Sorry for missing that [~harsha_ch]. I agree th

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482198#comment-14482198 ] Sriharsha Chintalapani commented on KAFKA-1809: --- [~gwenshap] I apologize for

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14440933#comment-14440933 ] Jun Rao commented on KAFKA-1809: [~gwenshap], thanks a lot for your patience and effort. +

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396077#comment-14396077 ] Gwen Shapira commented on KAFKA-1809: - Quick summary of changes since [~jjkoshy] and [

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396071#comment-14396071 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395982#comment-14395982 ] Gwen Shapira commented on KAFKA-1809: - Ick. Looks like KAFKA-1501 was committed. That

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395269#comment-14395269 ] Gwen Shapira commented on KAFKA-1809: - Yay on KAFKA-1546 :) > Refactor brokers to all

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395266#comment-14395266 ] Joel Koshy commented on KAFKA-1809: --- Re: ApiVersion - ok, but I just thought it would be

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395262#comment-14395262 ] Gwen Shapira commented on KAFKA-1809: - Yep, will submit this weekend. I'll address yo

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395251#comment-14395251 ] Jun Rao commented on KAFKA-1809: The latest patch looks good to me. Left a few comments on

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393941#comment-14393941 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393570#comment-14393570 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387348#comment-14387348 ] Joel Koshy commented on KAFKA-1809: --- Thanks for the ping - yes I would like to take a lo

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385906#comment-14385906 ] Jun Rao commented on KAFKA-1809: Thanks for the latest patch. Reviewed. Could you also pro

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384782#comment-14384782 ] Gwen Shapira commented on KAFKA-1809: - [~junrao] - the latest patch is: https://issue

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384769#comment-14384769 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363465#comment-14363465 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363429#comment-14363429 ] Gwen Shapira commented on KAFKA-1809: - [~junrao]: 1. Addressed all sub-points 2. I th

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363399#comment-14363399 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347236#comment-14347236 ] Jun Rao commented on KAFKA-1809: Thanks for the patch. Some comments. 1. KafkaConfig: 1.1

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342466#comment-14342466 ] Gwen Shapira commented on KAFKA-1809: - [~junrao] - patch updated per your review. Will

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303750#comment-14303750 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303740#comment-14303740 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303738#comment-14303738 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301791#comment-14301791 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295565#comment-14295565 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285116#comment-14285116 ] Gwen Shapira commented on KAFKA-1809: - Pinging [~junrao] for review :) I believe the

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276388#comment-14276388 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266634#comment-14266634 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265717#comment-14265717 ] Gwen Shapira commented on KAFKA-1809: - Upgrade tests pass, system tests pass, and I've

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265715#comment-14265715 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265686#comment-14265686 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265232#comment-14265232 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264127#comment-14264127 ] Gwen Shapira commented on KAFKA-1809: - Here's the testing plan: * Start a Kafka 0.8.2-

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261834#comment-14261834 ] Gwen Shapira commented on KAFKA-1809: - While I still need to do more testing (especial

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261830#comment-14261830 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261387#comment-14261387 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260396#comment-14260396 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259476#comment-14259476 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259474#comment-14259474 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258834#comment-14258834 ] Gwen Shapira commented on KAFKA-1809: - Updated reviewboard https://reviews.apache.org/

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236081#comment-14236081 ] Gwen Shapira commented on KAFKA-1809: - Also, this is badly lacking unit tests. I'm pl

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236072#comment-14236072 ] Gwen Shapira commented on KAFKA-1809: - Don't commit this please :) It builds and unit

[jira] [Commented] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236066#comment-14236066 ] Gwen Shapira commented on KAFKA-1809: - Created reviewboard https://reviews.apache.org/