Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

Thanks everyone for voting. KIP-157 has passed with +3 binding (Ewen, Jason and Guozhang Wang) and +3 non-binding (Matthias J. Sax and Bill Bejeck) Thanks, Bharat Viswanadham On Sat, Jun 10, 2017 at 4:49 PM, Guozhang Wang wrote: > Bharat, > > I think we already have 3

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

Bharat, I think we already have 3 committers voted on this KIP, could you conclude the thread? Guozhang On Fri, Jun 2, 2017 at 3:44 PM, Jason Gustafson wrote: > Thanks. +1 > > On Thu, Jun 1, 2017 at 9:40 PM, Matthias J. Sax > wrote: > > > +1 > > >

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

Thanks. +1 On Thu, Jun 1, 2017 at 9:40 PM, Matthias J. Sax wrote: > +1 > > Thanks for updating the KIP! > > -Matthias > > On 6/1/17 6:18 PM, Bill Bejeck wrote: > > +1 > > > > Thanks, > > Bill > > > > On Thu, Jun 1, 2017 at 7:45 PM, Guozhang Wang >

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

+1 Thanks for updating the KIP! -Matthias On 6/1/17 6:18 PM, Bill Bejeck wrote: > +1 > > Thanks, > Bill > > On Thu, Jun 1, 2017 at 7:45 PM, Guozhang Wang wrote: > >> +1 again. Thanks. >> >> On Tue, May 30, 2017 at 1:46 PM, BigData dev >> wrote:

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

+1 Thanks, Bill On Thu, Jun 1, 2017 at 7:45 PM, Guozhang Wang wrote: > +1 again. Thanks. > > On Tue, May 30, 2017 at 1:46 PM, BigData dev > wrote: > > > Hi All, > > Updated the KIP, as the consumer configurations are required for both > Admin > >

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

+1 again. Thanks. On Tue, May 30, 2017 at 1:46 PM, BigData dev wrote: > Hi All, > Updated the KIP, as the consumer configurations are required for both Admin > Client and Consumer in Stream reset tool. Updated the KIP to use > command-config option, similar to other

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

Hi All, Updated the KIP, as the consumer configurations are required for both Admin Client and Consumer in Stream reset tool. Updated the KIP to use command-config option, similar to other tools like kafka-consumer-groups.sh

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

+1. Thanks! On Tue, May 16, 2017 at 1:12 AM, Eno Thereska wrote: > +1 thanks. > > Eno > > On 16 May 2017, at 04:20, BigData dev wrote: > > > > Hi All, > > Given the simple and non-controversial nature of the KIP, I would like to > > start the

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

Hi Matthias, For the AdminClient, client configuration is needed. And for zookeeper, no properties are required. So, in other tools like consumerGroupCommand, they used the command config option. I think consumer-config and consumer-property are not required here. We will use the configurations

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

Couple of follow ups. The reset tool uses AdminClient, ZkUtils, and a KafkaConsumer internally. Thus, I am wondering if we need the possibility to specify configs for all of them? The original JIRA reported, that the reset tool does not work for a secured cluster, and thus, I doubt that consumer

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

Thanks for the info, Matthias. Regards, Bharat On Fri, May 19, 2017 at 10:25 AM, Matthias J. Sax wrote: > KIP-157 cannot be included in 0.11.0.0 anymore. KIP freeze date deadline > is strict. > > -Matthias > > On 5/19/17 10:15 AM, BigData dev wrote: > > Hi Matthias, > >

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

KIP-157 cannot be included in 0.11.0.0 anymore. KIP freeze date deadline is strict. -Matthias On 5/19/17 10:15 AM, BigData dev wrote: > Hi Matthias, > I will start a new KIP for Kafka tools options to be a standard across all > tools shortly. But I think the KIP 157 for Kafka Streams, should be

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

Hi Matthias, I will start a new KIP for Kafka tools options to be a standard across all tools shortly. But I think the KIP 157 for Kafka Streams, should be needed for 0.11.0.0 release, (KIP freeze date is already over, but I think this is minor code change in tools to add option to streams reset

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

I double checked with Matthew Warhaftig (the original author of KIP-14) and he has not interest to continue the KIP atm. Thus, Bharat can continue the work on KIP-14. I think it would be best, to start a new DISCUSS thread after you update KIP-14. Thanks for your contributions! -Matthias On

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

Hi, When I was trying to find more info, there is already a proposed KIP for this https://cwiki.apache.org/confluence/display/KAFKA/KIP-14+-+Tools+Standardization Thanks, Bharat On Wed, May 17, 2017 at 12:38 PM, BigData dev wrote: > Hi Ewen, Matthias, > For common

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

Hi Ewen, Matthias, For common configuration across all the tools, I will work on that as part of other KIP by looking into all Kafka tools. Thanks, Bharat On Wed, May 17, 2017 at 9:40 AM, Matthias J. Sax wrote: > +1 > > I also second Ewen comment -- standardizing the

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

+1 I also second Ewen comment -- standardizing the common supported parameters over all tools would be great! -Matthias On 5/17/17 12:57 AM, Damian Guy wrote: > +1 > > On Wed, 17 May 2017 at 05:40 Ewen Cheslack-Postava > wrote: > >> +1 (binding) >> >> I mentioned this in

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

+1 On Wed, 17 May 2017 at 05:40 Ewen Cheslack-Postava wrote: > +1 (binding) > > I mentioned this in the PR that triggered this: > > > KIP is accurate, though this is one of those things that we should > probably get a KIP for a standard set of config options across all tools

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

+1 (binding) I mentioned this in the PR that triggered this: > KIP is accurate, though this is one of those things that we should probably get a KIP for a standard set of config options across all tools so additions like this can just fall under the umbrella of that KIP... I think it would be

Re: Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

+1 thanks. Eno > On 16 May 2017, at 04:20, BigData dev wrote: > > Hi All, > Given the simple and non-controversial nature of the KIP, I would like to > start the voting process for KIP-157: Add consumer config options to > streams reset tool > >

Reg: [VOTE] KIP 157 - Add consumer config options to streams reset tool

Hi All, Given the simple and non-controversial nature of the KIP, I would like to start the voting process for KIP-157: Add consumer config options to streams reset tool *https://cwiki.apache.org/confluence/display/KAFKA/KIP+157+-+Add+consumer+config+options+to+streams+reset+tool