Re: Release source doesn't contain .gitignore

2015-11-30 Thread Ismael Juma
Hi Grant, On Sat, Nov 28, 2015 at 5:28 PM, Grant Henke wrote: > I am not sure what the best practice is. Since it is checked in as part of > the project, I considered it effectively part of its source. I suspect the > method for collecting and taring the source files

Re: Release source doesn't contain .gitignore

2015-11-28 Thread Grant Henke
Hi Edward, I am not sure what the best practice is. Since it is checked in as part of the project, I considered it effectively part of its source. I suspect the method for collecting and taring the source files excluded it by accident (perhaps by many of these projects) and is something that

Re: Release source doesn't contain .gitignore

2015-11-26 Thread Edward Ribeiro
Hi Grant, Sorry for my stupid question, but it is usually a best practice to include such file in the src tar balls? I am certainly okay with including it, of course. :) But I didn't see it in ZooKeeper 3.4.7, Hadoop 2.4.6 or Cassandra 3.0 sources, for example. OTOH, I see the .gitattributes

Release source doesn't contain .gitignore

2015-11-25 Thread Grant Henke
The recent release source does not contain the repo's .gitignore file. This is definitely not a major issue, but I wanted to bring it up so it could be added in future releases. I downloaded the source from: https://www.apache.org/dyn/closer.cgi?path=/kafka/0.9.0.0/kafka-0.9.0.0-src.tgz Thanks,