---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/#review74569
---
Ship it!
Minor locking issue noted below. I can take care of that.
On Feb. 27, 2015, 8:47 p.m., Joel Koshy wrote:
Minor locking issue noted below. I can take care of that.
This obviously does not cover the case of committing offsets to a topic
that is currently being deleted. I think that can be done in a separate
jira. Can you file one?
Joel,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/
---
(Updated Feb. 27, 2015, 9:50 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/#review74614
---
Ship it!
Ship It!
- Joel Koshy
On Feb. 27, 2015, 9:50 p.m.,
On Feb. 13, 2015, 7:01 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/OffsetManager.scala, line 215
https://reviews.apache.org/r/29912/diff/3/?file=862699#file862699line215
Minor comment. I think this may be better to pass in to the
OffsetManager.
We should
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/
---
(Updated Feb. 18, 2015, 9:13 p.m.)
Review request for kafka.
Bugs:
On Feb. 13, 2015, 7:01 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/OffsetManager.scala, line 215
https://reviews.apache.org/r/29912/diff/3/?file=862699#file862699line215
Minor comment. I think this may be better to pass in to the
OffsetManager.
We should
On Feb. 13, 2015, 7:01 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/OffsetManager.scala, line 215
https://reviews.apache.org/r/29912/diff/3/?file=862699#file862699line215
Minor comment. I think this may be better to pass in to the
OffsetManager.
We should
On Feb. 13, 2015, 6:24 p.m., Eric Olander wrote:
core/src/main/scala/kafka/server/KafkaApis.scala, line 303
https://reviews.apache.org/r/29912/diff/3/?file=862697#file862697line303
This code could be done using map and getOrElse on the Option rather
than using pattern
On Feb. 13, 2015, 6:24 p.m., Eric Olander wrote:
core/src/main/scala/kafka/server/KafkaApis.scala, line 303
https://reviews.apache.org/r/29912/diff/3/?file=862697#file862697line303
This code could be done using map and getOrElse on the Option rather
than using pattern
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/#review72405
---
core/src/main/scala/kafka/server/KafkaApis.scala
On Feb. 13, 2015, 6:24 p.m., Eric Olander wrote:
core/src/main/scala/kafka/server/KafkaApis.scala, line 303
https://reviews.apache.org/r/29912/diff/3/?file=862697#file862697line303
This code could be done using map and getOrElse on the Option rather
than using pattern
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/#review72413
---
minor comment, looks good otherwise
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/
---
(Updated Feb. 13, 2015, 12:46 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/#review72166
---
core/src/main/scala/kafka/server/OffsetManager.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/
---
(Updated Jan. 19, 2015, 6:44 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29912/
---
Review request for kafka.
Bugs: KAFKA-1852
17 matches
Mail list logo