Re: [DISCUSS] KIP-274: Kafka Streams Skipped Records Metrics

2018-04-03 Thread Guozhang Wang
m > > wondering if we should add this information into the corresponding WARN > > logs that we write anyway? For this case, we can also log the > > corresponding operator (and other information like topic name etc if > > needed). WDYT about this? > > > > > > -

Re: [DISCUSS] KIP-274: Kafka Streams Skipped Records Metrics

2018-04-03 Thread Guozhang Wang
yes, we should not nail down the exact log message. It's just to > point out the trade-off. If we can get the required information in the > logs, we might not need task level metrics. > > > -Matthias > > On 4/3/18 11:26 AM, Guozhang Wang wrote: > > I think Matthias&#

Re: [DISCUSS] KIP-274: Kafka Streams Skipped Records Metrics

2018-04-03 Thread Guozhang Wang
eric from the user's perspective, but I think it's the > > best we can do right now. It might be nice to explicitly take on a > > debugging ergonomics task in the future and give all processor nodes > > human-friendly names. Then, we could surface these names in any log

Re: [DISCUSS] KIP-253: Support in-order message delivery with partition expansion

2018-04-04 Thread Guozhang Wang
hing. And we need to remember the > > >> initial number of processors in the job, 10 in this example, and use > > this > > >> number in the linear hashing algorithm. This is pretty much the same > as > > >> how > > >> we use linear hashing to

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

2018-04-04 Thread Guozhang Wang
pache.org > >> Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different > >> consumers > >> > >> Thanks Matthias, Ted and Guozhang for the inputs. I shall address them > in > >> next round. > >> > >> > >> ___

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

2018-04-05 Thread Guozhang Wang
fully. Admittedly, some of the challenges in Connect don't appear here > (e.g. conflicts in producer/consumer config naming, since this is a > Consumer-only KIP), but similar problems arise. > > -Ewen > > On Wed, Apr 4, 2018 at 10:56 PM, Boyang Chen wrote: > > > Thanks G

Re: [VOTE] KIP-211: Revise Expiration Semantics of Consumer Group Offsets

2018-04-05 Thread Guozhang Wang
Thanks for the KIP! +1 (binding) On Thu, Apr 5, 2018 at 3:11 PM, Matthias J. Sax wrote: > +1 (binding) > > > -Matthias > > On 4/5/18 4:36 AM, Ted Yu wrote: > > +1 > > Original message From: Mickael Maison < > mickael.mai...@gmail.com> Date: 4/5/18 1:42 AM (GMT-08:00) To: dev

Re: Dead link in Kafka Streams documentation

2018-04-07 Thread Guozhang Wang
Thanks for reporting the issue Stephane, I will fix it. Guozhang On Fri, Apr 6, 2018 at 10:15 PM, Stephane Maarek < steph...@simplemachines.com.au> wrote: > https://kafka.apache.org/documentation/streams/developer-guide/ > > "Testing a Streams application" points to > https://kafka.apache.org/d

Re: Dead link in Kafka Streams documentation

2018-04-07 Thread Guozhang Wang
I have pushed a hotfix PR for fixing the default version links in streams dev-guide. https://github.com/apache/kafka-site/commit/94f59b43d013dca2832fecfa1efe919f3b66ca90 Guozhang On Sat, Apr 7, 2018 at 5:55 PM, Guozhang Wang wrote: > Thanks for reporting the issue Stephane, I will fix

Re: [VOTE] KIP-284 Set default retention ms for Streams repartition topics to Long.MAX_VALUE

2018-04-09 Thread Guozhang Wang
+1 (binding) On Mon, Apr 9, 2018 at 11:21 AM, Matthias J. Sax wrote: > +1 (binding) > > -Matthias > > On 4/9/18 8:57 AM, Bill Bejeck wrote: > > Thanks for the KIP. > > > > +1 > > > > -Bill > > > > On Mon, Apr 9, 2018 at 7:57 AM, zhenya Sun wrote: > > > >> +1 > >> > >> > >> from my iphone! > >>

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-09 Thread Guozhang Wang
Thanks for the KIP. 1) I'm also in favor of making the `timestamp` a preserved config value along with `offset`, for which we would not go into the headers to look for the matching key, but directly look into the timestamp field of the message. 2) About the `long` conversion from `byte[]` values,

Re: RE: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-11 Thread Guozhang Wang
Hello Luís, Regarding the timestamp: it is designed to be mainly used for indicating the time when this record is generated (i.e. CREATE_TIME at the producer side, it will set the timestamp), or when the record has been appended to Kafka brokers (i.e. LOG_APPEND_TIME at the broker side, where prod

Re: RE: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-11 Thread Guozhang Wang
> I do not mean that it is "used", but if what you meant is that you would prefer to use that field instead of a header? > This is in relation to a previous point of yours: I think maybe we have a mis-communication here: I'm not against the idea of using headers, but just trying to argue that we c

Re: RE: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-11 Thread Guozhang Wang
anings (e.g. it is encoded from a long) they we are forcing them to choose the encoder that obeys key lexicographic ordering; but I felt it is more general than enforcing any fields that may be used for log cleaner to be defined as a special type. Guozhang On Wed, Apr 11, 2018 at 10:18 AM, Gu

Re: RE: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-11 Thread Guozhang Wang
Yup, lazy copy-paste punishment :P Guozhang On Wed, Apr 11, 2018 at 10:19 AM, Ted Yu wrote: > bq. 2. if the config value is "timestamp", look into the offset field; > > I think you meant looking into timestamp field. > > Cheers > > On Wed, Apr 11, 2018 at 1

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

2018-04-12 Thread Guozhang Wang
t; But if it was just, e.g. group.id, client.id, > >>>> and offset.reset that needed adjustment for a restoreConsumer, that > >> would > >>>> be the default and everything else is inherited. > >> > >> Don't understand this part. > >

Re: [VOTE] KIP-279: Fix log divergence between leader and follower after fast leader fail over

2018-04-15 Thread Guozhang Wang
Anna, thanks for the KIP! +1 from me. Just one minor comment: `Broker A will respond with offset 11`, seems it should be `21`. On Sun, Apr 15, 2018 at 3:48 AM, Dong Lin wrote: > Thanks for the KIP! LGTM. +1 > > On Sat, Apr 14, 2018 at 5:31 PM, Ted Yu wrote: > > > +1 > > > > On Sat, Apr 14, 201

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-04-15 Thread Guozhang Wang
gt;> 3. As Jason mentioned in the discussion, it would be nice to extend > > >>> this > > >>>>> api to support general group management, instead of just the > consumer > > >>>> group > > >>>>> in the future. For t

Re: [VOTE] KIP-265: Make Windowed Serde to public APIs

2018-04-15 Thread Guozhang Wang
+APIs Guozhang On Thu, Mar 8, 2018 at 1:25 PM, Guozhang Wang wrote: > +1 from myself as well. > > > I'm closing the vote for KIP-265 with the following results: > > binding +1: Matthias, Damian, Guozhang > non-binding +1: Xi, Ted, Bill > > > Thanks everyone for

Re: [VOTE] KIP-270 A Scala wrapper library for Kafka Streams

2018-04-16 Thread Guozhang Wang
Thanks Debasish for the KIP! Will make another pass on the PR itself, but the KIP itself looks good. I'm +1 (binding). Guozhang On Mon, Apr 16, 2018 at 10:51 AM, John Roesler wrote: > Thanks again for this effort. I'm +1 (non-binding). > -John > > On Mon, Apr 16, 2018 at 9:39 AM, Ismael Juma

Re: [DISCUSS] KIP-277 - Fine Grained ACL for CreateTopics API

2018-04-17 Thread Guozhang Wang
Thanks for the KIP. The updated wiki LGTM to me now. I'd also want to have wildcard support for create / delete topic ACLs for Streams usage :) But I'd agree the feature itself may deserve a separate KIP. Guozhang On Tue, Apr 17, 2018 at 4:40 AM, Edoardo Comar wrote: > We updated the KIP add

Re: [VOTE] KIP-276 Add StreamsConfig prefix for different consumers

2018-04-18 Thread Guozhang Wang
Thanks Boyang, +1 from me. On Wed, Apr 18, 2018 at 4:43 PM, Boyang Chen wrote: > Hey guys, > > > sorry I forgot to include a summary of this KIP. Basically the idea is to > separate the stream config for different internal consumers of Kafka > Streams by supplying prefixes . We currently have >

Re: RE: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-20 Thread Guozhang Wang
Hi Luís, What I'm thinking primarily is that we only need to compare the compaction values as LONG for the offset and timestmap "type" (I still think it is worth defining `timestamp` as a special compaction value, with the reasons below). Not sure if you've seen my other comment earlier regarding

Re: [DISCUSS]KIP-216: IQ should throw different exceptions for different errors

2018-04-20 Thread Guozhang Wang
>>> After further understanding of KafkaStreams thread and state > store, > > >>>>>>> I am currently rewriting the KIP. > > >>>>>>> > > >>>>>>> > > >>>>>>> > > >>>>

Re: RE: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-23 Thread Guozhang Wang
sages nimble, but it would again be a shame to be forced into such a > hacky solution. > This is how I see it, and why I would like to avoid it. But maybe there is > some smarter way that you know of on how to handle it on the client side > that would invalidate these concerns? &g

Re: RE: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-23 Thread Guozhang Wang
ich ends up > being ok for my own use case... > This would then generally guarantee the lexicographic ordering, as you say. > Is this what you mean? Should I then add this restriction to the KIP? > > Cheers, > Luis > > From: Guozhang Wang > Sent: 23 April 2018 17:55 > To:

Re: RE: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-23 Thread Guozhang Wang
wrote: > Hello Guozhang, > > The KIP is now updated to reflect this choice in strategy. > Please let me know your thoughts there. > > Kind Regards, > Luís > > From: Guozhang Wang > Sent: 23 April 2018 19:32 > To: dev@kafka.apache.org > Subject: Re: RE: [DISCUSS]

Re: Can I get permission to create KIP?

2018-04-23 Thread Guozhang Wang
Hello Qingjun, I have added you to the Kafka wiki space. Cheers, Guozhang On Mon, Apr 23, 2018 at 4:21 PM, qingjun wu wrote: > Hi Dear, > > I found something that Kafka should improve. Can I get permission for this? > I am working for Microsoft actually. If you need me to login as Microsoft,

Re: [VOTE] Kafka 2.0.0 in June 2018

2018-04-24 Thread Guozhang Wang
+1. Thanks Ismael! Guozhang On Tue, Apr 24, 2018 at 8:33 AM, Stevo Slavić wrote: > +1 (non-binding) > > On Tue, Apr 24, 2018 at 5:29 PM, Matthias J. Sax > wrote: > > > +1 > > > > On 4/24/18 4:21 PM, Jason Gustafson wrote: > > > +1 Thanks Ismael. > > > > > > On Tue, Apr 24, 2018 at 5:01 AM, Th

Re: RE: RE: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-24 Thread Guozhang Wang
19978 > .yiv6853119978MsoChpDefault {} _filtered #yiv6853119978 {margin:72.0pt > 72.0pt 72.0pt 72.0pt;}#yiv6853119978 div.yiv6853119978WordSection1 > {}#yiv6853119978 > That is definitely clearer, KIP updated! > > > > From: Guozhang Wang > Sent: 23 April 2018 23:44 > To: dev@kaf

Re: Can I get permission to create KIP?

2018-04-25 Thread Guozhang Wang
I have already added you to the permission granted list. Guozhang On Wed, Apr 25, 2018 at 9:16 AM, qingjun wu wrote: > Hi Dear, > > Can I get any update for the permission request? > > Thank you very much! > > Wade Wu > > On Mon, Apr 23, 2018 at 4:21 PM, qingjun wu wrote: > > > Hi Dear, > > >

Re: [DISCUSSION] KIP-266: Add TimeoutException to KafkaConsumer#position()

2018-04-25 Thread Guozhang Wang
quot; > >> > > > > > > >> > > > > > Now, I'm wondering if we should actually consider one of my > >> > rejected > >> > > > > > alternatives, to treat the "operation timeout" as a separate > >> >

Re: [VOTE] KIP-277 - Fine Grained ACL for CreateTopics API

2018-04-25 Thread Guozhang Wang
Thanks Edo, +1 from me. Guozhang On Wed, Apr 25, 2018 at 2:45 AM, Edoardo Comar wrote: > Hi, > > The discuss thread on KIP-277 ( > https://www.mail-archive.com/dev@kafka.apache.org/msg86540.html ) > seems to have been fruitful and concerns have been addressed, please allow > me start a vote on

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-25 Thread Guozhang Wang
lace it with a direct record cache? > > Kind Regards > Luis > > > > On 24 Apr 2018, at 20:30, Guozhang Wang wrote: > > > > Not sure if I fully understand your question, but here's my > understanding: > > In LogCleaner we call: > > > > &qu

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-26 Thread Guozhang Wang
Hello Luís, > Offset is an integer? I've only noticed it being resolved as a long so far. You are right, offset is a long. As for timestamp / other types, I left a comment in your PR about handling tie breakers. > Given these arguments, is this point something that you absolutely must have? No

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-27 Thread Guozhang Wang
> > Hi, > > The KIP is now updated with the results of the byte array discussion. > > This is my first contribution to Kafka, so I'm not sure on what the > processes are. Is it now acceptable to take this into a vote, or should I > ask for more contributors to join th

Re: Permission to create KIP

2018-05-01 Thread Guozhang Wang
Hello Andy, I've added you to the list. Cheers, Guozhang On Tue, May 1, 2018 at 6:08 AM, Andy Coates wrote: > Hi, > > Can I get permission to add a KIP in Confluence please? > > My Wiki Id is: bigandy > > Thanks! > > Andy > -- -- Guozhang

Re: Permission request to create a KIP

2018-05-01 Thread Guozhang Wang
Hello Adam, I've added you to the permission list. Cheers, Guozhang On Tue, May 1, 2018 at 5:06 AM, Adam Kotwasinski wrote: > Hello, > > I'd like to create a KIP - Add new metrics for consumer/replication fetch > requests (re https://issues.apache.org/jira/browse/KAFKA-6830) > > Could you plea

Re: Permission to open a KIP

2018-05-01 Thread Guozhang Wang
Hello Piyush, I've added you to the permission list. Guozhang On Mon, Apr 30, 2018 at 10:36 AM, Piyush Vijay wrote: > Hi, > > Can someone please grant me permission to open a KIP? My id is piyushvijay. > > Thanks > Piyush Vijay > -- -- Guozhang

Re: KIP-244: Add Record Header support to Kafka Streams

2018-05-02 Thread Guozhang Wang
Hi Jorge, Thanks for the written KIP! Made a pass over it and left some comments (some of them overlapped with John's): 1. We need to have a clear inheritance protocol of headers in our topology: 1.a. In PAPI's context.forward() call, it should be straight-forward. 1.b. In DSL stateless operator

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-05-02 Thread Guozhang Wang
clients as well? > > Thanks again for the continued discussion! > Cheers, > LuisOn Friday, April 27, 2018, 8:21:13 PM GMT+2, Guozhang Wang < > wangg...@gmail.com> wrote: > > Hello Luis, > > When the comparing the version returns `equal`, the original proposal i

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-02 Thread Guozhang Wang
Hello Andy, Thanks for the KIP. The motivation and the general proposal looks good to me. I think in KTable it is indeed valuable to add the functions that does not change key, such as mapValues, transformValues, and filter. There are a few meta comments I have about the semantics of the newly ad

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-05 Thread Guozhang Wang
reuse the > consumer client id as unique identifier instead of introducing new terms. > From my experience, they should be unique in either Stream or Consumer use > case. > > > Thanks a lot for the clarification! > > > From: Guozhang Wang >

Re: [DISCUSS] KIP-353: Allow Users to Configure Kafka Streams Timestamp Synchronization

2018-08-07 Thread Guozhang Wang
g topic if it has data > available, regardless of timestamp. > > On Fri, 2018-08-03 at 14:00 -0700, Guozhang Wang wrote: > > Hello all, > > > I would like to kick off a discussion on the following KIP, to allow users > > control when a task can be processed base

Re: [DISCUSS] Applying scalafmt to core code

2018-08-07 Thread Guozhang Wang
Hello Ray, I saw on the original PR Jason (cc'ed) expressed a concern comparing scalafmt with scalastyle: the latter will throw exceptions in the build process to notify developers while the former will automatically reformat the code that developers may not be aware of. So I think maybe Jason can

Re: [DISCUSS] KIP-353: Allow Users to Configure Kafka Streams Timestamp Synchronization

2018-08-07 Thread Guozhang Wang
like to see something similar done in Kafka Streams. The > timestamp based choosing policy is great and makes sense in a lot of > scenarios, but having something like a priority based policy would be very > nice for some of our usecases. > > -Tommy > > On Tue, 2018-08-07

Enabled spotlessScalaCheck in Jenkins Job for Streams

2018-08-07 Thread Guozhang Wang
Hello folks, Since we have introduced scalafmt to the Streams module, we did not yet enable the check on the Jenkins job yet. It would cause Jenkins job to still pass with ill-formatted code, while the `./gradlew build` process will fail as it automatically execute the check. I have added spotless

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-07 Thread Guozhang Wang
g On Tue, Aug 7, 2018 at 1:19 AM, James Cheng wrote: > Guozhang, in a previous message, you proposed said this: > > > On Jul 30, 2018, at 3:56 PM, Guozhang Wang wrote: > > > > 1. We bump up the JoinGroupRequest with additional fields: > > > > 1.a) a flag i

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2018-08-09 Thread Guozhang Wang
ble the old request, we don't > gain > >>>> anything with this approach. The question is really, if we are willing > >>>> to pay this overhead from 1.2 on -- note, it would be limited to 2 > >>>> versions and not grow further in future releases. Mo

Re: [DISCUSS] KIP-353: Allow Users to Configure Kafka Streams Timestamp Synchronization

2018-08-09 Thread Guozhang Wang
cess data even if there are empty input topic partitions (because we > >> > >> cannot block forever in a stream processing scenario). > >> > >> > >> Not sure, what you mean by "using the timestamp of the last message"? > >> > >

[VOTE] KIP-353: Allow Users to Configure Multi-Streams Timestamp Synchronization Behavior

2018-08-09 Thread Guozhang Wang
Hello all, I would like to start the voting processing on the following KIP, to allow users control when a task can be processed based on its buffered records, and how the stream time of a task be advanced. https://cwiki.apache.org/confluence/display/KAFKA/KIP- 353%3A+Improve+Kafka+Streams+Timest

Re: [DISCUSS] KIP-347: Enable batching in FindCoordinatorRequest

2018-08-11 Thread Guozhang Wang
2018 at 3:55 PM Yishun Guan wrote: > > > > > Hi all, > > > > > > I would like to start a discussion on: > > > > > > KIP-347: Enable batching in FindCoordinatorRequest > > > https://cwiki.apache.org/confluence/x/CgZPBQ > > > > > > Thanks @Guozhang Wang for his help and patience! > > > > > > Thanks, > > > Yishun > > > > > > -- -- Guozhang

Re: [DISCUSS] KIP-347: Enable batching in FindCoordinatorRequest

2018-08-13 Thread Guozhang Wang
> incompatible? > > Best, > Yishun > > On Sat, Aug 11, 2018 at 11:27 AM Guozhang Wang wrote: > > > Hello Yishun, > > > > Thanks for the proposed KIP. I made a pass over the wiki and here are > some > > comments: > > > > 1. "DESCRIBE_G

Re: [DISCUSS] KIP-354 Time-based log compaction policy

2018-08-13 Thread Guozhang Wang
Hello Xiongqi, I think this KIP is already been covered in KIP-280? Could you check out that one and see if it is the case. Guozhang On Mon, Aug 13, 2018 at 1:23 PM, xiongqi wu wrote: > Hi Kafka, > > Just updated the confluence page to include the link to this KIP. > > Any comment will be ap

Re: [DISCUSS] KIP-354 Time-based log compaction policy

2018-08-13 Thread Guozhang Wang
gt; deletion of user record. > > There is no conflict and overlapping between this KIP and KIP-280. > > Thank you! > > > On Mon, Aug 13, 2018 at 1:33 PM, Guozhang Wang wrote: > > > Hello Xiongqi, > > > > I think this KIP is already been covered in KIP

[VOTE] KIP-356: Add withCachingDisabled() to StoreBuilder

2018-08-14 Thread Guozhang Wang
Hello folks, I'd like to start a voting thread on the following KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-356%3A+Add+withCachingDisabled%28%29+to+StoreBuilder It is a pretty straightforward one, adding a missing API to StoreBuilder which should actually be added at the very begi

Re: KIP-213 - Scalable/Usable Foreign-Key KTable joins - Rebooted.

2018-08-14 Thread Guozhang Wang
@gmail.com >>>> wrote: >>>> >>>> Hi Guozhang et al >>>> >>>>> I was just reading the 2.0 release notes and noticed a section on >>>>> Record >>>>> Headers. >>>>> https://cwiki.apache.org/confluenc

Re: [VOTE] KIP-353: Allow Users to Configure Multi-Streams Timestamp Synchronization Behavior

2018-08-15 Thread Guozhang Wang
nks, > > Bill > > > > On Thu, Aug 9, 2018 at 4:20 PM John Roesler wrote: > > > > > +1 non-binding > > > > > > On Thu, Aug 9, 2018 at 3:14 PM Matthias J. Sax > > > wrote: > > > > > > > +1 (binding) > > > > &g

Re: KIP-213 - Scalable/Usable Foreign-Key KTable joins - Rebooted.

2018-08-15 Thread Guozhang Wang
ors API. > > I updated the KIP today with some points worth talking about, should anyone > be so inclined to check it out. Currently we are running this code in > production to handle relational joins from our Kafka Connect topics, as per > the original motivation of the KIP. >

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-08-16 Thread Guozhang Wang
Regarding "broker-agnostic of headers": there are some KIPs from Streams to use headers for internal purposes as well, e.g. KIP-258 and KIP-213 (I admit there may be a conflict with user space, but practically I think it is very rare). So I think we are very likely going to make Kafka internals to

Re: [DISCUSS] KIP-347: Enable batching in FindCoordinatorRequest

2018-08-16 Thread Guozhang Wang
ace? > > On Mon, Aug 13, 2018 at 1:30 PM Guozhang Wang wrote: > > > Regarding 3): Today we do not have this logic with the existing client, > > because defer the decision about the version to use (we always assume > that > > an new versioned request need to be down-

Re: [VOTE] KIP-356: Add withCachingDisabled() to StoreBuilder

2018-08-17 Thread Guozhang Wang
; wrote: > > > +1 (binding) > > > > On 8/14/18 11:16 AM, Eno Thereska wrote: > > > +1 (non binding) > > > > > > Thanks > > > Eno > > > > > > On Tue, Aug 14, 2018 at 10:53 AM, Bill Bejeck > wrote: > > > > > >

Re: 答复: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest

2018-08-17 Thread Guozhang Wang
Yishun, some more comments: 1. "All the coordinator ids " + "for this request": it should be "all the requested group ids looking for their coordinators" right? 2. I just thought about this a bit more, regarding "*Compatibility issues between old and new versions need to be considered, we should

Re: 答复: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest

2018-08-17 Thread Guozhang Wang
, and that would be the logic your PR need to address. Guozhang On Fri, Aug 17, 2018 at 11:59 AM, Yishun Guan wrote: > @Guozhang Wang One thing that I remain confused > about (and forgive me if you have explained this to me before), is that if > we don't have any transformation h

Re: Add to contributor list

2018-08-19 Thread Guozhang Wang
Hello, I cannot find the id "muralimani" for either JIRA or wiki system. Could you double check if it is created? Guozhang On Sun, Aug 19, 2018 at 12:46 AM, Murali Mani wrote: > Hi, > > Could you please add me to the contributor list? My jira id is muralimani > > -- > regards > Murali Krishn

Re: Add to contributor list

2018-08-19 Thread Guozhang Wang
Sun, Aug 19, 2018 at 7:03 PM Guozhang Wang wrote: > > > Hello, > > > > I cannot find the id "muralimani" for either JIRA or wiki system. Could > you > > double check if it is created? > > > > > > Guozhang > > > > > > On Su

Re: [ANNOUNCE] New Kafka PMC member: Dong Lin

2018-08-20 Thread Guozhang Wang
Congratulations Dong! On Mon, Aug 20, 2018 at 10:59 AM, Matthias J. Sax wrote: > Congrats Dong! > > -Matthias > > On 8/20/18 3:54 AM, Ismael Juma wrote: > > Hi everyone, > > > > Dong Lin became a committer in March 2018. Since then, he has remained > > active in the community and contributed a n

Re: Request for contributor permissions

2018-08-21 Thread Guozhang Wang
Hello Jack, I've added you to the contributor list. Cheers. Guozhang 2018-08-21 19:07 GMT-07:00 楊宗訓 : > JIRA ID: jackyoh > > > Thanks in advance! > > > -- > * > 研究發展部 - 資深軟體工程師 > > 楊宗訓 jack > e-mail:j...@is-land.com.tw > > 亦思科技股份有限

Re: Current Kafka Steams and KSQL Performance Metrics / Benchmarks?

2018-08-22 Thread Guozhang Wang
Hello Adam, Thanks for your interests in working on Kafka Streams / KSQL potential performance improvements (I thought the non-key joining will take most of your time :P ) Currently there is no published performance numbers for latest versions of Streams AFAIK. Personally I ran the Streams Simple

Re: [DISCUSS] KIP-363: Make FunctionConversions private

2018-08-23 Thread Guozhang Wang
+1. On Thu, Aug 23, 2018 at 12:47 PM, Ted Yu wrote: > +1 > > In the Motivation section, you can quote the comment from pull request so > that reader doesn't have to click through. > > Cheers > > On Thu, Aug 23, 2018 at 12:13 PM Joan Goyeau wrote: > > > Hi, > > > > As pointed out in this comment

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-23 Thread Guozhang Wang
ernal config > > in the docs. > > > > About upgrading: why do we need have two rolling bounces and encode > > "static" vs "dynamic" in the JoinGroupRequest? > > > > If we upgrade an existing consumer group from dynamic to static, I do

Re: [DISCUSS] KIP-362: Dynamic Session Window Support

2018-08-24 Thread Guozhang Wang
Hello Lei, Thanks for the proposal. I've just made a quick pass over it and there is a question I have: The session windows are defined per key, i.e. does that mean that each incoming record of the key can dynamically change the gap of the window? For example, say you have the following record fo

Re: [VOTE] KIP-363: Make FunctionConversions private

2018-08-24 Thread Guozhang Wang
4 John Roesler wrote: > > > I'm also in favor of this. I don't think it's controversial either. > Should > > we just move to a vote? > > > > On Thu, Aug 23, 2018 at 7:01 PM Guozhang Wang > wrote: > > > > > +1. > > > >

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-24 Thread Guozhang Wang
rom the active members that support the latest JoinGroup > protocol and are using static membership. If we have to choose a leader > with an old version, however, it would see all members in the group (static > or dynamic) as dynamic members and perform the assignment as usual. > > Wo

Re: KIP-213 - Scalable/Usable Foreign-Key KTable joins - Rebooted.

2018-08-27 Thread Guozhang Wang
ill break from strictly using the DSL > and > > > >>>> move > > > >>>> down to the processors API. > > > >>>> > > > >>> I think. The abstraction is not powerful enough > > > >>> to not have kafka specifics leak up The leak I c

Re: KIP-213 - Scalable/Usable Foreign-Key KTable joins - Rebooted.

2018-08-29 Thread Guozhang Wang
goal is suss out agreement prior to moving to a vote. > > On Mon, Aug 27, 2018 at 3:19 PM, Guozhang Wang wrote: > > > I like John's idea as well: for this KIP specifically as we do not expect > > any other consumers to read the repartition topics externally, we ca

Re: [DISCUSS] KIP-347: Enable batching in FindCoordinatorRequest

2018-09-01 Thread Guozhang Wang
return multiple requests in the list, while all others will return singleton list, right? Guozhang On Fri, Aug 31, 2018 at 10:51 AM, Yishun Guan wrote: > @Guozhang Wang Could you review this again when you have time? Thanks! > -Yishun > On Wed, Aug 29, 2018 at 11:57 AM Yishun Gu

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-09-01 Thread Guozhang Wang
in the log, which > is potentially cleanable now? > > 4. Could you document how key deletion will be handled? > > 10. As for Jason's proposal on CompactionStrategy, it does make the feature > more general. On the other hand, it will be useful not to require > user-level code

Re: [VOTE] KIP-365: Materialized, Serialized, Joined, Consumed and Produced with implicit Serde

2018-09-01 Thread Guozhang Wang
+1 (binding). On Mon, Aug 27, 2018 at 5:20 PM, Dongjin Lee wrote: > +1 (non-binding) > > On Tue, Aug 28, 2018 at 8:53 AM Bill Bejeck wrote: > > > +1 > > > > -Bill > > > > On Mon, Aug 27, 2018 at 3:24 PM Ted Yu wrote: > > > > > +1 > > > > > > On Mon, Aug 27, 2018 at 12:18 PM John Roesler > wro

Re: KIP-213 - Scalable/Usable Foreign-Key KTable joins - Rebooted.

2018-09-01 Thread Guozhang Wang
PR ready to go to prod then I can make > those changes. Hope that clears things up. > > Thanks > > Adam > > > On Aug 29, 2018, at 12:42 PM, Guozhang Wang wrote: > > > > Hi Adam, > > > > What do you mean by "additional comments on the workflow.&quo

Re: [DISCUSS] KIP-347: Enable batching in FindCoordinatorRequest

2018-09-02 Thread Guozhang Wang
rth for this story, > and if not, is there another way out? > > Thanks, > Yishun > On Sat, Sep 1, 2018 at 11:04 AM Guozhang Wang wrote: > > > > Hello Yishun, > > > > Thanks for the updated KIP. I think option 1), i.e. return multiple > > requests from bu

Re: Add to contributor list

2018-09-04 Thread Guozhang Wang
> email once the ID has been created. I shall notify you / team to send the > > request for actvation. I hope it is fine. > > > > https://www.apache.org/dev/new-committers-guide.html#cla > > > > Thanks for your understanding. > > > > > > > >

Re: [DISCUSS] KIP-347: Enable batching in FindCoordinatorRequest

2018-09-04 Thread Guozhang Wang
+Enable+batching+in+FindCoordinatorRequest > > Let me know what you think. > > Thanks, > Yishun > On Sun, Sep 2, 2018 at 10:02 PM Guozhang Wang wrote: > > > > Hi Yishun, > > > > I was actually not suggesting we should immediately make such dramatic >

Re: [VOTE] KIP-366 - Make FunctionConversations private

2018-09-06 Thread Guozhang Wang
+1 for deprecating and copying the class over to internals. On Thu, Sep 6, 2018 at 6:56 AM, Bill Bejeck wrote: > +1 > > -Bill > > On Thu, Sep 6, 2018 at 4:29 AM Joan Goyeau wrote: > > > Sournds good, I'll make the deprecation and copy the class over. > > > > Thanks > > > > On Wed, 5 Sep 2018 at

[ANNOUNCE] Kafka Committers Guidelines

2018-09-06 Thread Guozhang Wang
Hello folks, Many of the Kafka PMC members have received emails asking about "how can I become a committer in Apache Kafka", and so we figured it is a good time to publish concrete guidelines on this regard. The PMC has discussed and voted on a short list of areas that we are looking for promoting

Re: Add to contributor list

2018-09-07 Thread Guozhang Wang
Added "Murali Krishnan Mani". Guozhang On Fri, Sep 7, 2018 at 8:42 AM, Murali Mani wrote: > Thanks Guozhang. I already have the id for Apache Jira / Issues. "Murali > Mani" is my id, can you please add me to the Apache Kafka contributor list? > > On Tue, Sep

Re: [DISCUSS] Apache Kafka 2.1.0 Release Plan

2018-09-09 Thread Guozhang Wang
Dong, thanks for driving the release! On Sun, Sep 9, 2018 at 5:57 PM, Ismael Juma wrote: > Thanks for volunteering Dong! > > Ismael > > On Sun, 9 Sep 2018, 17:32 Dong Lin, wrote: > > > Hi all, > > > > I would like to be the release manager for our next time-based feature > > release 2.1.0. > >

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-10 Thread Guozhang Wang
Hello Nikolay, Thanks for picking this up! Just sharing my two cents: 1) I'd suggest keeping `Punctuator#punctuate(long timestamp)` as is since comparing with other places where we are replacing with Duration and Instant, this is not a user specified value as part of the DSL but rather a passed-i

Re: [DISCUSS] KIP-362: Dynamic Session Window Support

2018-09-10 Thread Guozhang Wang
(15, 3) ... > > > > in this case when (15, 3) is received, [13,13] should be retrieved and > > merged to a new window [13, 15], then [19,19] should be updated to [13, > > 19]. Correct? > > > > To be able to achieve that, like you said, the gap needs to be stored for &g

Re: KIP-213 - Scalable/Usable Foreign-Key KTable joins - Rebooted.

2018-09-10 Thread Guozhang Wang
Hello Adam, Could you elaborate how would the hwm be defined for each record, and the detailed logic of Highwater Mark Processor (e.g. how to bound the space usage of the Highwater Mark store? would it be growing indefinitly)? Maybe it's already included in your running PR but I cannot fully diges

Re: [DISCUSS] KIP-372: Naming Joins and Grouping

2018-09-12 Thread Guozhang Wang
Hello Bill, I made a pass over your proposal and here are some questions: 1. For Joined names, the current proposal is to define the repartition topic names as * [app-id]-this-[join-name]-repartition * [app-id]-other-[join-name]-repartition And if [join-name] not specified, stay the same, whi

Re: [DISCUSS] KIP-372: Naming Joins and Grouping

2018-09-13 Thread Guozhang Wang
; to be orthogonal, and thus KIP-372 should not change any processor > names, but KIP-307 should define a holistic strategy for all processor. > Otherwise, we might up with different strategies or revert what we > decide in this KIP if it's not compatible with KIP-307. > > > -

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-13 Thread Guozhang Wang
+1 (binding), thank you Nikolay! Guozhang On Thu, Sep 13, 2018 at 9:39 AM, Matthias J. Sax wrote: > Thanks for the KIP. > > +1 (binding) > > > -Matthias > > On 9/5/18 8:52 AM, John Roesler wrote: > > I'm a +1 (non-binding) > > > > On Mon, Sep 3, 2018 at 8:33 AM Nikolay Izhikov > wrote: > > > >

Re: [DISCUSS] KIP-372: Naming Joins and Grouping

2018-09-14 Thread Guozhang Wang
uggests that, just like we propose to subsume the Serialized > config for grouping into a more general config called Grouped, we should > also want to do something similar and replace `KTable#join(KTable<>, > ValueJoiner<>, Materialized<>)` with one taking a more general >

Re: KIP-213 - Scalable/Usable Foreign-Key KTable joins - Rebooted.

2018-09-14 Thread Guozhang Wang
Hello Adam, Thanks for the explanation. Regarding the final step (i.e. the high watermark store, now altered to be replaced with a window store), I think another current on-going KIP may actually help: https://cwiki.apache.org/confluence/display/KAFKA/KIP-258%3A+Allow+to+Store+Record+Timestamps+i

Re: KIP-213 - Scalable/Usable Foreign-Key KTable joins - Rebooted.

2018-09-14 Thread Guozhang Wang
ing offset ordering, we will reject updates that are older than the current key's timestamps, i.e. following timestamp ordering. Guozhang On Fri, Sep 14, 2018 at 11:21 AM, Guozhang Wang wrote: > Hello Adam, > > Thanks for the explanation. Regarding the final step (i.e. the hig

Re: Access for a KIP creation

2018-09-14 Thread Guozhang Wang
Hello Wladimir, Thanks for your interests. Your ID has been granted permissions. Guozhang On Fri, Sep 14, 2018 at 11:43 AM, Wladimir Schmidt wrote: > Hi, > > I would like to request an access right for a KIP creation. > Reference: https://github.com/apache/kafka/pull/5344#issuecomment-41994

Re: [DISCUSS] KIP-372: Naming Joins and Grouping

2018-09-14 Thread Guozhang Wang
t; > > > > > > > > > > > On Thu, Sep 13, 2018 at 6:49 PM John Roesler wrote: > > > > > Hey all, > > > > > > I think it's slightly out of scope for this KIP, but I'm not sure it's > > > right to add a n

Re: Accessing Topology Builder

2018-09-16 Thread Guozhang Wang
Hello Jorge, >From the TracingProcessor implementation it seems you want to track per-processor processing latency, is that right? If this is the case you can actually use the per-processor metrics which include latency sensors. If you do want to track, for a certain record, what's the latency of

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

2018-09-17 Thread Guozhang Wang
+1 from me, thanks Bill ! On Mon, Sep 17, 2018 at 12:43 PM, Bill Bejeck wrote: > All, > > I'd like to start the voting process for KIP-372. Here's the link to the > updated proposal > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 372%3A+Naming+Repartition+Topics+for+Joins+and+Groupin

<    1   2   3   4   5   6   7   8   9   10   >