Re: [DISCUSS] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

2018-12-18 Thread Saïd Bouras
Hi everyone ! I saw this KIP and I comment the PR, but like *@Chia-Ping* mentioned, it's better to talk here with community. Well to summarize, I think that putting the methods *configure* and *close* default could bring misunderstanding in the approach when implementing customs serializers and

Re: [DISCUSS] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

2018-07-04 Thread Chia-Ping Tsai
hi John > Just really scraping my mind for concerns to investigate... This change > won't break source compatibility, but will it affect binary compatibility? > For example, if I compile my application against Kafka 2.0, for example, > and then swap in the Kafka jar containing your change on my

Re: [DISCUSS] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

2018-07-03 Thread John Roesler
Hi again, Chia-Ping, Thanks! I took a look at it, and it seems like a good change to me. I don't know if it will generate much discussion, so I recommend just letting it steep for another day or two and then moving on to a vote if no one else chimes in. Just really scraping my mind for concerns

Re: [DISCUSS] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

2018-07-02 Thread Chia-Ping Tsai
> Can you provide a link, please? Pardon me. I put the page in the incorrect location. https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde Cheers, Chia-Ping On 2018/07/02 19:45:19, John

Re: [DISCUSS] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

2018-07-02 Thread John Roesler
Hi Chia-Ping, I couldn't find KIP-331 in the list of KIPs ( https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals ). Can you provide a link, please? Thanks, -John On Sun, Jul 1, 2018 at 11:33 AM Chia-Ping Tsai wrote: > hi folks, > > KIP-331 is waiting for any

[DISCUSS] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

2018-07-01 Thread Chia-Ping Tsai
hi folks, KIP-331 is waiting for any suggestions, feedback and reviews. The main purpose of the KIP-331 is to add empty implementations to the close() and configure() so as to user can write less code to develop custom Serialzier, Deserializer and Serde. Cheers, Chia-Ping