Re: Karaf 4.4/Pax-Web 8.0.4 Tomcat login valve handling

2022-06-28 Thread Grzegorz Grzybek
Hello I didn't spot the change embedded in the move ;) But anyway - thanks for the PR and the improvement! The tests passed and I've merged your PR. Tomorrow I'll release 8.0.5. regards Grzegorz Grzybek wt., 28 cze 2022 o 15:08 Siano, Stephan napisaƂ(a): > Hi Grzegorz, > > The change is

RE: Karaf 4.4/Pax-Web 8.0.4 Tomcat login valve handling

2022-06-28 Thread Siano, Stephan
Hi Grzegorz, The change is actually simpler than it looks, I just moved some code further down. The only code that is actually new is // Has an authenticator been configured already? authenticationValve = (Valve)

Re: Karaf 4.4/Pax-Web 8.0.4 Tomcat login valve handling

2022-06-28 Thread Grzegorz Grzybek
Hello The process is perfectly fine ;) Just create a GH issue and/or PR and we can include it in the next release. By simply looking at https://github.com/ops4j/org.ops4j.pax.web/pull/1734/files I can't _feel_ the change, let me just run all the tests (btw - did you run it? I'd be happy to get a

Karaf 4.4/Pax-Web 8.0.4 Tomcat login valve handling

2022-06-28 Thread Siano, Stephan
Hi, I have a meta-question concerning extensions in pax-web. With pax-web 8.0.4 (which is the latest version of the pax-web in the karaf 4.4 release) thanks to Grzegorz parsing of global and war specific context.xml files works in pax-web-tomcat. However there is still one limitation: If the