Fwd: [apache/logging-log4cxx] Replace ant build with cmake (#14)

Hi All, I have done everything I can think of prepare https://github.com/apache/logging-log4cxx/pull/14 for inclusion in the repository. Please review. On Sat, Feb 8, 2020 at 3:33 AM Matt Sicker wrote: > *@jvz* commented on this pull request. > -- > > In

[log4cxx] Towards a release

I have posted the result of "mvn post-site" to https://stephen-webb.github.io/ Please review.

Re: [log4cxx] Towards a release

The issue is it has changed to core log4cxx api so that existing 0.10 code may not compile. The macros are the core log4cxx api. On Mon, Mar 2, 2020, 9:32 PM Thorsten Schöning wrote: > Guten Tag Stephen Webb, > am Montag, 2. März 2020 um 11:05 schrieben Sie: > > > In my review

Re: [log4cxx] Towards a release

of thousands of lines of code that will not work with this change. I would suggest we need a configure option to use the 0.10 macros instead of the new ones. The new macros can be the default. Regards Stephen Webb On Mon, Mar 2, 2020, 7:50 PM Thorsten Schöning wrote: > Guten Tag Stephen Webb, &

Re: [log4cxx] Towards a release

ckage managers (conan.io and vcpkg). I would be surprised if any unix distribution would change to 0.11 log4cxx if its API is incompatible with 0.10. Regards Stephen Webb On Tue, Mar 3, 2020 at 4:28 AM Thorsten Schöning wrote: > Guten Tag Ralph Goers, > am Montag, 2. März 2020 um 16:34 schriebe

[jira] [Commented] (LOGCXX-494) Provide a windows build environment for the project

Am I correct in thinking the ant build is very broken as 'find-apr.xml' does not make use of 'apr-1-config' like 'find_apr.m4' does? (The same applies to 'find-apr-util.xml' etc.) Am I missing something or is log4cxx the only Apache Portable Runtime user that provides an ant build (I looked at

Re: [jira] [Commented] (LOGCXX-494) Provide a windows build environment for the project

tephen/logging-log4cxx Username for 'https://gitbox.apache.org': stephen-webb Password for 'https://stephen-w...@gitbox.apache.org': [INFO] [INFO] BUILD FAILURE [INFO] --

Re: [log4cxx] Contributing a CMkae build system

Hi Thorsten, I saw in the mailing lists you have previously (July 2017, January 2018) attempted to get a release done, but I did not see any vote being taken. Could you tell us why the vote did not happen on these occasions? Also, who is the current PMC chair? Regards Stephen Webb On Tue, Jan

[log4cxx] Contributing a CMkae build system

comments? Regrads Stephen Webb

Re: [log4cxx] Towards a release

I see no question at that link, only the commit diff. On Mon, Mar 30, 2020 at 5:36 PM Thorsten Schöning wrote: > Guten Tag Stephen Webb, > am Montag, 30. März 2020 um 04:19 schrieben Sie: > > > My PR#21 (https://github.com/apache/logging-log4cxx/pull/21) remains > > un-revi

Re: [log4cxx] Towards a release

Is there anyway I can to help move this forward (I do not have an Apache account)? My PR#21 (https://github.com/apache/logging-log4cxx/pull/21) remains un-reviewed. I have created a migration tool https://github.com/stephen-webb/log4cxx_10_to_11 for anyone who has the same migration issues as I

Re: [log4cxx] Towards a release

mitter) can look at it. I don’t normally work on Windows so trying > to run a build with it is a bit more than I would like to do. > > Ralph > > > On Mar 29, 2020, at 7:19 PM, Stephen Webb wrote: > > > > Is there anyway I can to help move this forward (I do not have a

Re: Log4cxx version

I would completely support that change. On Sun, Aug 23, 2020, 3:14 AM Ralph Goers wrote: > In looking at the log4cxx changelog I can’t help notice that the first > release was 17 years ago. After all these years one would expect that the > version should have hit 1.0.0 at least 10-15 years ago.

Re: [VOTE] [log4xx] Release log4cxx 0.11.0

I am using a recent version in production Ubuntu servers, so it is definitely release ready. +1 On Mon, Aug 17, 2020, 7:27 PM Christian Grobmeier wrote: > Hello, > > I am not an expert on c++ or something, but I looked on the content, read > this thread and think it is safe to release this.

Re: [log4cxx] Release Testing

14, 2020, at 11:22 PM, Ralph Goers > wrote: > >> > >> Yes, it is at /usr/local/Cellar/apr/1.7.0/libexec/bin/. > >> > >> Ralph > >> > >>> On Jul 14, 2020, at 11:14 PM, Stephen Webb > wrote: > >>> > >>> Hi Ralph, > >

Re: [log4cxx] Release Testing

Hi Robert, I believe the failures are due to gzip,sed and zip programs not being available. My preference was to exclude those tests when the program was not available to prevent exactly the problem you encountered. Thorsten did not accept my pull request.

Re: [log4cxx] Release Testing

Hi Ralph, Could you tell me if your Mac has the script "apr-1-config" installed? The src/cmake/FindApr.cmake in log4cxx expects the apr installation to create that script and it calls it (passing --includedir) to set APR_INCLUDE_DIR with the output On Wed, Jul 15, 2020 at 3:57 PM Ralph Goers

Re: [log4cxx] Release Testing

bin/. > > Ralph > > > On Jul 14, 2020, at 11:14 PM, Stephen Webb wrote: > > > > Hi Ralph, > > > > Could you tell me if your Mac has the script "apr-1-config" installed? > > > > The src/cmake/FindApr.cmake in log4cxx expects the apr

Re: [log4cxx] Release Testing

gt; I don’t see a directory named “package” so I am assuming you meant > something else. > > Ralph > > > On Jul 14, 2020, at 11:56 PM, Stephen Webb wrote: > > > > Could you re-run that test by typing > > > > ctest -R streamtestcase --output-on-failure >

Re: [log4cxx] Release Testing

Hi Thorsten, Would you consider a PR that updated the failing tests with code to check for the required programmes? We could then output a failure message that informed the user why the test does not work. On Fri, Jul 17, 2020 at 8:57 PM Thorsten Schöning wrote: > Guten Tag Robert Middleton,

Re: [log4cxx] Site / Release?

The doxygen style is looking a bit old now - could we move to Doxygen + Breath + Sphinx? Here is a old resource walking through the process of integrating into CMake: https://devblogs.microsoft.com/cppblog/clear-functional-c-documentation-with-sphinx-breathe-doxygen-cmake/

Re: [VOTE] Release log4cxx 0.12.0-RC2

+1 On Sun, May 9, 2021 at 1:13 PM Robert Middleton wrote: > As a reminder, this vote is still outstanding. > > -Robert Middleton > > On Tue, May 4, 2021 at 7:10 PM Robert Middleton > wrote: > > > > I've updated the NOTICE file in git, so it will be correct for the > > next release. :) > > > >

Re: [log4cxx] Release Prep

_ptrs of different types pointing at the > same object). > > -Robert Middleton > > On Wed, Apr 21, 2021 at 2:52 AM Stephen Webb wrote: > > > Hi Robert, > > > > I suggest adding the following to 'change-report-gh.md' > > > > > > Migrating from 0.

Re: [VOTE] Release log4cxx 0.12.0

+1 I built and used it with the systems I maintain and everything looks good. On Tue, Apr 27, 2021 at 11:44 AM Robert Middleton wrote: > This is a vote to release log4cxx 0.12.0. > > Please download, test, and cast your votes on the log4j developers list. > [] +1, release the artifacts > []

Re: [log4cxx] Release Prep

Hi Robert, Using ${CMAKE_SOURCE_DIR} instead of a relative path creates a problem when including the log4cxx root directory from a higher level CMakeLists.txt. CMAKE_SOURCE_DIR is (inconveniently) set where the top-most CMakeLists.txt file resides. You are using ${CMAKE_SOURCE_DIR} in

Re: [log4cxx] Release Prep

> Or maybe we just need something like LOG4CXX_SOURCE_DIR? yes, I like that idea - something we control. Virus-free. www.avast.com

Re: [log4cxx] Release Prep

Hi Robert, I suggest adding the following to 'change-report-gh.md' Migrating from 0.11.0 - Code changes are required for log4cxx pointer downcasting. The automatic cast performed by the log4cxx 0.11 smart pointer assign operator is no longer supported. For example:

[log4cxx] CI Benchmarking

for each PR be useful? Regards Stephen Webb <https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail> Virus-free. www.avast.com <https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail> <#DAB4FAD8

Re: [log4cxx] Short filename options

I prefer option 2 if it is possible. I do not think it is useful to have the full path name (of the build directory) in shipped binaries. On Sun, Jan 2, 2022 at 7:11 AM Robert Middleton wrote: > PR #75 adds a new option for displaying the short filename of the log > location, which is probably

Re: [log4cxx] CI Benchmarking

gt; produce comparable results. > >>> > >>> It would however be good to provide some tools to run the (same) > benchmarks > >>> manually. > >>> > >>> When run on the same hardware with different codebases or on different > >>> har

Re: [log4cxx] How to run the throughput test?

That looks like a cmake issue - could you try cmake version 3.22? I am still using Visual Studio 2019 Community Edition. Virus-free. www.avast.com

Re: [log4cxx] How to run the throughput test?

red DLLs > from the PATH). > > -Robert Middleton > > On Wed, Dec 29, 2021 at 5:27 PM Stephen Webb wrote: > > > > That looks like a cmake issue - could you try cmake version 3.22? > > > > I am still using Visual Studio 2019 Community Edition. > > > >

Re: [log4cxx] next_stable and other fixes

Once the branches diverge, git cherry-pick is the better merge process. On Tue, Jan 4, 2022 at 11:06 AM Robert Middleton wrote: > Just as a note to all, what I've been doing with next_stable is to > periodically merge master back in once I make fixes on master(assuming > that those fixes are

Re: [log4cxx] Short filename options

ion info compiled in, we should have a preprocessor macro that > will compile out all of the location info data. We can already > compile out log messages of certain levels, so hiding the location is > just a natural extension of that. > > -Robert Middleton > > On Sat, Jan 1, 2

Re: Staging website (was: [VOTE] Release Apache Log4j 2.21.0)

? Thanks Stephen Webb On Sat, Oct 14, 2023 at 1:35 AM Piotr P. Karwasz wrote: > Hi Christian, > > On Fri, 13 Oct 2023 at 13:46, Christian Grobmeier > wrote: > > Why is content not causing this issue? > > For me both is possible, just trying to understand the best way. &g

Re: [log4j] Default configuration for 3.x

I recall my difficulties (many years ago), when first incorporating logging, working out what was a "good" logging configuration. I would have really appreciated a good out-of the box default. Now I think that the out-of-the box default should be * A root logger set to INFO * A rolling appender

Re: [General] What is logging?

Good job Robert. It frustrates me that the (essential) importance of logging is not emphasised sufficiently in introductory software engineering. This is a help towards getting the message out. My suggestion would be to mention runtime configuration of filtering and enabling of loggers earlier in

Re: [VOTE] Release log4cxx 0.13.0

+1 I tested 0.13.0 on Ubuntu and Windows - all OK On Sat, Apr 16, 2022 at 7:47 PM Thorsten Schöning wrote: > Guten Tag Robert Middleton, > am Samstag, 16. April 2022 um 03:00 schrieben Sie: > > > This is a vote to release log4cxx 0.13.0. > > +1 > > Mit freundlichen Grüßen > > Thorsten Schöning

Re: [log4cxx] JIRA Updates and next release?

I just went through the differences between master and rel/v0.13.0 and the only significant fix I saw in master was the crash in a statically linked log4cxx library. While I am not familiar with the amount of work required to create a release (it looks like a lot), I wonder if there are enough

Re: [log4cxx] Github windows builds

It works using a more recent version of vcpkg - not sure what the issue with the old version is. On Thu, Oct 27, 2022 at 1:41 PM Robert Middleton wrote: > I've been adding some more builds for log4cxx(to test more > combinations of features and stuff) but I seem to have broken the > windows

Re: [log4cxx] Github windows builds

ing? > > Anyway, it's fixed now. Are there any other configurations that we > should test for while I'm making updates? > > -Robert Middleton > > On Thu, Oct 27, 2022 at 1:37 AM Stephen Webb wrote: > > > > It works using a more recent version of vcpkg -

Re: [VOTE] Release log4cxx 1.0.0

+1 I have built and tested the .zip archive using Visual Studio 2019. I tested the .taz.gz archive with gcc 9.4 on Ubuntu On Tue, Jan 3, 2023 at 7:37 PM Remko Popma wrote: > +1 Remko > > On Tue, Jan 3, 2023 at 4:57 PM Thorsten Schöning > wrote: > > > Guten Tag Robert Middleton, > > am

Re: [log4cxx] Next steps / release?

I think the next_stable branch should be released now. I am not aware of any issue that would prevent a release. I will do some more tests with production code this weekend to ensure there is no anything I have missed. On Fri, Dec 30, 2022 at 9:21 AM Robert Middleton wrote: > With some fixes

Re: [log4cxx] Stacktrace support

I am not able to think of any use-case where filtering the stacktrace data would be useful. It is already possible to put the stacktrace into the log using C++ streams - boost stacktrace provides std::basic_ostream< CharT, TraitsT > & operator<<(std::basic_ostream< CharT, TraitsT > & os,

Re: [log4cxx] fmt compiling/linking issue

In Visual studio 2019 the line fmt::arg("d", event->getChronoTimeStamp()), causes the compile time error: error C2338: Cannot format an argument. To make type T formattable provide a formatter specialization: https://fmt.dev/latest/api.html#udt It seems to need a formatter specialization

Re: [log4cxx] fmt compiling/linking issue

mat > std::chrono::time_point, which I > thought was std::chrono::system_clock instead of steady_clock. > > -Robert Middleton > > > On Fri, Nov 25, 2022 at 11:03 PM Stephen Webb wrote: > > > > In Visual studio 2019 the line > > > > fmt::arg("d"

Re: [VOTE] Release log4cxx 1.1.0-RC2

+1 - Built and tested using Visual Studio 2019 On Wed, May 3, 2023 at 11:43 PM Volkan Yazıcı wrote: > +1 > > Verified signatures, checksums, and LICENSE/NOTICE files. > > On Wed, May 3, 2023 at 12:38 PM Robert Middleton > wrote: > > > This is a vote to release log4cxx 1.1.0-RC2. The old vote

Re: Apache Log4cxx 1.1.0

Yes, 32-bit builds should be OK. The code at line 64 should be AppenderSkeleton(const LayoutPtr& layout); The code at line 44 should be: AppenderSkeleton(LOG4CXX_PRIVATE_PTR(AppenderSkeletonPrivate) priv); Asif, is your AppenderSkeleton.h different? On Wed, Jun 21, 2023 at 7:25 AM Gary

Re: [VOTE] Release log4cxx 1.1.0

-1 I believe a bad security vulnerability was introduced by a recent commit On Wed, 3 May 2023, 6:02 am Remko Popma, wrote: > +1 Remko > > On Wed, May 3, 2023 at 2:34 AM Thorsten Schöning > wrote: > > > Guten Tag Robert Middleton, > > am Dienstag, 2. Mai 2023 um 13:47 schrieben Sie: > > > > >

Re: [log4cxx] Release review kit

+1 I have: - checked the SHA512 checksums - checked for unexpected changes in the list of files in the 1.2.0.tar.gz archive compared to the 1.1.0.tar.gz release archive - built on Windows using each compressed archive (using two conan recipes) - built and tested a suite of applications using

Re: [DOC] Make use of "common" logging website pages (security, downloads etc. pp)

Could you explain what is meant by " standard websites"? Is it possible/advisable to mandate "only one page to maintain" given the different types of user (e.g. digital infrastructure maintainer, developer, etc) and the diverse ecosystems that C++/JVM/DotNet have created? Do a few static pages

Re: [log4cxx] Board report entry

To make it a positive statement, I would report As a result of the result of work since the 1.2 release in January, benchmark performance measurements show upto 60% reduction in overhead in Log4cxx internals. On Wed, May 1, 2024 at 1:06 AM Robert Middleton wrote: > There's nothing major going