Re: Lucene 9.3.0 release

2022-07-20 Thread Julie Tibshirani
Hello Mayya, I can share my view. Strictly speaking, we only need a new codec version if the on-disk format changes for some type (like kNN vectors in this case). Otherwise we can just evolve the logic in the same way we do with other code, making the improvements in-place. Alessandro's PR is a

Re: Lucene 9.3.0 release

2022-07-20 Thread Mayya Sharipova
Hi Julie, thanks for raising this point, I was also thinking about it. I think it would be valuable to clarify what constitutes the format changes. Is on disk changes a necessary requirement for it? Or is it enough that codec readers and writers change their behaviour? For example, for

Re: New branch and feature freeze for Lucene 9.3.0

2022-07-20 Thread Greg Miller
Thanks Ignacio! I just created https://issues.apache.org/jira/browse/LUCENE-10659 as a proposed blocker for 9.3. It's a small bug fix for a unit test I recently introduced on the 9x branch (one of the last things to get pulled into the 9.3 candidate). I think we ought to fix this test before

Re: [JENKINS] Lucene-main-Linux (64bit/jdk-17.0.3) - Build # 35849 - Unstable!

2022-07-20 Thread Greg Miller
OK, I think these test failures should now be resolved (on both main and branch_9x). But I'll keep an eye on nightly builds/tests. Cheers, -g On Wed, Jul 20, 2022 at 9:17 AM Greg Miller wrote: > > I'll dig into this soon. Looks like a new test I recently added hit an > issue. Apologies. > >

Re: Lucene 9.3.0 release

2022-07-20 Thread Julie Tibshirani
Hello everyone, We had preemptively created a Lucene93Codec to support the vector search changes (Mike's work in LUCENE-10577, Mayya's work in LUCENE-10592). However neither of these changes made it for 9.3, so there have not been any real format changes-- Lucene93Codec is the same as

Re: [JENKINS] Lucene-main-Linux (64bit/jdk-17.0.3) - Build # 35849 - Unstable!

2022-07-20 Thread Greg Miller
I'll dig into this soon. Looks like a new test I recently added hit an issue. Apologies. Cheers, -g On Wed, Jul 20, 2022 at 2:32 AM Policeman Jenkins Server wrote: > > Build: https://jenkins.thetaphi.de/job/Lucene-main-Linux/35849/ > Java: 64bit/jdk-17.0.3 -XX:+UseCompressedOops

Re: New branch and feature freeze for Lucene 9.3.0

2022-07-20 Thread Ignacio Vera
Please find here the draft for the release highlights. I have probably missed things that should be included so please feel free to add them. https://cwiki.apache.org/confluence/pages/resumedraft.action?draftId=217391905 On Wed, Jul 20, 2022 at 10:17 AM Ignacio Vera wrote: > NOTICE: > > >

New branch and feature freeze for Lucene 9.3.0

2022-07-20 Thread Ignacio Vera
NOTICE: Branch branch_9_3 has been cut and versions updated to 9.4 on stable branch. Please observe the normal rules: * No new features may be committed to the branch. * Documentation patches, build patches and serious bug fixes may be committed to the branch. However, you should submit