Re: [VOTE] Release Lucene 9.4.0 RC2

2022-09-26 Thread Anshum Gupta
+1 (binding) Smoke tests passed and I tried out basic indexing and search. SUCCESS! [0:59:09.751008] Thanks for your effort Mike, and everyone else. On Mon, Sep 26, 2022 at 8:47 AM Michael Sokolov wrote: > Please vote for release candidate 2 for Lucene 9.4.0 > > The artifacts can be

Re: [VOTE] Release Lucene 9.4.0 RC2

2022-09-26 Thread Uwe Schindler
Hi, Policeman Jenkins checked the release for me (https://jenkins.thetaphi.de/job/Lucene-Release-Tester/20/console): SUCCESS! [1:30:14.639302] Finished: SUCCESS I also checked Luke downloaded from the binary JAR and tested Java 19 support: * When starting Luke with Java 11 it says in log

[VOTE] Release Lucene 9.4.0 RC2

2022-09-26 Thread Michael Sokolov
Please vote for release candidate 2 for Lucene 9.4.0 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-9.4.0-RC2-rev-0384b4fcad7856ddc574c8b994c814a568ce6d0a You can run the smoke tester directly with this command: python3 -u

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Michael Sokolov
OK - well, this vote passed, but we will re-spin to capture the bug fix and the JDK-19 support. I'll open a new vite thread for RC2 On Mon, Sep 26, 2022 at 9:57 AM Uwe Schindler wrote: > > See my mail before. Delete gradle.properties from Lucene checkout folder. > > Uwe > > Am 26.09.2022 um

Re: IMPORTANT: Please update your gradle.properties file in your Lucene checkout!

2022-09-26 Thread Uwe Schindler
Hi, with deleting the file, I meant the "gradle.properties" in the lucene checkout. Uwe Am 26.09.2022 um 15:44 schrieb Uwe Schindler: Hey, after merge of Java 19 support to main, 9.x and to-be-released 9.4, there is a small change needed in your gradle.properties file. In earlier

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Uwe Schindler
See my mail before. Delete gradle.properties from Lucene checkout folder. Uwe Am 26.09.2022 um 15:51 schrieb Michael Sokolov: Hm the build failed with this: FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':lucene:core:compileMain19Java'. Error while

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Michael Sokolov
Hm the build failed with this: FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':lucene:core:compileMain19Java'. > Error while evaluating property 'javaCompiler' of task > ':lucene:core:compileMain19Java' > Failed to calculate the value of task

IMPORTANT: Please update your gradle.properties file in your Lucene checkout!

2022-09-26 Thread Uwe Schindler
Hey, after merge of Java 19 support to main, 9.x and to-be-released 9.4, there is a small change needed in your gradle.properties file. In earlier version we disabled auto-provisioning of JDK releases for compilation, but now it is required. If your build hangs at

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Michael Sokolov
Nice! Thanks everyone, I will refresh and start building the artifacts On Mon, Sep 26, 2022 at 9:33 AM Uwe Schindler wrote: > > OK, > > Java 19 support for Panama Foreign is in! Thanks for waiting! > > Uwe > > Am 26.09.2022 um 15:08 schrieb Uwe Schindler: > > I will also merge shortly! Please

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Uwe Schindler
OK, Java 19 support for Panama Foreign is in! Thanks for waiting! Uwe Am 26.09.2022 um 15:08 schrieb Uwe Schindler: I will also merge shortly! Please have a quick look @ https://github.com/apache/lucene/pull/912 That's really great that Eclipse Adoptium released in time :-) Uwe Am

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Uwe Schindler
I will also merge shortly! Please have a quick look @ https://github.com/apache/lucene/pull/912 That's really great that Eclipse Adoptium released in time :-) Uwe Am 26.09.2022 um 14:57 schrieb Adrien Grand: The change is now on branch_9_4. On Mon, Sep 26, 2022 at 2:38 PM Adrien Grand

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Adrien Grand
The change is now on branch_9_4. On Mon, Sep 26, 2022 at 2:38 PM Adrien Grand wrote: > I opened a PR and will backport it to relevant branches shortly: > https://github.com/apache/lucene/pull/11818. > > On Mon, Sep 26, 2022 at 2:26 PM Uwe Schindler wrote: > >> Hi Michael, >> >> if you give me

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Adrien Grand
I opened a PR and will backport it to relevant branches shortly: https://github.com/apache/lucene/pull/11818. On Mon, Sep 26, 2022 at 2:26 PM Uwe Schindler wrote: > Hi Michael, > > if you give me an hour or so to add changes. All fine now! > > I will re-spin today. I don't think we should wait

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Uwe Schindler
Hi Michael, if you give me an hour or so to add changes. All fine now! I will re-spin today. I don't think we should wait any longer for AdoptOpenJDK - sorry Uwe; I too would like to be able to mess around with the new features in JDK19, but I think it's not a good precedent to tie our release

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Michael Sokolov
OK, this is clearly messed up, but just for my education, I'd like to understand the possible failure scenario. Oh thanks Adrien, just saw your latest. So that confirms what I was thinking: that this is not likely to cause problems in any foreseeable scenario; there is no

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Adrien Grand
Hey Uwe, This problem would not be observed by bwc tests because they always make sure to use the right codec. The problem only arises if things get mixed up for some reason, and the wrong codec gets used to read a segment. Hopefully no user would ever see this problem in practice. The main

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Uwe Schindler
Hi again, About the original bug you reported: This is really serious and we MUST respin! That opens the following question: Why was this bug not discoveredby the backwards compatibility tests? If you open a 9.0 index from backwards indexes with 9.4 it should complain? Or does this pass

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Uwe Schindler
Hi, cool. Could we please wait with the respon till Adoption released also OpenJDK 19, so we can include the Java 19 MMapDirectory as discussed before. Everything is ready to merge! Uwe Am 26.09.2022 um 11:42 schrieb Adrien Grand: Ignacio made me notice than the new Lucene94FieldInfosFormat

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Adrien Grand
Ignacio made me notice than the new Lucene94FieldInfosFormat did not change the codec name compared to Lucene90FieldInfosFormat: https://github.com/apache/lucene/blob/branch_9_4/lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94FieldInfosFormat.java#L376 . The issue with this is that