[jira] [Updated] (LUCENE-7736) Expose some IndexReader stats via DoubleValuesSources

2017-11-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7736: -- Attachment: LUCENE-7736.patch Updated to master; all reader-specific functions here now return

[jira] [Updated] (LUCENE-6278) Remove Scorer.freq()

2017-11-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6278: -- Attachment: LUCENE-6278.patch Boolean coord() is long gone now, so Scorer.freq() is now used

[jira] [Updated] (LUCENE-6278) Remove Scorer.freq()

2017-11-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6278: -- Summary: Remove Scorer.freq() (was: Rationalise Scorer.freq()) > Remove Scorer.freq() >

[jira] [Resolved] (LUCENE-8042) Add SegmentCachable interface

2017-11-10 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8042. --- Resolution: Fixed Assignee: Alan Woodward Fix Version/s: 7.2 Thanks for the

[jira] [Resolved] (LUCENE-8014) Remove SimScorer.computeSlopFactor and SimScorer.computePayloadFactor

2017-11-10 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8014. --- Resolution: Fixed > Remove SimScorer.computeSlopFactor and SimScorer.computePayloadFactor >

[jira] [Updated] (LUCENE-8014) Remove SimScorer.computeSlopFactor and SimScorer.computePayloadFactor

2017-11-10 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8014: -- Attachment: LUCENE-8014-tfidfsim.patch For the record, attaching a patch with the removal of

[jira] [Reopened] (LUCENE-8014) Remove SimScorer.computeSlopFactor and SimScorer.computePayloadFactor

2017-11-10 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward reopened LUCENE-8014: --- Re-opening to deprecate and remove TFIDFSimilarity.scorePayload() as well > Remove

[jira] [Commented] (LUCENE-8042) Add SegmentCachable interface

2017-11-10 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247328#comment-16247328 ] Alan Woodward commented on LUCENE-8042: --- [~rcmuir] are you happy with the last patch? > Add

[jira] [Commented] (LUCENE-8014) Remove SimScorer.computeSlopFactor and SimScorer.computePayloadFactor

2017-11-10 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247228#comment-16247228 ] Alan Woodward commented on LUCENE-8014: --- Ran tests on the wrong branch so I missed a few places

[jira] [Commented] (LUCENE-8014) Remove SimScorer.computeSlopFactor and SimScorer.computePayloadFactor

2017-11-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246834#comment-16246834 ] Alan Woodward commented on LUCENE-8014: --- Thanks [~steve_rowe], will look asap. > Remove

[jira] [Resolved] (SOLR-11610) Use PayloadDecoder instead of PayloadScoringSimilarityWrapper

2017-11-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved SOLR-11610. -- Resolution: Fixed Fix Version/s: 7.2 > Use PayloadDecoder instead of

[jira] [Assigned] (LUCENE-8014) Remove SimScorer.computeSlopFactor and SimScorer.computePayloadFactor

2017-11-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward reassigned LUCENE-8014: - Assignee: Alan Woodward > Remove SimScorer.computeSlopFactor and

[jira] [Resolved] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8038. --- Resolution: Fixed Fix Version/s: 7.2 > Decouple payload decoding from Similarity >

[jira] [Resolved] (LUCENE-8014) Remove SimScorer.computeSlopFactor and SimScorer.computePayloadFactor

2017-11-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8014. --- Resolution: Fixed Fix Version/s: 7.2 master (8.0) > Remove

[jira] [Resolved] (LUCENE-8045) ParallelReader does not propagate doc values generation numbers

2017-11-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8045. --- Resolution: Fixed Fix Version/s: 7.2 > ParallelReader does not propagate doc values

[jira] [Updated] (LUCENE-8045) ParallelReader does not propagate doc values generation numbers

2017-11-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8045: -- Attachment: LUCENE-8045.patch Turns out that it wasn't difficult to make

[jira] [Updated] (LUCENE-8045) ParallelReader does not propagate doc values generation numbers

2017-11-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8045: -- Summary: ParallelReader does not propagate doc values generation numbers (was:

[jira] [Commented] (LUCENE-8045) FieldInfos.Builder.add(FieldInfo) does not copy across dvGen

2017-11-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245488#comment-16245488 ] Alan Woodward commented on LUCENE-8045: --- Thinking about this more, ParallelReader is really set up

[jira] [Commented] (LUCENE-8045) FieldInfos.Builder.add(FieldInfo) does not copy across dvGen

2017-11-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245455#comment-16245455 ] Alan Woodward commented on LUCENE-8045: --- Looking further, I think the FieldInfos.Builder behaviour

[jira] [Created] (LUCENE-8045) FieldInfos.Builder.add(FieldInfo) does not copy across dvGen

2017-11-09 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8045: - Summary: FieldInfos.Builder.add(FieldInfo) does not copy across dvGen Key: LUCENE-8045 URL: https://issues.apache.org/jira/browse/LUCENE-8045 Project: Lucene -

[jira] [Updated] (LUCENE-8042) Add SegmentCachable interface

2017-11-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8042: -- Attachment: LUCENE-8042.patch bq. Also i would still like to see if we can make this simply a

[jira] [Updated] (LUCENE-8042) Add SegmentCachable interface

2017-11-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8042: -- Attachment: LUCENE-8042.patch Here's an updated patch with better testing for handling

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243566#comment-16243566 ] Alan Woodward commented on LUCENE-8038: --- PayloadScoreQuery just multiplies the score returned by

[jira] [Commented] (LUCENE-8042) Add SegmentCachable interface

2017-11-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243557#comment-16243557 ] Alan Woodward commented on LUCENE-8042: --- For reference, the method quoted above would now look like

[jira] [Updated] (LUCENE-8042) Add SegmentCachable interface

2017-11-07 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8042: -- Attachment: LUCENE-8042.patch This patch should simplify things a bit for implementers.

[jira] [Updated] (LUCENE-8014) Remove SimScorer.computeSlopFactor and SimScorer.computePayloadFactor

2017-11-07 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8014: -- Attachment: LUCENE-8014.patch Here's a patch for master, to be applied after LUCENE-8038 and

[jira] [Created] (LUCENE-8042) Add SegmentCachable interface

2017-11-07 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8042: - Summary: Add SegmentCachable interface Key: LUCENE-8042 URL: https://issues.apache.org/jira/browse/LUCENE-8042 Project: Lucene - Core Issue Type: New

[jira] [Updated] (LUCENE-8042) Add SegmentCachable interface

2017-11-07 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8042: -- Attachment: LUCENE-8042.patch Here is a patch adding the interface, and amending

[jira] [Comment Edited] (LUCENE-8014) Remove SimScorer.computeSlopFactor and SimScorer.computePayloadFactor

2017-11-06 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240425#comment-16240425 ] Alan Woodward edited comment on LUCENE-8014 at 11/6/17 3:15 PM: Should we

[jira] [Commented] (LUCENE-8014) Remove SimScorer.computeSlopFactor and SimScorer.computePayloadFactor

2017-11-06 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240425#comment-16240425 ] Alan Woodward commented on LUCENE-8014: --- Should we do the hardcoding of computeSlopFactor directly

[jira] [Updated] (SOLR-11610) Use PayloadDecoder instead of PayloadScoringSimilarityWrapper

2017-11-06 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-11610: - Attachment: SOLR-11610.patch Here's a patch cutting things over to using PayloadScoreQuery's

[jira] [Created] (SOLR-11610) Use PayloadDecoder instead of PayloadScoringSimilarityWrapper

2017-11-06 Thread Alan Woodward (JIRA)
Alan Woodward created SOLR-11610: Summary: Use PayloadDecoder instead of PayloadScoringSimilarityWrapper Key: SOLR-11610 URL: https://issues.apache.org/jira/browse/SOLR-11610 Project: Solr

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-06 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240276#comment-16240276 ] Alan Woodward commented on LUCENE-8038: --- I think the extra flexibility could be limited to just

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-06 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240182#comment-16240182 ] Alan Woodward commented on LUCENE-8038: --- bq. It might be useful to let PayloadDecoder return null

[jira] [Updated] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-06 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8038: -- Attachment: LUCENE-8038-master.patch And here's a patch for master, removing the deprecated

[jira] [Updated] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-06 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8038: -- Attachment: LUCENE-8038.patch Here is a patch for master/7x. If no PayloadDecoder is passed

[jira] [Created] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-06 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8038: - Summary: Decouple payload decoding from Similarity Key: LUCENE-8038 URL: https://issues.apache.org/jira/browse/LUCENE-8038 Project: Lucene - Core Issue

[jira] [Resolved] (LUCENE-8017) FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache

2017-11-03 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8017. --- Resolution: Fixed Fix Version/s: 7.2 Thanks all > FunctionRangeQuery and

[jira] [Commented] (LUCENE-8017) FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache

2017-11-03 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237438#comment-16237438 ] Alan Woodward commented on LUCENE-8017: --- OIC, ok will change. > FunctionRangeQuery and

[jira] [Commented] (LUCENE-8017) FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache

2017-11-03 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237413#comment-16237413 ] Alan Woodward commented on LUCENE-8017: --- I thought about doing that, but the callers are split more

[jira] [Updated] (LUCENE-8017) FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache

2017-11-03 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8017: -- Attachment: LUCENE-8017.patch We now return only getCoreCacheHelper() or null, with

[jira] [Commented] (LUCENE-8017) FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache

2017-11-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236244#comment-16236244 ] Alan Woodward commented on LUCENE-8017: --- bq. getReaderHelper does not mean caching on the top-level

[jira] [Updated] (LUCENE-8017) FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache

2017-11-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8017: -- Attachment: LUCENE-8017.patch Updated patch, checking dvGen for DV queries and returning null

[jira] [Commented] (LUCENE-8017) FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache

2017-11-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234159#comment-16234159 ] Alan Woodward commented on LUCENE-8017: --- bq. Instead couldn't we alternatively just check

[jira] [Updated] (LUCENE-8017) FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache

2017-11-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8017: -- Attachment: LUCENE-8017.patch Here's a patch adding getCacheHelper() as a method on Weight.

[jira] [Commented] (LUCENE-8017) FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache

2017-10-26 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220574#comment-16220574 ] Alan Woodward commented on LUCENE-8017: --- Nice, CacheHelper looks to be exactly what we need here.

[jira] [Commented] (LUCENE-8017) FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache

2017-10-26 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220259#comment-16220259 ] Alan Woodward commented on LUCENE-8017: --- The easiest solution is to just exclude the Function

[jira] [Created] (LUCENE-8017) FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache

2017-10-26 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8017: - Summary: FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache Key: LUCENE-8017 URL: https://issues.apache.org/jira/browse/LUCENE-8017 Project:

[jira] [Commented] (LUCENE-8012) Improve Explanation class

2017-10-25 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218331#comment-16218331 ] Alan Woodward commented on LUCENE-8012: --- +1 to take Number. I tried converting things to use

[jira] [Commented] (LUCENE-7736) Expose some IndexReader stats via DoubleValuesSources

2017-10-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211325#comment-16211325 ] Alan Woodward commented on LUCENE-7736: --- In fact, should all of these just always return false from

[jira] [Commented] (LUCENE-7736) Expose some IndexReader stats via DoubleValuesSources

2017-10-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211308#comment-16211308 ] Alan Woodward commented on LUCENE-7736: --- bq. I think it's important for equals to behave correctly

[jira] [Updated] (LUCENE-7998) Add a DoubleValuesSource that exposes a Query score

2017-10-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7998: -- Attachment: LUCENE-7998.patch Patch to be applied on top of LUCENE-7736. With this, we should

[jira] [Created] (LUCENE-7998) Add a DoubleValuesSource that exposes a Query score

2017-10-19 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-7998: - Summary: Add a DoubleValuesSource that exposes a Query score Key: LUCENE-7998 URL: https://issues.apache.org/jira/browse/LUCENE-7998 Project: Lucene - Core

[jira] [Updated] (LUCENE-7736) Expose some IndexReader stats via DoubleValuesSources

2017-10-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7736: -- Attachment: LUCENE-7736.patch Patch including Adrien's suggestions. This also changes

[jira] [Commented] (LUCENE-7736) Expose some IndexReader stats via DoubleValuesSources

2017-10-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210722#comment-16210722 ] Alan Woodward commented on LUCENE-7736: --- bq. two instances that have been built on a different

[jira] [Updated] (LUCENE-7736) Expose some IndexReader stats via DoubleValuesSources

2017-10-18 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7736: -- Attachment: LUCENE-7736.patch Final patch, all tests + precommit pass > Expose some

[jira] [Updated] (LUCENE-7736) Expose some IndexReader stats via DoubleValuesSources

2017-10-18 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7736: -- Attachment: LUCENE-7736.patch Patch bringing this up-to-date. Relevant changes are: *

[jira] [Commented] (SOLR-11392) StreamExpressionTest.testParallelExecutorStream fails too frequently

2017-09-29 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185583#comment-16185583 ] Alan Woodward commented on SOLR-11392: -- It looks like there are two issues here: 1) A previous test

[jira] [Commented] (LUCENE-7931) SpanNotQuery has bug?

2017-09-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162600#comment-16162600 ] Alan Woodward commented on LUCENE-7931: --- "not" is a stopword, and is removed by the

[jira] [Commented] (SOLR-11276) Refactoring SolrZkClient + ConnectionManager + ConnectionStrategy

2017-08-29 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144921#comment-16144921 ] Alan Woodward commented on SOLR-11276: -- I tried something like this as part of SOLR-9056 - didn't get

[jira] [Updated] (LUCENE-6513) Allow limits on SpanMultiTermQueryWrapper expansion

2017-07-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6513: -- Attachment: LUCENE-6513.patch Waking this one up again, here's a different attempt at limiting

[jira] [Commented] (LUCENE-7895) Add hooks to QueryBuilder to allow for the construction of MultiTermQueries in phrases

2017-07-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074583#comment-16074583 ] Alan Woodward commented on LUCENE-7895: --- I opened LUCENE-6513 a while back to try and stop the

[jira] [Commented] (SOLR-11008) TestMetricsHandler.testPropertyFilter failure

2017-07-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074445#comment-16074445 ] Alan Woodward commented on SOLR-11008: -- >From the log, it looks as though what's happening is the

[jira] [Created] (SOLR-11008) TestMetricsHandler.testPropertyFilter failure

2017-07-05 Thread Alan Woodward (JIRA)
Alan Woodward created SOLR-11008: Summary: TestMetricsHandler.testPropertyFilter failure Key: SOLR-11008 URL: https://issues.apache.org/jira/browse/SOLR-11008 Project: Solr Issue Type: Bug

[jira] [Commented] (LUCENE-7895) Add hooks to QueryBuilder to allow for the construction of MultiTermQueries in phrases

2017-07-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074433#comment-16074433 ] Alan Woodward commented on LUCENE-7895: --- I'd contest that it's giving first-class support. None of

[jira] [Commented] (LUCENE-7895) Add hooks to QueryBuilder to allow for the construction of MultiTermQueries in phrases

2017-07-04 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073519#comment-16073519 ] Alan Woodward commented on LUCENE-7895: --- Do we have a better way of running such queries though?

[jira] [Updated] (LUCENE-7895) Add hooks to QueryBuilder to allow for the construction of MultiTermQueries in phrases

2017-07-04 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7895: -- Attachment: LUCENE-7895.patch Patch, adding two new protected methods to QueryBuilder: *

[jira] [Created] (LUCENE-7895) Add hooks to QueryBuilder to allow for the construction of MultiTermQueries in phrases

2017-07-04 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-7895: - Summary: Add hooks to QueryBuilder to allow for the construction of MultiTermQueries in phrases Key: LUCENE-7895 URL: https://issues.apache.org/jira/browse/LUCENE-7895

[jira] [Commented] (LUCENE-7890) MemoryIndex should allow doc values iterator to be reset to the current docid

2017-06-28 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066993#comment-16066993 ] Alan Woodward commented on LUCENE-7890: --- +1 > MemoryIndex should allow doc values iterator to be

[jira] [Updated] (LUCENE-7889) Allow grouping on DoubleValuesSource ranges

2017-06-28 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7889: -- Attachment: LUCENE-7889.patch Here's a patch. Still needs some javadocs. The tests for this

[jira] [Created] (LUCENE-7889) Allow grouping on DoubleValuesSource ranges

2017-06-28 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-7889: - Summary: Allow grouping on DoubleValuesSource ranges Key: LUCENE-7889 URL: https://issues.apache.org/jira/browse/LUCENE-7889 Project: Lucene - Core Issue

[jira] [Resolved] (LUCENE-7723) LongValuesSource/DoubleValuesSource impls should implement equals/hashCode

2017-06-27 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-7723. --- Resolution: Fixed Assignee: Alan Woodward Fix Version/s: master (7.0) >

[jira] [Resolved] (LUCENE-7737) Remove spatial-extras dependency on queries

2017-06-27 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-7737. --- Resolution: Fixed Thanks for the reviews! > Remove spatial-extras dependency on queries >

[jira] [Commented] (SOLR-10272) Use a default configset and make the configName parameter optional.

2017-06-27 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064508#comment-16064508 ] Alan Woodward commented on SOLR-10272: -- Hey Ishan, I think this has broken precommit? ZkController

[jira] [Updated] (LUCENE-7737) Remove spatial-extras dependency on queries

2017-06-24 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7737: -- Attachment: LUCENE-7737.patch bq. Your move of code to fromDoubleValuesSource didn't compile

[jira] [Updated] (LUCENE-7737) Remove spatial-extras dependency on queries

2017-06-23 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7737: -- Attachment: LUCENE-7737.patch Thanks for the review David! Here's an updated patch. bq. I

[jira] [Created] (SOLR-10940) Rework spellcheck API to use Tokenstream instead of deprecated Token

2017-06-23 Thread Alan Woodward (JIRA)
Alan Woodward created SOLR-10940: Summary: Rework spellcheck API to use Tokenstream instead of deprecated Token Key: SOLR-10940 URL: https://issues.apache.org/jira/browse/SOLR-10940 Project: Solr

[jira] [Resolved] (LUCENE-7867) Remove deprecated Token class

2017-06-23 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-7867. --- Resolution: Fixed Fix Version/s: master (7.0) Thanks all. I'll open a separate issue

[jira] [Commented] (SOLR-9183) Test ImplicitSnitchTest.testGetTags_with_wrong_ipv4_format_ip_returns_nothing is failing

2017-06-22 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059419#comment-16059419 ] Alan Woodward commented on SOLR-9183: - This has started failing for me too, Mac OS Sierra, Java

[jira] [Created] (LUCENE-7886) Remove redundant FastCharStream implementations

2017-06-22 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-7886: - Summary: Remove redundant FastCharStream implementations Key: LUCENE-7886 URL: https://issues.apache.org/jira/browse/LUCENE-7886 Project: Lucene - Core

[jira] [Updated] (LUCENE-7867) Remove deprecated Token class

2017-06-22 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7867: -- Attachment: LUCENE-7867.patch Patch, deprecating Token again in Solr and fixing a bunch of

[jira] [Updated] (LUCENE-7867) Remove deprecated Token class

2017-06-22 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7867: -- Attachment: LUCENE-7867.patch Updated patch, taking into account LUCENE-7877. I'll commit

[jira] [Updated] (LUCENE-7737) Remove spatial-extras dependency on queries

2017-06-22 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7737: -- Attachment: LUCENE-7737.patch Here's an updated patch, with explanations included. Will

[jira] [Resolved] (LUCENE-7877) Replace PrefixAwareTokenStream

2017-06-22 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-7877. --- Resolution: Fixed Thanks for the reviews, chaps. > Replace PrefixAwareTokenStream >

[jira] [Commented] (LUCENE-7880) Make boolean query clause limit configurable per-query

2017-06-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055988#comment-16055988 ] Alan Woodward commented on LUCENE-7880: --- bq. we should find a heuristic that can detect when a

[jira] [Commented] (LUCENE-7880) Make boolean query clause limit configurable per-query

2017-06-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055443#comment-16055443 ] Alan Woodward commented on LUCENE-7880: --- I've run into the limit when building classifier queries,

[jira] [Commented] (LUCENE-7723) LongValuesSource/DoubleValuesSource impls should implement equals/hashCode

2017-06-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054290#comment-16054290 ] Alan Woodward commented on LUCENE-7723: --- Any objections to me committing this? >

[jira] [Updated] (LUCENE-7877) Replace PrefixAwareTokenStream

2017-06-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7877: -- Attachment: LUCENE-7877.patch Here's an updated patch folding in comments. > Replace

[jira] [Commented] (LUCENE-7867) Remove deprecated Token class

2017-06-14 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048787#comment-16048787 ] Alan Woodward commented on LUCENE-7867: --- I opened LUCENE-7877 to replace Prefix/Suffix. Redoing

[jira] [Updated] (LUCENE-7877) Replace PrefixAwareTokenStream

2017-06-14 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7877: -- Attachment: LUCENE-7877.patch Patch, implementing a ConcatenatingTokenStream that takes an

[jira] [Created] (LUCENE-7877) Replace PrefixAwareTokenStream

2017-06-14 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-7877: - Summary: Replace PrefixAwareTokenStream Key: LUCENE-7877 URL: https://issues.apache.org/jira/browse/LUCENE-7877 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-7867) Remove deprecated Token class

2017-06-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042710#comment-16042710 ] Alan Woodward commented on LUCENE-7867: --- It's fairly fundamentally broken as an AttributeFactory,

[jira] [Commented] (LUCENE-7867) Remove deprecated Token class

2017-06-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042688#comment-16042688 ] Alan Woodward commented on LUCENE-7867: --- The tricky part for prefix/suffix/concatenation is that

[jira] [Updated] (LUCENE-7867) Remove deprecated Token class

2017-06-07 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7867: -- Attachment: LUCENE-7867.patch Here's a patch. Token is used in three places: * in lots of

[jira] [Created] (LUCENE-7867) Remove deprecated Token class

2017-06-07 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-7867: - Summary: Remove deprecated Token class Key: LUCENE-7867 URL: https://issues.apache.org/jira/browse/LUCENE-7867 Project: Lucene - Core Issue Type:

[jira] [Commented] (SOLR-10829) IndexSchema should enforce that uniqueKey field must not be points based

2017-06-07 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040483#comment-16040483 ] Alan Woodward commented on SOLR-10829: -- Do you think it's worth creating a specific IDField class for

[jira] [Updated] (LUCENE-7723) LongValuesSource/DoubleValuesSource impls should implement equals/hashCode

2017-06-06 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-7723: -- Attachment: LUCENE-7723.patch Here's a patch adding abstract equals(), hashCode() and

[jira] [Commented] (LUCENE-7723) LongValuesSource/DoubleValuesSource impls should implement equals/hashCode

2017-05-28 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027868#comment-16027868 ] Alan Woodward commented on LUCENE-7723: --- Thinking this over, I'm tempted to move the function and

[jira] [Commented] (SOLR-10719) ADDREPLICA fails if the instanceDir is a symlink

2017-05-22 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019693#comment-16019693 ] Alan Woodward commented on SOLR-10719: -- I don't follow what's happening here - are you saying that

[jira] [Commented] (LUCENE-7828) Improve PointValues visitor calls when all docs in a leaf share a value

2017-05-16 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012600#comment-16012600 ] Alan Woodward commented on LUCENE-7828: --- Yes, this looks like it only affects range fields, so the

<    4   5   6   7   8   9   10   11   12   13   >