[jira] [Commented] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866797#comment-16866797 ] Atri Sharma commented on LUCENE-8769: - I think we would still need a way to process NOT ranges (for

[jira] [Updated] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8857: Attachment: LUCENE-8857.patch > Refactor TopDocs#Merge To Take In Custom Tie Breakers >

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866608#comment-16866608 ] Atri Sharma commented on LUCENE-8857: - [~simonw] The reason I did not add a default comparator for

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866564#comment-16866564 ] Atri Sharma commented on LUCENE-8857: - I havent added a line in MIGRATE.txt highlighting that

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866467#comment-16866467 ] Atri Sharma commented on LUCENE-8862: - Right, agreed.   Another thought was if we should add the

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866452#comment-16866452 ] Atri Sharma commented on LUCENE-8862: - {quote}doing it in setNextReader might perform the check long

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866438#comment-16866438 ] Atri Sharma commented on LUCENE-8862: - Ah, hmm, so your thought is that the memory tracker itself

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866431#comment-16866431 ] Atri Sharma commented on LUCENE-8862: - Another option could be to introduce an interface which

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866423#comment-16866423 ] Atri Sharma commented on LUCENE-8862: - [~jpountz] What are your thoughts on the options of

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866349#comment-16866349 ] Atri Sharma commented on LUCENE-8862: - We should probably add a visitLeafCollector(LeafCollector) in

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866328#comment-16866328 ] Atri Sharma commented on LUCENE-8857: - Attached is an updated patch. Does that look inline?  

[jira] [Updated] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8857: Attachment: LUCENE-8857.patch > Refactor TopDocs#Merge To Take In Custom Tie Breakers >

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-17 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865883#comment-16865883 ] Atri Sharma commented on LUCENE-8862: - The reason I was thinking of a visitor api is since it gives

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-17 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865873#comment-16865873 ] Atri Sharma commented on LUCENE-8862: - Visitor could have an API to take in a memory tracking object

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-17 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865809#comment-16865809 ] Atri Sharma commented on LUCENE-8862: - Thinking more about this, I am more inclined to do the

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-17 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865610#comment-16865610 ] Atri Sharma commented on LUCENE-8862: - {quote}Memory accounting has a cost API-wise {quote} Agreed,

[jira] [Commented] (LUCENE-8855) Add Accountable to Query implementations

2019-06-15 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864783#comment-16864783 ] Atri Sharma commented on LUCENE-8855: - {quote}Or alternatively compute a rough estimate of the

[jira] [Created] (LUCENE-8864) Add Query Memory Estimation Ability in QueryVisitor

2019-06-15 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8864: --- Summary: Add Query Memory Estimation Ability in QueryVisitor Key: LUCENE-8864 URL: https://issues.apache.org/jira/browse/LUCENE-8864 Project: Lucene - Core

[jira] [Created] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-15 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8862: --- Summary: Collector Level Dynamic Memory Accounting Key: LUCENE-8862 URL: https://issues.apache.org/jira/browse/LUCENE-8862 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-14 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864263#comment-16864263 ] Atri Sharma commented on LUCENE-8829: - [~jpountz] [~simonw] I have updated LUCENE-8857 to remove

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-14 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864258#comment-16864258 ] Atri Sharma commented on LUCENE-8857: - Removed setShardIndex and the ability to set shard index in

[jira] [Updated] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-14 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8857: Attachment: LUCENE-8857.patch > Refactor TopDocs#Merge To Take In Custom Tie Breakers >

[jira] [Commented] (LUCENE-8855) Add Accountable to Query implementations

2019-06-14 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864097#comment-16864097 ] Atri Sharma commented on LUCENE-8855: - +1, important change!   I had a few comments/questions:  

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-14 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863946#comment-16863946 ] Atri Sharma commented on LUCENE-8829: - +1, I agree   Do you think we should pursue LUCENE-8857 as

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-14 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863821#comment-16863821 ] Atri Sharma commented on LUCENE-8857: - Attached is a patch implementing this technique. It adds

[jira] [Updated] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-14 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8857: Attachment: LUCENE-8857.patch > Refactor TopDocs#Merge To Take In Custom Tie Breakers >

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-14 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863752#comment-16863752 ] Atri Sharma commented on LUCENE-8811: - Please let me know if the patch looks fine. Happy to iterate

[jira] [Commented] (LUCENE-8791) Add CollectorRescorer

2019-06-14 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863734#comment-16863734 ] Atri Sharma commented on LUCENE-8791: - I will take a look today > Add CollectorRescorer >

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-13 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863075#comment-16863075 ] Atri Sharma commented on LUCENE-8829: - bq. I am not sure we have to. Can't a user initialize it

[jira] [Created] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-13 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8857: --- Summary: Refactor TopDocs#Merge To Take In Custom Tie Breakers Key: LUCENE-8857 URL: https://issues.apache.org/jira/browse/LUCENE-8857 Project: Lucene - Core

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-13 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862914#comment-16862914 ] Atri Sharma commented on LUCENE-8829: - [~simonw] That is a fun idea, although it would still need a

[jira] [Commented] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-13 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862806#comment-16862806 ] Atri Sharma commented on LUCENE-8769: - Attached is an updated patch. I have refactored the patch to

[jira] [Updated] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-13 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8769: Attachment: LUCENE-8769.patch > Range Query Type With Logically Connected Ranges >

[jira] [Updated] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-12 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8811: Attachment: LUCENE-8811.patch > Add maximum clause count check to IndexSearcher rather than

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-12 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862005#comment-16862005 ] Atri Sharma commented on LUCENE-8811: - Thanks [~jpountz], attached is an updated patch

[jira] [Commented] (LUCENE-8839) Add IndexSearcher Level Query Max Clause Count Limits

2019-06-12 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861895#comment-16861895 ] Atri Sharma commented on LUCENE-8839: - [~jpountz] So what we can do is commit 8811 as is,and use

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-12 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861835#comment-16861835 ] Atri Sharma commented on LUCENE-8829: - [~simonw] Essentially, allow users to pass in the tie breaker

[jira] [Commented] (LUCENE-8839) Add IndexSearcher Level Query Max Clause Count Limits

2019-06-12 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861832#comment-16861832 ] Atri Sharma commented on LUCENE-8839: - [~jpountz] I agree that we can open up utility methods for

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-11 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860937#comment-16860937 ] Atri Sharma commented on LUCENE-8811: - [~romseygeek] Please let me know if this looks fine. Thanks

[jira] [Updated] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-11 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8829: Attachment: LUCENE-8829.patch > TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-11 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860923#comment-16860923 ] Atri Sharma commented on LUCENE-8829: - [~jpountz] Attached is an updated patch. I have moved the

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-11 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860713#comment-16860713 ] Atri Sharma commented on LUCENE-8829: - bq. I mean ordering on score or sort fields, then shardIndex,

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-11 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860679#comment-16860679 ] Atri Sharma commented on LUCENE-8829: - bq. I wonder whether we could rely on the fact that ScoreDoc

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-11 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860621#comment-16860621 ] Atri Sharma commented on LUCENE-8829: - [~jpountz] Agreed that the API is a bit weird in the proposed

[jira] [Updated] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-11 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8829: Attachment: LUCENE-8829.patch > TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-06-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860181#comment-16860181 ] Atri Sharma commented on LUCENE-8757: - [~hossman] This is a known issue

[jira] [Commented] (LUCENE-8845) Allow maxExpansions to be set on multi-term Intervals

2019-06-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860030#comment-16860030 ] Atri Sharma commented on LUCENE-8845: - ++, LGTM > Allow maxExpansions to be set on multi-term

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860026#comment-16860026 ] Atri Sharma commented on LUCENE-8362: - Thanks for pushing this, Adrien! > Add DocValue support for

[jira] [Commented] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860025#comment-16860025 ] Atri Sharma commented on LUCENE-8769: - This sets the base for the structures needed for OR and NOT.

[jira] [Commented] (LUCENE-8845) Allow maxExpansions to be set on multi-term Intervals

2019-06-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860006#comment-16860006 ] Atri Sharma commented on LUCENE-8845: - Patch looks good and a useful change! Here are some minor

[jira] [Commented] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859902#comment-16859902 ] Atri Sharma commented on LUCENE-8769: - Attached is an updated patch with more checks and tests.

[jira] [Updated] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8769: Attachment: LUCENE-8769.patch > Range Query Type With Logically Connected Ranges >

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859884#comment-16859884 ] Atri Sharma commented on LUCENE-8362: - Thanks Adrien, attached is an updated patch

[jira] [Updated] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8362: Attachment: LUCENE-8362.patch > Add DocValue support for RangeFields >

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859796#comment-16859796 ] Atri Sharma commented on LUCENE-8362: - Some minor test formatting cleanups [^LUCENE-8362.patch]

[jira] [Updated] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8362: Attachment: LUCENE-8362.patch > Add DocValue support for RangeFields >

[jira] [Commented] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859789#comment-16859789 ] Atri Sharma commented on LUCENE-8769: - Here is a first cut at the said approach. This patch only

[jira] [Updated] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8769: Attachment: LUCENE-8769.patch > Range Query Type With Logically Connected Ranges >

[jira] [Commented] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-09 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859421#comment-16859421 ] Atri Sharma commented on LUCENE-8769: - Here is a proposal for the said feature: A new Binary query

[jira] [Commented] (LUCENE-8791) Add CollectorRescorer

2019-06-08 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859239#comment-16859239 ] Atri Sharma commented on LUCENE-8791: - bq. could we make the single-threaded constructor take a

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-08 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859212#comment-16859212 ] Atri Sharma commented on LUCENE-8829: - [~jpountz] Does it make sense to backport this to earlier

[jira] [Commented] (LUCENE-8841) Explore Relevance Based Performance Benchmarks

2019-06-08 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859205#comment-16859205 ] Atri Sharma commented on LUCENE-8841: - Could we consider resurrecting it then? -- Regards, Atri

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858906#comment-16858906 ] Atri Sharma commented on LUCENE-8362: - [~jpountz] Please let me know if the latest iteration needs

[jira] [Created] (LUCENE-8841) Explore Relevance Based Performance Benchmarks

2019-06-07 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8841: --- Summary: Explore Relevance Based Performance Benchmarks Key: LUCENE-8841 URL: https://issues.apache.org/jira/browse/LUCENE-8841 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-8825) Improve Print Info Of CheckHits

2019-06-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858823#comment-16858823 ] Atri Sharma commented on LUCENE-8825: - [~jpountz] Thanks a lot! > Improve Print Info Of CheckHits >

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858721#comment-16858721 ] Atri Sharma commented on LUCENE-8811: - [~romseygeek] Please let me know if the current iteration

[jira] [Commented] (LUCENE-8839) Add IndexSearcher Level Query Max Clause Count Limits

2019-06-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858720#comment-16858720 ] Atri Sharma commented on LUCENE-8839: - [~jpountz] LUCENE-8811 focuses speifically on adding checks

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858661#comment-16858661 ] Atri Sharma commented on LUCENE-8811: - [~thetaphi] Arent consumeTerms and visitLeaf mutually

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858654#comment-16858654 ] Atri Sharma commented on LUCENE-8811: - [~romseygeek] Thanks, attached is an updated patch.  

[jira] [Updated] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8811: Attachment: LUCENE-8811.patch > Add maximum clause count check to IndexSearcher rather than

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858623#comment-16858623 ] Atri Sharma commented on LUCENE-8811: - [~romseygeek] Ok, I misinterpreted your previous comment to

[jira] [Commented] (LUCENE-8840) TopTermsBlendedFreqScoringRewrite should use SynonymQuery

2019-06-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858580#comment-16858580 ] Atri Sharma commented on LUCENE-8840: - I am curious to understand how including doc frequencies can

[jira] [Commented] (LUCENE-8839) Add IndexSearcher Level Query Max Clause Count Limits

2019-06-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858494#comment-16858494 ] Atri Sharma commented on LUCENE-8839: - [~romseygeek] [~jpountz] FYI please. Will post a patch post

[jira] [Updated] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8811: Attachment: LUCENE-8811.patch > Add maximum clause count check to IndexSearcher rather than

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858459#comment-16858459 ] Atri Sharma commented on LUCENE-8811: - [~romseygeek] Attached is a patch which does just that and

[jira] [Created] (LUCENE-8839) Add IndexSearcher Level Query Max Clause Count Limits

2019-06-07 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8839: --- Summary: Add IndexSearcher Level Query Max Clause Count Limits Key: LUCENE-8839 URL: https://issues.apache.org/jira/browse/LUCENE-8839 Project: Lucene - Core

[jira] [Updated] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-06 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8811: Attachment: LUCENE-8811.patch > Add maximum clause count check to IndexSearcher rather than

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-06 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858272#comment-16858272 ] Atri Sharma commented on LUCENE-8811: - The last patch had an unintentional type: attached is a fixed

[jira] [Updated] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-06 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8811: Attachment: LUCENE-8811.patch > Add maximum clause count check to IndexSearcher rather than

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-06 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857957#comment-16857957 ] Atri Sharma commented on LUCENE-8811: - [~jpountz] [~romseygeek] Attached patch implements a

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-06 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857501#comment-16857501 ] Atri Sharma commented on LUCENE-8829: - Attached is an updated patch with additional tests. I was

[jira] [Updated] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-06 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8829: Attachment: LUCENE-8829.patch > TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

[jira] [Updated] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-06 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8362: Attachment: LUCENE-8362.patch > Add DocValue support for RangeFields >

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-06 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857406#comment-16857406 ] Atri Sharma commented on LUCENE-8362: - [~jpountz] Sure, does attached look fine?  

[jira] [Commented] (LUCENE-8825) Improve Print Info Of CheckHits

2019-06-06 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857368#comment-16857368 ] Atri Sharma commented on LUCENE-8825: - [~jpountz] Thanks!   Any change we could push this change?

[jira] [Updated] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-06 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8362: Attachment: LUCENE-8362.patch > Add DocValue support for RangeFields >

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-06 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857363#comment-16857363 ] Atri Sharma commented on LUCENE-8362: - [~jpountz] Thanks, attached is an updated patch.  

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-05 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856693#comment-16856693 ] Atri Sharma commented on LUCENE-8362: - Thanks Adrien! > Add DocValue support for RangeFields >

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-05 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856668#comment-16856668 ] Atri Sharma commented on LUCENE-8362: - Does this patch look like in a commitable shape now? Anything

[jira] [Commented] (LUCENE-8825) Improve Print Info Of CheckHits

2019-06-05 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856657#comment-16856657 ] Atri Sharma commented on LUCENE-8825: - Does this look useful? I think this is a simple change that

[jira] [Commented] (LUCENE-8819) org.apache.lucene.search.TestTopDocsMerge.testSort_1 failure

2019-06-05 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856480#comment-16856480 ] Atri Sharma commented on LUCENE-8819: - [~jpountz] I have added a patch to LUCENE-8829 to essentially

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-05 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856478#comment-16856478 ] Atri Sharma commented on LUCENE-8829: - Attached is a patch implementing a fix for this. Note that

[jira] [Updated] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-05 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8829: Attachment: LUCENE-8829.patch > TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

[jira] [Commented] (LUCENE-8819) org.apache.lucene.search.TestTopDocsMerge.testSort_1 failure

2019-06-04 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856004#comment-16856004 ] Atri Sharma commented on LUCENE-8819: - [~jpountz] Yes, the problem is that there is no

[jira] [Created] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-04 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8829: --- Summary: TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved Key: LUCENE-8829 URL: https://issues.apache.org/jira/browse/LUCENE-8829 Project: Lucene -

[jira] [Commented] (LUCENE-8819) org.apache.lucene.search.TestTopDocsMerge.testSort_1 failure

2019-06-04 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855904#comment-16855904 ] Atri Sharma commented on LUCENE-8819: - [~ivera] Yes, you should not be getting different results.

[jira] [Commented] (LUCENE-8825) Improve Print Info Of CheckHits

2019-06-04 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855685#comment-16855685 ] Atri Sharma commented on LUCENE-8825: - [~ivera] This is a follow up from 8824, JFYI. > Improve

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-04 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855680#comment-16855680 ] Atri Sharma commented on LUCENE-8362: - I have opened up a follow up Jira for the follow up: 

[jira] [Created] (LUCENE-8826) Support CROSSES, WITHIN and CONTAINS Range Query For Range DocValues Fields

2019-06-04 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8826: --- Summary: Support CROSSES, WITHIN and CONTAINS Range Query For Range DocValues Fields Key: LUCENE-8826 URL: https://issues.apache.org/jira/browse/LUCENE-8826 Project:

[jira] [Commented] (LUCENE-8825) Improve Print Info Of CheckHits

2019-06-04 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855586#comment-16855586 ] Atri Sharma commented on LUCENE-8825: - Attached is a patch for the same.   [^LUCENE-8825.patch] >

<    1   2   3   4   >