[GitHub] [lucene-solr] sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them

sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them URL: https://github.com/apache/lucene-solr/pull/825#discussion_r312872053 ## File path:

[GitHub] [lucene-solr] sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them

sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them URL: https://github.com/apache/lucene-solr/pull/825#discussion_r312818632 ## File path:

[GitHub] [lucene-solr] sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them

sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them URL: https://github.com/apache/lucene-solr/pull/825#discussion_r312820738 ## File path:

[GitHub] [lucene-solr] sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them

sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them URL: https://github.com/apache/lucene-solr/pull/825#discussion_r312872979 ## File path:

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #755: SOLR-13592: Introduce EmbeddedSolrTestBase for better integration tests

thomaswoeckinger commented on issue #755: SOLR-13592: Introduce EmbeddedSolrTestBase for better integration tests URL: https://github.com/apache/lucene-solr/pull/755#issuecomment-520341697 > My apologies Thomas, my gmail filters weren't letting through github notifications and I didn't

[GitHub] [lucene-solr] sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them

sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them URL: https://github.com/apache/lucene-solr/pull/825#discussion_r312811000 ## File path:

[GitHub] [lucene-solr] sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them

sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them URL: https://github.com/apache/lucene-solr/pull/825#discussion_r312813568 ## File path:

[GitHub] [lucene-solr] sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them

sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them URL: https://github.com/apache/lucene-solr/pull/825#discussion_r312812678 ## File path:

[GitHub] [lucene-solr] sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them

sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them URL: https://github.com/apache/lucene-solr/pull/825#discussion_r312814903 ## File path:

[GitHub] [lucene-solr] sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them

sigram commented on a change in pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them URL: https://github.com/apache/lucene-solr/pull/825#discussion_r312811895 ## File path:

[GitHub] [lucene-solr] gerlowskija commented on issue #755: SOLR-13592: Introduce EmbeddedSolrTestBase for better integration tests

gerlowskija commented on issue #755: SOLR-13592: Introduce EmbeddedSolrTestBase for better integration tests URL: https://github.com/apache/lucene-solr/pull/755#issuecomment-520232283 My apologies Thomas, my gmail filters weren't letting through github notifications and I didn't see this

[GitHub] [lucene-solr] mocobeta closed pull request #761: SOLR-13593: Allow to use analyzer SPI names in schema definition.

mocobeta closed pull request #761: SOLR-13593: Allow to use analyzer SPI names in schema definition. URL: https://github.com/apache/lucene-solr/pull/761 This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] mocobeta commented on issue #761: SOLR-13593: Allow to use analyzer SPI names in schema definition.

mocobeta commented on issue #761: SOLR-13593: Allow to use analyzer SPI names in schema definition. URL: https://github.com/apache/lucene-solr/pull/761#issuecomment-520207375 This has been merged into ASF repo's master:

[GitHub] [lucene-solr] asfgit closed pull request #822: SOLR-13680 Auto closed resources after use which implements Closeable or AutoCloseable interface.

asfgit closed pull request #822: SOLR-13680 Auto closed resources after use which implements Closeable or AutoCloseable interface. URL: https://github.com/apache/lucene-solr/pull/822 This is an automated message from the

[GitHub] [lucene-solr] noblepaul merged pull request #827: SOLR-13682: command line option to export data to a file

noblepaul merged pull request #827: SOLR-13682: command line option to export data to a file URL: https://github.com/apache/lucene-solr/pull/827 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] noblepaul opened a new pull request #827: SOLR-13682: command line option to export data to a file

noblepaul opened a new pull request #827: SOLR-13682: command line option to export data to a file URL: https://github.com/apache/lucene-solr/pull/827 # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to

[GitHub] [lucene-solr] MarcusSorealheis edited a comment on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin. [WIP]

MarcusSorealheis edited a comment on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin. [WIP] URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-519736169 @janhoy I've appended Work In Progress to this PR's title because I'm facing a

[GitHub] [lucene-solr] MarcusSorealheis edited a comment on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin. [WIP]

MarcusSorealheis edited a comment on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin. [WIP] URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-519736169 @janhoy I've appended Work In Progress to this PR's title because I'm facing a

[GitHub] [lucene-solr] megancarey opened a new pull request #826: SOLR-13399: add splitByPrefix configuration to IndexSizeTrigger

megancarey opened a new pull request #826: SOLR-13399: add splitByPrefix configuration to IndexSizeTrigger URL: https://github.com/apache/lucene-solr/pull/826 # Description I've added the `splitByPrefix` parameter to the IndexSizeTrigger, so that the trigger is able to

[GitHub] [lucene-solr] cpoerschke commented on issue #738: SOLR-13532: Fix for non-recovering cores due to low timeouts

cpoerschke commented on issue #738: SOLR-13532: Fix for non-recovering cores due to low timeouts URL: https://github.com/apache/lucene-solr/pull/738#issuecomment-520039117 Hello. https://issues.apache.org/jira/browse/SOLR-13532 is closed now, could this PR be closed too then manually?

[GitHub] [lucene-solr] cpoerschke commented on issue #737: SOLR-13532: Fix for non-recovering cores due to low timeouts

cpoerschke commented on issue #737: SOLR-13532: Fix for non-recovering cores due to low timeouts URL: https://github.com/apache/lucene-solr/pull/737#issuecomment-520038871 Hello. https://issues.apache.org/jira/browse/SOLR-13532 is closed now, could this PR be closed too then manually?

[GitHub] [lucene-solr] cpoerschke commented on issue #736: SOLR-13532: Fix for non-recovering cores due to low timeouts

cpoerschke commented on issue #736: SOLR-13532: Fix for non-recovering cores due to low timeouts URL: https://github.com/apache/lucene-solr/pull/736#issuecomment-520038784 Hello. https://issues.apache.org/jira/browse/SOLR-13532 is closed now, could this PR be closed too then manually?

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences

cpoerschke commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences URL: https://github.com/apache/lucene-solr/pull/677#discussion_r312612736 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on issue #677: SOLR-13257: support for stable replica routing preferences

cpoerschke commented on issue #677: SOLR-13257: support for stable replica routing preferences URL: https://github.com/apache/lucene-solr/pull/677#issuecomment-520028607 Thanks @magibney for updating the pull request and splitting the updates into logical commit units, I found that really

[GitHub] [lucene-solr] Tdspringsteen commented on issue #777: SOLR-11724: Fix for 'Cdcr Bootstrapping does not cause ''index copying'' to follower nodes on Target' BUG

Tdspringsteen commented on issue #777: SOLR-11724: Fix for 'Cdcr Bootstrapping does not cause ''index copying'' to follower nodes on Target' BUG URL: https://github.com/apache/lucene-solr/pull/777#issuecomment-519904227 Thanks for looking into this and getting it fixed Shalin!

[GitHub] [lucene-solr] chenkovsky commented on issue #824: LUCENE-8755: QuadPrefixTree robustness

chenkovsky commented on issue #824: LUCENE-8755: QuadPrefixTree robustness URL: https://github.com/apache/lucene-solr/pull/824#issuecomment-519813035 I reimplemented it. now user can specify the version that the tree's compatible with.

[GitHub] [lucene-solr] shalinmangar closed pull request #777: SOLR-11724: Fix for 'Cdcr Bootstrapping does not cause ''index copying'' to follower nodes on Target' BUG

shalinmangar closed pull request #777: SOLR-11724: Fix for 'Cdcr Bootstrapping does not cause ''index copying'' to follower nodes on Target' BUG URL: https://github.com/apache/lucene-solr/pull/777 This is an automated

[GitHub] [lucene-solr] shalinmangar commented on issue #777: SOLR-11724: Fix for 'Cdcr Bootstrapping does not cause ''index copying'' to follower nodes on Target' BUG

shalinmangar commented on issue #777: SOLR-11724: Fix for 'Cdcr Bootstrapping does not cause ''index copying'' to follower nodes on Target' BUG URL: https://github.com/apache/lucene-solr/pull/777#issuecomment-519759928 This is closed by the commit made in SOLR-13141

[GitHub] [lucene-solr] MarcusSorealheis edited a comment on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin. [WIP]

MarcusSorealheis edited a comment on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin. [WIP] URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-519736169 @janhoy I've appended Work In Progress to this PR's title because I'm facing a

[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin. [WIP]

MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin. [WIP] URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-519736169 @janhoy I've appended Work In Progress to this PR's title because I'm facing a strange

[GitHub] [lucene-solr] dsmiley commented on issue #824: LUCENE-8755: QuadPrefixTree robustness

dsmiley commented on issue #824: LUCENE-8755: QuadPrefixTree robustness URL: https://github.com/apache/lucene-solr/pull/824#issuecomment-519654862 > Does the indexed data contain luncene version info which created the index? If it contains, We can use old code to search in old indexed

[GitHub] [lucene-solr] ErickErickson commented on issue #824: LUCENE-8755: QuadPrefixTree robustness

ErickErickson commented on issue #824: LUCENE-8755: QuadPrefixTree robustness URL: https://github.com/apache/lucene-solr/pull/824#issuecomment-519489983 No, IndexUpgraderTool doesn’t really help. It rewrites the index in the current format, but does not (and cannot) make it look just as

[GitHub] [lucene-solr] asfgit closed pull request #821: SOLR-13674: Add relica type property to NodeAddedTrigger

asfgit closed pull request #821: SOLR-13674: Add relica type property to NodeAddedTrigger URL: https://github.com/apache/lucene-solr/pull/821 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] chenkovsky commented on issue #824: LUCENE-8755: QuadPrefixTree robustness

chenkovsky commented on issue #824: LUCENE-8755: QuadPrefixTree robustness URL: https://github.com/apache/lucene-solr/pull/824#issuecomment-519363352 I find that Lucene has a tool called IndexUpgrader. Maybe updating index is a better solution for backward compatibility?

[GitHub] [lucene-solr] chenkovsky commented on issue #824: LUCENE-8755: QuadPrefixTree robustness

chenkovsky commented on issue #824: LUCENE-8755: QuadPrefixTree robustness URL: https://github.com/apache/lucene-solr/pull/824#issuecomment-519345358 @dsmiley for backward compatibility problem, is there something like "migration" in lucene? When I develop web project, I find that

[GitHub] [lucene-solr] chenkovsky commented on issue #824: LUCENE-8755: QuadPrefixTree robustness

chenkovsky commented on issue #824: LUCENE-8755: QuadPrefixTree robustness URL: https://github.com/apache/lucene-solr/pull/824#issuecomment-519342718 yes, I run spatial-extras tests. This is an automated message from the

[GitHub] [lucene-solr] dsmiley commented on issue #824: LUCENE-8755: QuadPrefixTree robustness

dsmiley commented on issue #824: LUCENE-8755: QuadPrefixTree robustness URL: https://github.com/apache/lucene-solr/pull/824#issuecomment-519303495 Thanks for the PR! Just curious; did you encounter this problem and thus were motivated to fix it? I didn't spend much time on it

[GitHub] [lucene-solr] msokolov commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache

msokolov commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#issuecomment-519137707 It should be enough to report the stats after the last iteration - it is cumulative, so the previous ones just add

[GitHub] [lucene-solr] noblepaul opened a new pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them

noblepaul opened a new pull request #825: SOLR-13677 All Metrics Gauges should be unregistered by the objects that registered them URL: https://github.com/apache/lucene-solr/pull/825 This is an automated message from the

[GitHub] [lucene-solr] noblepaul closed pull request #820: SOLR-13677: All Metrics Gauges should be unregistered by the objects that registered them

noblepaul closed pull request #820: SOLR-13677: All Metrics Gauges should be unregistered by the objects that registered them URL: https://github.com/apache/lucene-solr/pull/820 This is an automated message from the Apache

[GitHub] [lucene-solr] janhoy merged pull request #818: SOLR-13672: Zk Status page now parses response from Zookeeper 3.5.5 correctly

janhoy merged pull request #818: SOLR-13672: Zk Status page now parses response from Zookeeper 3.5.5 correctly URL: https://github.com/apache/lucene-solr/pull/818 This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r311203284 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r311202450 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r311202125 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r311201828 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#issuecomment-518781007 Thanks again @diegoceccarelli for rebasing on top of the current master! With the

[GitHub] [lucene-solr] atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf

atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf URL: https://github.com/apache/lucene-solr/pull/817#issuecomment-518528938 Any thoughts on this? Seems safe enough to merge?

[GitHub] [lucene-solr] atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search

atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-518522813 cc @jpountz This is an automated message

[GitHub] [lucene-solr] atris opened a new pull request #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search

atris opened a new pull request #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search URL: https://github.com/apache/lucene-solr/pull/823 This commit introduces a shared counter based CollectorManager which allows accurate early termination across all its

[GitHub] [lucene-solr] magibney commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences

magibney commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences URL: https://github.com/apache/lucene-solr/pull/677#discussion_r310721190 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences

cpoerschke commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences URL: https://github.com/apache/lucene-solr/pull/677#discussion_r310710025 ## File path:

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #755: SOLR-13592: Introduce EmbeddedSolrTestBase for better integration tests

thomaswoeckinger commented on issue #755: SOLR-13592: Introduce EmbeddedSolrTestBase for better integration tests URL: https://github.com/apache/lucene-solr/pull/755#issuecomment-518311292 @gerlowskija i saw you are working on other issues too, so i hope you have time to get this PR done,

[GitHub] [lucene-solr] atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache

atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#issuecomment-518182664 I ran luceneutil for wikipedia 10M with the concurrent searching and latency calculation patch applied.

[GitHub] [lucene-solr] dsmiley closed pull request #780: SOLR-11866: Support efficient subset matching in query elevation rules

dsmiley closed pull request #780: SOLR-11866: Support efficient subset matching in query elevation rules URL: https://github.com/apache/lucene-solr/pull/780 This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges

atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-518110914 Rebased per master. Could we merge this, if no objections?

[GitHub] [lucene-solr] munendrasn closed pull request #561: SOLR-13215 Upgrade dropwizard metrics to 4.0.5.

munendrasn closed pull request #561: SOLR-13215 Upgrade dropwizard metrics to 4.0.5. URL: https://github.com/apache/lucene-solr/pull/561 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene-solr] munendrasn merged pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping

munendrasn merged pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping URL: https://github.com/apache/lucene-solr/pull/819 This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene-solr] kamaci opened a new pull request #822: SOLR-13680 Auto closed resources after use which implements Closeable or AutoCloseable interface.

kamaci opened a new pull request #822: SOLR-13680 Auto closed resources after use which implements Closeable or AutoCloseable interface. URL: https://github.com/apache/lucene-solr/pull/822 # Description Files, streams or connections which implements Closeable or AutoCloseable

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-13539

thomaswoeckinger commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-518040563 So please, i put a lot of work into this, it would be really great if somebody could help to review and get this into the main line at least!

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping

diegoceccarelli commented on a change in pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping URL: https://github.com/apache/lucene-solr/pull/819#discussion_r310396186 ## File path: solr/core/src/test/org/apache/solr/TestDistributedGrouping.java

[GitHub] [lucene-solr] munendrasn commented on a change in pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping

munendrasn commented on a change in pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping URL: https://github.com/apache/lucene-solr/pull/819#discussion_r310394712 ## File path: solr/core/src/test/org/apache/solr/TestDistributedGrouping.java ##

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping

diegoceccarelli commented on a change in pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping URL: https://github.com/apache/lucene-solr/pull/819#discussion_r310389936 ## File path: solr/core/src/test/org/apache/solr/TestDistributedGrouping.java

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping

diegoceccarelli commented on a change in pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping URL: https://github.com/apache/lucene-solr/pull/819#discussion_r310389946 ## File path: solr/core/src/test/org/apache/solr/TestDistributedGrouping.java

[GitHub] [lucene-solr] diegoceccarelli closed pull request #507: Update jira/gradle to the latest master

diegoceccarelli closed pull request #507: Update jira/gradle to the latest master URL: https://github.com/apache/lucene-solr/pull/507 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene-solr] munendrasn commented on a change in pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping

munendrasn commented on a change in pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping URL: https://github.com/apache/lucene-solr/pull/819#discussion_r310343627 ## File path: solr/core/src/test/org/apache/solr/TestDistributedGrouping.java ##

[GitHub] [lucene-solr] munendrasn commented on a change in pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping

munendrasn commented on a change in pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping URL: https://github.com/apache/lucene-solr/pull/819#discussion_r310343648 ## File path: solr/core/src/test/org/apache/solr/TestDistributedGrouping.java ##

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change the default behavior of the basic authentication plugin.

MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change the default behavior of the basic authentication plugin. URL: https://github.com/apache/lucene-solr/pull/805#discussion_r310342305 ## File path: solr/CHANGES.txt ## @@ -57,6 +57,8 @@ Upgrade

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change the default behavior of the basic authentication plugin.

MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change the default behavior of the basic authentication plugin. URL: https://github.com/apache/lucene-solr/pull/805#discussion_r310342269 ## File path: solr/CHANGES.txt ## @@ -57,6 +57,8 @@ Upgrade

[GitHub] [lucene-solr] ishaigor opened a new pull request #821: SOLR-13674: Add relica type property to NodeAddedTrigger

ishaigor opened a new pull request #821: SOLR-13674: Add relica type property to NodeAddedTrigger URL: https://github.com/apache/lucene-solr/pull/821 # Description The auto-scaling nodes are always added as NRT as there is no way to specify desired replica type in the

[GitHub] [lucene-solr] noblepaul opened a new pull request #820: SOLR-13677: All Metrics Gauges should be unregistered by the objects that registered them

noblepaul opened a new pull request #820: SOLR-13677: All Metrics Gauges should be unregistered by the objects that registered them URL: https://github.com/apache/lucene-solr/pull/820 This is an automated message from the

[GitHub] [lucene-solr] magibney commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences

magibney commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences URL: https://github.com/apache/lucene-solr/pull/677#discussion_r310278050 ## File path:

[GitHub] [lucene-solr] magibney commented on issue #677: SOLR-13257: support for stable replica routing preferences

magibney commented on issue #677: SOLR-13257: support for stable replica routing preferences URL: https://github.com/apache/lucene-solr/pull/677#issuecomment-517823813 Indeed, I'll update the docs under the ShardHandlerFactory section. Thanks!

[GitHub] [lucene-solr] magibney commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences

magibney commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences URL: https://github.com/apache/lucene-solr/pull/677#discussion_r310274283 ## File path:

[GitHub] [lucene-solr] cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#issuecomment-517808063 > I rebased on top of the current master ... Thanks @diegoceccarelli! > ... had to

[GitHub] [lucene-solr] cpoerschke commented on issue #677: SOLR-13257: support for stable replica routing preferences

cpoerschke commented on issue #677: SOLR-13257: support for stable replica routing preferences URL: https://github.com/apache/lucene-solr/pull/677#issuecomment-517804537 > ... Also, we should probably add some documentation on how to configure the replicaRouting in solr.xml Might

[GitHub] [lucene-solr] brjeter commented on issue #508: Simplified JAVA_VER_NUM to utilize single expr execution

brjeter commented on issue #508: Simplified JAVA_VER_NUM to utilize single expr execution URL: https://github.com/apache/lucene-solr/pull/508#issuecomment-517801789 Yes I just got stuck on this for awhile in our maven build in CI. It'd be nice to have this fixed.

[GitHub] [lucene-solr] LinkMJB commented on issue #508: Simplified JAVA_VER_NUM to utilize single expr execution

LinkMJB commented on issue #508: Simplified JAVA_VER_NUM to utilize single expr execution URL: https://github.com/apache/lucene-solr/pull/508#issuecomment-517797067 Any chance we can get this reviewed and merged? This PR has been rotting for quite awhile now, and is a small change.

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences

cpoerschke commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences URL: https://github.com/apache/lucene-solr/pull/677#discussion_r310237271 ## File path:

[GitHub] [lucene-solr] diegoceccarelli edited a comment on issue #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping

diegoceccarelli edited a comment on issue #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping URL: https://github.com/apache/lucene-solr/pull/819#issuecomment-517788448 Please note: I ran precommit but it failed, I'm not sure it is my change, I'll look into that tomorrow..

[GitHub] [lucene-solr] diegoceccarelli commented on issue #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping

diegoceccarelli commented on issue #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping URL: https://github.com/apache/lucene-solr/pull/819#issuecomment-517788448 Please note: I ran precommit but it failed, I'm not sure it is my change, I'll look into that tomorrow..

[GitHub] [lucene-solr] diegoceccarelli opened a new pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping

diegoceccarelli opened a new pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping URL: https://github.com/apache/lucene-solr/pull/819 using ignoreException # Description SOLR-13404 added a test that expects Solr to fail if grouping is called with

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences

cpoerschke commented on a change in pull request #677: SOLR-13257: support for stable replica routing preferences URL: https://github.com/apache/lucene-solr/pull/677#discussion_r310231462 ## File path:

[GitHub] [lucene-solr] asfgit closed pull request #814: SOLR-13666: Pull Request Template to sign-post to the Solr Ref Guide source

asfgit closed pull request #814: SOLR-13666: Pull Request Template to sign-post to the Solr Ref Guide source URL: https://github.com/apache/lucene-solr/pull/814 This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] diegoceccarelli commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

diegoceccarelli commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#issuecomment-517760941 @cpoerschke I rebased on top of the current master, please note that: 1. I had to

[GitHub] [lucene-solr] janhoy opened a new pull request #818: SOLR-13672: Zk Status page now parses response from Zookeeper 3.5.5 correctly

janhoy opened a new pull request #818: SOLR-13672: Zk Status page now parses response from Zookeeper 3.5.5 correctly URL: https://github.com/apache/lucene-solr/pull/818 # Description Admin UI/ZK Status page: Zookeeper 3.5 : 4lw.commands.whitellist error Turned out that there is a

[GitHub] [lucene-solr] atris opened a new pull request #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf

atris opened a new pull request #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf URL: https://github.com/apache/lucene-solr/pull/817 This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] janhoy commented on a change in pull request #805: SOLR-13649 change the default behavior of the basic authentication plugin.

janhoy commented on a change in pull request #805: SOLR-13649 change the default behavior of the basic authentication plugin. URL: https://github.com/apache/lucene-solr/pull/805#discussion_r309926547 ## File path: solr/CHANGES.txt ## @@ -57,6 +57,8 @@ Upgrade Notes *

[GitHub] [lucene-solr] janhoy commented on a change in pull request #805: SOLR-13649 change the default behavior of the basic authentication plugin.

janhoy commented on a change in pull request #805: SOLR-13649 change the default behavior of the basic authentication plugin. URL: https://github.com/apache/lucene-solr/pull/805#discussion_r309926975 ## File path: solr/solr-ref-guide/src/basic-authentication-plugin.adoc ##

[GitHub] [lucene-solr] dsmiley closed pull request #798: LUCENE-8906: Lucene50PostingsFormat.IntBlockTermState becomes public

dsmiley closed pull request #798: LUCENE-8906: Lucene50PostingsFormat.IntBlockTermState becomes public URL: https://github.com/apache/lucene-solr/pull/798 This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] atris opened a new pull request #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods

atris opened a new pull request #816: LUCENE-8942: Tighten Up LRUQueryCache's Methods URL: https://github.com/apache/lucene-solr/pull/816 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene-solr] atris opened a new pull request #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache

atris opened a new pull request #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815 This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene-solr] alessandrobenedetti commented on issue #812: [SOLR-13663] Span Positional Range Support in XML Query Parser + test

alessandrobenedetti commented on issue #812: [SOLR-13663] Span Positional Range Support in XML Query Parser + test URL: https://github.com/apache/lucene-solr/pull/812#issuecomment-516806472 Thanks @cpoerschke for the suggestion, it has been very helpful. I just edited the doc and

[GitHub] [lucene-solr] cpoerschke opened a new pull request #814: SOLR-13666: Pull Request Template to sign-post to the Solr Ref Guide source

cpoerschke opened a new pull request #814: SOLR-13666: Pull Request Template to sign-post to the Solr Ref Guide source URL: https://github.com/apache/lucene-solr/pull/814 # Description To make the "I have added documentation for the Ref Guide (for Solr changes only)" checklist item

[GitHub] [lucene-solr] cpoerschke commented on issue #812: [SOLR-13663] Span Positional Range Support in XML Query Parser + test

cpoerschke commented on issue #812: [SOLR-13663] Span Positional Range Support in XML Query Parser + test URL: https://github.com/apache/lucene-solr/pull/812#issuecomment-516802097 Hello @alessandrobenedetti > ... For the documentation it will be necessary to edit ... In

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-13539

thomaswoeckinger commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-516759833 Last interaction is now one month ago, so can anyone takeover the review please? This is

[GitHub] [lucene-solr] alessandrobenedetti commented on issue #812: [SOLR-13663] Span Positional Range Support in XML Query Parser + test

alessandrobenedetti commented on issue #812: [SOLR-13663] Span Positional Range Support in XML Query Parser + test URL: https://github.com/apache/lucene-solr/pull/812#issuecomment-516743847 https://lucene.apache.org/solr/guide/8_1/other-parsers.html#xml-query-parser For the

[GitHub] [lucene-solr] noblepaul merged pull request #813: SOLR-13659: Refactor Cache config to lazily load the the class

noblepaul merged pull request #813: SOLR-13659: Refactor Cache config to lazily load the the class URL: https://github.com/apache/lucene-solr/pull/813 This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene-solr] noblepaul opened a new pull request #813: Refactor Cache config to lazily load the the class

noblepaul opened a new pull request #813: Refactor Cache config to lazily load the the class URL: https://github.com/apache/lucene-solr/pull/813 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] danmuzi merged pull request #808: LUCENE-8934: promote nori tools to main jar

danmuzi merged pull request #808: LUCENE-8934: promote nori tools to main jar URL: https://github.com/apache/lucene-solr/pull/808 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene-solr] danmuzi commented on issue #808: LUCENE-8934: promote nori tools to main jar

danmuzi commented on issue #808: LUCENE-8934: promote nori tools to main jar URL: https://github.com/apache/lucene-solr/pull/808#issuecomment-516488439 Thank you for your review! @jimczi I'll merge this PR and close. This

<    2   3   4   5   6   7   8   9   10   11   >