cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#issuecomment-517808063 > I rebased on top of the current master ... Thanks @diegoceccarelli! > ... had to change the returned type of serializeOneSearchGroup from Object[] to Object because ... Yes, that sounds right. The `serializeOneSearchGroup` factoring out in master was scoped on the master code at the time only i.e. it did not anticipate what would be needed subsequently e.g. with the `SkipSecondStepSearchResultResultTransformer` here.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
