cpoerschke commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#issuecomment-518781007 Thanks again @diegoceccarelli for rebasing on top of the current master! With the serialise/deserialiseOneGroup methods in place the `SearchGroupsResultTransformer` in particular is really nice to read and understand now, even and especially after some time away from the code. My https://github.com/cpoerschke/lucene-solr/commit/20129e7d3f7e12f442254e780e7da9a590a9036b commit has a couple of tweaks and suggestions, lumped together as one commit (sorry!) but do feel free to look and selectively pick as you like. I'll also go and annotate on the PR here the suggested tweaks that are _not_ related to code comprehension or style consistency. And then next (not today) I'm planning to look at the tests; the `.adoc` documentation changes are also on the known to-do list.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
