[jira] [Commented] (SOLR-13452) Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle.

2019-05-14 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839666#comment-16839666 ] Mark Miller commented on SOLR-13452: Awesome, thanks for the help! Keep in mind, I'm a groovy and

[jira] [Commented] (SOLR-13452) Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle.

2019-05-12 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838156#comment-16838156 ] Mark Miller commented on SOLR-13452: Thanks [~Tomoko Uchida], will do. In the above I have a good

[jira] [Commented] (SOLR-13268) Clean up any test failures resulting from defaulting to async logging

2019-05-10 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837677#comment-16837677 ] Mark Miller commented on SOLR-13268: I've seen them. I don't believe the shutdown is enough and yo

[jira] [Commented] (SOLR-13452) Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle.

2019-05-10 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837460#comment-16837460 ] Mark Miller commented on SOLR-13452: I've pushed the branch I was working on last weekend:

[jira] [Commented] (SOLR-13452) Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle.

2019-05-07 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835260#comment-16835260 ] Mark Miller commented on SOLR-13452: [~caomanhdat], thanks for starting this! Picking things out of

[jira] [Commented] (SOLR-13452) Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle.

2019-05-07 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835228#comment-16835228 ] Mark Miller commented on SOLR-13452: Fair warning, I don't know groovy and I'm pretty new to Gradle

[jira] [Updated] (SOLR-13452) Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle.

2019-05-07 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-13452: --- Description: I took some things from the great work that Dat did in

[jira] [Created] (SOLR-13452) Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle.

2019-05-07 Thread Mark Miller (JIRA)
Mark Miller created SOLR-13452: -- Summary: Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle. Key: SOLR-13452 URL: https://issues.apache.org/jira/browse/SOLR-13452 Project: Solr

[jira] [Resolved] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-15 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller resolved SOLR-13386. Resolution: Fixed Fix Version/s: (was: 7.7.2) master (9.0) > Remove

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-15 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818195#comment-16818195 ] Mark Miller commented on SOLR-13386: bq. I imagine this is basically impossible to write a unit test

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-15 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818178#comment-16818178 ] Mark Miller commented on SOLR-13386: Here is patch that handles NoNodeException and also prevents the

[jira] [Updated] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-15 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-13386: --- Attachment: SOLR-13386.patch > Remove race in OverseerTaskQueue#remove that can result in the

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-15 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818172#comment-16818172 ] Mark Miller commented on SOLR-13386: bq. I'll take a look. I'm hesitant to change these as part of

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-15 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818095#comment-16818095 ] Mark Miller commented on SOLR-13386: bq. Maybe we can just skip the "exists" call? Yeah, good

[jira] [Comment Edited] (SOLR-13389) rectify discrepencies in socket (and connect) timeout values used throughout the code and tests - probably helping to reduce TimeoutExceptions in tests

2019-04-10 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814722#comment-16814722 ] Mark Miller edited comment on SOLR-13389 at 4/10/19 5:57 PM: - Because no test

[jira] [Commented] (SOLR-13389) rectify discrepencies in socket (and connect) timeout values used throughout the code and tests - probably helping to reduce TimeoutExceptions in tests

2019-04-10 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814722#comment-16814722 ] Mark Miller commented on SOLR-13389: Because no test should have a call that takes 10 minutes like it

[jira] [Updated] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-13386: --- Description: If the data call hits NoNodeException, it will throw and the Overseer work queue

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814018#comment-16814018 ] Mark Miller commented on SOLR-13386: We just need to catch the NoNodeException setData can throw and

[jira] [Updated] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-13386: --- Description: If the getData call hits NoNodeException, it will throw and the Overseer work queue

[jira] [Created] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-09 Thread Mark Miller (JIRA)
Mark Miller created SOLR-13386: -- Summary: Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike. Key: SOLR-13386 URL:

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

2019-04-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807970#comment-16807970 ] Mark Miller commented on SOLR-12833: Yes, we should fight to minimize this cost and add documentation

[jira] [Commented] (SOLR-13300) Reproducing seed in master for DistributedFacetExistsSmallTest

2019-03-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788798#comment-16788798 ] Mark Miller commented on SOLR-13300: Attached a patch that allows for null as a key again and also

[jira] [Commented] (SOLR-13300) Reproducing seed in master for DistributedFacetExistsSmallTest

2019-03-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788800#comment-16788800 ] Mark Miller commented on SOLR-13300: I think this class is a good idea because it's difficult to

[jira] [Updated] (SOLR-13300) Reproducing seed in master for DistributedFacetExistsSmallTest

2019-03-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-13300: --- Attachment: SOLR-13300.patch > Reproducing seed in master for DistributedFacetExistsSmallTest >

[jira] [Commented] (SOLR-13310) facet.threads is using the updateExecutor

2019-03-08 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788442#comment-16788442 ] Mark Miller commented on SOLR-13310: I guess I'm still now sure how you would handle the lifecycle of

[jira] [Commented] (SOLR-13300) Reproducing seed in master for DistributedFacetExistsSmallTest

2019-03-08 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788433#comment-16788433 ] Mark Miller commented on SOLR-13300: Or maybe not ... you still can't iterate on that without risk of

[jira] [Commented] (SOLR-13310) facet.threads is using the updateExecutor

2019-03-08 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788437#comment-16788437 ] Mark Miller commented on SOLR-13310: Yeah, we could share a thread pool and executor from the core

[jira] [Commented] (SOLR-13300) Reproducing seed in master for DistributedFacetExistsSmallTest

2019-03-08 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788412#comment-16788412 ] Mark Miller commented on SOLR-13300: This isn't some kind of performance thing, perhaps we can just

[jira] [Commented] (SOLR-13310) facet.threads is using the updateExecutor

2019-03-08 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788407#comment-16788407 ] Mark Miller commented on SOLR-13310: bq. but there is really no reason why there needs to be a "long

[jira] [Comment Edited] (SOLR-13310) facet.threads is using the updateExecutor

2019-03-08 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788404#comment-16788404 ] Mark Miller edited comment on SOLR-13310 at 3/9/19 12:25 AM: - bq. Maybe, but

[jira] [Commented] (SOLR-13310) facet.threads is using the updateExecutor

2019-03-08 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788404#comment-16788404 ] Mark Miller commented on SOLR-13310: bq. Maybe, but there is really no reason why there needs to be a

[jira] [Comment Edited] (SOLR-13300) Reproducing seed in master for DistributedFacetExistsSmallTest

2019-03-08 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788401#comment-16788401 ] Mark Miller edited comment on SOLR-13300 at 3/9/19 12:15 AM: - bq. i'm not

[jira] [Commented] (SOLR-13300) Reproducing seed in master for DistributedFacetExistsSmallTest

2019-03-08 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788401#comment-16788401 ] Mark Miller commented on SOLR-13300: bq. i'm not sure why exactly that was a neccessary change given

[jira] [Commented] (SOLR-13300) Reproducing seed in master for DistributedFacetExistsSmallTest

2019-03-08 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788399#comment-16788399 ] Mark Miller commented on SOLR-13300: {noformat} HashMap to a ConcurrentHashMap (which doesn't support

[jira] [Commented] (SOLR-13310) facet.threads is using the updateExecutor

2019-03-08 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788391#comment-16788391 ] Mark Miller commented on SOLR-13310: I got rid of the ugly exceptions that allowed static executors

[jira] [Commented] (SOLR-12992) Avoid creating Strings from BytesRef in ExportWriter

2019-02-18 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771281#comment-16771281 ] Mark Miller commented on SOLR-12992: We can't release Solr 7.7 with this breaking change. SOLR-13249

[jira] [Reopened] (SOLR-12885) BinaryResponseWriter (javabin format) should directly copy from Bytesref to output

2019-02-18 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller reopened SOLR-12885: > BinaryResponseWriter (javabin format) should directly copy from Bytesref to > output >

[jira] [Commented] (SOLR-13249) ByteArrayUtf8CharSequence.getStringOrNull returns null

2019-02-18 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771283#comment-16771283 ] Mark Miller commented on SOLR-13249: I reopened SOLR-12992. I would recommend we revert that for Solr

[jira] [Updated] (SOLR-12992) Avoid creating Strings from BytesRef in ExportWriter

2019-02-18 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12992: --- Priority: Blocker (was: Major) > Avoid creating Strings from BytesRef in ExportWriter >

[jira] [Comment Edited] (SOLR-13249) ByteArrayUtf8CharSequence.getStringOrNull returns null

2019-02-18 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771279#comment-16771279 ] Mark Miller edited comment on SOLR-13249 at 2/18/19 6:19 PM: - {quote} I have

[jira] [Commented] (SOLR-13249) ByteArrayUtf8CharSequence.getStringOrNull returns null

2019-02-18 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771279#comment-16771279 ] Mark Miller commented on SOLR-13249: {format} I have an URP that, in processAdd(), gets a field

[jira] [Commented] (SOLR-13249) ByteArrayUtf8CharSequence.getStringOrNull returns null

2019-02-18 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771277#comment-16771277 ] Mark Miller commented on SOLR-13249: Should we revert this change? Seems like it needs more time to

[jira] [Commented] (SOLR-13231) CREATE collection request doesn't fail or cleanup when the request fails

2019-02-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765256#comment-16765256 ] Mark Miller commented on SOLR-13231: {quote}bq. So it is an incompatible change as it is right now

[jira] [Resolved] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

2019-02-07 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller resolved SOLR-12833. Resolution: Fixed Fix Version/s: 7.7 > Use timed-out lock in DistributedUpdateProcessor >

[jira] [Commented] (SOLR-13189) Need reliable example (Test) of how to use TestInjection.failReplicaRequests

2019-02-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759155#comment-16759155 ] Mark Miller commented on SOLR-13189: To try and be extra clear. My patch is intended to prove to you

[jira] [Commented] (SOLR-13189) Need reliable example (Test) of how to use TestInjection.failReplicaRequests

2019-02-01 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758826#comment-16758826 ] Mark Miller commented on SOLR-13189: {quote}i guess i was just hoping for a less complicated {quote}

[jira] [Commented] (SOLR-13189) Need reliable example (Test) of how to use TestInjection.failReplicaRequests

2019-02-01 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758625#comment-16758625 ] Mark Miller commented on SOLR-13189: {quote} * was bad in real life because if replica was having

[jira] [Commented] (SOLR-9515) Update to Hadoop 3

2019-01-31 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757960#comment-16757960 ] Mark Miller commented on SOLR-9515: --- You should file a Hadoop Jira and see what they say. I was using a

[jira] [Commented] (SOLR-13189) Need reliable example (Test) of how to use TestInjection.failReplicaRequests

2019-01-31 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757955#comment-16757955 ] Mark Miller commented on SOLR-13189: Whoops, waiting for consistency isn't enough, you also have to

[jira] [Updated] (SOLR-13189) Need reliable example (Test) of how to use TestInjection.failReplicaRequests

2019-01-31 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-13189: --- Attachment: SOLR-13189.patch > Need reliable example (Test) of how to use

[jira] [Commented] (SOLR-13189) Need reliable example (Test) of how to use TestInjection.failReplicaRequests

2019-01-31 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757947#comment-16757947 ] Mark Miller commented on SOLR-13189: Here is a hack to that test. If we want to handle any valid

[jira] [Updated] (SOLR-13189) Need reliable example (Test) of how to use TestInjection.failReplicaRequests

2019-01-31 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-13189: --- Attachment: SOLR-13189.patch > Need reliable example (Test) of how to use

[jira] [Commented] (SOLR-13189) Need reliable example (Test) of how to use TestInjection.failReplicaRequests

2019-01-31 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757921#comment-16757921 ] Mark Miller commented on SOLR-13189: Basically another example in a long line of someone introducing

[jira] [Commented] (SOLR-13189) Need reliable example (Test) of how to use TestInjection.failReplicaRequests

2019-01-31 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757918#comment-16757918 ] Mark Miller commented on SOLR-13189: And it was just starting to feel good being away again ... As

[jira] [Created] (SOLR-13186) When a node wins the Overseer election there is a race that can cause an invalid Overseer leader node to be registered.

2019-01-29 Thread Mark Miller (JIRA)
Mark Miller created SOLR-13186: -- Summary: When a node wins the Overseer election there is a race that can cause an invalid Overseer leader node to be registered. Key: SOLR-13186 URL:

[jira] [Commented] (LUCENE-8662) Override seekExact(BytesRef) in FilterLeafReader.FilterTermsEnum

2019-01-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754885#comment-16754885 ] Mark Miller commented on LUCENE-8662: - I’ve discussed this issue a little and I’m not sure we know

[jira] [Commented] (LUCENE-8662) Override seekExact(BytesRef) in FilterLeafReader.FilterTermsEnum

2019-01-28 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754458#comment-16754458 ] Mark Miller commented on LUCENE-8662: - [~jpountz] any thoughts on this one? > Override

[jira] [Comment Edited] (SOLR-13021) You cannot safely create and delete the same collection.

2019-01-20 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747546#comment-16747546 ] Mark Miller edited comment on SOLR-13021 at 1/20/19 8:48 PM: - It happens

[jira] [Commented] (SOLR-13021) You cannot safely create and delete the same collection.

2019-01-20 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747546#comment-16747546 ] Mark Miller commented on SOLR-13021: It happens beasting tests that try and clean up their env for

[jira] [Commented] (SOLR-13100) harden/manage connectionpool used for intra-cluster communication when we know nodes go down

2019-01-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732635#comment-16732635 ] Mark Miller commented on SOLR-13100: You might be able to - I mention that more of the impl is

[jira] [Commented] (SOLR-13100) harden/manage connectionpool used for intra-cluster communication when we know nodes go down

2019-01-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732378#comment-16732378 ] Mark Miller commented on SOLR-13100: I can spend a little more time here, but a quick reply.   HTTP

[jira] [Created] (SOLR-13075) Harden SaslZkACLProviderTest.

2018-12-16 Thread Mark Miller (JIRA)
Mark Miller created SOLR-13075: -- Summary: Harden SaslZkACLProviderTest. Key: SOLR-13075 URL: https://issues.apache.org/jira/browse/SOLR-13075 Project: Solr Issue Type: Sub-task Security

[jira] [Commented] (SOLR-13058) Probable synchronization bug in OverseerTaskProcessor

2018-12-13 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720371#comment-16720371 ] Mark Miller commented on SOLR-13058: Good catch and fix! > Probable synchronization bug in

[jira] [Commented] (SOLR-13067) Harden BasicAuthIntegrationTest.

2018-12-12 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719633#comment-16719633 ] Mark Miller commented on SOLR-13067: Yeah, I went for relaxing for now as well. I don't like it, but

[jira] [Commented] (SOLR-13067) Harden BasicAuthIntegrationTest.

2018-12-12 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719436#comment-16719436 ] Mark Miller commented on SOLR-13067: I see lots of other fails in beasting today, including due to a

[jira] [Created] (SOLR-13067) Harden BasicAuthIntegrationTest.

2018-12-12 Thread Mark Miller (JIRA)
Mark Miller created SOLR-13067: -- Summary: Harden BasicAuthIntegrationTest. Key: SOLR-13067 URL: https://issues.apache.org/jira/browse/SOLR-13067 Project: Solr Issue Type: Sub-task

[jira] [Created] (SOLR-13066) A failure while reloading a SolrCore can result in the SolrCore not being closed.

2018-12-12 Thread Mark Miller (JIRA)
Mark Miller created SOLR-13066: -- Summary: A failure while reloading a SolrCore can result in the SolrCore not being closed. Key: SOLR-13066 URL: https://issues.apache.org/jira/browse/SOLR-13066 Project:

[jira] [Commented] (SOLR-13040) Harden TestSQLHandler.

2018-12-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718459#comment-16718459 ] Mark Miller commented on SOLR-13040: That may have been a different fail though. I think we can fix

[jira] [Commented] (SOLR-13040) Harden TestSQLHandler.

2018-12-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718440#comment-16718440 ] Mark Miller commented on SOLR-13040: I've had it fail not beasting, that's why I started looking at

[jira] [Commented] (SOLR-13040) Harden TestSQLHandler.

2018-12-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718259#comment-16718259 ] Mark Miller commented on SOLR-13040: If I remember right it’s something weird about not being able to

[jira] [Commented] (SOLR-13040) Harden TestSQLHandler.

2018-12-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718256#comment-16718256 ] Mark Miller commented on SOLR-13040: It’s flakey - if you beast it the fail will come out. I’ll post

[jira] [Resolved] (SOLR-12933) Fix SolrCloud distributed commit.

2018-12-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller resolved SOLR-12933. Resolution: Fixed Fix Version/s: master (8.0) 7.6 > Fix SolrCloud

[jira] [Resolved] (LUCENE-8546) Fix ant beast to fail and succeed based on whether beasting actually fails or succeeds.

2018-12-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller resolved LUCENE-8546. - Resolution: Fixed Fix Version/s: master (8.0) 7.6 > Fix ant beast to

[jira] [Resolved] (LUCENE-8541) Fix ant beast to not overwrite junit xml results for each beast.iters iteration.

2018-12-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller resolved LUCENE-8541. - Resolution: Fixed Fix Version/s: master (8.0) 7.6 > Fix ant beast to

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714308#comment-16714308 ] Mark Miller commented on SOLR-12801: {quote}The 2 sec wait at the end of the test, while ugly does

[jira] [Commented] (SOLR-13028) Harden AutoAddReplicasPlanActionTest#testSimple

2018-12-07 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713029#comment-16713029 ] Mark Miller commented on SOLR-13028: {quote}Ironically the error it throws if it retries on

[jira] [Commented] (SOLR-13043) clean up suspicious ExecutorService lifecycles in MiniSolrCloudCluster

2018-12-06 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711510#comment-16711510 ] Mark Miller commented on SOLR-13043: Just part of a series of changes as I explored getting tests to

[jira] [Commented] (SOLR-13032) Harden MaxSizeAutoCommitTest.testAdds

2018-12-04 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708976#comment-16708976 ] Mark Miller commented on SOLR-13032: +1, that tests well. > Harden MaxSizeAutoCommitTest.testAdds >

[jira] [Updated] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

2018-12-04 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12833: --- Attachment: SOLR-12833.patch > Use timed-out lock in DistributedUpdateProcessor >

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

2018-12-04 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708910#comment-16708910 ] Mark Miller commented on SOLR-12833: Hey [~yuanyun.cn], how does this approach look to you? It keeps

[jira] [Updated] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

2018-12-04 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12833: --- Attachment: SOLR-12833.patch > Use timed-out lock in DistributedUpdateProcessor >

[jira] [Created] (SOLR-13040) Harden TestSQLHandler.

2018-12-03 Thread Mark Miller (JIRA)
Mark Miller created SOLR-13040: -- Summary: Harden TestSQLHandler. Key: SOLR-13040 URL: https://issues.apache.org/jira/browse/SOLR-13040 Project: Solr Issue Type: Sub-task Security Level:

[jira] [Commented] (SOLR-13037) Harden TestSimGenericDistributedQueue.

2018-12-03 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707546#comment-16707546 ] Mark Miller commented on SOLR-13037: {noformat} [beaster] 2> NOTE: reproduce with: ant test

[jira] [Commented] (SOLR-13032) Harden MaxSizeAutoCommitTest.testAdds

2018-12-03 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707515#comment-16707515 ] Mark Miller commented on SOLR-13032: testDeletes can also fail (very rare it seems)   {noformat}

[jira] [Commented] (SOLR-13027) Harden LeaderTragicEventTest.

2018-12-03 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707507#comment-16707507 ] Mark Miller commented on SOLR-13027: I think the above addressed the fails I was seeing here, but

[jira] [Commented] (SOLR-13036) JettySolrRunner's port retry is broken

2018-12-03 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707345#comment-16707345 ] Mark Miller commented on SOLR-13036: Looks good - I didn't walk it because I saw a raw bind exception

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-12-03 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707322#comment-16707322 ] Mark Miller commented on SOLR-12801: {quote} If this test/technique seems to be a source of

[jira] [Created] (SOLR-13037) Harden TestSimGenericDistributedQueue.

2018-12-03 Thread Mark Miller (JIRA)
Mark Miller created SOLR-13037: -- Summary: Harden TestSimGenericDistributedQueue. Key: SOLR-13037 URL: https://issues.apache.org/jira/browse/SOLR-13037 Project: Solr Issue Type: Sub-task

[jira] [Commented] (SOLR-12932) ant test (without badapples=false) should pass easily for developers.

2018-12-01 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706045#comment-16706045 ] Mark Miller commented on SOLR-12932: Beasting is a separate effort that I will work on by package

[jira] [Created] (SOLR-13033) Harden HttpSolrCallGetCoreTest

2018-12-01 Thread Mark Miller (JIRA)
Mark Miller created SOLR-13033: -- Summary: Harden HttpSolrCallGetCoreTest Key: SOLR-13033 URL: https://issues.apache.org/jira/browse/SOLR-13033 Project: Solr Issue Type: Sub-task Security

[jira] [Created] (SOLR-13032) Harden MaxSizeAutoCommitTest.testAdds

2018-12-01 Thread Mark Miller (JIRA)
Mark Miller created SOLR-13032: -- Summary: Harden MaxSizeAutoCommitTest.testAdds Key: SOLR-13032 URL: https://issues.apache.org/jira/browse/SOLR-13032 Project: Solr Issue Type: Sub-task

[jira] [Created] (SOLR-13031) Harden ChaosMonkeySafeLeaderWithPullReplicasTest

2018-12-01 Thread Mark Miller (JIRA)
Mark Miller created SOLR-13031: -- Summary: Harden ChaosMonkeySafeLeaderWithPullReplicasTest Key: SOLR-13031 URL: https://issues.apache.org/jira/browse/SOLR-13031 Project: Solr Issue Type:

[jira] [Commented] (SOLR-13030) MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?

2018-11-30 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705677#comment-16705677 ] Mark Miller commented on SOLR-13030: [~hossman], I think I addressed most of that and it was related

[jira] [Commented] (SOLR-13030) MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?

2018-11-30 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705574#comment-16705574 ] Mark Miller commented on SOLR-13030: I see some permissions issues with Java 11 I have to deal with.

[jira] [Comment Edited] (SOLR-13030) MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?

2018-11-30 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705503#comment-16705503 ] Mark Miller edited comment on SOLR-13030 at 12/1/18 12:17 AM: -- I'm not sure

[jira] [Commented] (SOLR-13030) MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?

2018-11-30 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705503#comment-16705503 ] Mark Miller commented on SOLR-13030: I'm not sure if it's as simple as that, but for now I'll just

[jira] [Commented] (SOLR-12932) ant test (without badapples=false) should pass easily for developers.

2018-11-30 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705359#comment-16705359 ] Mark Miller commented on SOLR-12932: Or maybe it is JVM version related - I'll look at that angle as

[jira] [Commented] (SOLR-12932) ant test (without badapples=false) should pass easily for developers.

2018-11-30 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705142#comment-16705142 ] Mark Miller commented on SOLR-12932: Yeah, I've seen the leak emails - most likely related to

[jira] [Created] (SOLR-13028) Harden AutoAddReplicasPlanActionTest#testSimple

2018-11-30 Thread Mark Miller (JIRA)
Mark Miller created SOLR-13028: -- Summary: Harden AutoAddReplicasPlanActionTest#testSimple Key: SOLR-13028 URL: https://issues.apache.org/jira/browse/SOLR-13028 Project: Solr Issue Type:

[jira] [Created] (SOLR-13027) Harden LeaderTragicEventTest.

2018-11-30 Thread Mark Miller (JIRA)
Mark Miller created SOLR-13027: -- Summary: Harden LeaderTragicEventTest. Key: SOLR-13027 URL: https://issues.apache.org/jira/browse/SOLR-13027 Project: Solr Issue Type: Sub-task Security

<    1   2   3   4   5   6   7   8   9   10   >