[jira] [Commented] (LUCENE-3997) join module should not depend on grouping module

2012-04-18 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257191#comment-13257191 ] Michael McCandless commented on LUCENE-3997: +1 join module

[jira] [Commented] (LUCENE-3972) Improve AllGroupsCollector implementations

2012-04-12 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252315#comment-13252315 ] Michael McCandless commented on LUCENE-3972: Curious that it's so much faster

[jira] [Commented] (LUCENE-3972) Improve AllGroupsCollector implementations

2012-04-12 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252518#comment-13252518 ] Michael McCandless commented on LUCENE-3972: Actually, we are storing term

[jira] [Commented] (LUCENE-3970) Rename getUnique[Field/Terms]Count() into size()

2012-04-10 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251004#comment-13251004 ] Michael McCandless commented on LUCENE-3970: Thanks Iulius, this looks good

[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to InvertedFieldsConsumer

2012-04-08 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249512#comment-13249512 ] Michael McCandless commented on LUCENE-3109: Thanks Iulius, looks great!

[jira] [Commented] (LUCENE-3963) improve smoketester to work on windows

2012-04-08 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249516#comment-13249516 ] Michael McCandless commented on LUCENE-3963: +1 improve

[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to InvertedFieldsConsumer

2012-04-08 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249520#comment-13249520 ] Michael McCandless commented on LUCENE-3109: bq. We need to change

[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to InvertedFieldsConsumer

2012-04-08 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249546#comment-13249546 ] Michael McCandless commented on LUCENE-3109: OK I'll revert so we can discuss

[jira] [Commented] (LUCENE-3967) nuke AtomicReader.termDocsEnum(termState) and termPositionsEnum(termState)

2012-04-08 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249570#comment-13249570 ] Michael McCandless commented on LUCENE-3967: +1 nuke

[jira] [Commented] (LUCENE-3965) consolidate all api modules in one place and un!@$# packaging for 4.0

2012-04-07 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249284#comment-13249284 ] Michael McCandless commented on LUCENE-3965: +1, to moving/merging modules/*

[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to InvertedFieldsConsumer

2012-04-07 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249390#comment-13249390 ] Michael McCandless commented on LUCENE-3109: Thanks for the fast turnaround

[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to InvertedFieldsConsumer

2012-04-07 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249398#comment-13249398 ] Michael McCandless commented on LUCENE-3109: Hmm, one thing: I noticed the

[jira] [Commented] (SOLR-3331) solr NOTICE.txt is missing information

2012-04-06 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248263#comment-13248263 ] Michael McCandless commented on SOLR-3331: -- I'll fix smoke tester... I already

[jira] [Commented] (SOLR-3316) Distributed Grouping fails in some scenarios.

2012-04-06 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248343#comment-13248343 ] Michael McCandless commented on SOLR-3316: -- Patch looks good! I guess it's OK to

[jira] [Commented] (LUCENE-3109) Rename FieldsConsumer to InvertedFieldsConsumer

2012-04-06 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248604#comment-13248604 ] Michael McCandless commented on LUCENE-3109: Hi Iulius, this patch is great:

[jira] [Commented] (LUCENE-3932) Improve load time of .tii files

2012-04-05 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247239#comment-13247239 ] Michael McCandless commented on LUCENE-3932: OK I committed this to trunk

[jira] [Commented] (LUCENE-3946) improve docs ivy verification output to explain classpath problems and mention --noconfig

2012-04-04 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246465#comment-13246465 ] Michael McCandless commented on LUCENE-3946: Shawn, I'm not certain this is

[jira] [Commented] (LUCENE-3943) Use ivy cachepath and cachefileset instead of ivy retrieve

2012-04-03 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245123#comment-13245123 ] Michael McCandless commented on LUCENE-3943: Would this also mean ivy doesn't

[jira] [Commented] (LUCENE-2026) Refactoring of IndexWriter

2012-04-03 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245125#comment-13245125 ] Michael McCandless commented on LUCENE-2026: Is there anyone who can

[jira] [Commented] (LUCENE-2357) Reduce transient RAM usage while merging by using packed ints array for docID re-mapping

2012-04-03 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245343#comment-13245343 ] Michael McCandless commented on LUCENE-2357: Hi Iulius, The basic idea is to

[jira] [Commented] (LUCENE-3892) Add a useful intblock postings format (eg, FOR, PFOR, PFORDelta, Simple9/16/64, etc.)

2012-04-03 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245374#comment-13245374 ] Michael McCandless commented on LUCENE-3892: The proposal at

[jira] [Commented] (LUCENE-3930) nuke jars from source tree and use ivy

2012-04-03 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245799#comment-13245799 ] Michael McCandless commented on LUCENE-3930: Shawn, I have similar problems

[jira] [Commented] (LUCENE-3946) improve docs ivy verification output to explain classpath problems and mention --noconfig

2012-04-03 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245900#comment-13245900 ] Michael McCandless commented on LUCENE-3946: Patch works -- I see lots of

[jira] [Commented] (LUCENE-3946) improve docs ivy verification output to explain classpath problems and mention --noconfig

2012-04-03 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245902#comment-13245902 ] Michael McCandless commented on LUCENE-3946: I passed --execdebug to ant, and

[jira] [Commented] (SOLR-3296) Explore alternatives to Commons CSV

2012-04-02 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244502#comment-13244502 ] Michael McCandless commented on SOLR-3296: -- bq. wrt commons-csv alternatives, it's

[jira] [Commented] (LUCENE-3939) ClassCastException thrown in the map(String,int,TermVectorOffsetInfo[],int[]) method in org.apache.lucene.index.SortedTermVectorMapper

2012-04-01 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243727#comment-13243727 ] Michael McCandless commented on LUCENE-3939: bq. For example, if the first

[jira] [Commented] (LUCENE-3938) Add query time parent child search

2012-04-01 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243763#comment-13243763 ] Michael McCandless commented on LUCENE-3938: I don't fully grok this yet :)

[jira] [Commented] (LUCENE-3940) When Japanese (Kuromoji) tokenizer removes a punctuation token it should leave a hole

2012-04-01 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243782#comment-13243782 ] Michael McCandless commented on LUCENE-3940: Here's an example where we

[jira] [Commented] (LUCENE-3940) When Japanese (Kuromoji) tokenizer removes a punctuation token it should leave a hole

2012-04-01 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243785#comment-13243785 ] Michael McCandless commented on LUCENE-3940: OK here's one possible fix...

[jira] [Commented] (LUCENE-3932) Improve load time of .tii files

2012-03-31 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243102#comment-13243102 ] Michael McCandless commented on LUCENE-3932: bq. Is the space savings of

[jira] [Commented] (LUCENE-3939) ClassCastException thrown in the map(String,int,TermVectorOffsetInfo[],int[]) method in org.apache.lucene.index.SortedTermVectorMapper

2012-03-31 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243108#comment-13243108 ] Michael McCandless commented on LUCENE-3939: I'm confused on how something's

[jira] [Commented] (LUCENE-3738) Be consistent about negative vInt/vLong

2012-03-31 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243125#comment-13243125 ] Michael McCandless commented on LUCENE-3738: Thanks Uwe, I'll test!

[jira] [Commented] (LUCENE-3738) Be consistent about negative vInt/vLong

2012-03-31 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243138#comment-13243138 ] Michael McCandless commented on LUCENE-3738: Alas, the results are now all

[jira] [Commented] (LUCENE-3738) Be consistent about negative vInt/vLong

2012-03-31 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243293#comment-13243293 ] Michael McCandless commented on LUCENE-3738: Sorry Uwe, that was exactly it:

[jira] [Commented] (LUCENE-3940) When Japanese (Kuromoji) tokenizer removes a punctuation token it should leave a hole

2012-03-31 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243299#comment-13243299 ] Michael McCandless commented on LUCENE-3940: bq. StandardTokenizer doesnt

[jira] [Commented] (LUCENE-3930) nuke jars from source tree and use ivy

2012-03-30 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242520#comment-13242520 ] Michael McCandless commented on LUCENE-3930: bq. In my opinion this is ready

[jira] [Commented] (LUCENE-3932) Improve load time of .tii files

2012-03-30 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242541#comment-13242541 ] Michael McCandless commented on LUCENE-3932: {quote} utf8 - utf 16 is 7% of

[jira] [Commented] (LUCENE-3738) Be consistent about negative vInt/vLong

2012-03-30 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242550#comment-13242550 ] Michael McCandless commented on LUCENE-3738: Removing the asserts apparently

[jira] [Commented] (LUCENE-3935) Optimize Kuromoji inner loop - rewrite ConnectionCosts.get() method

2012-03-29 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241328#comment-13241328 ] Michael McCandless commented on LUCENE-3935: +1 Optimize

[jira] [Commented] (LUCENE-3312) Break out StorableField from IndexableField

2012-03-29 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241354#comment-13241354 ] Michael McCandless commented on LUCENE-3312: Hi Nikola, I think this plus

[jira] [Commented] (LUCENE-3907) Improve the Edge/NGramTokenizer/Filters

2012-03-29 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241357#comment-13241357 ] Michael McCandless commented on LUCENE-3907: Awesome! We just need a

[jira] [Commented] (LUCENE-3936) Rename StringIndexDocValues to DocTermsIndexDocValues

2012-03-29 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241359#comment-13241359 ] Michael McCandless commented on LUCENE-3936: +1 Rename

[jira] [Commented] (LUCENE-2000) Use covariant clone() return types

2012-03-29 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241364#comment-13241364 ] Michael McCandless commented on LUCENE-2000: We now get a bunch of redundant

[jira] [Commented] (LUCENE-3932) Improve load time of .tii files

2012-03-29 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241386#comment-13241386 ] Michael McCandless commented on LUCENE-3932: I agree net/net that change is

[jira] [Commented] (LUCENE-2000) Use covariant clone() return types

2012-03-29 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241417#comment-13241417 ] Michael McCandless commented on LUCENE-2000: Thanks Ryan!

[jira] [Commented] (LUCENE-1591) Enable bzip compression in benchmark

2012-03-29 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241428#comment-13241428 ] Michael McCandless commented on LUCENE-1591: Note that

[jira] [Commented] (LUCENE-3937) Workaround the XERCES-J bug in Benchmark

2012-03-29 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241438#comment-13241438 ] Michael McCandless commented on LUCENE-3937: LUCENE-1591 is when we first

[jira] [Commented] (LUCENE-3937) Workaround the XERCES-J bug in Benchmark

2012-03-29 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241445#comment-13241445 ] Michael McCandless commented on LUCENE-3937: Note: I just run benchmark's

[jira] [Commented] (LUCENE-3937) Workaround the XERCES-J bug in Benchmark

2012-03-29 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241486#comment-13241486 ] Michael McCandless commented on LUCENE-3937: OK with this patch the decode of

[jira] [Commented] (LUCENE-3932) Improve load time of .tii files

2012-03-29 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241497#comment-13241497 ] Michael McCandless commented on LUCENE-3932: Nice. I'd love to know how

[jira] [Commented] (LUCENE-3892) Add a useful intblock postings format (eg, FOR, PFOR, PFORDelta, Simple9/16/64, etc.)

2012-03-28 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240527#comment-13240527 ] Michael McCandless commented on LUCENE-3892: That's great Han, I'll have a

[jira] [Commented] (SOLR-3282) Perform Kuromoji/Japanese stability test before 3.6 freeze

2012-03-27 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239447#comment-13239447 ] Michael McCandless commented on SOLR-3282: -- This sounds like a fabulous test! I

[jira] [Commented] (LUCENE-3738) Be consistent about negative vInt/vLong

2012-03-27 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239667#comment-13239667 ] Michael McCandless commented on LUCENE-3738: +1 to remove those asserts...

[jira] [Commented] (SOLR-3076) Solr should support block joins

2012-03-26 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238239#comment-13238239 ] Michael McCandless commented on SOLR-3076: -- {quote} 2. Do you agree with overall

[jira] [Commented] (LUCENE-3923) fail the build on wrong svn:eol-style

2012-03-26 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238355#comment-13238355 ] Michael McCandless commented on LUCENE-3923: +1 And, ideally, ant test as

[jira] [Commented] (LUCENE-3873) tie MockGraphTokenFilter into all analyzers tests

2012-03-26 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238398#comment-13238398 ] Michael McCandless commented on LUCENE-3873: LUCENE-3848 has the

[jira] [Commented] (LUCENE-3659) Improve Javadocs of RAMDirectory to document its limitations and add improvements to make it more GC friendly on large indexes

2012-03-26 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238402#comment-13238402 ] Michael McCandless commented on LUCENE-3659: This looks great Uwe! I'm a

[jira] [Commented] (LUCENE-3873) tie MockGraphTokenFilter into all analyzers tests

2012-03-26 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238422#comment-13238422 ] Michael McCandless commented on LUCENE-3873: I agree we can use it in

[jira] [Commented] (LUCENE-1410) PFOR implementation

2012-03-25 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237893#comment-13237893 ] Michael McCandless commented on LUCENE-1410: bq. Out of curiousity, is the

[jira] [Commented] (LUCENE-3581) IndexReader#isCurrent() should return true on a NRT reader if no deletes are applied and only deletes are present in IW

2012-03-25 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237926#comment-13237926 ] Michael McCandless commented on LUCENE-3581: This need not block 3.6.0 right?

[jira] [Commented] (LUCENE-3919) more thorough testing of analysis chains

2012-03-25 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237994#comment-13237994 ] Michael McCandless commented on LUCENE-3919: Awesome! more

[jira] [Commented] (LUCENE-3909) Move Kuromoji to analysis.ja and introduce Japanese* naming

2012-03-24 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237494#comment-13237494 ] Michael McCandless commented on LUCENE-3909: +1 Move

[jira] [Commented] (LUCENE-3913) HTMLStripCharFilter produces invalid final offset

2012-03-24 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237545#comment-13237545 ] Michael McCandless commented on LUCENE-3913: I forgot to say: patch is

[jira] [Commented] (LUCENE-3911) improve BaseTokenStreamTestCase random string generation

2012-03-24 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237547#comment-13237547 ] Michael McCandless commented on LUCENE-3911: Looks great!

[jira] [Commented] (LUCENE-3913) HTMLStripCharFilter produces invalid final offset

2012-03-24 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237548#comment-13237548 ] Michael McCandless commented on LUCENE-3913: Good idea! I'll fix that test

[jira] [Commented] (LUCENE-3913) HTMLStripCharFilter produces invalid final offset

2012-03-24 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237652#comment-13237652 ] Michael McCandless commented on LUCENE-3913: Awesome, thanks Steve!

[jira] [Commented] (SOLR-3268) remove write acess to source tree (chmod 555) when running tests in jenkins

2012-03-23 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236500#comment-13236500 ] Michael McCandless commented on SOLR-3268: -- +1 remove write

[jira] [Commented] (LUCENE-3905) BaseTokenStreamTestCase should test analyzers on real-ish content

2012-03-23 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236806#comment-13236806 ] Michael McCandless commented on LUCENE-3905: The ngram filters are

[jira] [Commented] (LUCENE-3905) BaseTokenStreamTestCase should test analyzers on real-ish content

2012-03-23 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236820#comment-13236820 ] Michael McCandless commented on LUCENE-3905: OK I opened LUCENE-3907 for

[jira] [Commented] (LUCENE-3897) KuromojiTokenizer fails with large docs

2012-03-22 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235493#comment-13235493 ] Michael McCandless commented on LUCENE-3897: Thanks Christian!

[jira] [Commented] (LUCENE-3887) 'ant javadocs' should fail if a package is missing a package.html

2012-03-22 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235574#comment-13235574 ] Michael McCandless commented on LUCENE-3887: You can also just run the

[jira] [Commented] (LUCENE-3887) 'ant javadocs' should fail if a package is missing a package.html

2012-03-22 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235635#comment-13235635 ] Michael McCandless commented on LUCENE-3887: OK I committed the basic

[jira] [Commented] (LUCENE-3898) possible SynonymFilter bug: hudson fail

2012-03-21 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234263#comment-13234263 ] Michael McCandless commented on LUCENE-3898: I can't provoke this failure

[jira] [Commented] (LUCENE-3896) CharTokenizer has bugs for large documents.

2012-03-21 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234397#comment-13234397 ] Michael McCandless commented on LUCENE-3896: Thanks Rob!

[jira] [Commented] (LUCENE-3899) Evil up MockDirectoryWrapper.checkIndexOnClose

2012-03-21 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234400#comment-13234400 ] Michael McCandless commented on LUCENE-3899: +1 More evilness!

[jira] [Commented] (LUCENE-3778) Create a grouping convenience class

2012-03-21 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234445#comment-13234445 ] Michael McCandless commented on LUCENE-3778: +1 Create a

[jira] [Commented] (LUCENE-3900) Make BaseTokenStreamTestCase.checkRandomData more debuggable

2012-03-21 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234446#comment-13234446 ] Michael McCandless commented on LUCENE-3900: +1! Make

[jira] [Commented] (LUCENE-3897) KuromojiTokenizer fails with large docs

2012-03-21 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234455#comment-13234455 ] Michael McCandless commented on LUCENE-3897: I think the problem is when we

[jira] [Commented] (LUCENE-2788) Make CharFilter reusable

2012-03-21 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234556#comment-13234556 ] Michael McCandless commented on LUCENE-2788: +1 I really like the approach

[jira] [Commented] (LUCENE-3893) TermsFilter should use AutomatonQuery

2012-03-20 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233522#comment-13233522 ] Michael McCandless commented on LUCENE-3893: LUCENE-3832 should also be done

[jira] [Commented] (LUCENE-3887) 'ant javadocs' should fail if a package is missing a package.html

2012-03-20 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233544#comment-13233544 ] Michael McCandless commented on LUCENE-3887: +1 It shouldn't be the RM who

[jira] [Commented] (LUCENE-3889) Remove/Uncommit SegmentingTokenizerBase

2012-03-20 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233545#comment-13233545 ] Michael McCandless commented on LUCENE-3889: +1

[jira] [Commented] (LUCENE-3894) Make BaseTokenStreamTestCase a bit more evil

2012-03-20 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233886#comment-13233886 ] Michael McCandless commented on LUCENE-3894: I think that new read method

[jira] [Commented] (LUCENE-3894) Make BaseTokenStreamTestCase a bit more evil

2012-03-20 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233945#comment-13233945 ] Michael McCandless commented on LUCENE-3894: Thanks Rob!

[jira] [Commented] (SOLR-3076) Solr should support block joins

2012-03-19 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232938#comment-13232938 ] Michael McCandless commented on SOLR-3076: -- Hi Mikhail, I've committed fixes for

[jira] [Commented] (LUCENE-3738) Be consistent about negative vInt/vLong

2012-03-18 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232272#comment-13232272 ] Michael McCandless commented on LUCENE-3738: bq. In my opinion, we should

[jira] [Commented] (LUCENE-3738) Be consistent about negative vInt/vLong

2012-03-18 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232336#comment-13232336 ] Michael McCandless commented on LUCENE-3738: +1 Looks awesome Uwe!

[jira] [Commented] (LUCENE-3738) Be consistent about negative vInt/vLong

2012-03-17 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231962#comment-13231962 ] Michael McCandless commented on LUCENE-3738: bq. The check is only ommitted

[jira] [Commented] (LUCENE-3870) VarDerefBytesImpl doc values prefix length may fall across two pages

2012-03-16 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231033#comment-13231033 ] Michael McCandless commented on LUCENE-3870: +1, looks good Simon! Just

[jira] [Commented] (LUCENE-3876) TestIndexWriterExceptions fails (reproducible)

2012-03-16 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231035#comment-13231035 ] Michael McCandless commented on LUCENE-3876: Hmm I think we need a separate

[jira] [Commented] (LUCENE-3877) Lucene should not call System.out.println

2012-03-16 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231090#comment-13231090 ] Michael McCandless commented on LUCENE-3877: I think it's fine if tests write

[jira] [Commented] (LUCENE-3876) TestIndexWriterExceptions fails (reproducible)

2012-03-16 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231107#comment-13231107 ] Michael McCandless commented on LUCENE-3876: +1

[jira] [Commented] (LUCENE-3738) Be consistent about negative vInt/vLong

2012-03-16 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231295#comment-13231295 ] Michael McCandless commented on LUCENE-3738: Hmm... I think we should think

[jira] [Commented] (LUCENE-3878) CheckIndex should check deleted documents too

2012-03-16 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231296#comment-13231296 ] Michael McCandless commented on LUCENE-3878: +1 CheckIndex

[jira] [Commented] (LUCENE-3877) Lucene should not call System.out.println

2012-03-16 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231307#comment-13231307 ] Michael McCandless commented on LUCENE-3877: I removed the std prints in

[jira] [Commented] (LUCENE-3738) Be consistent about negative vInt/vLong

2012-03-16 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231309#comment-13231309 ] Michael McCandless commented on LUCENE-3738: {quote} don't see how we can

[jira] [Commented] (LUCENE-3738) Be consistent about negative vInt/vLong

2012-03-16 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231470#comment-13231470 ] Michael McCandless commented on LUCENE-3738: bq. If we disallow, it should be

[jira] [Commented] (LUCENE-3872) Index changes are lost if you call prepareCommit() then close()

2012-03-15 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230307#comment-13230307 ] Michael McCandless commented on LUCENE-3872: Well, we could also easily allow

[jira] [Commented] (LUCENE-3848) basetokenstreamtestcase should fail if tokenstream starts with posinc=0

2012-03-15 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230341#comment-13230341 ] Michael McCandless commented on LUCENE-3848: +1

[jira] [Commented] (LUCENE-3874) bogus positions create a corrumpt index

2012-03-15 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230402#comment-13230402 ] Michael McCandless commented on LUCENE-3874: +1 Crazy we don't catch this

  1   2   3   4   5   >