[ https://issues.apache.org/jira/browse/LUCENE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252518#comment-13252518 ]
Michael McCandless commented on LUCENE-3972: -------------------------------------------- Actually, we are storing term ords here, not docIDs. I think the high number of unique groups explains why the new patch is faster: the time is likely dominated by re-ord'ing for each segment? If you have fewer unique groups (and as the number of docs collected goes up), I think the current impl should be faster...? > Improve AllGroupsCollector implementations > ------------------------------------------ > > Key: LUCENE-3972 > URL: https://issues.apache.org/jira/browse/LUCENE-3972 > Project: Lucene - Java > Issue Type: Improvement > Components: modules/grouping > Reporter: Martijn van Groningen > Attachments: LUCENE-3972.patch, LUCENE-3972.patch > > > I think that the performance of TermAllGroupsCollectorm, > DVAllGroupsCollector.BR and DVAllGroupsCollector.SortedBR can be improved by > using BytesRefHash to store the groups instead of an ArrayList. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org