[jira] [Commented] (SOLR-9014) Deprecate and reduce usage of ClusterState methods which may make calls to ZK via the lazy collection reference

2016-05-04 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270829#comment-15270829 ] Scott Blum commented on SOLR-9014: -- BTW, I'm surprised this was super tricky. There aren't really that

[jira] [Commented] (SOLR-9014) Deprecate and reduce usage of ClusterState methods which may make calls to ZK via the lazy collection reference

2016-05-04 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270817#comment-15270817 ] Scott Blum commented on SOLR-9014: -- I don't know... seems like a dicey game to try to ensure that no

[jira] [Commented] (SOLR-9056) Add ZkConnectionListener interface

2016-05-02 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267392#comment-15267392 ] Scott Blum commented on SOLR-9056: -- Interested, but no bandwidth until we finish the other one. :) > Add

[jira] [Commented] (SOLR-9030) The 'downnode' command can trip asserts in ZkStateWriter or cause BadVersionException in Overseer

2016-04-28 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263124#comment-15263124 ] Scott Blum commented on SOLR-9030: -- Glad you wrote back to clarify, this got me to go do some reading as

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-27 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260519#comment-15260519 ] Scott Blum commented on SOLR-8323: -- Sorry! I'll look at it today. Been swamped with other stuff. :( > Add

[jira] [Commented] (SOLR-9030) The 'downnode' command can trip asserts in ZkStateWriter or cause BadVersionException in Overseer

2016-04-26 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259219#comment-15259219 ] Scott Blum commented on SOLR-9030: -- I did say it was a long shot. :) Still, any reason for me not to do

[jira] [Commented] (SOLR-9014) Deprecate and reduce usage of ClusterState methods which may make calls to ZK via the lazy collection reference

2016-04-26 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258576#comment-15258576 ] Scott Blum commented on SOLR-9014: -- Correct, the edge case is what we're guarding against here. I would

[jira] [Commented] (SOLR-9030) The 'downnode' command can trip asserts in ZkStateWriter or cause BadVersionException in Overseer

2016-04-26 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258571#comment-15258571 ] Scott Blum commented on SOLR-9030: -- Nice digging! Can I just say for the record, I'm not a huge fan of

[jira] [Commented] (SOLR-9030) The 'downnode' command can trip asserts in ZkStateWriter or cause BadVersionException in Overseer

2016-04-26 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258560#comment-15258560 ] Scott Blum commented on SOLR-9030: -- The final keyword conveys special thread-safety semantics in the JMM.

[jira] [Resolved] (SOLR-9029) regular fails since ZkStateReaderTest.testStateFormatUpdateWithExplicitRefreshLazy

2016-04-25 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum resolved SOLR-9029. -- Resolution: Fixed Fix Version/s: 6.1 master > regular fails since >

[jira] [Commented] (SOLR-9029) regular fails since ZkStateReaderTest.testStateFormatUpdateWithExplicitRefreshLazy

2016-04-25 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257379#comment-15257379 ] Scott Blum commented on SOLR-9029: -- Testing a fix now:

[jira] [Commented] (SOLR-9029) regular fails since ZkStateReaderTest.testStateFormatUpdateWithExplicitRefreshLazy

2016-04-25 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257375#comment-15257375 ] Scott Blum commented on SOLR-9029: -- Finally found it... there's an very rare edge case in

[jira] [Commented] (SOLR-9029) regular fails since ZkStateReaderTest.testStateFormatUpdateWithExplicitRefreshLazy

2016-04-25 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257329#comment-15257329 ] Scott Blum commented on SOLR-9029: -- Super puzzling. We've tested that the ZK node exists, and the fact

[jira] [Commented] (SOLR-9030) The 'downnode' command can trip asserts in ZkStateWriter or cause BadVersionException in Overseer

2016-04-25 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257312#comment-15257312 ] Scott Blum commented on SOLR-9030: -- BTW, can you paste in the beast command you're using? I can try it

[jira] [Commented] (SOLR-9030) The 'downnode' command can trip asserts in ZkStateWriter or cause BadVersionException in Overseer

2016-04-25 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257309#comment-15257309 ] Scott Blum commented on SOLR-9030: -- Can you try making DocCollection.znodeVersion be private final int?

[jira] [Commented] (SOLR-9014) Deprecate and reduce usage of ClusterState methods which may make calls to ZK via the lazy collection reference

2016-04-25 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257276#comment-15257276 ] Scott Blum commented on SOLR-9014: -- Yes, unfortunately. ClusterState.collectionStates is driven (in part)

[jira] [Comment Edited] (SOLR-9014) Deprecate and reduce usage of ClusterState methods which may make calls to ZK via the lazy collection reference

2016-04-25 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257276#comment-15257276 ] Scott Blum edited comment on SOLR-9014 at 4/25/16 11:54 PM: Yes, unfortunately.

[jira] [Commented] (LUCENE-7248) Interrupting IndexWriter causing unhandled ClosedChannelException

2016-04-22 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254386#comment-15254386 ] Scott Blum commented on LUCENE-7248: We fixed a bunch of cases where Solr could interrupt an

[jira] [Assigned] (SOLR-9029) regular fails since ZkStateReaderTest.testStateFormatUpdateWithExplicitRefreshLazy

2016-04-21 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum reassigned SOLR-9029: Assignee: Scott Blum > regular fails since >

[jira] [Commented] (SOLR-9029) regular fails since ZkStateReaderTest.testStateFormatUpdateWithExplicitRefreshLazy

2016-04-21 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252998#comment-15252998 ] Scott Blum commented on SOLR-9029: -- Scanned through the code, nothing jumps out at me. I'll dig deeper at

[jira] [Resolved] (SOLR-8694) DistributedMap/Queue simplifications and fixes.

2016-04-20 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum resolved SOLR-8694. -- Resolution: Fixed Fix Version/s: 5.6 5.5.1 > DistributedMap/Queue

[jira] [Commented] (SOLR-8694) DistributedMap/Queue simplifications and fixes.

2016-04-20 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250935#comment-15250935 ] Scott Blum commented on SOLR-8694: -- In progress. > DistributedMap/Queue simplifications and fixes. >

[jira] [Updated] (SOLR-8694) DistributedMap/Queue simplifications and fixes.

2016-04-20 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum updated SOLR-8694: - Fix Version/s: 6.0 > DistributedMap/Queue simplifications and fixes. >

[jira] [Resolved] (SOLR-8973) TX-frenzy on Zookeeper when collection is put to use

2016-04-20 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum resolved SOLR-8973. -- Resolution: Fixed Fix Version/s: 5.6 5.5.1 > TX-frenzy on Zookeeper when

[jira] [Updated] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-04-20 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum updated SOLR-8914: - Fix Version/s: 5.5.1 > ZkStateReader's refreshLiveNodes(Watcher) is not thread safe >

[jira] [Resolved] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-04-20 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum resolved SOLR-8914. -- Resolution: Fixed > ZkStateReader's refreshLiveNodes(Watcher) is not thread safe >

[jira] [Commented] (SOLR-8929) Add an idea module for solr/server to enable launching start.jar

2016-04-20 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250904#comment-15250904 ] Scott Blum commented on SOLR-8929: -- Follow up issue: SOLR-9023 > Add an idea module for solr/server to

[jira] [Created] (SOLR-9023) Improve idea solrcloud launch config

2016-04-20 Thread Scott Blum (JIRA)
Scott Blum created SOLR-9023: Summary: Improve idea solrcloud launch config Key: SOLR-9023 URL: https://issues.apache.org/jira/browse/SOLR-9023 Project: Solr Issue Type: Improvement

[jira] [Commented] (SOLR-9014) Audit all usages of ClusterState methods which may make calls to ZK via the lazy collection reference

2016-04-20 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250898#comment-15250898 ] Scott Blum commented on SOLR-9014: -- Hard to get the right context in mind in all these cases, eh? 1. If

[jira] [Updated] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-04-20 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum updated SOLR-8914: - Fix Version/s: 5.6 6.0.1 > ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

[jira] [Commented] (SOLR-8973) TX-frenzy on Zookeeper when collection is put to use

2016-04-20 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250457#comment-15250457 ] Scott Blum commented on SOLR-8973: -- Yeah it wouldn't surprise me if it applies clean. > TX-frenzy on

[jira] [Resolved] (SOLR-8929) Add an idea module for solr/server to enable launching start.jar

2016-04-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum resolved SOLR-8929. -- Resolution: Fixed > Add an idea module for solr/server to enable launching start.jar >

[jira] [Updated] (SOLR-8929) Add an idea module for solr/server to enable launching start.jar

2016-04-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum updated SOLR-8929: - Fix Version/s: 6.1 master > Add an idea module for solr/server to enable launching

[jira] [Updated] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-04-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum updated SOLR-8914: - Fix Version/s: 6.1 master > ZkStateReader's refreshLiveNodes(Watcher) is not thread

[jira] [Updated] (SOLR-8973) TX-frenzy on Zookeeper when collection is put to use

2016-04-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum updated SOLR-8973: - Fix Version/s: 6.1 master > TX-frenzy on Zookeeper when collection is put to use >

[jira] [Assigned] (SOLR-8694) DistributedMap/Queue simplifications and fixes.

2016-04-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum reassigned SOLR-8694: Assignee: Scott Blum (was: Mark Miller) > DistributedMap/Queue simplifications and fixes. >

[jira] [Commented] (SOLR-8694) DistributedMap/Queue simplifications and fixes.

2016-04-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249050#comment-15249050 ] Scott Blum commented on SOLR-8694: -- I have a compatible patch if you'd like me to take this one as well.

[jira] [Commented] (SOLR-8973) TX-frenzy on Zookeeper when collection is put to use

2016-04-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249048#comment-15249048 ] Scott Blum commented on SOLR-8973: -- [~anshumg] Landing this on master/6x now. Another one to consider for

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-04-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249004#comment-15249004 ] Scott Blum commented on SOLR-8914: -- [~anshumg] I think we should backport this to 5.5.1. Happy to push a

[jira] [Updated] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-04-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum updated SOLR-8914: - Affects Version/s: 6.0 master 5.5

[jira] [Commented] (SOLR-8929) Add an idea module for solr/server to enable launching start.jar

2016-04-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248669#comment-15248669 ] Scott Blum commented on SOLR-8929: -- You're correct, it pulls the binaries from WEB-INF/lib. In this

[jira] [Assigned] (SOLR-8929) Add an idea module for solr/server to enable launching start.jar

2016-04-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum reassigned SOLR-8929: Assignee: Scott Blum > Add an idea module for solr/server to enable launching start.jar >

[jira] [Assigned] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-04-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum reassigned SOLR-8914: Assignee: Scott Blum (was: Mark Miller) > ZkStateReader's refreshLiveNodes(Watcher) is not thread

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-04-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248325#comment-15248325 ] Scott Blum commented on SOLR-8914: -- I think it's definitely work backporting, and I'm happy to do it. I

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-18 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246778#comment-15246778 ] Scott Blum commented on SOLR-8323: -- Don't suppose I could convince you to open a github PR? Would make it

[jira] [Updated] (SOLR-8929) Add an idea module for solr/server to enable launching start.jar

2016-04-18 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum updated SOLR-8929: - Attachment: SOLR-8929.patch Updated patch with a real run configuration. > Add an idea module for

[jira] [Commented] (SOLR-8929) Add an idea module for solr/server to enable launching start.jar

2016-04-15 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243451#comment-15243451 ] Scott Blum commented on SOLR-8929: -- Ok, I have a working config that actually runs a solr in cloud mode w/

[jira] [Commented] (SOLR-8929) Add an idea module for solr/server to enable launching start.jar

2016-04-15 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243396#comment-15243396 ] Scott Blum commented on SOLR-8929: -- Will do! Is there a canonical "launch a local solr" I can copy?

[jira] [Commented] (SOLR-8973) TX-frenzy on Zookeeper when collection is put to use

2016-04-14 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241936#comment-15241936 ] Scott Blum commented on SOLR-8973: -- BTW: this may also fix a "bug" where we could queue more watchers than

[jira] [Comment Edited] (SOLR-8973) TX-frenzy on Zookeeper when collection is put to use

2016-04-14 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241923#comment-15241923 ] Scott Blum edited comment on SOLR-8973 at 4/14/16 9:16 PM: --- [~shalinmangar] I've

[jira] [Updated] (SOLR-8973) TX-frenzy on Zookeeper when collection is put to use

2016-04-14 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum updated SOLR-8973: - Attachment: SOLR-8973-ZkStateReader.patch > TX-frenzy on Zookeeper when collection is put to use >

[jira] [Commented] (SOLR-8973) TX-frenzy on Zookeeper when collection is put to use

2016-04-14 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241923#comment-15241923 ] Scott Blum commented on SOLR-8973: -- [~shalinmangar] I've come to the conclusion that ZkStateReader isn't

[jira] [Commented] (SOLR-8988) Improve facet.method=fcs performance in SolrCloud

2016-04-14 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241799#comment-15241799 ] Scott Blum commented on SOLR-8988: -- +1, we ran across this too, and couldn't think of any reason for the

[jira] [Commented] (SOLR-8973) TX-frenzy on Zookeeper when collection is put to use

2016-04-14 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241697#comment-15241697 ] Scott Blum commented on SOLR-8973: -- I'll need to look at the code again and run it to verify, but I'm 99%

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-04-13 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239957#comment-15239957 ] Scott Blum commented on SOLR-8914: -- Yay! Thanks guys! > ZkStateReader's refreshLiveNodes(Watcher) is not

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-12 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238243#comment-15238243 ] Scott Blum commented on SOLR-8323: -- I did get one failure on a test run: "Did not see a fully active

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-12 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238214#comment-15238214 ] Scott Blum commented on SOLR-8323: -- getStateWatchers() could return null vs. empty set to differentiate

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-12 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238210#comment-15238210 ] Scott Blum commented on SOLR-8323: -- registerCore/ unregisterCore should probably retain the previous doc:

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-12 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238207#comment-15238207 ] Scott Blum commented on SOLR-8323: -- fetchCollectionState() expectExists parameter doesn't make sense to

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-12 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238186#comment-15238186 ] Scott Blum commented on SOLR-8323: -- In getStateWatchers() you probably still want to wrap in a compute

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-12 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238183#comment-15238183 ] Scott Blum commented on SOLR-8323: -- In notifyStateWatchers you can avoid some copies but just re-assigning

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-12 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238180#comment-15238180 ] Scott Blum commented on SOLR-8323: -- {code} if (watchers.size() == 0) return; {code} No need to

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-12 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238178#comment-15238178 ] Scott Blum commented on SOLR-8323: -- {code} LOG.info("Deleting data for [{}]", coll);

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-12 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238170#comment-15238170 ] Scott Blum commented on SOLR-8323: -- unregisterCore needs a better guard against under-referencing, since

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-12 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238166#comment-15238166 ] Scott Blum commented on SOLR-8323: -- nit: make the static type of collectionWatchers be ConcurrentMap?

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-12 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238149#comment-15238149 ] Scott Blum commented on SOLR-8323: -- Could collectionWatches and interestingCollections be unified into a

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-12 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238148#comment-15238148 ] Scott Blum commented on SOLR-8323: -- I like the scheme of reference counting the ZkController core

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-04-12 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238145#comment-15238145 ] Scott Blum commented on SOLR-8323: -- Looking at this now. BTW, a Github PR might actually make this way

[jira] [Commented] (SOLR-8929) Add an idea module for solr/server to enable launching start.jar

2016-04-11 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236566#comment-15236566 ] Scott Blum commented on SOLR-8929: -- Thanks for looking at this. I don't think calling the bin/solr script

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-04-11 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235604#comment-15235604 ] Scott Blum commented on SOLR-8914: -- FWIW these both passed for me. > ZkStateReader's

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-04-11 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235573#comment-15235573 ] Scott Blum commented on SOLR-8914: -- Thanks Erick! I'll give this a shot myself. I'm going to venture to

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-04-01 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222384#comment-15222384 ] Scott Blum commented on SOLR-8914: -- Maybe [~shalinmangar] or [~noble.paul] would be willing to

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-04-01 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222382#comment-15222382 ] Scott Blum commented on SOLR-8914: -- What's the next step here? I really think, despite the minority

[jira] [Updated] (SOLR-8929) Add an idea module for solr/server to enable launching start.jar

2016-03-31 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum updated SOLR-8929: - Attachment: SOLR-8929.patch > Add an idea module for solr/server to enable launching start.jar >

[jira] [Created] (SOLR-8929) Add an idea module for solr/server to enable launching start.jar

2016-03-31 Thread Scott Blum (JIRA)
Scott Blum created SOLR-8929: Summary: Add an idea module for solr/server to enable launching start.jar Key: SOLR-8929 URL: https://issues.apache.org/jira/browse/SOLR-8929 Project: Solr Issue

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-31 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220429#comment-15220429 ] Scott Blum commented on SOLR-8914: -- Erick, if all the errors you're seeing are related to Zookeeper

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-30 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218529#comment-15218529 ] Scott Blum commented on SOLR-8914: -- Correct, the refreshCollectionListLock solves the same class of bug

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-30 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218518#comment-15218518 ] Scott Blum commented on SOLR-8914: -- That was actually my first formulation, but that causes deadlock, see

[jira] [Updated] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-30 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum updated SOLR-8914: - Attachment: SOLR-8914.patch Updated patch, with a refinement of the channel formulation. NOTE: I could

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-30 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217612#comment-15217612 ] Scott Blum commented on SOLR-8914: -- Alternatively I could imagine a more golang channel style formulation

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-30 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217597#comment-15217597 ] Scott Blum commented on SOLR-8914: -- Oh.. I can see by inspection. It's because

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-30 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217585#comment-15217585 ] Scott Blum commented on SOLR-8914: -- Yep, that's what my patch does. I just have to debug the deadlock. >

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-30 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217497#comment-15217497 ] Scott Blum commented on SOLR-8914: -- Should be easy enough to debug the deadlock. I'll take a look

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-30 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217494#comment-15217494 ] Scott Blum commented on SOLR-8914: -- The problem is inherently that if you getChildren() three times and

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-29 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217043#comment-15217043 ] Scott Blum commented on SOLR-8914: -- Yeah, one of the things about ZK is it's impossible to view all

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-29 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217036#comment-15217036 ] Scott Blum commented on SOLR-8914: -- BTW, a million thanks to Hoss for digging into this. We've seen this

[jira] [Updated] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-29 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum updated SOLR-8914: - Attachment: SOLR-8914.patch Here's a pretty simple patch that I believe should fix. I think #3 is

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-29 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217011#comment-15217011 ] Scott Blum commented on SOLR-8914: -- Hoss-- great analysis! I was just looking at this code myself. The

[jira] [Commented] (SOLR-8914) ZkStateReader's refreshLiveNodes(Watcher) is not thread safe

2016-03-29 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216979#comment-15216979 ] Scott Blum commented on SOLR-8914: -- This is super troubling 1290071 port 56361 Updated live nodes

[jira] [Updated] (SOLR-8875) ZkStateWriter.writePendingUpdates() can return null clusterState; NPE in Overseer

2016-03-29 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Blum updated SOLR-8875: - Attachment: SOLR-8875.patch I think this may be a one-liner; in the calling loop, I think there are cases

[jira] [Commented] (SOLR-8875) ZkStateWriter.writePendingUpdates() can return null clusterState; NPE in Overseer

2016-03-29 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216253#comment-15216253 ] Scott Blum commented on SOLR-8875: -- Perfect! Thank you > ZkStateWriter.writePendingUpdates() can return

[jira] [Commented] (SOLR-8875) ZkStateWriter.writePendingUpdates() can return null CollectionState; NPE in Overseer

2016-03-28 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215414#comment-15215414 ] Scott Blum commented on SOLR-8875: -- Can you send me a SHA that captures the state to repro? >

[jira] [Commented] (SOLR-8875) ZkStateWriter.writePendingUpdates() can return null CollectionState; NPE in Overseer

2016-03-28 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215116#comment-15215116 ] Scott Blum commented on SOLR-8875: -- Hi David, Can you give me a little more detail on how to repro? I

[jira] [Commented] (SOLR-8914) inexplicable "no servers hosting shard: shard2" using MiniSolrCloudCluster

2016-03-28 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215090#comment-15215090 ] Scott Blum commented on SOLR-8914: -- I see something weird in there: {code} [junit4] 2> 1301674 INFO

[jira] [Commented] (SOLR-8327) SolrDispatchFilter is not caching new state format, which results in live fetch from ZK per request if node does not contain core from collection

2016-03-22 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207112#comment-15207112 ] Scott Blum commented on SOLR-8327: -- Thanks for the extra context. So it looks like this falls outside the

[jira] [Commented] (SOLR-7090) Cross collection join

2016-03-22 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207079#comment-15207079 ] Scott Blum commented on SOLR-7090: -- Makes sense to me. BTW, the patch posted is not meant to be "This is

[jira] [Commented] (SOLR-8327) SolrDispatchFilter is not caching new state format, which results in live fetch from ZK per request if node does not contain core from collection

2016-03-22 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207072#comment-15207072 ] Scott Blum commented on SOLR-8327: -- What does solrj do? How do you know when the cached data is stale? >

[jira] [Commented] (SOLR-8327) SolrDispatchFilter is not caching new state format, which results in live fetch from ZK per request if node does not contain core from collection

2016-03-22 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207019#comment-15207019 ] Scott Blum commented on SOLR-8327: -- There's a TODO in LazyCollectionRef: // TODO: consider limited

[jira] [Commented] (SOLR-8323) Add CollectionWatcher API to ZkStateReader

2016-03-21 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205105#comment-15205105 ] Scott Blum commented on SOLR-8323: -- I haven't forgotten this one, going to give the new patch a look this

[jira] [Commented] (SOLR-8862) /live_nodes is populated too early to be very useful for clients -- CloudSolrClient (and MiniSolrCloudCluster.createCollection) need some other ephemeral zk node to know

2016-03-19 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200439#comment-15200439 ] Scott Blum commented on SOLR-8862: -- I think I can comment on this just a bit. The first call to

<    1   2   3   4   5   6   >