[
https://issues.apache.org/jira/browse/LUCENE-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5772.
Resolution: Fixed
Fix Version/s: 5.0
4.9
Assignee: Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5772:
---
Fix Version/s: 4.10
SortingAtomicReader should implement getSortedNumericDocValues
Shai Erera created LUCENE-5772:
--
Summary: SortingAtomicReader should implement
getSortedNumericDocValues
Key: LUCENE-5772
URL: https://issues.apache.org/jira/browse/LUCENE-5772
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5772:
---
Attachment: LUCENE-5772.patch
Fixed SortingAtomicReader and added relevant test
[
https://issues.apache.org/jira/browse/LUCENE-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034131#comment-14034131
]
Shai Erera commented on LUCENE-5772:
Thanks Rob. I know you're working on 4.9 release
[
https://issues.apache.org/jira/browse/LUCENE-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5772:
---
Attachment: LUCENE-5772.patch
Fixed silly test bug.
SortingAtomicReader should implement
[
https://issues.apache.org/jira/browse/LUCENE-5102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032260#comment-14032260
]
Shai Erera commented on LUCENE-5102:
I think we should remove it, but deprecate in 4
[
https://issues.apache.org/jira/browse/LUCENE-5762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032264#comment-14032264
]
Shai Erera commented on LUCENE-5762:
+1
Disable old codecs as much as possible
[
https://issues.apache.org/jira/browse/LUCENE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028884#comment-14028884
]
Shai Erera commented on LUCENE-5748:
Reviewed the patch, looks good. Maybe add
[
https://issues.apache.org/jira/browse/LUCENE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029011#comment-14029011
]
Shai Erera commented on LUCENE-5748:
As I said, +1 to commit anyway. I like
[
https://issues.apache.org/jira/browse/LUCENE-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014922#comment-14014922
]
Shai Erera commented on LUCENE-5688:
Ahh, I see now that you only wrote a DVFormat
[
https://issues.apache.org/jira/browse/LUCENE-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14012177#comment-14012177
]
Shai Erera commented on LUCENE-5688:
bq. It does a binary search on the position data
[
https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5680.
Resolution: Fixed
Fix Version/s: 5.0
4.9
Committed to trunk and 4x
[
https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5680:
---
Attachment: LUCENE-5680.patch
Patch ports all tests to use the atomic updates. This removed
[
https://issues.apache.org/jira/browse/LUCENE-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14011098#comment-14011098
]
Shai Erera commented on LUCENE-5711:
Note that this was changed in LUCENE-1763
[
https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14012065#comment-14012065
]
Shai Erera commented on LUCENE-5680:
I think it's ready so if there are no objections
[
https://issues.apache.org/jira/browse/LUCENE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009722#comment-14009722
]
Shai Erera commented on LUCENE-5708:
I think the way you fixed some tests that used
[
https://issues.apache.org/jira/browse/LUCENE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009988#comment-14009988
]
Shai Erera commented on LUCENE-5708:
bq. Hmm which tests rely on using the same IWC
[
https://issues.apache.org/jira/browse/LUCENE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009988#comment-14009988
]
Shai Erera edited comment on LUCENE-5708 at 5/27/14 5:56 PM
[
https://issues.apache.org/jira/browse/LUCENE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5706.
Resolution: Fixed
Fix Version/s: 5.0
4.9
Committed to trunk and 4x
[
https://issues.apache.org/jira/browse/LUCENE-5705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008282#comment-14008282
]
Shai Erera edited comment on LUCENE-5705 at 5/25/14 6:07 AM
Shai Erera created LUCENE-5706:
--
Summary: Don't allow unsetting values through DocValues updates
Key: LUCENE-5706
URL: https://issues.apache.org/jira/browse/LUCENE-5706
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008386#comment-14008386
]
Shai Erera commented on LUCENE-5680:
Opened LUCENE-5706 to disallow unsetting values
[
https://issues.apache.org/jira/browse/LUCENE-5705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008387#comment-14008387
]
Shai Erera commented on LUCENE-5705:
Orthogonal to this issue, but it sounds like
[
https://issues.apache.org/jira/browse/LUCENE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008391#comment-14008391
]
Shai Erera commented on LUCENE-5706:
Why is that impossible? Solr can still update
[
https://issues.apache.org/jira/browse/LUCENE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008394#comment-14008394
]
Shai Erera commented on LUCENE-5706:
I checked the patch on SOLR-5944 and I only see
[
https://issues.apache.org/jira/browse/LUCENE-5705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008396#comment-14008396
]
Shai Erera commented on LUCENE-5705:
It depends what would you like to achieve
[
https://issues.apache.org/jira/browse/LUCENE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5706:
---
Attachment: LUCENE-5706.patch
Patch removes this capability. It simplified a lot of the internal
[
https://issues.apache.org/jira/browse/LUCENE-5705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008282#comment-14008282
]
Shai Erera commented on LUCENE-5705:
+1 to not change the default in CMS, and commit
[
https://issues.apache.org/jira/browse/LUCENE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007040#comment-14007040
]
Shai Erera commented on LUCENE-5683:
It's not ridiculous :). But +1 to commit
[
https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007150#comment-14007150
]
Shai Erera commented on LUCENE-5680:
bq. why do we have both MISSING
[
https://issues.apache.org/jira/browse/LUCENE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005729#comment-14005729
]
Shai Erera commented on LUCENE-5683:
I've thought about it more ... I really don't
[
https://issues.apache.org/jira/browse/LUCENE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5683.
Resolution: Won't Fix
Improve SegmentReader.getXXXDocValues
[
https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005735#comment-14005735
]
Shai Erera commented on LUCENE-5693:
So the question is, if we think the common case
[
https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005754#comment-14005754
]
Shai Erera commented on LUCENE-5693:
I don't see what's wrong w/ not sending
[
https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005795#comment-14005795
]
Shai Erera commented on LUCENE-5693:
Hmm, I reviewed SortedDVWriter and I understand
[
https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005837#comment-14005837
]
Shai Erera commented on LUCENE-5693:
bq. But I'll resolve this as WONTFIX ... looks
[
https://issues.apache.org/jira/browse/LUCENE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006759#comment-14006759
]
Shai Erera commented on LUCENE-5683:
You replaced a hash lookup by an instanceof
[
https://issues.apache.org/jira/browse/LUCENE-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004557#comment-14004557
]
Shai Erera commented on LUCENE-5689:
ReaderAndUpdates already clones all FIs
[
https://issues.apache.org/jira/browse/LUCENE-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004560#comment-14004560
]
Shai Erera commented on LUCENE-5679:
I'm not sure how critical it is Uwe. Yes
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5618.
Resolution: Fixed
Lucene Fields: New,Patch Available (was: New)
Committed to trunk and 4x
[
https://issues.apache.org/jira/browse/LUCENE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5636.
Resolution: Fixed
Fix Version/s: 5.0
4.9
Fixed in LUCENE-5618
[
https://issues.apache.org/jira/browse/LUCENE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004742#comment-14004742
]
Shai Erera commented on LUCENE-5683:
I implemented it, many tests fail in CheckIndex
[
https://issues.apache.org/jira/browse/LUCENE-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004835#comment-14004835
]
Shai Erera commented on LUCENE-5693:
Today we apply the deletes (update the bitset
[
https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002928#comment-14002928
]
Shai Erera commented on LUCENE-5680:
Well, first updateNumeric/BinaryDV() allows you
[
https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002928#comment-14002928
]
Shai Erera edited comment on LUCENE-5680 at 5/20/14 8:32 AM
[
https://issues.apache.org/jira/browse/LUCENE-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5679:
---
Attachment: LUCENE-5679.patch
Patch removes the single-arg delDocs Term/Query variants. Everything
[
https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5680:
---
Attachment: LUCENE-5680.patch
Patch contains the {{Field...}} vs {{DocValuesUpdate...}} variants
[
https://issues.apache.org/jira/browse/LUCENE-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003556#comment-14003556
]
Shai Erera commented on LUCENE-5689:
Looks good. So now FI.setDVGen is used only
[
https://issues.apache.org/jira/browse/LUCENE-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5679.
Resolution: Fixed
Fix Version/s: 5.0
4.9
Assignee: Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001491#comment-14001491
]
Shai Erera commented on LUCENE-5618:
I looked and I can easily pull all
Shai Erera created LUCENE-5683:
--
Summary: Improve SegmentReader.getXXXDocValues
Key: LUCENE-5683
URL: https://issues.apache.org/jira/browse/LUCENE-5683
Project: Lucene - Core
Issue Type
[
https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002744#comment-14002744
]
Shai Erera commented on LUCENE-5680:
I started to implement an {{updateDocValues(Term
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5618:
---
Attachment: LUCENE-5618.patch
Good idea Mike, patch clarifies this code block.
DocValues updates
Opened https://issues.apache.org/jira/browse/LUCENE-5679.
On Sat, May 17, 2014 at 11:38 AM, Michael McCandless
luc...@mikemccandless.com wrote:
+1
Mike McCandless
http://blog.mikemccandless.com
On Fri, May 16, 2014 at 7:03 PM, Chris Hostetter
hossman_luc...@fucit.org wrote:
: I
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001008#comment-14001008
]
Shai Erera commented on LUCENE-5618:
Thanks Rob!
bq. My only concern (which can
[
https://issues.apache.org/jira/browse/LUCENE-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001038#comment-14001038
]
Shai Erera commented on LUCENE-5672:
IIRC, I changed that on LUCENE-2245. The core
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5618:
---
Attachment: LUCENE-5618.patch
I modified SegDocValues API to take FieldInfos
Shai Erera created LUCENE-5680:
--
Summary: Allow updating multiple DocValues fields atomically
Key: LUCENE-5680
URL: https://issues.apache.org/jira/browse/LUCENE-5680
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5680:
---
Attachment: LUCENE-5680.patch
Patch add {{IndexWriter.updateDocValues(DocValuesUpdate...)}} API
[
https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5680:
---
Attachment: LUCENE-5680.patch
I made a slight change to the reduce the API: instead of exposing
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5618:
---
Attachment: LUCENE-5618.patch
Patch folds in latest feedback.
DocValues updates send wrong
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001186#comment-14001186
]
Shai Erera commented on LUCENE-5618:
{quote}
In SegmentReader.initDocValuesProducers
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001291#comment-14001291
]
Shai Erera commented on LUCENE-5618:
bq. Thats not the code. you are omitting
[
https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001296#comment-14001296
]
Shai Erera commented on LUCENE-5680:
bq. I think whats wrong here
[
https://issues.apache.org/jira/browse/LUCENE-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001363#comment-14001363
]
Shai Erera commented on LUCENE-5663:
I don't like the shadowing idea. The open method
Shai Erera created LUCENE-5679:
--
Summary: Consolidate IndexWriter.deleteDocuments()
Key: LUCENE-5679
URL: https://issues.apache.org/jira/browse/LUCENE-5679
Project: Lucene - Core
Issue Type
Hi
I was looking at IW.deleteDocs() API, and was wondering why do we have both
deleteDocuments(Term) and deleteDocuments(Term...). Why can't we have just
the vararg one? Same applies to deleteDocuments(Query).
Both delDocs(Term) and delDocs(Term..) call DocsWriter.deleteTerms(Term...)
and
[
https://issues.apache.org/jira/browse/LUCENE-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993113#comment-13993113
]
Shai Erera commented on LUCENE-5658:
An update, after a short chat with the guy
[
https://issues.apache.org/jira/browse/LUCENE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5619.
Resolution: Fixed
Fix Version/s: 5.0
4.9
Assignee: Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993571#comment-13993571
]
Shai Erera commented on LUCENE-5619:
I am looking into this since it's important
[
https://issues.apache.org/jira/browse/LUCENE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997358#comment-13997358
]
Shai Erera commented on LUCENE-5619:
If there are no objections, I will commit
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5618:
---
Attachment: LUCENE-5618.patch
After committing LUCENE-5619, with the previous patch
[
https://issues.apache.org/jira/browse/LUCENE-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993585#comment-13993585
]
Shai Erera commented on LUCENE-5661:
I hit this confusing magic order myself a couple
[
https://issues.apache.org/jira/browse/LUCENE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5619:
---
Attachment: dvupdates.48.zip
LUCENE-5619.patch
Patch adds a test to TestBackCompat
Shai Erera created LUCENE-5658:
--
Summary: IllegalArgumentException from
ByteBufferIndexInput.buildSlice
Key: LUCENE-5658
URL: https://issues.apache.org/jira/browse/LUCENE-5658
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13994475#comment-13994475
]
Shai Erera commented on LUCENE-5663:
We can have FSDirectoryFactory, but I usually
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5618:
---
Attachment: LUCENE-5618.patch
Patch addresses the following:
* Modifies Lucene45
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera reassigned LUCENE-5618:
--
Assignee: Shai Erera
DocValues updates send wrong fieldinfos to codec producers
[
https://issues.apache.org/jira/browse/LUCENE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13992564#comment-13992564
]
Shai Erera commented on LUCENE-5644:
{quote}
For that to work right you need to use
[
https://issues.apache.org/jira/browse/LUCENE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5636:
---
Priority: Major (was: Critical)
SegmentCommitInfo continues to list unneeded gen'd files
[
https://issues.apache.org/jira/browse/LUCENE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988005#comment-13988005
]
Shai Erera commented on LUCENE-5636:
I chatted with Robert about this. The current
Shai Erera created LUCENE-5636:
--
Summary: SegmentCommitInfo continues to list unneeded gen'd files
Key: LUCENE-5636
URL: https://issues.apache.org/jira/browse/LUCENE-5636
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5636:
---
Attachment: LUCENE-5636.patch
Patch improves the test to expose the bug.
SegmentCommitInfo
[
https://issues.apache.org/jira/browse/LUCENE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986859#comment-13986859
]
Shai Erera commented on LUCENE-5636:
Hmm, actually I think I can fix it w/o breaking
[
https://issues.apache.org/jira/browse/LUCENE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5591:
---
Attachment: LUCENE-5591.patch
Thanks Mike. I modified to ramBytesPerDoc and fixed Numeric to return
[
https://issues.apache.org/jira/browse/LUCENE-5633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5633:
---
Attachment: LUCENE-5633.patch
Patch removes the two singletons and adds a single INSTANCE. Also
[
https://issues.apache.org/jira/browse/LUCENE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5591:
---
Attachment: LUCENE-5591.patch
OK I moved to Math.ceil(). I thought ceil2() is quite cool
[
https://issues.apache.org/jira/browse/LUCENE-5633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5633.
Resolution: Fixed
Fix Version/s: 5.0
4.9
Assignee: Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5591.
Resolution: Fixed
Fix Version/s: 5.0
4.9
Assignee: Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13984218#comment-13984218
]
Shai Erera commented on LUCENE-5618:
bq. I dont like this pushing back against
[
https://issues.apache.org/jira/browse/LUCENE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5591:
---
Attachment: LUCENE-5591.patch
Patch adds an approximation flush size
[
https://issues.apache.org/jira/browse/LUCENE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13984234#comment-13984234
]
Shai Erera commented on LUCENE-5591:
BTW, I started by adding {{ramBytesUsed
[
https://issues.apache.org/jira/browse/LUCENE-5633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13984302#comment-13984302
]
Shai Erera commented on LUCENE-5633:
To repeat here what I wrote on the thread, if we
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13982853#comment-13982853
]
Shai Erera commented on LUCENE-5618:
I modified the code to pass all the FIs
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13982931#comment-13982931
]
Shai Erera commented on LUCENE-5618:
If we separate each DV update into its own file
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13977136#comment-13977136
]
Shai Erera commented on LUCENE-5618:
bq. I'm still unsure if this should block 4.8
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13977133#comment-13977133
]
Shai Erera commented on LUCENE-5618:
bq. I think its a design flaw in how this stuff
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13977152#comment-13977152
]
Shai Erera commented on LUCENE-5618:
bq. The codec should NOT be aware of dv updates
[
https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13977216#comment-13977216
]
Shai Erera commented on LUCENE-5618:
OK I'll take a look at passing all FIs. I agree
601 - 700 of 4461 matches
Mail list logo
