[GitHub] lucene-solr issue #509: [SOLR-13019] Fix typo in MailEntityProcessor.java

2018-12-04 Thread gerlowskija
Github user gerlowskija commented on the issue: https://github.com/apache/lucene-solr/pull/509 Thanks Tommy; merged to master. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands

[GitHub] lucene-solr issue #464: SOLR-12555: refactor tests in package org.apache.sol...

2018-11-03 Thread gerlowskija
Github user gerlowskija commented on the issue: https://github.com/apache/lucene-solr/pull/464 Thanks again for the work Bar. I've merged this to `master`. Should see this PR get closed out shortly. --- ---

[GitHub] lucene-solr pull request #464: WIP SOLR-12555: refactor tests in package org...

2018-10-22 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/464#discussion_r227202749 --- Diff: solr/core/src/test/org/apache/solr/search/TestRealTimeGet.java --- @@ -414,56 +391,44 @@ public void testOptimisticLocking() throws

[GitHub] lucene-solr pull request #464: WIP SOLR-12555: refactor tests in package org...

2018-10-22 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/464#discussion_r227030813 --- Diff: solr/core/src/test/org/apache/solr/search/TestRealTimeGet.java --- @@ -414,56 +391,44 @@ public void testOptimisticLocking() throws

[GitHub] lucene-solr pull request #464: WIP SOLR-12555: refactor tests in package org...

2018-10-22 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/464#discussion_r227022552 --- Diff: solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java --- @@ -1214,29 +1208,23 @@ public void testPayloadScoreQuery() throws

[GitHub] lucene-solr pull request #464: WIP SOLR-12555: refactor tests in package org...

2018-10-22 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/464#discussion_r227021582 --- Diff: solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java --- @@ -1190,14 +1190,8 @@ public void testCompares() throws Exception

[GitHub] lucene-solr pull request #464: WIP SOLR-12555: refactor tests in package org...

2018-10-22 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/464#discussion_r227024512 --- Diff: solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java --- @@ -1260,16 +1248,14 @@ public void testBoolQuery() throws Exception

[GitHub] lucene-solr pull request #464: WIP SOLR-12555: refactor tests in package org...

2018-10-22 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/464#discussion_r227024256 --- Diff: solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java --- @@ -1214,29 +1208,23 @@ public void testPayloadScoreQuery() throws

[GitHub] lucene-solr pull request #464: WIP SOLR-12555: refactor tests in package org...

2018-10-22 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/464#discussion_r227025974 --- Diff: solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java --- @@ -656,45 +656,38 @@ public void testAliasingBoost() throws

[GitHub] lucene-solr issue #425: WIP SOLR-12555: refactor tests to use expectThrows

2018-07-27 Thread gerlowskija
Github user gerlowskija commented on the issue: https://github.com/apache/lucene-solr/pull/425 Thanks for all the work Bar. I'm going to run the tests throughout the day and I hope to get this merged this evening or this we

[GitHub] lucene-solr pull request #425: WIP SOLR-12555: refactor tests to use expectT...

2018-07-23 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/425#discussion_r204599561 --- Diff: solr/core/src/test/org/apache/solr/cloud/OverseerStatusTest.java --- @@ -58,14 +59,13 @@ public void test() throws Exception

[GitHub] lucene-solr pull request #425: WIP SOLR-12555: refactor tests to use expectT...

2018-07-23 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/425#discussion_r204601997 --- Diff: solr/core/src/test/org/apache/solr/cloud/TestSolrCloudWithSecureImpersonation.java --- @@ -223,37 +223,26 @@ private String

[GitHub] lucene-solr pull request #425: WIP SOLR-12555: refactor tests to use expectT...

2018-07-23 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/425#discussion_r204597595 --- Diff: solr/core/src/test/org/apache/solr/TestDistributedSearch.java --- @@ -910,13 +910,11 @@ public void test() throws Exception

[GitHub] lucene-solr pull request #425: WIP SOLR-12555: refactor tests to use expectT...

2018-07-23 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/425#discussion_r204600183 --- Diff: solr/core/src/test/org/apache/solr/cloud/TestAuthenticationFramework.java --- @@ -78,17 +79,11 @@ public void testBasics() throws

[GitHub] lucene-solr pull request #425: WIP SOLR-12555: refactor tests to use expectT...

2018-07-23 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/425#discussion_r20468 --- Diff: solr/core/src/test/org/apache/solr/cloud/SolrXmlInZkTest.java --- @@ -139,16 +139,13 @@ public void testNotInZkFallbackLocal() throws

[GitHub] lucene-solr pull request #425: WIP SOLR-12555: refactor tests to use expectT...

2018-07-23 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/425#discussion_r204601140 --- Diff: solr/core/src/test/org/apache/solr/cloud/TestPullReplicaErrorHandling.java --- @@ -151,12 +151,14 @@ public void

[GitHub] lucene-solr pull request #425: WIP SOLR-12555: refactor tests to use expectT...

2018-07-23 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/425#discussion_r204598388 --- Diff: solr/core/src/test/org/apache/solr/cloud/BasicZkTest.java --- @@ -150,15 +150,13 @@ public void testBasic() throws Exception

[GitHub] lucene-solr pull request #425: WIP SOLR-12555: refactor tests to use expectT...

2018-07-23 Thread gerlowskija
Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/425#discussion_r204596268 --- Diff: solr/core/src/test/org/apache/solr/cloud/BasicZkTest.java --- @@ -150,15 +150,13 @@ public void testBasic() throws Exception