[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-12-12 Thread janhoy
Github user janhoy closed the pull request at: https://github.com/apache/lucene-solr/pull/457 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-10 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r224121448 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-10 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r224121574 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-08 Thread sigram
Github user sigram commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r223290128 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-08 Thread sigram
Github user sigram commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r223288246 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-08 Thread sigram
Github user sigram commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r223286527 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-08 Thread sigram
Github user sigram commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r223286109 --- Diff: solr/core/src/java/org/apache/solr/core/SolrInfoBean.java --- @@ -34,7 +34,7 @@ * Category of Solr component. */ enum

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222759868 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222761151 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222761691 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222759422 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -52,11 +80,73 @@ public abstract boolean

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222759139 --- Diff: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java --- @@ -20,16 +20,44 @@ import javax.servlet.ServletRequest;

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222757598 --- Diff: solr/core/src/java/org/apache/solr/core/SolrInfoBean.java --- @@ -34,7 +34,7 @@ * Category of Solr component. */ enum

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222658500 --- Diff: solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java --- @@ -420,4 +425,68 @@ public static void ensureRunningJettys(int

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread janhoy
Github user janhoy commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222657709 --- Diff: solr/core/src/java/org/apache/solr/core/CoreContainer.java --- @@ -798,6 +798,12 @@ private void reloadSecurityProperties() {

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread sigram
Github user sigram commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222593938 --- Diff: solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java --- @@ -420,4 +425,68 @@ public static void ensureRunningJettys(int

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-10-04 Thread sigram
Github user sigram commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/457#discussion_r222587616 --- Diff: solr/core/src/java/org/apache/solr/core/CoreContainer.java --- @@ -798,6 +798,12 @@ private void reloadSecurityProperties() {

[GitHub] lucene-solr pull request #457: SOLR-12791: Add Metrics reporting for Authent...

2018-09-20 Thread janhoy
GitHub user janhoy opened a pull request: https://github.com/apache/lucene-solr/pull/457 SOLR-12791: Add Metrics reporting for AuthenticationPlugin First partial patch You can merge this pull request into a Git repository by running: $ git pull