Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Michael Sokolov
OK - well, this vote passed, but we will re-spin to capture the bug fix and the JDK-19 support. I'll open a new vite thread for RC2 On Mon, Sep 26, 2022 at 9:57 AM Uwe Schindler wrote: > > See my mail before. Delete gradle.properties from Lucene checkout folder. > > Uwe > > Am 26.09.2022 um

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Uwe Schindler
See my mail before. Delete gradle.properties from Lucene checkout folder. Uwe Am 26.09.2022 um 15:51 schrieb Michael Sokolov: Hm the build failed with this: FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':lucene:core:compileMain19Java'. Error while

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Michael Sokolov
Hm the build failed with this: FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':lucene:core:compileMain19Java'. > Error while evaluating property 'javaCompiler' of task > ':lucene:core:compileMain19Java' > Failed to calculate the value of task

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Michael Sokolov
Nice! Thanks everyone, I will refresh and start building the artifacts On Mon, Sep 26, 2022 at 9:33 AM Uwe Schindler wrote: > > OK, > > Java 19 support for Panama Foreign is in! Thanks for waiting! > > Uwe > > Am 26.09.2022 um 15:08 schrieb Uwe Schindler: > > I will also merge shortly! Please

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Uwe Schindler
OK, Java 19 support for Panama Foreign is in! Thanks for waiting! Uwe Am 26.09.2022 um 15:08 schrieb Uwe Schindler: I will also merge shortly! Please have a quick look @ https://github.com/apache/lucene/pull/912 That's really great that Eclipse Adoptium released in time :-) Uwe Am

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Uwe Schindler
I will also merge shortly! Please have a quick look @ https://github.com/apache/lucene/pull/912 That's really great that Eclipse Adoptium released in time :-) Uwe Am 26.09.2022 um 14:57 schrieb Adrien Grand: The change is now on branch_9_4. On Mon, Sep 26, 2022 at 2:38 PM Adrien Grand

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Adrien Grand
The change is now on branch_9_4. On Mon, Sep 26, 2022 at 2:38 PM Adrien Grand wrote: > I opened a PR and will backport it to relevant branches shortly: > https://github.com/apache/lucene/pull/11818. > > On Mon, Sep 26, 2022 at 2:26 PM Uwe Schindler wrote: > >> Hi Michael, >> >> if you give me

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Adrien Grand
I opened a PR and will backport it to relevant branches shortly: https://github.com/apache/lucene/pull/11818. On Mon, Sep 26, 2022 at 2:26 PM Uwe Schindler wrote: > Hi Michael, > > if you give me an hour or so to add changes. All fine now! > > I will re-spin today. I don't think we should wait

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Uwe Schindler
Hi Michael, if you give me an hour or so to add changes. All fine now! I will re-spin today. I don't think we should wait any longer for AdoptOpenJDK - sorry Uwe; I too would like to be able to mess around with the new features in JDK19, but I think it's not a good precedent to tie our release

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Michael Sokolov
OK, this is clearly messed up, but just for my education, I'd like to understand the possible failure scenario. Oh thanks Adrien, just saw your latest. So that confirms what I was thinking: that this is not likely to cause problems in any foreseeable scenario; there is no

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Adrien Grand
Hey Uwe, This problem would not be observed by bwc tests because they always make sure to use the right codec. The problem only arises if things get mixed up for some reason, and the wrong codec gets used to read a segment. Hopefully no user would ever see this problem in practice. The main

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Uwe Schindler
Hi again, About the original bug you reported: This is really serious and we MUST respin! That opens the following question: Why was this bug not discoveredby the backwards compatibility tests? If you open a 9.0 index from backwards indexes with 9.4 it should complain? Or does this pass

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Uwe Schindler
Hi, cool. Could we please wait with the respon till Adoption released also OpenJDK 19, so we can include the Java 19 MMapDirectory as discussed before. Everything is ready to merge! Uwe Am 26.09.2022 um 11:42 schrieb Adrien Grand: Ignacio made me notice than the new Lucene94FieldInfosFormat

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-26 Thread Adrien Grand
Ignacio made me notice than the new Lucene94FieldInfosFormat did not change the codec name compared to Lucene90FieldInfosFormat: https://github.com/apache/lucene/blob/branch_9_4/lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94FieldInfosFormat.java#L376 . The issue with this is that

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-25 Thread Anshum Gupta
+1 (binding) The smoke tests passed. SUCCESS! [2:49:17.242508] On Fri, Sep 23, 2022 at 12:22 PM Patrick Zhai wrote: > (non-binding) +1 > > SUCCESS! [1:11:00.934249] > > On Fri, Sep 23, 2022 at 9:44 AM Vigya Sharma wrote: > >> The smoke tests passed for me too.. >> >> >> (no vote) >> >>

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-23 Thread Patrick Zhai
(non-binding) +1 SUCCESS! [1:11:00.934249] On Fri, Sep 23, 2022 at 9:44 AM Vigya Sharma wrote: > The smoke tests passed for me too.. > > > (no vote) > > SUCCESS! [1:12:31.588303] > > On Thu, Sep 22, 2022 at 2:27 AM Ignacio Vera wrote: > >> +1 >> >> >> SUCCESS! [0:46:00.508949] >> >> On Thu,

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-23 Thread Vigya Sharma
The smoke tests passed for me too.. (no vote) SUCCESS! [1:12:31.588303] On Thu, Sep 22, 2022 at 2:27 AM Ignacio Vera wrote: > +1 > > > SUCCESS! [0:46:00.508949] > > On Thu, Sep 22, 2022 at 9:53 AM Adrien Grand wrote: > >> +1 SUCCESS! [0:45:35.275017] >> >> On Wed, Sep 21, 2022 at 9:19 PM

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-22 Thread Ignacio Vera
+1 SUCCESS! [0:46:00.508949] On Thu, Sep 22, 2022 at 9:53 AM Adrien Grand wrote: > +1 SUCCESS! [0:45:35.275017] > > On Wed, Sep 21, 2022 at 9:19 PM Michael McCandless < > luc...@mikemccandless.com> wrote: > >> +1 >> >> >> SUCCESS! [0:27:16.514391] >> >> >> Mike McCandless >> >>

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-22 Thread Adrien Grand
+1 SUCCESS! [0:45:35.275017] On Wed, Sep 21, 2022 at 9:19 PM Michael McCandless < luc...@mikemccandless.com> wrote: > +1 > > > SUCCESS! [0:27:16.514391] > > > Mike McCandless > > http://blog.mikemccandless.com > > > On Wed, Sep 21, 2022 at 2:32 PM Dawid Weiss wrote: > >> >> +1. >> SUCCESS!

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-21 Thread Michael McCandless
+1 SUCCESS! [0:27:16.514391] Mike McCandless http://blog.mikemccandless.com On Wed, Sep 21, 2022 at 2:32 PM Dawid Weiss wrote: > > +1. > SUCCESS! [0:53:33.891603] > > >> Ran the smoketester with both java 11 and 17: >> >> SUCCESS! [2:41:19.024193] >> >> On Tue, Sep 20, 2022 at 10:10 PM

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-21 Thread Dawid Weiss
+1. SUCCESS! [0:53:33.891603] > Ran the smoketester with both java 11 and 17: > > SUCCESS! [2:41:19.024193] > > On Tue, Sep 20, 2022 at 10:10 PM Michael Sokolov > wrote: > > > > Please vote for release candidate 1 for Lucene 9.4.0 > > > > The artifacts can be downloaded from: > > >

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-21 Thread Robert Muir
+1 Ran the smoketester with both java 11 and 17: SUCCESS! [2:41:19.024193] On Tue, Sep 20, 2022 at 10:10 PM Michael Sokolov wrote: > > Please vote for release candidate 1 for Lucene 9.4.0 > > The artifacts can be downloaded from: >

Re: [VOTE] Release Lucene 9.4.0 RC1

2022-09-21 Thread Uwe Schindler
Hi, Policeman Jenkins tested the release, no issues found: https://jenkins.thetaphi.de/job/Lucene-Release-Tester/19/console SUCCESS! [1:31:12.952025] Finished: SUCCESS I have no problem with releasing this,but please also check my other mail. Uwe Am 21.09.2022 um 04:10 schrieb Michael

[VOTE] Release Lucene 9.4.0 RC1

2022-09-20 Thread Michael Sokolov
Please vote for release candidate 1 for Lucene 9.4.0 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-9.4.0-RC1-rev-f5d0646daa5651f2192282ac85551bca667e34f9 You can run the smoke tester directly with this command: python3 -u