[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13061836#comment-13061836
]
Simon Willnauer commented on LUCENE-2793:
-
I fixed the two minor things from
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13061439#comment-13061439
]
Michael McCandless commented on LUCENE-2793:
Looks good! +1 to land it!
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13060537#comment-13060537
]
Simon Willnauer commented on LUCENE-2793:
-
bq. Made the necessary changes and
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13060538#comment-13060538
]
Michael McCandless commented on LUCENE-2793:
+1
Directory createOutput and
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13059527#comment-13059527
]
Michael McCandless commented on LUCENE-2793:
I think BufferedIndexInput
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057903#comment-13057903
]
Simon Willnauer commented on LUCENE-2793:
-
Varun this patch looks great. I am
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058116#comment-13058116
]
Michael McCandless commented on LUCENE-2793:
To address the nocommits about
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13056449#comment-13056449
]
Simon Willnauer commented on LUCENE-2793:
-
Varun, patch looks great!
here are
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055649#comment-13055649
]
Simon Willnauer commented on LUCENE-2793:
-
bq. Should IOContext and MergeInfo be
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054359#comment-13054359
]
Michael McCandless commented on LUCENE-2793:
I took quick look @ the branch
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051857#comment-13051857
]
Simon Willnauer commented on LUCENE-2793:
-
I created a branch for this issue and
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051665#comment-13051665
]
Simon Willnauer commented on LUCENE-2793:
-
hey varun thanks for the new patch,
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050444#comment-13050444
]
Simon Willnauer commented on LUCENE-2793:
-
hey varun
patch looks close!
here
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049293#comment-13049293
]
Michael McCandless commented on LUCENE-2793:
LUCENE-3203 is another example
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13048285#comment-13048285
]
Michael McCandless commented on LUCENE-2793:
bq. Can OneMerge extend
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047970#comment-13047970
]
Simon Willnauer commented on LUCENE-2793:
-
hi varun,
looks good, some quick
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047234#comment-13047234
]
Simon Willnauer commented on LUCENE-2793:
-
Varun, your patch doesn't apply
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046403#comment-13046403
]
Simon Willnauer commented on LUCENE-2793:
-
Hey varun,
here are some more
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046635#comment-13046635
]
Michael McCandless commented on LUCENE-2793:
bq. It seems that we don't need
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13045322#comment-13045322
]
Simon Willnauer commented on LUCENE-2793:
-
Very very quick review:
* I think
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13045354#comment-13045354
]
Michael McCandless commented on LUCENE-2793:
Patch looks great! Comments:
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13045455#comment-13045455
]
Michael McCandless commented on LUCENE-2793:
{quote}
I think we'll need a
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13042824#comment-13042824
]
Michael McCandless commented on LUCENE-2793:
Patch is looking good! Some
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13041560#comment-13041560
]
Simon Willnauer commented on LUCENE-2793:
-
bq. Why not use a normal struct/bean
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13041617#comment-13041617
]
Michael McCandless commented on LUCENE-2793:
bq. If bean or copy-on-write
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13041642#comment-13041642
]
Chris Male commented on LUCENE-2793:
{quote}
So, if we really don't want to include
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13041224#comment-13041224
]
Michael McCandless commented on LUCENE-2793:
Great to see your patch here
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13041225#comment-13041225
]
Michael McCandless commented on LUCENE-2793:
bq. Some kind of a copy-on-write
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13041248#comment-13041248
]
Michael McCandless commented on LUCENE-2793:
bq. I removed bufferSize from
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13040845#comment-13040845
]
Jason Rutherglen commented on LUCENE-2793:
--
I already posted a patch to this
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13040850#comment-13040850
]
Varun Thacker commented on LUCENE-2793:
---
I should have seen the patch! I have taken
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13040906#comment-13040906
]
Simon Willnauer commented on LUCENE-2793:
-
bq. I already posted a patch to this
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032992#comment-13032992
]
Michael McCandless commented on LUCENE-2793:
For LUCENE-3092, it would be
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13015785#comment-13015785
]
Varun Thacker commented on LUCENE-2793:
---
Hi. I would be interested in taking this
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13015790#comment-13015790
]
Simon Willnauer commented on LUCENE-2793:
-
bq. Hi. I would be interested in
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980625#action_12980625
]
Shai Erera commented on LUCENE-2793:
bq. No you dont... you can also call the
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980649#action_12980649
]
Earwin Burrfoot commented on LUCENE-2793:
-
What's with ongoing crazyness? :)
bq.
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980727#action_12980727
]
Shai Erera commented on LUCENE-2793:
I assume you mean setBufferSize(IOContext, size)
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980731#action_12980731
]
Robert Muir commented on LUCENE-2793:
-
bq. The proper way is to test out the things,
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980732#action_12980732
]
Earwin Burrfoot commented on LUCENE-2793:
-
bq. Because in your example code above,
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980736#action_12980736
]
Earwin Burrfoot commented on LUCENE-2793:
-
{quote}
As I said before though, i
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980740#action_12980740
]
Robert Muir commented on LUCENE-2793:
-
{quote}
I'm perfectly OK with that approach
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980400#action_12980400
]
Earwin Burrfoot commented on LUCENE-2793:
-
Looks crazy. In a -bad- tangled way.
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980435#action_12980435
]
Jason Rutherglen commented on LUCENE-2793:
--
bq. You get IOFactory from Directory
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980454#action_12980454
]
Earwin Burrfoot commented on LUCENE-2793:
-
{quote}
bq. You get IOFactory from
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980458#action_12980458
]
Earwin Burrfoot commented on LUCENE-2793:
-
In fact, I suggest dropping bufferSize
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980470#action_12980470
]
Robert Muir commented on LUCENE-2793:
-
bq. In fact, I suggest dropping bufferSize
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980533#action_12980533
]
Jason Rutherglen commented on LUCENE-2793:
--
Ok, lets remove bufferSize.
bq.
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980543#action_12980543
]
Robert Muir commented on LUCENE-2793:
-
bq. That's how the patch works. If that doesn't
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980546#action_12980546
]
Jason Rutherglen commented on LUCENE-2793:
--
bq. The directory is the factory for
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980551#action_12980551
]
Shai Erera commented on LUCENE-2793:
If we drop bufferSize, how will I be able to tell
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980555#action_12980555
]
Jason Rutherglen commented on LUCENE-2793:
--
In the patch the bufferSize is an int
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980557#action_12980557
]
Robert Muir commented on LUCENE-2793:
-
bq. If we drop bufferSize, how will I be able
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980559#action_12980559
]
Shai Erera commented on LUCENE-2793:
bq. This way the bufferSize is settable by the
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980561#action_12980561
]
Shai Erera commented on LUCENE-2793:
Robert, nothing is too difficult to understand.
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12980564#action_12980564
]
Robert Muir commented on LUCENE-2793:
-
bq. But your code example tells me that if I
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979728#action_12979728
]
Jason Rutherglen commented on LUCENE-2793:
--
Shall I take this one? With the plan
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979731#action_12979731
]
Michael McCandless commented on LUCENE-2793:
Yes please!
But, this issue only
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979736#action_12979736
]
Jason Rutherglen commented on LUCENE-2793:
--
{quote}this issue only adds the
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979738#action_12979738
]
Michael McCandless commented on LUCENE-2793:
Sorry, I think we should also do
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979740#action_12979740
]
Jason Rutherglen commented on LUCENE-2793:
--
bq. Basically the IOContext needs to
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12970530#action_12970530
]
Jason Rutherglen commented on LUCENE-2793:
--
Perhaps we can add the ability to
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966963#action_12966963
]
Robert Muir commented on LUCENE-2793:
-
There is another problem we should solve here,
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966564#action_12966564
]
Robert Muir commented on LUCENE-2793:
-
Sounds great, at least in theory we could do
[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966566#action_12966566
]
Uwe Schindler commented on LUCENE-2793:
---
And MMapDir should return a
65 matches
Mail list logo
