[jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document

2011-06-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042811#comment-13042811 ] Michael McCandless commented on LUCENE-3099: Patch looks great -- I think it'

[jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document

2011-06-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042377#comment-13042377 ] Michael McCandless commented on LUCENE-3099: I think we are close here! It's

[jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document

2011-05-30 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041249#comment-13041249 ] Martijn van Groningen commented on LUCENE-3099: --- {quote} After FQ is relati

[jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document

2011-05-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041246#comment-13041246 ] Michael McCandless commented on LUCENE-3099: bq. I thought that 2883 was more

[jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document

2011-05-30 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041239#comment-13041239 ] Martijn van Groningen commented on LUCENE-3099: --- bq. I think we can take th

[jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document

2011-05-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041228#comment-13041228 ] Michael McCandless commented on LUCENE-3099: bq. Should we rename all abstra

[jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document

2011-05-29 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040893#comment-13040893 ] Martijn van Groningen commented on LUCENE-3099: --- I think the SecondPassGrou

[jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document

2011-05-29 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040870#comment-13040870 ] Martijn van Groningen commented on LUCENE-3099: --- {quote} Separately, we sho

[jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document

2011-05-29 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040824#comment-13040824 ] Michael McCandless commented on LUCENE-3099: That patch is totally untested,

[jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document

2011-05-28 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040681#comment-13040681 ] Martijn van Groningen commented on LUCENE-3099: --- Also some initial performa

[jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document

2011-05-25 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039444#comment-13039444 ] Martijn van Groningen commented on LUCENE-3099: --- In order to avoid double F

[jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document

2011-05-15 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033692#comment-13033692 ] Michael McCandless commented on LUCENE-3099: I was thinking we could paramete

[jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document

2011-05-15 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033688#comment-13033688 ] Martijn van Groningen commented on LUCENE-3099: --- All the current group coll