[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610472#comment-13610472
]
Commit Tag Bot commented on LUCENE-4575:
[branch_4x commit] Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508245#comment-13508245
]
Michael McCandless commented on LUCENE-4575:
I thought we were going to
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508251#comment-13508251
]
Michael McCandless commented on LUCENE-4575:
Actually I think we should just
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508254#comment-13508254
]
Shai Erera commented on LUCENE-4575:
bq. I thought we were going to rename
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508267#comment-13508267
]
Michael McCandless commented on LUCENE-4575:
{quote}
I agree that calling
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508268#comment-13508268
]
Shai Erera commented on LUCENE-4575:
I'll make the changes, and also it seems like
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508275#comment-13508275
]
Michael McCandless commented on LUCENE-4575:
I'll make a test exposing the
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508319#comment-13508319
]
Shai Erera commented on LUCENE-4575:
The test isn't exactly accurate, because it
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508327#comment-13508327
]
Shai Erera commented on LUCENE-4575:
Hmmm ... setting the commitData on pendingCommit
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508356#comment-13508356
]
Michael McCandless commented on LUCENE-4575:
bq. Hmmm ... setting the
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508363#comment-13508363
]
Shai Erera commented on LUCENE-4575:
I don't think that we should add more work to
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508375#comment-13508375
]
Michael McCandless commented on LUCENE-4575:
+1, looks great. Thanks Shai!
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508524#comment-13508524
]
Commit Tag Bot commented on LUCENE-4575:
[trunk commit] Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508551#comment-13508551
]
Commit Tag Bot commented on LUCENE-4575:
[branch_4x commit] Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506432#comment-13506432
]
Michael McCandless commented on LUCENE-4575:
+1 to do a hard break; this is
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506468#comment-13506468
]
Shai Erera commented on LUCENE-4575:
Thanks. I forgot to mention two things about the
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506492#comment-13506492
]
Yonik Seeley commented on LUCENE-4575:
--
bq. I currently copy the commitData map on
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506526#comment-13506526
]
Shai Erera commented on LUCENE-4575:
We use commitData extensively but we don't care
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506528#comment-13506528
]
Uwe Schindler commented on LUCENE-4575:
---
The API returns MapString,String, so we
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506530#comment-13506530
]
Yonik Seeley commented on LUCENE-4575:
--
bq. I don't think though that it's trivial
[
https://issues.apache.org/jira/browse/LUCENE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506540#comment-13506540
]
Shai Erera commented on LUCENE-4575:
bq. Then the only thing that would need to
21 matches
Mail list logo
