[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-27 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384283#comment-14384283 ] Michael McCandless commented on LUCENE-6308: bq. From the current TermSpans.j

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-27 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384276#comment-14384276 ] Michael McCandless commented on LUCENE-6308: bq. I've seen people use large p

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-27 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384267#comment-14384267 ] Paul Elschot commented on LUCENE-6308: -- bq. The patch just needs a minor fix to Near

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-27 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384124#comment-14384124 ] Paul Elschot commented on LUCENE-6308: -- >From the current TermSpans.java: {code} p

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-27 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384013#comment-14384013 ] Robert Muir commented on LUCENE-6308: - Alan is correct. Mike, the issue is you don't

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-27 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383772#comment-14383772 ] Michael McCandless commented on LUCENE-6308: bq. What if you have a term that

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-27 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383736#comment-14383736 ] Alan Woodward commented on LUCENE-6308: --- I don't think Integer.MAX_VALUE works thou

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-27 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383521#comment-14383521 ] Michael McCandless commented on LUCENE-6308: +1 to the latest patch: it's a g

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-26 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382229#comment-14382229 ] Paul Elschot commented on LUCENE-6308: -- I created some spinoff issues from this to a

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379227#comment-14379227 ] David Smiley commented on LUCENE-6308: -- The pain of not using _any_ review tool (no

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-24 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378744#comment-14378744 ] Paul Elschot commented on LUCENE-6308: -- bq. we needn’t add getClass().hashCode as Qu

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-24 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378515#comment-14378515 ] Paul Elschot commented on LUCENE-6308: -- For the NO_MORE_POSITIONS: personally I actu

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378250#comment-14378250 ] David Smiley commented on LUCENE-6308: -- Without the benefit of a code review tool; I

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377972#comment-14377972 ] David Smiley commented on LUCENE-6308: -- If we can't use Integer.MAX_VALUE as NO_MORE

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-24 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377885#comment-14377885 ] Alan Woodward commented on LUCENE-6308: --- Sorry, I wasn't clear - you can't use Inte

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-24 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377831#comment-14377831 ] Robert Muir commented on LUCENE-6308: - reviewboard sucks, ive used it at a previous j

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377799#comment-14377799 ] David Smiley commented on LUCENE-6308: -- https://reviews.apache.org/dashboard/ It's i

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-24 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377438#comment-14377438 ] Paul Elschot commented on LUCENE-6308: -- Where is the ReviewBoard? > SpansEnum, depr

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-23 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376859#comment-14376859 ] David Smiley commented on LUCENE-6308: -- Can you please use ReviewBoard? > SpansEnum

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-23 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376505#comment-14376505 ] Paul Elschot commented on LUCENE-6308: -- Nice to see that Test03Distance.test3Example

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-23 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376249#comment-14376249 ] Robert Muir commented on LUCENE-6308: - Also, I ran very quick and dirty benchmarks, t

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-23 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376134#comment-14376134 ] Paul Elschot commented on LUCENE-6308: -- I took a quick look at the changeapi patch.

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-23 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375566#comment-14375566 ] Alan Woodward commented on LUCENE-6308: --- Should NO_MORE_POSITIONS be something othe

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-23 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375496#comment-14375496 ] Robert Muir commented on LUCENE-6308: - By the way, at least i think this exercise may

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-22 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14374946#comment-14374946 ] Paul Elschot commented on LUCENE-6308: -- The patch of 21 March 2015 does not have a S

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-14 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362005#comment-14362005 ] Paul Elschot commented on LUCENE-6308: -- I'm slowly progressing with this. There is o

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-05 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349636#comment-14349636 ] Paul Elschot commented on LUCENE-6308: -- Even though this has another goal (avoiding

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-03-04 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347702#comment-14347702 ] Paul Elschot commented on LUCENE-6308: -- Still to do: FieldMaskingSpanQuery, SpanNear

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-02-28 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341479#comment-14341479 ] Paul Elschot commented on LUCENE-6308: -- I just had a quick look at the latest patch

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-02-28 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341463#comment-14341463 ] Paul Elschot commented on LUCENE-6308: -- bq. if we get it in shape The idea was to h

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-02-27 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340763#comment-14340763 ] Robert Muir commented on LUCENE-6308: - I really like the idea of bringing spans "up t

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-02-27 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340719#comment-14340719 ] Paul Elschot commented on LUCENE-6308: -- This could also be an alternative for LUCENE

[jira] [Commented] (LUCENE-6308) SpansEnum, deprecate Spans

2015-02-27 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340706#comment-14340706 ] Paul Elschot commented on LUCENE-6308: -- This avoids the problem of Spans going to th