[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966553#comment-14966553
]
ASF subversion and git services commented on LUCENE-6821:
-
Commit 1709780 from
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14964899#comment-14964899
]
Tommaso Teofili commented on LUCENE-6821:
-
I will run another round of testing and inspections
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965008#comment-14965008
]
ASF subversion and git services commented on LUCENE-6821:
-
Commit 1709576 from
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965344#comment-14965344
]
Michael McCandless commented on LUCENE-6821:
bq. Do we want to backport it to 5.x?
+1, I
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965765#comment-14965765
]
ASF subversion and git services commented on LUCENE-6821:
-
Commit 1709683 from
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963041#comment-14963041
]
Adrien Grand commented on LUCENE-6821:
--
+1 on my end as well
> TermQuery's constructors should
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961776#comment-14961776
]
Tommaso Teofili commented on LUCENE-6821:
-
from my perspective we can proceed committing this
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961845#comment-14961845
]
Paul Elschot commented on LUCENE-6821:
--
The patch of 14 October LGTM, and tests pass here.
>
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956971#comment-14956971
]
Tommaso Teofili commented on LUCENE-6821:
-
bq. One could also create the Term in the loop and
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953138#comment-14953138
]
Tommaso Teofili commented on LUCENE-6821:
-
do you mean the {{BytesRef.deepCopyOf}} at
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953160#comment-14953160
]
Tommaso Teofili commented on LUCENE-6821:
-
after a quick look it doesn't seem removing the deep
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953479#comment-14953479
]
Paul Elschot commented on LUCENE-6821:
--
One could also create the Term in the loop and pass that, or
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14950213#comment-14950213
]
Adrien Grand commented on LUCENE-6821:
--
I like how the patch makes things simpler. I'll wait a bit
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14950780#comment-14950780
]
Paul Elschot commented on LUCENE-6821:
--
bq. Can you also remove the explicit cloning that we added
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942304#comment-14942304
]
Paul Elschot commented on LUCENE-6821:
--
The patch also removes a call to the term constructor in
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942337#comment-14942337
]
Paul Elschot commented on LUCENE-6821:
--
There is another Term constructor call that is a clone at
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942191#comment-14942191
]
Paul Elschot commented on LUCENE-6821:
--
I had a look at the core code for the use of the TermQuery
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942310#comment-14942310
]
Jack Krupansky commented on LUCENE-6821:
Won't this change have the prospect of increasing the
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942325#comment-14942325
]
Adrien Grand commented on LUCENE-6821:
--
I don't think we should bother at all: executing a term
[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936541#comment-14936541
]
Paul Elschot commented on LUCENE-6821:
--
See (also?) LUCENE-4483.
> TermQuery's constructors should
20 matches
Mail list logo
