[
https://issues.apache.org/jira/browse/LUCENE-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606965#comment-16606965
]
ASF subversion and git services commented on LUCENE-8483:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606936#comment-16606936
]
Alan Woodward commented on LUCENE-8483:
---
ScoreAndDoc is always an implementation detail, so I'm
[
https://issues.apache.org/jira/browse/LUCENE-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604369#comment-16604369
]
David Smiley commented on LUCENE-8483:
--
+1 looks good Alan. If you want to standardize on the name
[
https://issues.apache.org/jira/browse/LUCENE-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604131#comment-16604131
]
Alan Woodward commented on LUCENE-8483:
---
Good point! Renamed everywhere except for tests where it
[
https://issues.apache.org/jira/browse/LUCENE-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604118#comment-16604118
]
Adrien Grand commented on LUCENE-8483:
--
bq. I renamed FakeScorable to ScoreAndDoc
+1 let's also
[
https://issues.apache.org/jira/browse/LUCENE-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604110#comment-16604110
]
Alan Woodward commented on LUCENE-8483:
---
ValueSource.getRangeScorer() now takes a Weight as well,
[
https://issues.apache.org/jira/browse/LUCENE-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603002#comment-16603002
]
Adrien Grand commented on LUCENE-8483:
--
Can we somehow avoid the FakeWeight in ValuesSourceScorer?
[
https://issues.apache.org/jira/browse/LUCENE-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602992#comment-16602992
]
Alan Woodward commented on LUCENE-8483:
---
Patch. Several FakeScorer implementations have been
