[jira] [Commented] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9

[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900164#comment-15900164 ] ASF subversion and git services commented on SOLR-10235: Commit

[jira] [Commented] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9

[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900161#comment-15900161 ] ASF subversion and git services commented on SOLR-10235: Commit

[jira] [Commented] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9

[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900136#comment-15900136 ] Uwe Schindler commented on SOLR-10235: -- Oh yeah. Sorry, I'll fix. > fix last TestJdbcDataSource /

[jira] [Commented] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9

[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900064#comment-15900064 ] Kevin Risden commented on SOLR-10235: - I haven't looked too closely at this patch, but for the

[jira] [Commented] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9

[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900060#comment-15900060 ] Mikhail Khludnev commented on SOLR-10235: - I have this commit locally. {{precommit}} just failed

[jira] [Commented] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9

[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899855#comment-15899855 ] ASF subversion and git services commented on SOLR-10235: Commit

[jira] [Commented] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9

[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899854#comment-15899854 ] ASF subversion and git services commented on SOLR-10235: Commit

[jira] [Commented] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9

[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899830#comment-15899830 ] Hoss Man commented on SOLR-10235: - +1 > fix last TestJdbcDataSource / mock issue with java9 >

[jira] [Commented] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9

[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899816#comment-15899816 ] Hoss Man commented on SOLR-10235: - bq. I can add a note to the Javadocs why it is not a mock, but the

[jira] [Commented] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9

[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899806#comment-15899806 ] Uwe Schindler commented on SOLR-10235: -- bq. 1) the javadocs for MockDriver should explain the purpose

[jira] [Commented] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9

[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899790#comment-15899790 ] Hoss Man commented on SOLR-10235: - Uwe: i like this approach, three nits... 1) the javadocs for

[jira] [Commented] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9

[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898929#comment-15898929 ] Uwe Schindler commented on SOLR-10235: -- In addition, I made the Driver class public, otherwise it's

[jira] [Commented] (SOLR-10235) fix last TestJdbcDataSource / mock issue with java9

[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898878#comment-15898878 ] Uwe Schindler commented on SOLR-10235: -- Hi [~hossman], thanks for converting it, but there are 2