[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-30 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668780#comment-16668780 ] Mark Miller commented on SOLR-12801: Still coming. FYI, I'm turning off most tlog replica testing

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667769#comment-16667769 ] Mark Miller commented on SOLR-12801: Wow. The tests were in very rough shape. We *have* to execute on

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1191#comment-1191 ] Mark Miller commented on SOLR-12801: Once I get my patch in for SOLR-12804, I'll fix or help fix any

Re: [jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-26 Thread Mark Miller
I'll get back to you on that very shortly. - Mark On Thu, Oct 25, 2018 at 7:51 PM Erick Erickson wrote: > Mark: > > All power to you of course. Procedurally, what is most helpful? My > impression is that there's going to be a _lot_ of reorganization going > on and what I don't quite understand

Re: [jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-25 Thread Erick Erickson
Mark: All power to you of course. Procedurally, what is most helpful? My impression is that there's going to be a _lot_ of reorganization going on and what I don't quite understand is how others can be most helpful. IOW, will it be one of those things where you'd prefer to work alone for the

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-25 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664333#comment-16664333 ] Mark Miller commented on SOLR-12801: [~dsmiley] - I've linked both those issues. They are probably

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-25 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664300#comment-16664300 ] Mark Miller commented on SOLR-12801: bq. I suppose it doesn't fit within the scope of this issue

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-25 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664080#comment-16664080 ] David Smiley commented on SOLR-12801: - I've been interested in making tests easier to maintain and

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-24 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663047#comment-16663047 ] Mark Miller commented on SOLR-12801: We currently have a complete mix of integration and unit tests.

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-24 Thread Varun Thacker (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662860#comment-16662860 ] Varun Thacker commented on SOLR-12801: -- {quote}I want to start having a place for unit tests and

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-23 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661480#comment-16661480 ] Mark Miller commented on SOLR-12801: I want to start having a place for unit tests and integration

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-23 Thread Varun Thacker (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661473#comment-16661473 ] Varun Thacker commented on SOLR-12801: -- {quote}I'm going to start addressing tests by package

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-23 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661463#comment-16661463 ] Mark Miller commented on SOLR-12801: I'm going to start addressing tests by package (search package

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-23 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660315#comment-16660315 ] Mark Miller commented on SOLR-12801: bq. BadApple=true is the default, you have to deliberately

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-23 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660312#comment-16660312 ] Mark Miller commented on SOLR-12801: My first patch includes the first 3 sub issues I've linked. It's

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-10-23 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660310#comment-16660310 ] Mark Miller commented on SOLR-12801: This is an umbrella issue to track a variety of things I'll be

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-09-26 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628943#comment-16628943 ] Erick Erickson commented on SOLR-12801: --- {quote}You can only meaningful run tests with BadApples

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-09-26 Thread Jason Gerlowski (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628680#comment-16628680 ] Jason Gerlowski commented on SOLR-12801: Hey Mark, 100% agreed the tests are a problem.  But can

[jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

2018-09-24 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626075#comment-16626075 ] Mark Miller commented on SOLR-12801: The tests are getting less and less useful all the time. Devs

<    1   2