[
https://issues.apache.org/jira/browse/SOLR-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13167889#comment-13167889
]
Hoss Man commented on SOLR-2920:
yep yep ... totally get it now. they don't use any of the
[
https://issues.apache.org/jira/browse/SOLR-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166462#comment-13166462
]
Hoss Man commented on SOLR-2920:
David: thanks for the updated, reading the diff something
[
https://issues.apache.org/jira/browse/SOLR-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166635#comment-13166635
]
David Smiley commented on SOLR-2920:
Those params weren't used at all -- dead code.
[
https://issues.apache.org/jira/browse/SOLR-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165442#comment-13165442
]
Hoss Man commented on SOLR-2920:
bq. I started this by putting a method in the respective
[
https://issues.apache.org/jira/browse/SOLR-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163878#comment-13163878
]
David Smiley commented on SOLR-2920:
Anybody have any opinion here? I'd love to get
[
https://issues.apache.org/jira/browse/SOLR-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159522#comment-13159522
]
Hoss Man commented on SOLR-2920:
David:
+1 to the refactoring ... thta's a great idea to
[
https://issues.apache.org/jira/browse/SOLR-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159850#comment-13159850
]
David Smiley commented on SOLR-2920:
Thanks for noticing my issue, Hoss.
combine vs
